[Python-Dev] Request For Review: Fix test_socket.CANTest.testSendFrame (bpo-40297)

2021-04-23 Thread Karl Ding
Hi all,

Could someone help take a look at the following PR, which fixes one of the
broken socket module tests that exercises part of the standard library?

PR Link: https://github.com/python/cpython/pull/19548
BPO Link: https://bugs.python.org/issue40297

The test can be run locally on Linux by setting up the virtual SocketCAN
interface the test expects:

# Load SocketCAN vcan kernel module
sudo modprobe vcan

# Start and set up a virtual SocketCAN interface
# Note: The SocketCAN tests expect a network interface called 'vcan0' to
exist
sudo ip link add dev vcan0 type vcan
sudo ip link set up vcan0

# Run the socket tests using locally built Python
./python -m unittest -v test.test_socket.CANTest

Thanks!

-- 
Karl Ding
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/54BGN5TO3UWXD3EBTUVPWLJJCFJCDACV/
Code of Conduct: http://python.org/psf/codeofconduct/


[Python-Dev] Request For Review: Add support for CAN_J1939 sockets (bpo-40291)

2020-04-28 Thread Karl Ding
Hi all,

Could someone take a look at the following PR to add support for CAN_J1939
to the socket module? I'd like to try landing this for 3.9. This
enhancement would be useful for anyone working in automotive and/or dealing
with the SAE J1939 CAN protocol.

This feature is available on Linux 5.4+ (Ubuntu 20.04 LTS ships with a
compatible kernel).

PR Link: https://github.com/python/cpython/pull/19538
BPO Link: https://bugs.python.org/issue40291

You may find the following links useful if you want to find out more about
how the kernel J1939 implementation is used.

J1939 Kernel Docs:
https://www.kernel.org/doc/html/latest/networking/j1939.html
J1939 header:
https://elixir.bootlin.com/linux/latest/source/include/uapi/linux/can/j1939.h

Thanks!

-- 
Karl Ding
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/ESCVNT24QHL26XV6TUF3JEH7OONIQV4W/
Code of Conduct: http://python.org/psf/codeofconduct/