Re: [Python-Dev] [Python-checkins] commit of r41880 - python/trunk/Python/Python-ast.c

2006-01-03 Thread Martin v. Löwis
Jeremy Hylton wrote: I think this solution is better. It's relatively rare for people to change the ast definition, so for most purposes these should be static files. Interestingly enough, I found yesterday that Python-ast.c did change for me, even though I had not touched the AST grammar at

Re: [Python-Dev] [Python-checkins] commit of r41880 - python/trunk/Python/Python-ast.c

2006-01-03 Thread Donovan Baarda
On Mon, 2006-01-02 at 15:16 -0800, Neal Norwitz wrote: On 1/2/06, Barry Warsaw [EMAIL PROTECTED] wrote: I think we have a fundamental problem with Python-ast.c and Python-ast.h. These files should not be both auto-generated and checked into Subversion. I agree with the problem

Re: [Python-Dev] [Python-checkins] commit of r41880 - python/trunk/Python/Python-ast.c

2006-01-03 Thread Tim Peters
[Jeremy Hylton] I think this solution is better. It's relatively rare for people to change the ast definition, so for most purposes these should be static files. [Martin v. Löwis] Interestingly enough, I found yesterday that Python-ast.c did change for me, even though I had not touched the

Re: [Python-Dev] [Python-checkins] commit of r41880 - python/trunk/Python/Python-ast.c

2006-01-02 Thread Barry Warsaw
I think we have a fundamental problem with Python-ast.c and Python-ast.h. These files should not be both auto-generated and checked into Subversion. The problem is that if you do a make distclean, these files will get removed and svn stat will give you a ! flag. Of course, you can svn up to get

Re: [Python-Dev] [Python-checkins] commit of r41880 - python/trunk/Python/Python-ast.c

2006-01-02 Thread Neal Norwitz
On 1/2/06, Barry Warsaw [EMAIL PROTECTED] wrote: I think we have a fundamental problem with Python-ast.c and Python-ast.h. These files should not be both auto-generated and checked into Subversion. I agree with the problem statement. The general rule should be that no file that is ever

Re: [Python-Dev] [Python-checkins] commit of r41880 - python/trunk/Python/Python-ast.c

2006-01-02 Thread Barry Warsaw
On Mon, 2006-01-02 at 15:16 -0800, Neal Norwitz wrote: The Python-ast.[ch] should probably not be removed by distclean. This is similar to configure. Would that make you happy? What else would improve the current situation? I think it would, without causing bootstrapping issues. -Barry

Re: [Python-Dev] [Python-checkins] commit of r41880 - python/trunk/Python/Python-ast.c

2006-01-02 Thread Jeremy Hylton
On 1/2/06, Neal Norwitz [EMAIL PROTECTED] wrote: On 1/2/06, Barry Warsaw [EMAIL PROTECTED] wrote: I think we have a fundamental problem with Python-ast.c and Python-ast.h. These files should not be both auto-generated and checked into Subversion. I agree with the problem statement.