Re: [Python-Dev] [Python-checkins] r88914 - tracker/instances/python-dev/html/issue.item.js

2011-10-26 Thread Berker Peksağ
Hi,

On Wed, Oct 26, 2011 at 11:45 AM, ezio.melotti
python-check...@python.org wrote:
 Author: ezio.melotti
 Date: Wed Oct 26 10:45:41 2011
 New Revision: 88914

 Log:
 Mark automated messages with a different background.

 Modified:
   tracker/instances/python-dev/html/issue.item.js

 Modified: tracker/instances/python-dev/html/issue.item.js
 ==
 --- tracker/instances/python-dev/html/issue.item.js     (original)
 +++ tracker/instances/python-dev/html/issue.item.js     Wed Oct 26 10:45:41 
 2011
 @@ -313,3 +313,14 @@
     if (link.length != 0)
         link.attr('href', link.attr('href').split('?')[0]);
  });
 +
 +
 +$(document).ready(function() {
 +    /* Mark automated messages with a different background */
 +    $('table.messages th:nth-child(2)').each(function (i, e) {
 +        var e = $(e);
 +        if (/\(python-dev\)$/.test(e.text()))
 +            e.parent().next().find('td.content').css(
 +                'background-color', '#efeff9');
 +    });
 +});

I think this is shorter than $(document).ready();

$(function() {
// ...
});

See: 
http://stackoverflow.com/questions/3528509/document-readyfunction-vs-function/3528528#3528528

--Berker

 ___
 Python-checkins mailing list
 python-check...@python.org
 http://mail.python.org/mailman/listinfo/python-checkins

___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] [Python-checkins] r88914 - tracker/instances/python-dev/html/issue.item.js

2011-10-26 Thread Ezio Melotti

Hi,

On 26/10/2011 12.39, Berker Peksağ wrote:

Hi,
I think this is shorter than $(document).ready();

$(function() {
 // ...
});

See: 
http://stackoverflow.com/questions/3528509/document-readyfunction-vs-function/3528528#3528528


Thanks a lot for the review, I didn't know about this shortcut!
However I think I'll just leave $(document).ready(...); because, even if 
longer, is more explicit and readable.


Best Regards,
Ezio Melotti


--Berker



___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com