[Python-Dev] Coverity Scan, Python upgraded to rung 2

2008-01-11 Thread Jim Jewett
Neal Norwitz wrote: For codeobject.c, line 327 should not be reachable. ... Christian Heimes wrote: Please suppress the warning. I removed the last two lines and GCC complained ... Either way, it would be worth adding a comment to the source code so this doesn't come up again. -jJ

Re: [Python-Dev] Coverity Scan, Python upgraded to rung 2

2008-01-10 Thread A.M. Kuchling
On Wed, Jan 09, 2008 at 09:11:21PM -0800, Neal Norwitz wrote: For mmapmodule.c, fd should be checked for -1 before calling stat on line 1064. I'll fix the mmap problem. --amk ___ Python-Dev mailing list Python-Dev@python.org

Re: [Python-Dev] Coverity Scan, Python upgraded to rung 2

2008-01-10 Thread A.M. Kuchling
On Wed, Jan 09, 2008 at 09:11:21PM -0800, Neal Norwitz wrote: For mmapmodule.c, fd should be checked for -1 before calling stat on line 1064. On looking at this, it doesn't seem like an actual problem. fstat(-1, ...) returns a -1 and errno is set to EBADF, 'bad file descriptor'. /*

Re: [Python-Dev] Coverity Scan, Python upgraded to rung 2

2008-01-10 Thread Christian Heimes
Neal Norwitz wrote: I think only Coverity can add people. You can send them a message if you would like to be added: [EMAIL PROTECTED] Or you can send mail to me and I can forward along all the people that would like to be added. I'll wait a few days to collect names so I can batch up the

Re: [Python-Dev] Coverity Scan, Python upgraded to rung 2

2008-01-10 Thread Christian Heimes
Neal Norwitz wrote: For traceback.c, namebuf defined on line 155 should be moved out one block since filename is an alias to namebuf and it is used outside the current scope. I think this is unlikely to be a problem in practice, but is technically wrong and should be fixed. Agreed, the early

Re: [Python-Dev] Coverity Scan, Python upgraded to rung 2

2008-01-10 Thread Joseph Armbruster
I am not a developer but i'm interested in browsing it. Is it possible to be added? On Jan 10, 2008 10:57 AM, Christian Heimes [EMAIL PROTECTED] wrote: Neal Norwitz wrote: I think only Coverity can add people. You can send them a message if you would like to be added: [EMAIL PROTECTED] Or

Re: [Python-Dev] Coverity Scan, Python upgraded to rung 2

2008-01-10 Thread Neal Norwitz
On Jan 10, 2008 8:01 AM, Joseph Armbruster [EMAIL PROTECTED] wrote: I am not a developer but i'm interested in browsing it. Is it possible to be added? Yes, I've added you to the list. I'll probably send the list off tomorrow, so let me know if you would like to be added. n -- On Jan 10,

[Python-Dev] Coverity Scan, Python upgraded to rung 2

2008-01-09 Thread Christian Heimes
I read the announcement of the Python Users list and figured out that some of the other core developers might be interested in the news, too. Among other projects Python was upgraded to Rung 2 on the Coverity Scan list: http://scan.coverity.com/ Christian

Re: [Python-Dev] Coverity Scan, Python upgraded to rung 2

2008-01-09 Thread Christian Heimes
Joseph Armbruster wrote: Christian, Is there any way you (or someone else) could post up the results? It looks like you need a log in to check them out. I haven't figured out how to access the results. Who has a login and access to the site? Christian

Re: [Python-Dev] Coverity Scan, Python upgraded to rung 2

2008-01-09 Thread Nick Coghlan
Christian Heimes wrote: Joseph Armbruster wrote: Christian, Is there any way you (or someone else) could post up the results? It looks like you need a log in to check them out. I haven't figured out how to access the results. Who has a login and access to the site? I know Neal has

Re: [Python-Dev] Coverity Scan, Python upgraded to rung 2

2008-01-09 Thread skip
Christian I read the announcement of the Python Users list and figured Christian out that some of the other core developers might be Christian interested in the news, too. Christian Among other projects Python was upgraded to Rung 2 on the Christian Coverity Scan list:

Re: [Python-Dev] Coverity Scan, Python upgraded to rung 2

2008-01-09 Thread Christian Heimes
[EMAIL PROTECTED] wrote: I shows 6 uninspected defects for Python. How do we see what they are? What is an uninspected defect? Any idea how the Coverity folks compute Defects/KLOC? For example, how does tcl manage to get a 0.0 score? I can't answer your question. I don't have access to the

Re: [Python-Dev] Coverity Scan, Python upgraded to rung 2

2008-01-09 Thread Guido van Rossum
On Jan 9, 2008 9:47 AM, Christian Heimes [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: I shows 6 uninspected defects for Python. How do we see what they are? What is an uninspected defect? Any idea how the Coverity folks compute Defects/KLOC? For example, how does tcl manage to get a

Re: [Python-Dev] Coverity Scan, Python upgraded to rung 2

2008-01-09 Thread Thomas Heller
[EMAIL PROTECTED] schrieb: Christian I read the announcement of the Python Users list and figured Christian out that some of the other core developers might be Christian interested in the news, too. Christian Among other projects Python was upgraded to Rung 2 on the

Re: [Python-Dev] Coverity Scan, Python upgraded to rung 2

2008-01-09 Thread Thomas Heller
Guido van Rossum schrieb: On Jan 9, 2008 9:47 AM, Christian Heimes [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: I shows 6 uninspected defects for Python. How do we see what they are? What is an uninspected defect? Any idea how the Coverity folks compute Defects/KLOC? For example,

Re: [Python-Dev] Coverity Scan, Python upgraded to rung 2

2008-01-09 Thread Christian Heimes
Thomas Heller wrote: Seems they are referring to the results of the rung 1 run (what ever 'rung' means ;-). With the account Neal made me some months ago, I can login on this page: http://scan.coverity.com:7475/ and see the scan results for Python. Last run at 2007-12-27: 11

Re: [Python-Dev] Coverity Scan, Python upgraded to rung 2

2008-01-09 Thread Thomas Heller
Christian Heimes schrieb: Thomas Heller wrote: Seems they are referring to the results of the rung 1 run (what ever 'rung' means ;-). With the account Neal made me some months ago, I can login on this page: http://scan.coverity.com:7475/ and see the scan results for Python. Last

Re: [Python-Dev] Coverity Scan, Python upgraded to rung 2

2008-01-09 Thread Neal Norwitz
On Jan 9, 2008 1:12 PM, Christian Heimes [EMAIL PROTECTED] wrote: Thomas Heller wrote: Seems they are referring to the results of the rung 1 run (what ever 'rung' means ;-). With the account Neal made me some months ago, I can login on this page: http://scan.coverity.com:7475/

Re: [Python-Dev] Coverity Scan, Python upgraded to rung 2

2008-01-09 Thread Neal Norwitz
On Jan 9, 2008 9:08 AM, [EMAIL PROTECTED] wrote: Christian I read the announcement of the Python Users list and figured Christian out that some of the other core developers might be Christian interested in the news, too. Christian Among other projects Python was upgraded to

Re: [Python-Dev] Coverity Scan, Python upgraded to rung 2

2008-01-09 Thread Neal Norwitz
On Jan 9, 2008 9:08 AM, [EMAIL PROTECTED] wrote: I went to the run2 page: http://scan.coverity.com/rung2.html I shows 6 uninspected defects for Python. How do we see what they are? What is an uninspected defect? Any idea how the Coverity folks compute Defects/KLOC? For example, how