Re: [Python-Dev] Highlighting reference-stealing APIs [was Re: cpython: Fix email post-commit review comments.]

2012-04-19 Thread Sam Partington
On 19 April 2012 02:20, Nick Coghlan ncogh...@gmail.com wrote: On Thu, Apr 19, 2012 at 12:21 AM, Antoine Pitrou solip...@pitrou.net wrote: (and here we see why reference-stealing APIs are a nuisance: because you never know in advance whether a function will steal a reference or not, and you

Re: [Python-Dev] Highlighting reference-stealing APIs [was Re: cpython: Fix email post-commit review comments.]

2012-04-19 Thread Martin v. Löwis
Am 19.04.2012 12:42, schrieb Sam Partington: On 19 April 2012 02:20, Nick Coghlan ncogh...@gmail.com wrote: On Thu, Apr 19, 2012 at 12:21 AM, Antoine Pitrou solip...@pitrou.net wrote: (and here we see why reference-stealing APIs are a nuisance: because you never know in advance whether a

[Python-Dev] Highlighting reference-stealing APIs [was Re: cpython: Fix email post-commit review comments.]

2012-04-18 Thread David Malcolm
On Thu, 2012-04-19 at 10:48 +1200, Greg Ewing wrote: Antoine Pitrou wrote: (and here we see why reference-stealing APIs are a nuisance: because you never know in advance whether a function will steal a reference or not, and you have to read the docs for each and every C API call you

Re: [Python-Dev] Highlighting reference-stealing APIs [was Re: cpython: Fix email post-commit review comments.]

2012-04-18 Thread Gregory P. Smith
On Wed, Apr 18, 2012 at 5:01 PM, David Malcolm dmalc...@redhat.com wrote: On Thu, 2012-04-19 at 10:48 +1200, Greg Ewing wrote: Antoine Pitrou wrote: (and here we see why reference-stealing APIs are a nuisance: because you never know in advance whether a function will steal a reference

Re: [Python-Dev] Highlighting reference-stealing APIs [was Re: cpython: Fix email post-commit review comments.]

2012-04-18 Thread Nick Coghlan
On Thu, Apr 19, 2012 at 11:04 AM, Gregory P. Smith g...@krypto.org wrote: +1  Adding these annotations and setting up a buildbot that builds using cpychecker would be a great. Even without the extra annotations, running cpychecker on at least one of the buildbots might be helpful. I'm in the