Re: [Python-Dev] Math.sqrt(-1) -- nan or ValueError?
I think it's better for the test to fail, to indicate that there's an unresolved problem on the platform. On 9/4/07, Hasan Diwan <[EMAIL PROTECTED]> wrote: > On 04/09/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > > Is this on OSX? That test has been failing (because on that platform > > sqrt(-1) returns nan instead of raising ValueError) for years -- but > > the test is only run when run in verbose mode, which mostly hides the > > issue. Have you read the comment for the test? > > Indeed, I am on OSX. Yes, I have read the comment for the test. Would the > following pseudocode be an acceptable fix for the problem: > if sys.platform == 'darwin' and math.sqrt(-1) == nan: > return > else: > try: > x = math.sqrt(-1) > except ValueError: > pass > ... > or should I just not bother? > -- > Cheers, > > Hasan Diwan < [EMAIL PROTECTED]> -- --Guido van Rossum (home page: http://www.python.org/~guido/) ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Math.sqrt(-1) -- nan or ValueError?
On 04/09/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > > Is this on OSX? That test has been failing (because on that platform > sqrt(-1) returns nan instead of raising ValueError) for years -- but > the test is only run when run in verbose mode, which mostly hides the > issue. Have you read the comment for the test? Indeed, I am on OSX. Yes, I have read the comment for the test. Would the following pseudocode be an acceptable fix for the problem: if sys.platform == 'darwin' and math.sqrt(-1) == nan: return else: try: x = math.sqrt(-1) except ValueError: pass ... or should I just not bother? -- Cheers, Hasan Diwan <[EMAIL PROTECTED]> ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Math.sqrt(-1) -- nan or ValueError?
Is this on OSX? That test has been failing (because on that platform sqrt(-1) returns nan instead of raising ValueError) for years -- but the test is only run when run in verbose mode, which mostly hides the issue. Have you read the comment for the test? On 9/4/07, Hasan Diwan <[EMAIL PROTECTED]> wrote: > I'm trying to fix a failing unit test in revision 57974. The test in > question claims that math.sqrt(-1) should raise ValueError; the code itself > gives "nan" as a result for that expression. I can modify the test and > therefore have it pass, but I'm not sure if an exception would be more > appropriate. I'd be happy for some direction here. Many thanks! -- --Guido van Rossum (home page: http://www.python.org/~guido/) ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
[Python-Dev] Math.sqrt(-1) -- nan or ValueError?
I'm trying to fix a failing unit test in revision 57974. The test in question claims that math.sqrt(-1) should raise ValueError; the code itself gives "nan" as a result for that expression. I can modify the test and therefore have it pass, but I'm not sure if an exception would be more appropriate. I'd be happy for some direction here. Many thanks! -- Cheers, Hasan Diwan <[EMAIL PROTECTED]> ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
