[Python-Dev] Re: Draft PEP: Remove wstr from Unicode

2020-06-24 Thread Victor Stinner
I commented https://github.com/python/peps/pull/1462 as a review. Le mer. 24 juin 2020 à 10:21, Inada Naoki a écrit : > Do you mean APIs relating to Py_UNICODE, but not relating to > wstr nor legacy Unicode? (e.g. PyLong_FromUnicode, PyUnicode_Encode, etc...) > > We can remove them one-by-one

[Python-Dev] Re: Draft PEP: Remove wstr from Unicode

2020-06-24 Thread Inada Naoki
On Tue, Jun 23, 2020 at 6:31 PM Victor Stinner wrote: > > Le mar. 23 juin 2020 à 04:02, Inada Naoki a écrit : > > Legacy unicode representation is using wstr so legacy unicode support > > is removed with wstr. > > PyUnicode_READY() will be no-op when wstr is removed. We can remove > > calling

[Python-Dev] Re: Draft PEP: Remove wstr from Unicode

2020-06-23 Thread Victor Stinner
Le mar. 23 juin 2020 à 04:02, Inada Naoki a écrit : > Legacy unicode representation is using wstr so legacy unicode support > is removed with wstr. > PyUnicode_READY() will be no-op when wstr is removed. We can remove > calling of PyUnicode_READY() since then. > > I think we can deprecate

[Python-Dev] Re: Draft PEP: Remove wstr from Unicode

2020-06-22 Thread Inada Naoki
On Tue, Jun 23, 2020 at 6:58 AM Victor Stinner wrote: > > Hi INADA-san, > > First of all, thanks for writing down a PEP! > > Le jeu. 18 juin 2020 à 11:42, Inada Naoki a écrit : > > To support legacy Unicode object created by > > ``PyUnicode_FromUnicode(NULL, length)``, many Unicode APIs has > >

[Python-Dev] Re: Draft PEP: Remove wstr from Unicode

2020-06-22 Thread Victor Stinner
Hi INADA-san, First of all, thanks for writing down a PEP! Le jeu. 18 juin 2020 à 11:42, Inada Naoki a écrit : > To support legacy Unicode object created by > ``PyUnicode_FromUnicode(NULL, length)``, many Unicode APIs has > ``PyUnicode_READY()`` check. I don't see PyUnicode_READY() removal in