[Python-Dev] Re: Review patch fixing packed bitfields in ctypes struct/union

2020-11-20 Thread Simon Cross
The PR already has a fair amount of good review and discussion. Me doing a superficial review is not going to help get it merged. ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org

[Python-Dev] Re: Review patch fixing packed bitfields in ctypes struct/union

2020-11-20 Thread Terry Reedy
On 11/20/2020 4:03 AM, Simon Cross wrote: Thank you for this [cttpes] patch! > I can't help land it, but it looks sane to me. If you have a github account, you can help by reviewing it. Check the spelling, grammar, and clarity of comments, docstrings, and news item. Can the code be

[Python-Dev] Re: Review patch fixing packed bitfields in ctypes struct/union

2020-11-20 Thread Simon Cross
Hello! Thank you for this patch! I can't help land it, but it looks sane to me. I fear you have discovered a fundamental truth about ctypes though -- it tries to mimic what C compilers do and this inevitably leads to many discrepancies. E.g. if a C structure you're trying to use is wrapped in an