Re: [Python-Dev] Review request: issue 27350, compact ordered dict

Thank you for all core devs! I'll polish the implementation until 3.6b2. On Fri, Sep 9, 2016 at 6:42 AM, Guido van Rossum wrote: > It's in! Congrats, and thanks for your great work! See longer post by Victor. > > On Sun, Aug 28, 2016 at 12:16 AM, INADA Naoki

Re: [Python-Dev] Review request: issue 27350, compact ordered dict

It's in! Congrats, and thanks for your great work! See longer post by Victor. On Sun, Aug 28, 2016 at 12:16 AM, INADA Naoki wrote: > On Sun, Aug 28, 2016 at 2:05 PM, Guido van Rossum wrote: >> Hopefully some core dev(s) can work on this during the core

Re: [Python-Dev] Review request: issue 27350, compact ordered dict

On Sun, Aug 28, 2016 at 2:05 PM, Guido van Rossum wrote: > Hopefully some core dev(s) can work on this during the core sprint, which is > from Sept 5-9. > OK. While I'm in Japan (UTC+9) and cannot join the sprint, I'll be active as possible while the sprint. Thank you! > >

Re: [Python-Dev] Review request: issue 27350, compact ordered dict

Hopefully some core dev(s) can work on this during the core sprint, which is from Sept 5-9. On Sat, Aug 27, 2016 at 7:59 PM, INADA Naoki wrote: > Last call. There are only two weeks until 3.6 beta. > Please review it if possible. > > On Tue, Aug 9, 2016 at 10:12 PM,

Re: [Python-Dev] Review request: issue 27350, compact ordered dict

Last call. There are only two weeks until 3.6 beta. Please review it if possible. On Tue, Aug 9, 2016 at 10:12 PM, INADA Naoki wrote: > Hi, devs. > > I've implemented compact and ordered dictionary [1], which PyPy > implemented in 2015 [2]. > > Since it is my first large

Re: [Python-Dev] Review request: issue 27350, compact ordered dict

Hi Inada, On 10 August 2016 at 18:52, INADA Naoki wrote: > a. dict has one additional word and support ring internally. > b. OrderedDict reimplements many APIs (iterating, resizing, etc...) to > support ring. There is a solution "c." which might be simpler. Let's think

Re: [Python-Dev] Review request: issue 27350, compact ordered dict

>> >> I've implemented compact and ordered dictionary [1], which PyPy >> implemented in 2015 [2]. > > > Does this mean that keyword arguments will become ordered? > > Yury > Yes, regardless it will be language spec or just an implementation detail like PyPy

Re: [Python-Dev] Review request: issue 27350, compact ordered dict

On 2016-08-09 9:12 AM, INADA Naoki wrote: Hi, devs. I've implemented compact and ordered dictionary [1], which PyPy implemented in 2015 [2]. Does this mean that keyword arguments will become ordered? Yury ___ Python-Dev mailing list

Re: [Python-Dev] Review request: issue 27350, compact ordered dict

On Mon, Aug 15, 2016 at 6:02 AM, Xavier Combelle wrote: > > > On 10/08/2016 17:06, Maciej Fijalkowski wrote: >> * there are nice speedups >> > in this blog post > https://morepypy.blogspot.fr/2015/01/faster-more-memory-efficient-and-more.html > it is mentioned big

Re: [Python-Dev] Review request: issue 27350, compact ordered dict

On 10/08/2016 17:06, Maciej Fijalkowski wrote: > * there are nice speedups > in this blog post https://morepypy.blogspot.fr/2015/01/faster-more-memory-efficient-and-more.html it is mentioned big speedup only on microbenchmark and small speedups on pypy benchmark. is it what you call nice

Re: [Python-Dev] Review request: issue 27350, compact ordered dict

Thanks you for supporting. BTW, my patch doesn't include OrderedDict speedup. (I'll try it when compact dict is merged.) In case of Python 3, OrderedDict.move_to_end(key, last=False) can append item at front. So implementing OrderedDict based on compact dict is not so easy as OrderedDict = dict.

Re: [Python-Dev] Review request: issue 27350, compact ordered dict

Hello everyone. I did do only a cursory look on that one, but I would like to reiterate that this gives huge benefits in general and we measured nice speedups on pypy (where all the dicts are ordered forever): * you can essentially kill OrderedDict or make it almost OrderedDict = dict (in pypy

[Python-Dev] Review request: issue 27350, compact ordered dict

Hi, devs. I've implemented compact and ordered dictionary [1], which PyPy implemented in 2015 [2]. Since it is my first large patch, I would like to have enough time for review cycle by Python 3.6 beta1. Could someone review it? [1] http://bugs.python.org/issue27350 [2]