[Python-Dev] opinions on issue2142 ('\ No newline at end of file' to difflib.unified_diff)?

2010-10-07 Thread Trent Mick
Soliciting opinions on issue 2142 (http://bugs.python.org/issue2142). There are patched available so this isn't vapour. :) The issue is this (I'll discuss only unified_diff(), but the same applies to context_diff()): from difflib import * gen = unified_diff(one\ntwo\nthree.splitlines(1), ...

Re: [Python-Dev] opinions on issue2142 ('\ No newline at end of file' to difflib.unified_diff)?

2010-10-07 Thread R. David Murray
On Wed, 06 Oct 2010 15:53:59 -0700, Trent Mick tre...@gmail.com wrote: Soliciting opinions on issue 2142 (http://bugs.python.org/issue2142). There are patched available so this isn't vapour. :) [...] Possiblities: 1. Change `difflib.unified_diff` to emit: ['--- \n', '+++ \n', '@@

Re: [Python-Dev] opinions on issue2142 ('\ No newline at end of file' to difflib.unified_diff)?

2010-10-07 Thread Dirkjan Ochtman
On Thu, Oct 7, 2010 at 00:53, Trent Mick tre...@gmail.com wrote: 1. Change `difflib.unified_diff` to emit:    ['---  \n', '+++  \n', '@@ -1,3 +1,3 @@\n', ' one\n', ' two\n', '-three\n', '\ No newline at end of file', '+trois\n', '\ No newline at end of file'] instead of:    ['---  \n',