Re: [Python-Dev] sgmllib Comments

2006-06-12 Thread Martin v. Löwis
Sam Ruby wrote: If we can agree on the behavior, I would be glad to write up a patch. It seems to me that the simplest way to proceed would be for the code that attempts to resolve character references (both named and numeric) in attributes to be isolated in a single method. Subclasses that

Re: [Python-Dev] sgmllib Comments

2006-06-12 Thread Sam Ruby
Martin v. Löwis wrote: Sam Ruby wrote: If we can agree on the behavior, I would be glad to write up a patch. It seems to me that the simplest way to proceed would be for the code that attempts to resolve character references (both named and numeric) in attributes to be isolated in a single

Re: [Python-Dev] sgmllib Comments

2006-06-12 Thread Martin v. Löwis
Sam Ruby wrote: I don't see why expanding to multiple characters is a problem. That isn't a problem. Expanding to unparsed entities is. So the current call to handle_entityref must remain. Regards, Martin ___ Python-Dev mailing list

[Python-Dev] sgmllib Comments

2006-06-11 Thread Sam Ruby
Planet is a feed aggregator written in Python. It depends heavily on SGMLLib. A recent bug report turned out to be a deficiency in sgmllib, and I've submitted a test case and a patch[1] (use or discard the patch, it is the test that I care about). While looking around, a few things surfaced.

Re: [Python-Dev] sgmllib Comments

2006-06-11 Thread Aahz
On Sun, Jun 11, 2006, Sam Ruby wrote: Planet is a feed aggregator written in Python. It depends heavily on SGMLLib. A recent bug report turned out to be a deficiency in sgmllib, and I've submitted a test case and a patch[1] (use or discard the patch, it is the test that I care about).

Re: [Python-Dev] sgmllib Comments

2006-06-11 Thread Terry Reedy
Fred L. Drake, Jr. [EMAIL PROTECTED] wrote in message news:[EMAIL PROTECTED] On Sunday 11 June 2006 16:26, Sam Ruby wrote: Planet is a feed aggregator written in Python. It depends heavily on SGMLLib. A recent bug report turned out to be a deficiency in sgmllib, and I've submitted a

Re: [Python-Dev] sgmllib Comments

2006-06-11 Thread Sam Ruby
Fred L. Drake, Jr. wrote: On Sunday 11 June 2006 16:26, Sam Ruby wrote: Planet is a feed aggregator written in Python. It depends heavily on SGMLLib. A recent bug report turned out to be a deficiency in sgmllib, and I've submitted a test case and a patch[1] (use or discard the patch,

Re: [Python-Dev] sgmllib Comments

2006-06-11 Thread Sam Ruby
Terry Reedy wrote: Fred L. Drake, Jr. [EMAIL PROTECTED] wrote in message news:[EMAIL PROTECTED] On Sunday 11 June 2006 16:26, Sam Ruby wrote: Planet is a feed aggregator written in Python. It depends heavily on SGMLLib. A recent bug report turned out to be a deficiency in sgmllib, and

Re: [Python-Dev] sgmllib Comments

2006-06-11 Thread Fred L. Drake, Jr.
On Monday 12 June 2006 00:05, Sam Ruby wrote: Just to be clear: Planet uses Mark's feed parser, which uses SGMLlib. Cool. I was investigating a bug in sgmllib which affected the feed parser (and therefore Planet), and noticed that there were changes in the SVN head of Python which broke

Re: [Python-Dev] sgmllib Comments

2006-06-11 Thread Martin v. Löwis
Sam Ruby wrote: Planet is a feed aggregator written in Python. It depends heavily on SGMLLib. A recent bug report turned out to be a deficiency in sgmllib, and I've submitted a test case and a patch[1] (use or discard the patch, it is the test that I care about). I think (but am not

Re: [Python-Dev] sgmllib Comments

2006-06-11 Thread Sam Ruby
Martin v. Löwis wrote: Alternatively, a callback function could be provided for character references. Unfortunately, the existing callback is unsuitable, as it is supposed to do the full processing; this callback should return the replacement text. Generally assuming Unicode would be wrong,