This patch should be reverted or fixed so that the Py2.5 build works
again.
It contains a disasterous search and replace error that prevents it from
compiling. Hence, it couldn't have passed the test suite before being
checked in.
Also, all of the project and config files need to be updated
Raymond Hettinger [EMAIL PROTECTED] writes:
This patch should be reverted or fixed so that the Py2.5 build works
again.
It contains a disasterous search and replace error that prevents it from
compiling. Hence, it couldn't have passed the test suite before being
checked in.
It works for
[Raymond Hettinger]
This patch should be reverted or fixed so that the Py2.5 build works
again.
It contains a disasterous search and replace error that prevents it
from
compiling. Hence, it couldn't have passed the test suite before
being
checked in.
[Michael Hudson]
It works for
Here's an excerpt from the check-in note for sha512module.c:
RND(S[0],S[1],S[2],S[3],S[4],S[5],S[6],S[7],0,0x428a2f98d728ae22ULL);
RND(S[7],S[0],S[1],S[2],S[3],S[4],S[5],S[6],1,0x7137449123ef65cdULL);
RND(S[6],S[7],S[0],S[1],S[2],S[3],S[4],S[5],2,0xb5c0fbcfec4d3b2fULL);
Raymond Hettinger [EMAIL PROTECTED] writes:
[Raymond Hettinger]
This patch should be reverted or fixed so that the Py2.5 build works
again.
It contains a disasterous search and replace error that prevents it
from
compiling. Hence, it couldn't have passed the test suite before
being
Michael Hudson [EMAIL PROTECTED] writes:
Raymond Hettinger [EMAIL PROTECTED] writes:
[Raymond Hettinger]
This patch should be reverted or fixed so that the Py2.5 build works
again.
It contains a disasterous search and replace error that prevents it
from
compiling. Hence, it
[Michael Hudson]
It's an C99 unsigned long long literal, AFAICT (p70 of the PDF I found
lying around somewhere...), so I think it's just Bill who's behind.
However, Python doesn't require C99, so it's pretty dodgy code by our
standards.
More than just dodgy.
Except from PEP 7:
Use
This patch should be reverted or fixed so that the Py2.5 build works
again.
It contains a disasterous search and replace error that prevents it from
compiling. Hence, it couldn't have passed the test suite before being
checked in.
Also, all of the project and config files need to be
Raymond Hettinger [EMAIL PROTECTED] wrote in message
news:[EMAIL PROTECTED]
Except from PEP 7:
Use ANSI/ISO standard C (the 1989 version of the standard).
Just checked (PB, Standard C): only one L allowed, not two. But with C99
compilers becoming more common, accidental usages of C99-isms
The project files are just text files and can be updated simply and
directly. But yes, that is no big deal and I'll just do it for him once
the code gets to a compilable state.
I just checked in an update removing all of the ULLs. Could you check
that it compiles on windows and passes
Terry Reedy wrote:
Just checked (PB, Standard C): only one L allowed, not two. But with C99
compilers becoming more common, accidental usages of C99-isms in submitted
code will likely become more common, especially when there is not a
graceful C89 alternative. While the current policy
[Gregory P. Smith]
I just checked in an update removing all of the ULLs. Could you check
that it compiles on windows and passes test_hashlib.py now?
Okay, all is well.
Raymond
___
Python-Dev mailing list
Python-Dev@python.org
12 matches
Mail list logo
