Nick Coghlan ncogh...@gmail.com added the comment:
Right, this is a separate bug in pkgutil. Specifically, when it goes to import
a package in order to check it for submodules, it invokes the global import
system via __import__() rather than constraining the import to the path
argument
Hynek Schlawack h...@ox.cx added the comment:
If nobody else, I’ll review it tomorrow at the latest.
On a first glance I realized our shutil Exceptions are all derived from
EnvironmentError which is just a compatibility alias for OSError since 3.3.
Quick poll before I open a dedicated ticket,
Atsuo Ishimoto ishim...@gembook.org added the comment:
So, the title of this issue is misleading.
The patch originally proposed by Zooko does not raise SameFileError in
shutil.move(). If source and destination is same file, shutil.move() may
raise exception, but the exception is NOT
Hynek Schlawack h...@ox.cx added the comment:
Well, then fix is for shutil.move() too please, otherwise we can’t close
this ticket which is a pity after over 6 years. :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1492704
Atsuo Ishimoto ishim...@gembook.org added the comment:
Well, I happy to improve patch.
But, on Linux and Windows, shutil.move() does not raise any exception if source
and destination are identical. If we change the behavior, I'm afraid we would
break a lot of existing applications.
Changes by Mark Dickinson dicki...@gmail.com:
--
nosy: +mark.dickinson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15368
___
___
Hynek Schlawack h...@ox.cx added the comment:
Sorry, I didn’t look at zooko’s patch which was also just about copyfile. I
presume it’s all about the copy fallback that happens when os.rename didn’t
work out.
Will look at your code more closely later.
--
title: distinct error type
Atsuo Ishimoto ishim...@gembook.org added the comment:
Ooops, shutil.move() will raise SameFileError if destination is directory. I'll
investigate the patch further more.
--
___
Python tracker rep...@bugs.python.org
Nick Coghlan ncogh...@gmail.com added the comment:
At the very least, the pkgutil docs need to state clearly that walk_packages
only works properly with sys.path entries, and the constraint feature may not
descend into packages correctly if an entry is shadowed by a sys.modules entry
or an
New submission from Nick Coghlan ncogh...@gmail.com:
test_runpy doesn't currently check that code can be correctly executed from
namespace packages
--
components: Tests
messages: 165613
nosy: ncoghlan
priority: normal
severity: normal
status: open
title: test_runpy should include
New submission from Nick Coghlan ncogh...@gmail.com:
test_cmd_line_script doesn't currently check that namespace packages and
submodules of namespace packages can be executed via the -m switch
--
components: Library (Lib)
messages: 165614
nosy: ncoghlan
priority: normal
severity:
Ronald Oussoren ronaldousso...@mac.com added the comment:
And a final update: don't use TAB characters
--
Added file: http://bugs.python.org/file26398/venv-symlinks-v7.txt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15307
Changes by Florent Xicluna florent.xicl...@gmail.com:
--
nosy: +flox
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15368
___
___
Python-bugs-list
Nick Coghlan ncogh...@gmail.com added the comment:
The walk_packages tests should also be enhanced to ensure correctly handling of
namespace packages
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15358
Nick Coghlan ncogh...@gmail.com added the comment:
Note that the problem described in #14787 will limit the scope of what can be
tested.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15358
Nick Coghlan ncogh...@gmail.com added the comment:
I just realised this is going to behave strangely with namespace packages as
well: the __import__ step will pick up *every* portion of the namespace
package, not just those defined in the identified subset of sys.path.
--
Nick Coghlan ncogh...@gmail.com added the comment:
At least we know the hash randomisation is working :)
Spurious changes when freezing modules seems like a legitimate reason to fix it
- the import benchmarks would probably give the compiler enough of a workout to
highlight if the sorting is
Ronald Oussoren ronaldousso...@mac.com added the comment:
I don't recall what the issue was the resulted in the check-in that you
mention. Sadly enough it is not-trivial to find that check-in I mention due to
the migration from Subversion to Mercurial.
How was python itself configured
Antoine Pitrou pit...@free.fr added the comment:
Ditto. I think predictability of bytecode generation is useful, e.g. for
make-like tools that examine content, or for unit testing.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
Larry Hastings la...@hastings.org added the comment:
Hynek, it's clear you understand this far better than I do. Could I get you to
fix the Fedora buildbot problem, etc, etc?
--
___
Python tracker rep...@bugs.python.org
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15352
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15368
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11698
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 265e36e277f3 by Hynek Schlawack in branch 'default':
#15238: Fix xattr related shutil.copystat tests
http://hg.python.org/cpython/rev/265e36e277f3
--
___
Python tracker
Richard Oudkerk shibt...@gmail.com added the comment:
Updated patch. Old one broke test_distutils...
--
Added file: http://bugs.python.org/file26399/distutils-sysconfig.patch
___
Python tracker rep...@bugs.python.org
Richard Oudkerk shibt...@gmail.com added the comment:
Updated patch which does not fail test_distutils.
--
Added file: http://bugs.python.org/file26400/build_ext.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15367
Hynek Schlawack h...@ox.cx added the comment:
I removed the check for good as we check for the existence of the xattr in the
next line. However we check the destination now whether the xattrs have been
copied. ;) Fedora is green again.
--
___
Chris Jerdonek chris.jerdo...@gmail.com added the comment:
This isn't an easy one to fix - you basically need something along the lines
of a PEP 406 style import engine API in order to do the import without having
potentially adverse effects on the state in the sys module.
By adverse, do
Richard Oudkerk shibt...@gmail.com added the comment:
I don't recall what the issue was the resulted in the check-in that you
mention.
I think it was http://bugs.python.org/issue8577. The issue was about having
srcdir != builddir. The initial patch caused a test failure, and 356d0ea8ea34
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15364
___
___
Python-bugs-list
Atsuo Ishimoto ishim...@gembook.org added the comment:
Patch updated.
- SameFileError is now derived from EnvironmentError.
- Fixed documentation.
- Fixed test method name.
I investigated this patch:
- shutil.copyfile() and shutil.copy() raises SameFileError if source and
destination are
New submission from Luca Fabbri luca...@gmail.com:
Using the unicodedata.decomposition function on characters like \u201c and
\u201d I didn't get back the classic quote character ().
This is a very common error when text is taken from Microsoft Word (where in
italian language a couple of
New submission from Hartmut Goebel h.goe...@crazy-compilers.com:
Wehn copying os.environ usinf copy.copy(), any manipulation on the copied
object will change os.environment, too.
$ python
Python 2.7.3 (default, Apr 22 2012, 07:46:58)
[GCC 4.6.3] on linux2
Type help, copyright, credits or
Éric Araujo mer...@netwok.org added the comment:
It is actually simple to find the revision: http://hg.python.org/lookup/r81999
:)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15364
___
Éric Araujo mer...@netwok.org added the comment:
I have to add that I’m quite confused by srcdir vs. projectbase. There are a
handful of open bugs related to sysconfig and built but uninstalled Pythons,
and many commits changing code to use srcdir or projectbase after empirical
testing or
Ronald Oussoren ronaldousso...@mac.com added the comment:
srcdir vs. project base is quite easy: srcdir is the directory containing the
source files, the project base is where you ran configure. These are the same
if you run configure in the root of a checkout, but don't have to be, for
Hynek Schlawack h...@ox.cx added the comment:
- SameFileError is now derived from EnvironmentError.
Why?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1492704
___
R. David Murray rdmur...@bitdance.com added the comment:
I don't understand why you would expect to get a . The unicode characters
aren't s. As far as I can see (from, for example,
http://codepoints.net/U+201C), Python is behaving as expected here.
--
nosy: +r.david.murray
R. David Murray rdmur...@bitdance.com added the comment:
os.environ is not a dictionary, so it isn't all that surprising that a shallow
copy doesn't behave like a shallow copy of a dictionary. deepcopy does what
you'd expect, as does os.environ.copy().
Perhaps it is worth improving this by
Atsuo Ishimoto ishim...@gembook.org added the comment:
- SameFileError is now derived from EnvironmentError.
Why?
oh, sorry, I misunderstood you suggested to do so.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1492704
Hynek Schlawack h...@ox.cx added the comment:
No, sorry if my ramblings confused you. I'm pondering about deriving Error from
OSError in 3.4. That has nothing to do with this ticket. I just saw it while
glancing over your patch.
--
___
Python
Karl Chen qu...@09e0.clgubaohtf.z.quarl.org added the comment:
For the record, this was eventually fixed for Python 3.2. See
http://bugs.python.org/issue9666.
Adding this here because issue504714 comes up earlier than issue9666 in many
web searches.
--
nosy: +quarl
Brett Cannon br...@python.org added the comment:
OK, so it sounds like we need to do the equivalent of sorting those tuples when
generating the bytecode. That would suggest that probably need to tweak
Python/compile.c to make it deterministic.
--
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 998c8a8f2aea by Vinay Sajip in branch 'default':
Closes #15366: Corrected computation of include location for source builds.
Thanks to Richard Oudkerk for the bug report and patch.
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset a970054a93fb by Vinay Sajip in branch 'default':
Closes #15367: Corrected computation of include locations for source builds on
Windows. Thanks to Richard Oudkerk for the bug report and patch.
Matthew Barnett pyt...@mrabarnett.plus.com added the comment:
A codepoint such as é (\N{LATIN SMALL LETTER E WITH ACUTE}) can be
decomposed to \u0065\u0301 (\N{LATIN SMALL LETTER E}\N{COMBINING ACUTE
ACCENT), but \u201c (\N{LEFT DOUBLE QUOTATION MARK}) and \u201d
(\N{RIGHT DOUBLE QUOTATION
Changes by Antoine Pitrou pit...@free.fr:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15372
___
___
Python-bugs-list
New submission from Antoine Pitrou pit...@free.fr:
pyvenv's environment variable is currently named VIRTUAL_ENV (it seems).
It would be better if it followed the trend of other Python environment
variables such as PYTHONHOME, PYTHONSTARTUP, etc.
(so, PYTHONVENV ?)
Setting as deferred blocker,
Erik Johansson e...@ejohansson.se added the comment:
Document the difference between __getattr__ and __getitem__.
--
keywords: +patch
Added file: http://bugs.python.org/file26402/issue14201.patch
___
Python tracker rep...@bugs.python.org
Anton Barkovsky swarmer...@gmail.com added the comment:
Here's a patch.
--
keywords: +patch
nosy: +anton.barkovsky
Added file: http://bugs.python.org/file26403/environcopy.patch
___
Python tracker rep...@bugs.python.org
Ned Deily n...@acm.org added the comment:
v7 looks good to me
--
stage: - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15307
___
David Bolen db3l@gmail.com added the comment:
It seems really unlikely to be related to this issue since I'm pretty sure
build-amd64 doesn't get used on XP-4.
From the log it looks like it couldn't clean out and reuse the VS temporary
build directory. Manually cleaning it out and
Antoine Pitrou pit...@free.fr added the comment:
This broke the buildbots without poll() (Windows).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14635
___
Antoine Pitrou pit...@free.fr added the comment:
A test fails on the XP buildbots:
==
FAIL: test_get_importer_avoids_emulation
(test.test_pkgutil.ImportlibMigrationTests)
Anton Barkovsky swarmer...@gmail.com added the comment:
A new patch with tests.
--
Added file: http://bugs.python.org/file26404/environcopy_v2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15373
Antoine Pitrou pit...@free.fr added the comment:
David, since you are here, perhaps you could take a look at why your Windows 7
buildbot doesn't compile?
http://buildbot.python.org/all/builders/x86%20Windows7%203.x
I tried to e-mail you but apparently you didn't receive the message.
Chris Jerdonek chris.jerdo...@gmail.com added the comment:
Issue 15322 is a recently filed bug regarding srcdir:
sysconfig.get_config_var('srcdir') returns unexpected value
--
nosy: +cjerdonek
___
Python tracker rep...@bugs.python.org
Chris Jerdonek chris.jerdo...@gmail.com added the comment:
Attached is a patch illustrating the API I suggested for discussion.
To add custom setup and teardown context managers, the user can override the
following method:
def executeTest(self):
with self.setUpContext():
Antoine Pitrou pit...@free.fr added the comment:
This broke some 3.2 buildbots, e.g.:
http://buildbot.python.org/all/builders/AMD64%20Lion%203.2/builds/25
--
nosy: +pitrou
status: closed - open
___
Python tracker rep...@bugs.python.org
Ned Deily n...@acm.org added the comment:
Georg, are you still able to reproduce this? I've subsequently tried on a
Debian platform with an installed clang and could not reproduce. And, after
further inspecting the current code, I really don't see how the clang
substitution could happen on a
Changes by Ned Deily n...@acm.org:
Removed file:
http://bugs.python.org/file26163/issue15184_preserve_config_vars.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15184
___
Daniel Swanson popcorn.tomato.d...@gmail.com added the comment:
I am also somewhat puzzled by this issue.
The other day I was able to open some .txt files just to see if I could and
they opened just fine.
Just now I tryed to open a .jpg file and I got an error message, but then
again, why
HCT hcta...@gmail.com added the comment:
Hirokazu's v3 patch is a clean solution for the issue and works on 3.2
any update on when it will go into 3.2/3.3? I can help if needed
--
nosy: +hct
___
Python tracker rep...@bugs.python.org
Changes by Antoine Pitrou pit...@free.fr:
--
assignee: theller -
components: +Library (Lib), Windows
nosy: +meador.inge
stage: commit review - patch review
versions: +Python 3.3 -Python 3.1
___
Python tracker rep...@bugs.python.org
Alex Leach beamesle...@gmail.com added the comment:
I just had a dig around my cpython build dir, and found an ffi64.c I hacked at
a
while back.
I copied the edits over to the latest libffi git revision, rebuilt, and `make
check` (of libffi) passes all tests. So as far as I can tell the below
Alex Leach beamesle...@gmail.com added the comment:
It skips 55, sorry, passing 1659.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4130
___
Alex Leach beamesle...@gmail.com added the comment:
That's the same patch as I attached before actually, so sorry for the spam..
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4130
___
Atsuo Ishimoto ishim...@gembook.org added the comment:
Patch updated.
- SameFileError is reverted to be derived from shutil.Error as original patch.
--
Added file: http://bugs.python.org/file26406/issue1492704_new_3.patch
___
Python tracker
Richard Oudkerk shibt...@gmail.com added the comment:
In the attached patch _safe_realpath() is only called after calculating the
absolute path for srcdir.
--
keywords: +patch
Added file: http://bugs.python.org/file26407/sysconf.patch
___
Python
Gregory P. Smith g...@krypto.org added the comment:
Those should all be fixed as of my most recent commit.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14635
___
Vinay Sajip vinay_sa...@yahoo.co.uk added the comment:
This name was picked because the virtualenv tool uses it, and keeping the name
allows any existing third-party projects and scripts which use it to require
minimal, if any, changes.
--
___
Antoine Pitrou pit...@free.fr added the comment:
This name was picked because the virtualenv tool uses it, and keeping
the name allows any existing third-party projects and scripts which
use it to require minimal, if any, changes.
Which means that these third-party projects are automatically
Roger Serwy roger.se...@gmail.com added the comment:
Is the error message a traceback? If so, could you open a separate issue for it?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6804
Vinay Sajip vinay_sa...@yahoo.co.uk added the comment:
Which means that these third-party projects are automatically
compatible with pyvenv?
I can't speak for them, but it's one less thing for people to have to change.
The intention certainly was to minimise friction in this area.
I would
New submission from Renato Cunha ren...@renatocunha.com:
The word child is needlessly repeated in the subprocess documentation. This
trivial patch fixes this.
--
assignee: docs@python
components: Documentation
files: subprocess.diff
keywords: patch
messages: 165670
nosy: docs@python,
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 227a22288688 by R David Murray in branch '2.7':
#15375: remove duplicated word 'child'
http://hg.python.org/cpython/rev/227a22288688
--
nosy: +python-dev
___
Python
R. David Murray rdmur...@bitdance.com added the comment:
Thanks. (This error existed on only in the 2.7 docs.)
--
nosy: +r.david.murray
resolution: - fixed
stage: - committed/rejected
status: open - closed
type: enhancement - behavior
___
Python
Eli Bendersky eli...@gmail.com added the comment:
Fixed the invariant violation in changeset 64ff90e07d71
I'll review the performance difference separately
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1767933
Carl Meyer c...@dirtcircle.com added the comment:
Yes, there are a number of third-party utility packages (and many, many e.g.
personal custom bash prompts) that check the value of the $VIRTUAL_ENV variable
to detect whether one is currently active, and display its name. Unless there's
an
Eli Bendersky eli...@gmail.com added the comment:
I posted a message to python-dev about the performance issue
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1767933
___
Meador Inge mead...@gmail.com added the comment:
I haven't done any benchmarking (yet), but here is a patch implementing the
basic sorting approach.
--
keywords: +patch
Added file: http://bugs.python.org/file26409/issue15368-v0.patch
___
Python
Eli Bendersky eli...@gmail.com added the comment:
I agree. Any improvement is preferred over just letting this decay in the issue
tracker ;-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14332
Eli Bendersky eli...@gmail.com added the comment:
I tried blocking the import of 'pyexpat' in a test by using
test.support.import_fresh_module, placing 'pyexpat' into the blocked list, but
it doesn't work (i.e. pyexpat, if it exists, is still imported)
--
Eli Bendersky eli...@gmail.com added the comment:
Benjamin, what old behavior? Did it happen to raise ImportError historically
and only recent changes made it RuntimeError? I'm not sure this is the case.
--
___
Python tracker rep...@bugs.python.org
Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com added the comment:
Did it happen to raise ImportError historically and only recent
changes made it RuntimeError? I'm not sure this is the case.
ImportError was raised in Python 2.
--
___
Yury Selivanov yselivanov...@gmail.com added the comment:
Larry, Brett,
I compiled the documentation from the PEP (attached as inspect.pep362.1.patch).
Please take a look and feel free to add/edit.
--
keywords: +patch
Added file:
101 - 186 of 186 matches
Mail list logo
