Brett Cannon added the comment:
Should it be ModuleNotFoundError or ModuleNotFound? It's not necessarily an
error if a module doesn't exist, so failing to find it isn't quite that
negative. It also acts somewhat like StopIteration/GeneratorExit which also
don't have the common Error suffix of
Mark Dickinson added the comment:
The first patch looks great (modulo a stray extra line in test_int). Thank you!
Let's just apply that for now; I'll open a new issue for the suggested
OverflowError / ValueError switch. (Getting rid of the TypeError seems a clear
win to me; switching the
Changes by Brett Cannon br...@python.org:
--
stage: needs patch - test needed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15767
___
___
Mark Dickinson added the comment:
Fixed in http://hg.python.org/cpython/rev/a2b54b6d9759. Thanks for the report
and patch.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16469
Nikolay Bryskin added the comment:
Great, thanks!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16391
___
___
Python-bugs-list mailing list
New submission from Mark Dickinson:
[Broken out of the issue 16469 discussion about infinity - Fraction and nan -
Fraction conversions.]
Conversions from float('inf') or Decimal('inf') to int (or Fraction) currently
generate an OverflowError, while conversions from nan give a ValueError. I'm
Brett Cannon added the comment:
Files removed in 7e37a6c76e36.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9893
___
Mark Dickinson added the comment:
See issue #16483 for the ValueError / OverflowError switch. To be honest,
while I would have preferred ValueError to OverflowError for int(float('inf'))
if we were doing this from scratch, I'm not convinced that it's actually worth
switching.
--
Brett Cannon added the comment:
7e37a6c76e36 removed the Misc/Vim files since we just were not staying on top
of them. Thanks for the patch regardless, July. If the syntax file in Vim
itself is off I would submit those as I have found the Vim maintainers very
willing to accept fixes.
Brett Cannon added the comment:
7e37a6c76e36 removes the files in Misc/Vim. Thanks for the patch regardless,
Daniel. If the syntax file in Vim is out of date then I would suggest trying to
submit a patch. I have found the Vim maintainer quite willing to take fixes.
--
resolution: -
Mark Dickinson added the comment:
Should we go ahead with this?
Sure: if you're willing to write the patch, go for it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15783
___
Éric Araujo added the comment:
Did you decide against including README.vim after all or just forgot that part?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9893
___
Stephen added the comment:
Please ignore this. I have figured out it was caused by our company's make
wrapper. Using native make works like a charm.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16479
Chris Jerdonek added the comment:
Since it subclasses ImportError, it seems like we're already considering it to
be an error? StopIteration and GeneratorExit don't inherit from an Error
exception type unlike, say, the OSError exception types.
--
Chris Jerdonek added the comment:
I meant to include this link for convenience:
http://docs.python.org/dev/library/exceptions.html#exception-hierarchy
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15767
Antoine Pitrou added the comment:
Ok, closing then.
--
nosy: +pitrou
resolution: - invalid
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16479
___
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16478
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
The C implementation writes and reads BINBYTES and BINUNICODE up to 4G (on
64-bit platform). The Python implementation writes and reads BINBYTES and
BINUNICODE up to 2G. What should be compatible fix? Allow the Python
implementation to write and read up to
Alexey Kachayev added the comment:
Patch is attached (ported from full issue patch for issue 16469).
--
keywords: +patch
nosy: +kachayev
Added file: http://bugs.python.org/file27993/issue16483.diff
___
Python tracker rep...@bugs.python.org
Alexey Kachayev added the comment:
Ok, I think that ValueError is more appropriate and I have already attached
adopted patch for issue 16483.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16469
Dwayne Litzenberger added the comment:
After seeing a context manager named like TempfileIfNeeded(..., cond), whole
sole purpose is to handle the conditional case, I'm firmly +1 on this proposal.
It's much easier to just read with Tempfile() if cond else nullcontext():
than to read through
Eric Snow added the comment:
I agree with Andrew.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16386
___
___
Python-bugs-list mailing list
Eric Snow added the comment:
Though I haven't been able to get to this, I do have a demo of sorts that I've
been using elsewhere:
https://bitbucket.org/ericsnowcurrently/pylt/src/default/pylt/_importing.py?at=default#cl-225
--
___
Python tracker
Eric Snow added the comment:
I'd say ModuleNotFoundError. You could argue that other exception types aren't
really errors in certain circumstances. I'd think that generally this would be
an error.
--
___
Python tracker rep...@bugs.python.org
Eric Snow added the comment:
Effectively the exception indicates that the import system had an error.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15767
___
Nick Coghlan added the comment:
Perhaps go a bit more generic and call it something like load_cached_data?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15031
___
Nick Coghlan added the comment:
No, an empty ExitStack() instance already works fine as a no-op context manager
in 3.3:
http://docs.python.org/3/library/contextlib#simplifying-support-for-single-optional-context-managers
We're not going to add a dedicated one under a different name.
Brett Cannon added the comment:
I decided against it. If Emacs doesn't already have one I figured Vim shouldn't
either.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9893
___
Brett Cannon added the comment:
You can't use data as there are connotations for that word thanks to
get_data(). Same goes for load since this is something that get_code() would
use more directly than load_module().
--
___
Python tracker
Brett Cannon added the comment:
The chances of this being a problem is REALLY small and the single function
that calls this is a public void function so there is no way for an exception
to propagate short of a fatal error which seems a bit much.
I did change to using NOWAIT_LOCK, though.
Brett Cannon added the comment:
I'm at PyCon Argentina Friday and Saturday, so I have a rare opportunity to get
stuff done. If anyone has issues or comments, please get them in over the next
day or so, else I'm going to check this in as-is.
--
___
Mathias Panzenböck added the comment:
New patch. Instead of adding the data URL support to the doc as a recipe I
added it to urllib.request directly. I think this is better and justified,
because the old legacy URLopener had (some kind) of support for data URLs.
OT: I think that the legacy
Changes by Mathias Panzenböck grosser.meister.mo...@gmx.net:
--
components: +Library (Lib) -Documentation
title: urllib data URL recipe - urllib data URL
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16423
Case Van Horsen added the comment:
I agree that ValueError is a more correct exception but I also don't think
OverflowError is all that wrong. I don't think the change is worth the risk of
breaking existing code.
I'd be fine with either option.
--
nosy: +casevh
Georg Brandl added the comment:
Well, sounds reasonable since we're working with an integer number of spaces :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16478
___
101 - 135 of 135 matches
Mail list logo
