Changes by Guido van Rossum gu...@python.org:
Removed file: http://bugs.python.org/file32282/sockpair.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
___
Guido van Rossum added the comment:
New, improved version of sockpair.diff.
--
Added file: http://bugs.python.org/file32284/sockpair.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
Antoine Pitrou added the comment:
Antoine, could we make that option official on my build slave? Currently
I'm subverting the build system by exporting an environment variable.
Done. Can you please watch for failures and ensure they get fixed?
--
Changes by Maciej Fijalkowski fij...@gmail.com:
--
nosy: +fijall
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19336
___
___
Python-bugs-list
Changes by R. David Murray rdmur...@bitdance.com:
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19331
___
___
Charles-François Natali added the comment:
This is by design. Let me try to defend the design.
OK, if that's a know limitation, then that's fine.
It would be nice to add maybe a note somewhere in the documentation, so that
people don't get bitten by this (and also probably add a test for
Antoine Pitrou added the comment:
s/should be followed/may be followed/
As an other point of reference, for a long time the synchronization classes in
the threading module were actually mediated by function wrappers, e.g.:
def Lock(*args, **kwargs):
return _Lock(*args, **kwargs)
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19331
___
___
Python-bugs-list mailing
Serhiy Storchaka added the comment:
LGTM. Could you please sign a contributor agreement ([1], [2]) Arfrever?
[1] http://www.python.org/psf/contrib/
[2] http://www.python.org/psf/contrib/contrib-form/
--
assignee: - serhiy.storchaka
nosy: +serhiy.storchaka
priority: release blocker -
Serhiy Storchaka added the comment:
LGTM.
--
assignee: - serhiy.storchaka
nosy: +serhiy.storchaka
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19288
___
New submission from Ribhi Kamal:
I was about to use memory mapping for something when I discovered that the code
example posted on python.org causes python to core dump. %100 reproducible
The steps are really simple.
1- Create a file and map it using mmap.mmap
2- In a while loop, contintously
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +haypo, neologix, pitrou, sbt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19337
___
Changes by Ned Deily n...@acm.org:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19317
___
___
Python-bugs-list mailing list
Ribhi Kamal added the comment:
Code dump attached
--
Added file: http://bugs.python.org/file32285/core.gz
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19337
___
Serhiy Storchaka added the comment:
Confirm on 2.7 and 3.x.
--
components: +Library (Lib)
nosy: +serhiy.storchaka
versions: +Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19337
Charles-François Natali added the comment:
3- From another process, like bash, continuously write to the file.
That's the problem: reducing (actually truncating in your case) a file
currently mmaped *can only result in a core dump*: when you try to read from a
location in memory which
Stefan Krah added the comment:
Antoine Pitrou rep...@bugs.python.org wrote:
Done. Can you please watch for failures and ensure they get fixed?
Thanks! Yes, I'll keep an eye on it.
--
___
Python tracker rep...@bugs.python.org
Ribhi Kamal added the comment:
I figured I was doing something wrong... sorry about that
--
components: -Library (Lib)
resolution: invalid -
status: closed - open
versions: -Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
Changes by Ribhi Kamal rbhka...@gmail.com:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19337
___
___
Python-bugs-list
Changes by Ribhi Kamal rbhka...@gmail.com:
Removed file: http://bugs.python.org/file32285/core.gz
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19337
___
Antoine Pitrou added the comment:
One of the main use cases for atfork hooks would be the numerous
stdlib objects which have locks (or locks themselves): most of such
objects have arbitrary lifetimes (e.g. logging, events, open files,
etc).
The risk of leak is IMO much greater.
Well it is
Michael Foord added the comment:
pprint is also likely to have performance issues. I agree with Ezio that a diff
consisting of more than 30(x2) lines is not likely to be directly useful
anyway.
A test for the changed behaviour would be nice.
--
Antoine Pitrou added the comment:
I'm not strong on a new invariant, however I think bug #1 would deserve fixing:
1. sched.cancel() can remove wrong event (because it uses equality instead
identity).
--
___
Python tracker rep...@bugs.python.org
Yuriy Taraday added the comment:
Can someone please point out why do we have to do that dance with recursion
limit?
I've came upon this problem as well. I had some (bad) API I had to work with.
It always raised the same exception with the only difference in the message. So
I thought I could
Serhiy Storchaka added the comment:
I'm not strong on a new invariant, however I think bug #1 would deserve
fixing:
How would you do this?
1. Use identity instead equality to search canceled event. It will break code
where an user cancels an event by time and priority:
Antoine Pitrou added the comment:
4. Mixed strategy. First use identity search, then equality search,
and only if found several equals events fallback to slow variant. This
is too complicated. It will work as expected in most normal cases, but
in rare cases... This behavior would hard to
Giampaolo Rodola' added the comment:
This module has been around for a long time and no users have reported
any issues with respect to event ordering. The logic is essentially
the same as is used in popular event loops like Tornado.
Please don't just make-up a new invariant for this
New submission from Brodie Rao:
Normally:
$ python
import sys
sys.exit('foo')
foo
$ echo $?
1
However, with multiprocessing:
import sys
from multiprocessing import Process
p = Process(target=lambda: sys.exit('foo'))
p.start()
foo
p.join()
p.is_alive()
STINNER Victor added the comment:
FYI I just create #19339: telnetlib: time.monotonic() should be used instead
of time.time() for timeout.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19170
New submission from STINNER Victor:
While reading the patch attached to #19170, I saw that telnetlib uses
time.time() to compute a timeout. This is wrong: the system clock may jump
forward or backward (ex: summer/winter time, NTP adjust, manual clock change by
the administrator, etc.).
Changes by Brodie Rao j...@dackz.net:
Added file: http://bugs.python.org/file32287/multiprocessing-sys-exit-2.7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19338
___
Brodie Rao added the comment:
Here's the patch for 3.3.
--
keywords: +patch
Added file: http://bugs.python.org/file32286/multiprocessing-sys-exit-3.3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19338
Changes by Brodie Rao j...@dackz.net:
--
nosy: +jnoller, sbt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19338
___
___
Python-bugs-list mailing
Nick Coghlan added the comment:
I haven't fully thought this one through, but perhaps we could:
- deprecate calling the current concrete APIs with subclasses (since doing
so may break subclass invariants)
- add PyBaseDict_* APIs (etc) that subclass implementations can call.
- offer a
Matteo Cafasso added the comment:
On 09/10/13 22:59, Richard Oudkerk wrote:
Yes. But my point was that somebody might have used such a function as the
initializer argument. The proposed change would break a program which does
with Pool(initializer=os.nice, initargs=(incr,)) as p:
Terry J. Reedy added the comment:
This started as a python-list thread. On that thread, Peter Otten verified the
behavior on Linux, so it is not specific to the Windows pythonw executable. He
also verified on 3.2 (which gets security fixes only) and 3.4. I just checked
2.7. On that thread, I
Nick Coghlan added the comment:
Lots of builtins, collections and itertools use lowercase names as well, as do
some older stdlib types (array, mmap, socket).
The only clear dividing lines I can really discern are that ABCs *must* start
with a capital, as should classes paired with a separate
Nick Coghlan added the comment:
That said, I quite like Paul's suggestions.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19331
___
___
Eric Snow added the comment:
I had roughly the same idea, Nick, though my approach to address backward
compatibility was more complicated. Definitely worth at least looking into for
3.5.
--
___
Python tracker rep...@bugs.python.org
Ethan Furman added the comment:
Well, with all the changes to inspect to properly locate attributes in the
class and metaclass mro, __objclass__ is necessary to get the home class
correct (without it inspect thinks it lives in the EnumMeta metaclass).
--
Charles-François Natali added the comment:
Well it is customary for callback-based APIs to hold strong references to
their callbacks. If a library wants to avoid leaks, it should register a
single callback which will then walk the current live resources and protect
them.
I guess that the
Barry A. Warsaw added the comment:
On Oct 21, 2013, at 08:41 PM, Nick Coghlan wrote:
That said, I quite like Paul's suggestions.
As do I.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19331
Changes by Charles-François Natali cf.nat...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19170
Charles-François Natali added the comment:
You can go ahead!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19339
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset 2e8dd5c240b7 by Peter Moody in branch 'default':
#17400; ipaddress should make it easy to identify rfc6598 addresses
http://hg.python.org/cpython/rev/2e8dd5c240b7
--
nosy: +python-dev
___
Python tracker
STINNER Victor added the comment:
Patch for telnetlib of Python 3.3.
--
keywords: +patch
Added file: http://bugs.python.org/file32288/telnetlib_monotonic.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19339
New submission from Sunny K:
While working on issue7757, i noticed that test_srcdir fails when python is
built with prefix .
This is because in Lib/sysconfig.py, _safe_realpath() is called on srcdir which
normalises //lib to /lib. In the test case, it is compared directly to the
output of
Guido van Rossum added the comment:
I haven't seen any such hangs. I've seen one test_asyncio failure on FreeBSD
6.4 3.x, which is the following weirdness.
http://buildbot.python.org/all/builders/x86%20FreeBSD%206.4%203.x/builds/4116/steps/test/logs/stdio
test test_asyncio crashed --
Guido van Rossum added the comment:
I find it pretty suspicious that when this fails it is always connecting the
stdin pipe. That code is also suspect in the AIX failure (issue 19293),
although for a different reason.
The only theory I have at this point is that perhaps there's a platform bug
Christian Heimes added the comment:
About 2e8dd5c240b7
It might be a good idea to cache the two lists in a class or module variable in
order to speed things up. It might also be a good idea to move the most common
networks like 192.168.0.0/16 to the top of the list.
--
Roundup Robot added the comment:
New changeset 07a5610bae9d by Peter Moody in branch 'default':
#17400; NEWS and ipaddress.rst change
http://hg.python.org/cpython/rev/07a5610bae9d
--
___
Python tracker rep...@bugs.python.org
pmoody added the comment:
I have a change that needs to be submitted for the parser then I'll come back
to the caching.
The pedant in me would like like to keep the addresses ordered because that
makes it clear where to add new networks as iana changes classifications, but
it may just make
Terry J. Reedy added the comment:
A test will be a challenge since the three lines have to be run as if entered
interactively. This may require new code to inject lines into the interactive
processing stream, or a least a re-factoring of existing code.
--
Christian Tismer added the comment:
@georg:
While reviewing: is it intended that the filter is only called for
directories and not for individual files?
Not really. I will add this, later. Just wanted to see if this makes
sense and it's worth the effort to extend it.
--
Ethan Furman added the comment:
The proposed text is something along the lines of:
__objclass__: 1) Indicates this callable requires an instance of the given type
(or a subclass) as its first positional argument; e.g. CPython sets this for
unbound methods that are implemented in C rather than
Paul Hawkins added the comment:
I ran into this bug the first time I needed nargs + in a tool.
I found of course that if the option with the nargs is followed by another
option before the positional arguments it will work as expected. But then the
help would have to point this out, and it
Christian Tismer added the comment:
added that with tests.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19274
___
___
Python-bugs-list mailing
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19337
___
___
Python-bugs-list mailing list
Changes by David Edelsohn dje@gmail.com:
--
nosy: +David.Edelsohn
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19334
___
___
Python-bugs-list
David Edelsohn added the comment:
The testsuite is hanging in test_asyncio again and
test_subprocess_close_client_stream needs to be skipped.
--
Added file: http://bugs.python.org/file32289/issue19293.patch2
___
Python tracker rep...@bugs.python.org
David Edelsohn added the comment:
Other than the skipped tests, test_asyncio now passes on AIX except for:
FAIL: test_write_pipe (test.test_asyncio.test_events.PollEventLoopTests)
--
Traceback (most recent call last):
File
Jesús Cea Avión added the comment:
Patch looks good. Any other reviewer?
Maciej, do you know about any generally available library in Solaris with
SONAME and RPATH?. A test would be nice.
Would this patch solve the locate the C library using ctypes, in Solaris? :-).
--
paul j3 added the comment:
parse_args() would see ['-foo', 'bar1,bar2,bar3', 'pos1', 'pos2']. The
splitting on space is done by the shell. So having your own code split
'bar1,bar2,bar3' is simplest. But that would be messed up if the user entered
'bar1, bar2, bar3...'. You could also ask
Changes by Jesús Cea Avión j...@jcea.es:
--
keywords: +needs review -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19317
___
___
Jesús Cea Avión added the comment:
/usr/bin/chkpass.so has both SONAME and RPATH.
Would you mind, anyway, to elaborate a bit your use case, including some
example?. Thanks!.
--
___
Python tracker rep...@bugs.python.org
Jesús Cea Avión added the comment:
I mean /usr/lib/chkpass.so.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19317
___
___
Python-bugs-list
Terry J. Reedy added the comment:
The bug is not in Idle. Its interpreter is a subclass of
code.InteractiveInterpreter (II) and that (and its subclass InteractiveConsole)
have the bug.
C:\Programs\Python33python -m code
Python 3.3.2 (v3.3.2:d047928ae3f6, May 16 2013, 00:06:53) [MSC v.1600 64
Guido van Rossum added the comment:
Thanks; I've applied and pushed your fix for the hang.
I think it's time to commit the sockpair.diff change; the test_write_pipe()
failure looks related -- as you recall the problem doesn't really cause a hang,
it causes a premature closing of a write pipe,
Roundup Robot added the comment:
New changeset 2a0bda8d283d by Guido van Rossum in branch 'default':
Switch subprocess stdin to a socketpair, attempting to fix issue #19293 (AIX
hang).
http://hg.python.org/cpython/rev/2a0bda8d283d
--
___
Python
Guido van Rossum added the comment:
Let's see how this fares. If it passes on the AIX buildbot, maybe see which of
the tests we skipped on AIX can be re-enabled again?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
Guido van Rossum added the comment:
I committed a patch that should hopefully fix issue 19293 -- maybe it will also
reduce the flakiness of test_subprocess_shell() on OS X?
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset b9019b942435 by Ethan Furman in branch 'default':
Close #19263: add tests to ensure __objclass__ correctly set.
http://hg.python.org/cpython/rev/b9019b942435
--
nosy: +python-dev
resolution: - fixed
stage: - committed/rejected
status:
David Edelsohn added the comment:
With the latest changeset applied to default, the test_subprocess tests no
longer hang, but test_write_pipe_disconnect_on_close now hangs.
The attached patch changes test_event.py to not skip test_subprocess_* but now
skips
Guido van Rossum added the comment:
I think I know what that is -- the test should use a socketpair now. I'll see
how quickly I can give you a patch for that. The other one is now committed.
--
___
Python tracker rep...@bugs.python.org
Guido van Rossum added the comment:
David, try this fix (aixfix.diff).
--
Added file: http://bugs.python.org/file32291/aixfix.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
___
David Edelsohn added the comment:
I think I see the source of the confusion. test_distutils fails because it runs
in the build tree and without files installed. The test does not use the
installed version of sysconfig, so it looks for ./Modules/ld_so_aix, which
fails. The kludge from 2000 was
David Edelsohn added the comment:
test_asyncio no longer hangs on AIX with the aixfix.diff patch. Thanks!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
___
Guido van Rossum added the comment:
Corrected aixfix.diff (the other one was for the Tulip repo).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
___
Changes by Guido van Rossum gu...@python.org:
--
Removed message: http://bugs.python.org/msg200877
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
___
Guido van Rossum added the comment:
Corrected aixfix.diff for CPython repo (the previous one was for the Tulip
repo).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
___
Guido van Rossum added the comment:
Third try's a charm. Corrected aix fix.
--
Added file: http://bugs.python.org/file32292/aixfix2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
Changes by Guido van Rossum gu...@python.org:
--
Removed message: http://bugs.python.org/msg200878
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
___
Changes by Guido van Rossum gu...@python.org:
Removed file: http://bugs.python.org/file32291/aixfix.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
___
Roundup Robot added the comment:
New changeset c2e018c54689 by Guido van Rossum in branch 'default':
Fix asyncio issue #19293 (hangs on AIX).
http://hg.python.org/cpython/rev/c2e018c54689
--
___
Python tracker rep...@bugs.python.org
Guido van Rossum added the comment:
And there was much rejoicing.
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
David Edelsohn added the comment:
You have to try harder to break it again. aixfix2.diff still works. ;-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19293
___
Ned Deily added the comment:
Success! (I think.) On my elderly 10.4 machine, as of f33cc4a175a4:
tag: tip
user:Guido van Rossum gu...@dropbox.com
date:Mon Oct 21 20:57:25 2013 -0700
files: Lib/test/test_asyncio/test_events.py
description:
Unsilence several asyncio
201 - 287 of 287 matches
Mail list logo
