[issue34155] email.utils.parseaddr mistakenly parse an email

Larry Hastings added the comment: All PRs merged. Thanks, everybody! -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue37835] typing.get_type_hints wrong namespace for forward-declaration of inner class

Netzeband added the comment: Thanks for your explanations. It sounds, that there is no way to fix this issue officially. Only the meta-class workaround is left, which is - as you highlight - really just a workaround. I anyway always wonder, why functions, which are methods, do not hold a

[issue34155] email.utils.parseaddr mistakenly parse an email

Larry Hastings added the comment: New changeset 063eba280a11d3c9a5dd9ee5abe4de640907951b by larryhastings (Abhilash Raj) in branch '3.5': [3.5] bpo-34155: Dont parse domains containing @ (GH-13079) (#15317) https://github.com/python/cpython/commit/063eba280a11d3c9a5dd9ee5abe4de640907951b

[issue24416] Have date.isocalendar() return a structseq instance

Tim Peters added the comment: I favor making this a structseq, primarily based on Paul's attempt to find actual use cases, which showed that named member access would be most useful most often. I have no intuition for that myself, because while I wrote the original functions here, I've

[issue15382] os.utime() mishandles some arguments

Dong-hee Na added the comment: @vstinner This issue is not solved yet. Can I finalize this issue? -- nosy: +corona10 ___ Python tracker ___

[issue38037] reference counter issue in signal module

Change by Ma Lin : -- title: Assertion failed: object has negative ref count -> reference counter issue in signal module ___ Python tracker ___

[issue38015] inline function generates slightly inefficient machine code

Ma Lin added the comment: This range has not been changed since "preallocated small integer pool" was introduced: #define NSMALLPOSINTS 257 #define NSMALLNEGINTS 5 The commit (Jan 2007): https://github.com/python/cpython/commit/ddefaf31b366ea84250fc5090837c2b764a04102 Is it worth

[issue38003] Change 2to3 to replace 'basestring' with '(str,bytes)'

Change by Terry J. Reedy : -- nosy: +benjamin.peterson title: Incorrect "fixing" of isinstance tests for basestring -> Change 2to3 to replace 'basestring' with '(str,bytes)' versions: +Python 3.9 -Python 3.7 ___ Python tracker

[issue38003] Incorrect "fixing" of isinstance tests for basestring

Josh Rosenberg added the comment: basestring in Python 2 means "thing that is logically text", because in Python 2, str can mean *either* logical text *or* binary data, and unicode is always logical text. str and unicode can kinda sorta interoperate on Python 2, so it can make sense to test

[issue38047] multiarch headers are added when cross compiling

Change by Haibo Huang : -- components: Cross-Build nosy: Alex.Willmer, hhb priority: normal pull_requests: 15375 severity: normal status: open title: multiarch headers are added when cross compiling versions: Python 3.8 ___ Python tracker

NumPy 1.17.2 released.

Hi All, On behalf of the NumPy team I am pleased to announce that NumPy 1.17.2 has been released. This release contains fixes for bugs reported against NumPy 1.17.1 along with some documentation improvements. The most important fix is for lexsort when the keys are of type (u)int8 or (u)int16. If

[issue38040] Typo: "Writeable" Should be "Writable" in IO Library Documentation

Terry J. Reedy added the comment: Wiktionary and dictionary.com see 'writeable' as an alternate spelling of 'writable', while merriam-webster.com does not. Neither of the former say anything about American versus British usage. I wonder if the first two are rubber-stamping what used to be

[issue38007] Regression: name of PyType_Spec::slots conflicts with Qt macro

Terry J. Reedy added the comment: My initial thought is similar to that of Michael Hudson in msg23757, that Python should not be hostage to foreign code processors. I also note that the 2010 patch is by Martin Loewis, who was part of the 2006 discussion, and that the 2010 patch was about

[issue38005] Coercing strings and non-integer numbers to interpreter ID and channel ID

Terry J. Reedy added the comment: Regardless of the intention of the _xx... author, intransitive equality is objectionable as it violates the assumption of sets and dicts. We went through this before with decimal.Decimal when the original implementation had 1.0 == 1 == Decimal(1) but 1.0

Re: Multidimensional dicts

On 06Sep2019 22:48, Ralf M. wrote: Recently I wrote a quick and dirty script to do some counting and statistics. When I re-read it a bit later I noticed that I had been using two different ways to create two-dimensional (default-)dicts. Now I'm wondering whether one of them is "better" or

[issue38003] Incorrect "fixing" of isinstance tests for basestring

Bob Kline added the comment: > Unless you have a specific proposal, ... I _do_ have a specific proposal: replace `basestring` with `(str, bytes)`, which preserves the behavior of the original code. So, if isinstance(value, basestring) becomes if isinstance(value, (str, bytes))

[issue38003] Incorrect "fixing" of isinstance tests for basestring

Terry J. Reedy added the comment: Bob, this issue tracker is for managing patches to the cpython repository. not for 'help me understand' requests, The latter belong on, for instance, python-list. Unless you have a specific proposal, other than leaving 'basestring' alone(1), that we

[issue37995] Multiline ast.dump()

Terry J. Reedy added the comment: Much better. I prefer the first version with closers on the last item. -- nosy: +terry.reedy ___ Python tracker ___

[issue37992] Change datetime.MINYEAR to allow for negative years

Change by Terry J. Reedy : -- resolution: -> rejected stage: -> resolved status: open -> closed versions: +Python 3.9 -Python 3.7 ___ Python tracker ___

Multidimensional dicts

Recently I wrote a quick and dirty script to do some counting and statistics. When I re-read it a bit later I noticed that I had been using two different ways to create two-dimensional (default-)dicts. Now I'm wondering whether one of them is "better" or more pythonic than the other. What I

[issue38046] Can't use sort_keys in json.dumps with mismatched types

Josh Rosenberg added the comment: This is an exact duplicate of #25457. -- nosy: +josh.r resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> json dump fails for mixed-type keys when sort_keys is specified ___ Python

[issue38046] Can't use sort_keys in json.dumps with mismatched types

Change by Nick Timkovich : -- components: +Library (Lib) title: JSON sorting type error -> Can't use sort_keys in json.dumps with mismatched types versions: +Python 3.9 -Python 3.7 ___ Python tracker

Re: Help me fix a problem

On Friday, 6 September 2019 20:15:40 UTC+2, MRAB wrote: > On 2019-09-06 18:11, Spencer Du wrote: > > Hi > > > > I want to print yes in gui.py but it does not get printed because of the > > json. How do I fix this. Execute embedded.py and then gui.py to test. > > > > def on_message(client,

Re: Help me fix a problem

On Friday, 6 September 2019 20:15:40 UTC+2, MRAB wrote: > On 2019-09-06 18:11, Spencer Du wrote: > > Hi > > > > I want to print yes in gui.py but it does not get printed because of the > > json. How do I fix this. Execute embedded.py and then gui.py to test. > > > > def on_message(client,

Re: Help me fix a problem

On Friday, 6 September 2019 20:15:40 UTC+2, MRAB wrote: > On 2019-09-06 18:11, Spencer Du wrote: > > Hi > > > > I want to print yes in gui.py but it does not get printed because of the > > json. How do I fix this. Execute embedded.py and then gui.py to test. > > > > def on_message(client,

[issue38046] JSON sorting type error

Nick Timkovich added the comment: It's not clear what you suggest, but it is likely better to alert the user that their keys have mismatched types than to suppress it by default. Perhaps alongside the `sort_keys` argument, you would like a parameter that gets passed into `sorted()` when the

[issue38046] JSON sorting type error

New submission from guillard : If the dict included both str and int keys, sorted returns this error : TypeError: '<' not supported between instances of 'int' and 'str' It is a little bit problematic when used with default library behavior, as jsonify in Flask. possible solution : try:

[issue38041] IDLE Shell: Refine restart line

miss-islington added the comment: New changeset 084ba337a93facac4694459b460cf329d58d2b62 by Miss Islington (bot) in branch '3.7': bpo-38041: Refine IDLE Shell restart lines. (GH-15709) https://github.com/python/cpython/commit/084ba337a93facac4694459b460cf329d58d2b62 --

Re: Help me fix a problem

On 2019-09-06 18:11, Spencer Du wrote: Hi I want to print yes in gui.py but it does not get printed because of the json. How do I fix this. Execute embedded.py and then gui.py to test. def on_message(client, userdata, msg): print("message recieved= " + msg.payload.decode()) #

[issue38041] IDLE Shell: Refine restart line

miss-islington added the comment: New changeset 4009a8522d774c36918005527dfb0975f389c8c2 by Miss Islington (bot) in branch '3.8': bpo-38041: Refine IDLE Shell restart lines. (GH-15709) https://github.com/python/cpython/commit/4009a8522d774c36918005527dfb0975f389c8c2 -- nosy:

[issue38045] enum.Flag instance creation is slow

Antony Lee added the comment: Actually, microoptimizing _power_of_two is a red herring and the problem is the quadratic complexity of _decompose (_value2member_map_ becomes bigger and bigger at each iteration). Replacing the implementation of _decompose by the following fixes the

[issue38041] IDLE Shell: Refine restart line

Terry J. Reedy added the comment: New changeset 38da805d563422cf1bb9cd9be24c73806840fe30 by Terry Jan Reedy in branch 'master': bpo-38041: Refine IDLE Shell restart lines. (GH-15709) https://github.com/python/cpython/commit/38da805d563422cf1bb9cd9be24c73806840fe30 --

[issue38041] IDLE Shell: Refine restart line

Change by miss-islington : -- pull_requests: +15374 pull_request: https://github.com/python/cpython/pull/15720 ___ Python tracker ___

[issue38041] IDLE Shell: Refine restart line

Change by miss-islington : -- pull_requests: +15373 stage: commit review -> patch review pull_request: https://github.com/python/cpython/pull/15719 ___ Python tracker ___

Help me fix a problem

Hi I want to print yes in gui.py but it does not get printed because of the json. How do I fix this. Execute embedded.py and then gui.py to test. embedded.py import paho.mqtt.client as mqtt from mqtt import * client = mqtt.Client() client.connect("broker.hivemq.com",1883,60)

[issue38039] Segfault when pickling dictionary with large pandas dataframes

Ilya Valmianski added the comment: As a sizing clarification, timed_dfs ~ 150GB, control_features ~30 GB, notime_dfs ~ 2GB. -- ___ Python tracker ___

[issue38039] Segfault when pickling dictionary with large pandas dataframes

Ilya Valmianski added the comment: Below is the code. It segfaults with either dill or pickle on 3.6 and 3.7. with open(output_path,'wb') as fout: dill.dump({ 'timed_dfs': timed_dfs, #large pandas dataframe with all but one columns being

[issue37380] subprocess.Popen._cleanup() "The handle is invalid" error when some old process is gone

Eryk Sun added the comment: > When a Popen instance is finalized by the garbage collector, the > internal handle is also finalized and closed despite the instance > being put on the active list. This results in _cleanup throwing > because the handle can no longer be used. Thanks. I hadn't

Re: Where can I find libtiff binary for 64-bit windows - for use in conjunction with Python package libtiff

Thanks for the answer. That site provides wheels for installing the Python libtiff package - great if "pip install libtiff" does not work out well. Besides that package, you'll need to have a 64-bits DLL on your system for it to work. That's the DLL I'm looking for. --

Re: Where can I find libtiff binary for 64-bit windows - for use in conjunction with Python package libtiff

On 2019-09-06 14:05, Dobedani wrote: Hi there! I'm using Python package libtiff on Windows (version 0.4.2) - see also https://github.com/pearu/pylibtiff. For this package to work well, it requires you to have a libtiff.dll in your PATH. For 32-bits I got my DLL here:

[issue26868] Document PyModule_AddObject's behavior on error

Brandt Bucher added the comment: It looks like the idiom of calling PyModule_AddObject without Py_DECREF'ing on the error condition (or even checking for it at all) has spread quite a bit since this first reported. I'm preparing a PR to fix the other call sites. -- nosy:

[issue15088] Remove unused and undocumented PyGen_NeedsFinalizing() function

STINNER Victor added the comment: I merged Joannah's change: thanks. If anyone uses the removed function, please complain before Python 3.9.0 release :-) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed title: PyGen_NeedsFinalizing is public, but

[issue15088] PyGen_NeedsFinalizing is public, but undocumented

STINNER Victor added the comment: New changeset 74b662cf202753d224d82d5503974cce881f7436 by Victor Stinner (Joannah Nanjekye) in branch 'master': bpo-15088 : Remove PyGen_NeedsFinalizing() (GH-15702) https://github.com/python/cpython/commit/74b662cf202753d224d82d5503974cce881f7436

[issue22454] Adding the opposite function of shlex.split()

Daniel Himmelstein added the comment: I am interested in shlex.join as a way to log subprocess.CompletedProcess.args as a string that users could run in their terminals. I initially assumed that this was also the scope of shlex.join. However, it seems that shlex.join does not accept all

[issue18049] Re-enable threading test on macOS

Ronald Oussoren added the comment: I think it is unlikely that the timeouts on Azure CI are related to this change. -- ___ Python tracker ___

[issue38015] inline function generates slightly inefficient machine code

Sergey Fedoseev added the comment: I added similar patch that replaces get_small_int() with macro version, since it also induces unnecessary casts and makes machine code less efficient. Example assembly can be checked at https://godbolt.org/z/1SjG3E. This change produces tiny, but

[issue38033] Use After Free: PyObject_Free (valgrind)

Charalampos Stratakis added the comment: Another thing also, is to be sure to utilize the python's suppression file by adding the --suppressions= to valgrind's command line invocation. -- nosy: +cstratak ___ Python tracker

[issue38015] inline function generates slightly inefficient machine code

Change by Sergey Fedoseev : -- pull_requests: +15372 pull_request: https://github.com/python/cpython/pull/15718 ___ Python tracker ___

[issue37064] Feature request: option to keep/add flags to pathfix.

Change by Patrik Kopkan : -- pull_requests: +15371 pull_request: https://github.com/python/cpython/pull/15717 ___ Python tracker ___

[issue38033] Use After Free: PyObject_Free (valgrind)

STINNER Victor added the comment: By default, Python is optimized for performance but its pymalloc memory allocator causes false alarms in Valgrind. > https://github.com/python/cpython/blob/master/Misc/README.valgrind This or you can disable pymalloc at runtime using: PYTHONMALLOC=malloc

[issue24416] Have date.isocalendar() return a structseq instance

STINNER Victor added the comment: > It seems to affect performance. Oh ok. So this change makes .isocalendar() slower and breaks the backward compatibility on the serialization. I'm not longer sure that it's worth it. I defer the decision the datetime module maintainers: Alexander Beloposky

[issue38037] Assertion failed: object has negative ref count

Joannah Nanjekye added the comment: I will look after my next meeting which is in 10 minutes. In the meantime have you perused this PR : https://github.com/python/cpython/pull/15701 If it can solve this? -- ___ Python tracker

[issue24011] Add error checks to PyInit_signal()

STINNER Victor added the comment: There is a regression related to reference count: see bpo-38037. -- nosy: +vstinner ___ Python tracker ___

[issue38037] Assertion failed: object has negative ref count

STINNER Victor added the comment: This issue is a Python 3.8 regression. Joannah: Would you mind to have a look? x = DefaultHandler = PyLong_FromVoidPtr((void *)SIG_DFL); if (PyModule_AddObject(m, "SIG_DFL", x)) goto finally; This change is not easy to read. DefaultHandler

[issue14689] make PYTHONWARNINGS variable work in libpython

STINNER Victor added the comment: I close the issue since it's now fixed ;-) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8 -Python 3.5 ___ Python tracker

[issue14689] make PYTHONWARNINGS variable work in libpython

STINNER Victor added the comment: I refactored deeply Modules/main.c and moved the code to Python/initconfig.c and Python/preconfig.c. There is now a public C API to access to all configuration parameters documented at: https://docs.python.org/dev/c-api/init_config.html The design document

Re: "How to protect the python code"

On Thu, Sep 5, 2019 at 5:49 AM Saba Kauser wrote: > Hello Experts, > > I am looking for ways available to protect the python source code from > being available to users for write/modify. > Is it a good idea to think that python source code can be protected? > > I am aware that there are ways

[issue38045] enum.Flag instance creation is slow

Change by STINNER Victor : -- title: Flag instance creation is slow -> enum.Flag instance creation is slow ___ Python tracker ___

Where can I find libtiff binary for 64-bit windows - for use in conjunction with Python package libtiff

Hi there! I'm using Python package libtiff on Windows (version 0.4.2) - see also https://github.com/pearu/pylibtiff. For this package to work well, it requires you to have a libtiff.dll in your PATH. For 32-bits I got my DLL here: http://gnuwin32.sourceforge.net/packages/tiff.htm (version

[issue38045] Flag instance creation is slow

Serhiy Storchaka added the comment: The fast method to check if the value is a power of two: not value & (value - 1) -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue38042] Crash on double list(lxml.etree.iterparse(f))

STINNER Victor added the comment: https://github.com/python/cpython/commit/8cbffc4d96d1da0fbc38da6f34f2da30c5ffd601 has been merged after 3.7.4 has been released, correct. I will be part of the next 3.7.5 release. About the workflow: we close a bug once the change is merged into the

[issue38045] Flag instance creation is slow

New submission from Antony Lee : Consider the following example from enum import Flag F = Flag("F", list("abcdefghijklm")) for idx in range(2**len(F) - 1): F(idx) creating all possible combos of 13 flags, so 8192 instances (yes, I know the instances are cached later, but

[issue38044] unittest causing segfaults with string malloc in c++ module

New submission from Jeremy : If a unittest is written which accesses a module written in C++ (I used Pybind11 to allow Python access) which uses malloc for a string, a segmentation fault is caused. This is not replicated when malloc is used for some other data types such as int, char or

[issue38042] Crash on double list(lxml.etree.iterparse(f))

Alexander Kurakin added the comment: Ok, thanks! Good that I was too lazy to open bug in June because our colleague did it better then me :) Seems like the fix doesn't present in current 3.7 version (3.7.4). Will try in 3.7.5 and will close UPD: Oh, closed? Ok. But *no*, it's not fixed in

[issue38042] Crash on double list(lxml.etree.iterparse(f))

STINNER Victor added the comment: I understand that this bug is a duplicate of bpo-37467 that I fixed recently in 3.7, 3.8 and master branches: commit f9b7457bd7f438263e0d2dd1f70589ad56a2585e Author: Victor Stinner Date: Mon Jul 1 16:51:18 2019 +0200 bpo-37467: Fix PyErr_Display()

[issue37380] subprocess.Popen._cleanup() "The handle is invalid" error when some old process is gone

STINNER Victor added the comment: Steve Dower: "I triggered automatic backports to see how they go. Doesn't necessarily mean we'll merge them without looking more closely, but may as well check out what our automated tools suggest." Thanks, I merged the backports. --

[issue27145] long_add and long_sub might return a new int where _ints[x] could be returned

Change by hongweipeng : -- pull_requests: +15370 pull_request: https://github.com/python/cpython/pull/15716 ___ Python tracker ___

[issue38042] Crash on double list(lxml.etree.iterparse(f))

Serhiy Storchaka added the comment: Indeed, there is a bug in Python. It can be reproduced without lxml: $ ./python -c "raise SyntaxError('error', (b'file', 1, 2, 'text'))" Traceback (most recent call last): File "", line 1, in python: Objects/unicodeobject.c:397:

[issue37380] subprocess.Popen._cleanup() "The handle is invalid" error when some old process is gone

STINNER Victor added the comment: Thanks Ruslan Kuprieiev for the bug report and the fix. Thanks Eryk Sun (as usual!) for the great analysis of this issue. Ok, the bug should now be fixed in 3.7, 3.8 and master branches. I chose to not fix Python 2.7: see my previous comment. See bpo-37410

[issue37380] subprocess.Popen._cleanup() "The handle is invalid" error when some old process is gone

STINNER Victor added the comment: New changeset 1e2707d7e82aedf73c59772bc7aa228286323c3c by Victor Stinner (Miss Islington (bot)) in branch '3.7': bpo-37380: subprocess: don't use _active on win (GH-14360) (GH-15706)

[issue37380] subprocess.Popen._cleanup() "The handle is invalid" error when some old process is gone

STINNER Victor added the comment: New changeset 4d1abedce9422473af2ac78047e55cde73208208 by Victor Stinner (Miss Islington (bot)) in branch '3.8': bpo-37380: subprocess: don't use _active on win (GH-14360) (GH-15707)

[issue37380] subprocess.Popen._cleanup() "The handle is invalid" error when some old process is gone

STINNER Victor added the comment: > When a Popen instance is finalized by the garbage collector, the internal > handle is also finalized and closed despite the instance being put on the > active list. This results in _cleanup throwing because the handle can no > longer be used. Right,

[issue38042] Crash on double list(lxml.etree.iterparse(f))

Alexander Kurakin added the comment: Yes, I do. Please read all. 1) According to https://bugs.launchpad.net/lxml/+bug/1833050 (by lxml author's opinion) it's not a lxml bug. 2) I wouldn't said that but according to backtrace we have crash at Python-time. 3) Moreover crash existence depends

[issue38042] Crash on double list(lxml.etree.iterparse(f))

Serhiy Storchaka added the comment: This tracker is for bugs in CPython (the C implementation of Python). lxml is not a part of the standard library. Please use a proper tracker for reporting a bug in lxml. -- nosy: +serhiy.storchaka resolution: -> third party stage: -> resolved

[issue34037] asyncio: BaseEventLoop.close() shutdowns the executor without waiting causing leak of dangling threads

Kyle Stanley added the comment: > Any plan to reapply my change, or fix it? I can try to help with this. I'm not the most familiar with the internals of asyncio, but I think it would provide a good learning experience. -- nosy: +aeros167 ___

[issue34037] asyncio: BaseEventLoop.close() shutdowns the executor without waiting causing leak of dangling threads

STINNER Victor added the comment: This bug still occurs randomly on the CI. Example on AppVeyor: https://ci.appveyor.com/project/python/cpython/builds/27209898 test_reader_callback (test.test_asyncio.test_events.SelectEventLoopTests) ... ok test_remove_fds_after_closing

Re: Renaming an import

Rob Gaddi wrote: > I'm trying to figure out how to rename an import globally for an entire > package. > Something like: > > pkg/__init__.py: > import graphing_module_b as graph If you want to go low-level: sys.modules["pkg.graph"] = graph will make > pkg/foobar.py: > from .graph