Alex Lord added the comment:
Adding a patch for 3.6 since 3.5 is in beta.
--
versions: +Python 3.6 -Python 3.5
Added file: http://bugs.python.org/file39677/replace_lastrowid_3_6.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Alex Lord added the comment:
Oh, alright. That makes a lot of sense. Sorry for being dense. I should have
read the docs on subtest.
All lines are under 80 characters and I modified the unit test to use subtest.
Thanks for taking the time to walk me through this.
--
Added file: http
Alex Lord added the comment:
There was a bunch of things wrong with that patch.
In addition to the issues you brought up in the review I was mixing up what the
actual problem is
REPLACE INTO is an alias for INSERT OR REPLACE. INSERT OR REPLACE was correctly
setting the lastrowid values
Changes by Alex Lord lostdogs...@gmail.com:
Added file: http://bugs.python.org/file39367/sqlite_lastrowid_35_updated_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16864
Changes by Alex Lord lostdogs...@gmail.com:
Added file: http://bugs.python.org/file39366/sqlite_lastrowid_35_updated.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16864
Alex Lord added the comment:
Went back to test to see if the other statements are covered already. Unit
tests show that lastrowid is set properly no matter what form of sqlite insert
statement is used.
sqlite_lastrowid_35_v2.patch contains the doc changes, unit test changes, and
code change
Alex Lord added the comment:
Thanks for Alex_gayner and lifeless. They pointed out the sqlite3_last_row_id
is part of the sqlite3 module itself (not cpython).
https://www.sqlite.org/c3ref/last_insert_rowid.html
According the documentation we can expect that if a constraint stops an
insertion
Alex Lord added the comment:
Updated the patch to have a versionchanged for lastrowid in
Doc/Library/sqlite3.rst and Doc/whatsnew/3.5.rst
One thing of note is that I wasn't able to get the indentation to be on the
same level for sqlite3.rst (it would either intent the description text
Alex Lord added the comment:
../cpython/python.exe test_xmlparser_setevents.py
__del__ 1
__del__ 3
Segmentation fault: 11
Confirmation on 3.5.0a4 Python 3.5.0a4+
--
nosy: +Alex.Lord
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Alex Lord added the comment:
Any follow up on this?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18262
___
___
Python-bugs-list mailing list
Alex Lord added the comment:
I've added a set of tests which test the insert or [algorithm] branch of
sqlite. It took some getting used to python.sqlite3's transaction model but I
think I have a much better understanding now.
--
keywords: +patch
Added file: http://bugs.python.org
Changes by Alex Lord lostdogs...@gmail.com:
--
components: +Library (Lib)
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21250
___
___
Python-bugs
Alex Lord added the comment:
Ah, Alright. I thought that hg up would bring me up to speed. Sorry for that.
--
status: pending - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23939
Changes by Alex Lord lostdogs...@gmail.com:
--
components: +Macintosh
nosy: +ned.deily, ronaldoussoren
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23939
New submission from Alex Lord:
On a fresh clone of cpython 3.5.0a0 if you run
$ ./configure --with-pydebug make -j2
$ ./python.exe -m test.test__osx_support -j3
on osx 10.10.2 (14C109) these two test failures are reported
Changes by Alex Lord lostdogs...@gmail.com:
--
components: +Macintosh
nosy: +ned.deily, ronaldoussoren
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23940
New submission from Alex Lord:
On a fresh clone of cpython 3.5.0a0 if you run
$ ./configure --with-pydebug make -j2
$ ./python.exe -m test.test__osx_support -j3
on osx 10.10.2 (14C109) these two test failures are reported
Alex Lord added the comment:
Just adding that I have also run into this problem.
--
nosy: +Alex.Lord
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22212
Alex Lord added the comment:
Have a unit test that replicates this bug. Working on the C code to fix it
right now.
--
nosy: +Alex.Lord
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16864
Alex Lord added the comment:
Patch that fixes Issue16864. Follows Jim Minters suggestion.
Unit test will reproduce the issue without the c modifications. C modifications
fix the issue.
--
keywords: +patch
Added file: http://bugs.python.org/file34953/Issue16864_py35.patch
New submission from Alex Lord:
In Lib/sqlite3/tests/dbapi.py there are no unit tests which test out sqlite3's
'insert or [algorithm].' These algorithms are also referred to as SQL 'insert
on conflict.'
More details at,
https://www.sqlite.org/lang_conflict.html
Not having unit tests
Alex Lord added the comment:
Yes, I'm going to work on one after I fix Issue16864 today.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21250
Alex Lord added the comment:
Here's a documentation patch for 2.7 that informs the users that Zipfile.extra
and Zipfile.extraall don't save permissions and that Zipfile.writestr will use
ZipInfo.extra_attr or default to chmod permission set of 0600.
--
keywords: +patch
nosy
Alex Lord added the comment:
And here's the 3.4 and 3.5 patch
--
Added file: http://bugs.python.org/file34859/Issue18262_34_35.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18262
24 matches
Mail list logo
