New submission from Claudiu.Popa:
Hello.
Here's a short patch for dbm.dumb, which uses in various places the `with`
statement for opening and closing files. Thanks.
--
components: Library (Lib)
files: dbm_with_open.patch
keywords: patch
messages: 220335
nosy: Claudiu.Popa
Claudiu.Popa added the comment:
This doesn't seem to be the case for Python 3.4. Also, _ast.arguments didn't
have lineno and col_offset attributes neither in Python 2. But the _arg.arg
nodes have those attributes, as seen in this example.
from ast import parse
parse(
... def test(a): pass
Changes by Claudiu.Popa pcmantic...@gmail.com:
--
nosy: +Claudiu.Popa
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16512
___
___
Python-bugs-list
Changes by Claudiu.Popa pcmantic...@gmail.com:
--
versions: +Python 3.5 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16512
Claudiu.Popa added the comment:
Using \xff\xd8 sounds good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16512
___
___
Python-bugs-list
Claudiu.Popa added the comment:
Can we close this? The feature already landed in Python 3.4.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17457
Claudiu.Popa added the comment:
Any type of feedback will be appreciated.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19840
___
___
Python
Claudiu.Popa added the comment:
Since issue15745 hasn't been fixed yet, would be okay to skip these tests when
the test suite runs from a ZFS container? Currently, these failures are a
nuissance when running the test suite.
--
___
Python tracker
Claudiu.Popa added the comment:
Thanks for the reviews, Serhiy. Here's the new version of the patch.
--
Added file: http://bugs.python.org/file35549/issue18039_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18039
Claudiu.Popa added the comment:
Here's a patch that marks those tests as expected failures if the source
checkout is inside a zfs container. It uses `df -t zfs`, it was the easiest way
I could find to detect that we are running from a zfs container.
--
keywords: +patch
Added file
Claudiu.Popa added the comment:
Thanks, David. The new version of the patch is attached.
--
Added file: http://bugs.python.org/file35554/issue19840_1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19840
Changes by Claudiu.Popa pcmantic...@gmail.com:
Added file: http://bugs.python.org/file3/issue18039_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18039
Claudiu.Popa added the comment:
Thanks, Serhiy. Here's the new version of the patch. Hope that the warning
message is clear enough.
--
Added file: http://bugs.python.org/file35544/issue18039_1.patch
___
Python tracker rep...@bugs.python.org
http
New submission from Claudiu.Popa:
Hello!
Working with Shelf instances in the interactive console is cumbersome because
you can't have an instant feedback when running the following:
from shelve import Shelf
s = Shelf({})
s['a'] = 1
s
shelve.Shelf object at 0x033D0AF0
This patch adds
Claudiu.Popa added the comment:
It's actually better to close the socket in __init__ in this case.
--
Added file: http://bugs.python.org/file35466/issue21641.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21641
New submission from Claudiu.Popa:
To be precise, when running test_urllib on a machine with a local FTP server,
but with a set of credentials different than the ones used by
test_urllib.urlopen_HttpTests.test_ftp_nonexisting. In this case, ftpwrapper
from urllib.request will succesfully
New submission from Claudiu.Popa:
Running asyncio tests on Windows will give a ResourceWarning. The attached
patch fixes this problem.
[1/1] test_asyncio
D:\Projects\cpython\lib\test\test_asyncio\test_events.py:233: ResourceWarning:
unclosed socket.socket fd=668, family=AddressFamily.AF_INET
Changes by Claudiu.Popa pcmantic...@gmail.com:
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18039
___
___
Python-bugs
Claudiu.Popa added the comment:
Serhiy, could you please have a look at this patch? Given the fact that you
committed my last dbm patch, I hope you have a couple of minutes to have a look
at this one as well.
--
___
Python tracker rep
Claudiu.Popa added the comment:
There are other modules with support for bytes filenames in their API:
bz2
codecs
gzip
lzma
pipes.Template
tarfile
tokenize
fileinput
filecmp
sndhdr
New submission from Claudiu.Popa:
Hello! The attached patch fixes a crash for the logging tests on Windows.
That's because the tests assume that socket.AF_UNIX exists. The actual
traceback is:
[1/1] test_logging
test test_logging crashed -- Traceback (most recent call last):
File D
Claudiu.Popa added the comment:
No, because the tests will be skipped after the assignment of the address
family.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21636
New submission from Claudiu.Popa:
Given the following code, tracemalloc crashes with:
Floating point exception: 8 (core dumped)
import tracemalloc
tracemalloc.start(10)
import io
io.StringIO()
The culprit is this line assert(nelem = PY_SIZE_MAX / elsize); from
tracemalloc_alloc. elsize is 0
Claudiu.Popa added the comment:
An alternative to this approach would be to catch the error in __init__ and
close the socket there.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21641
New submission from Claudiu.Popa:
Hello!
I noticed that test_smtplib raises a ResourceWarning, tracking this to this
piece of code:
self.assertRaises(smtplib.SMTPResponseException, smtplib.SMTP,
HOST, self.port, 'localhost', 3)
What happens is that `SMTP.getreply
Claudiu.Popa added the comment:
Looks good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19385
___
___
Python-bugs-list mailing list
Claudiu.Popa added the comment:
Thanks. Patch modified.
--
Added file: http://bugs.python.org/file35376/issue10203_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10203
New submission from Claudiu.Popa:
Hello.
This patch proposes using `assertIn` in the first unittest example, instead of
`assertTrue(x in seq)`. This is clearer and recommending it first is better for
beginners.
--
assignee: docs@python
components: Documentation
files
Claudiu.Popa added the comment:
Thanks. Here's a fix.
--
Added file: http://bugs.python.org/file35373/issue10203_1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10203
Claudiu.Popa added the comment:
Sounds good, I'll create a patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21574
___
___
Python-bugs-list
Claudiu.Popa added the comment:
Thanks. Here's the updated patch. It supports negative indeces (my previous
patch didn't do that).
--
Added file: http://bugs.python.org/file35354/issue10203.patch
___
Python tracker rep...@bugs.python.org
http
Claudiu.Popa added the comment:
Here's an updated patch.
--
Added file: http://bugs.python.org/file35355/issue21493.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21493
Claudiu.Popa added the comment:
Moving `self.crc = zlib.crc32(data, self.crc) 0x` before `self.size =
self.size + len(data)` should be enough. Also, your patch needs a test.
--
nosy: +Claudiu.Popa
___
Python tracker rep...@bugs.python.org
Claudiu.Popa added the comment:
I don't think that adding it to Tools/script helps that much on Windows at
least. See issue21027 for reference. Except this, +1 from me.
--
nosy: +Claudiu.Popa
___
Python tracker rep...@bugs.python.org
http
Changes by Claudiu.Popa pcmantic...@gmail.com:
--
nosy: -Claudiu.Popa
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21090
___
___
Python-bugs
Claudiu.Popa added the comment:
I'm working on this issue and I have a minimal patch ready, but it depends on
issue21518, which proposes adding UnloadKey to winreg, so that we can unload
the keys mounted with LoadKey. Also, that issue adds a mechanism for privilege
acquisition, which I'll
Claudiu.Popa added the comment:
This version of the patch skips the test if the privileges can't be acquired.
--
Added file: http://bugs.python.org/file35285/issue21518.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21518
New submission from Claudiu.Popa:
As the title says, ThreadPoolExecutor does not use a default value for
max_workers parameter, as ProcessPoolExecutor does. When the user does not care
about the number of workers and wants only for something to run in background,
he has to write code like
Claudiu.Popa added the comment:
Thanks. Here's the updated version. Also, I only tested it on Windows 8.1. I'll
try to find another machine with an older OS for testing it.
--
Added file: http://bugs.python.org/file35288/issue21518_1.patch
New submission from Claudiu.Popa:
Hello. While working on issue8579, I noticed that there is no way to detach a
key from the registry, loaded with LoadKey function. The attached patch exposes
RegUnLoadKeyW as winreg.UnloadKey. Also, this patch adds a new script in the
test folder
Claudiu.Popa added the comment:
It needs administrator elevation for running the test. I'll update the patch to
skip the test if the user doesn't have elevation.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21518
Claudiu.Popa added the comment:
Attached the new version of the patch which removes the resource warnings.
Raymond, I disagree on certain points. `difflib -m` does help the development,
especially for platforms where there aren't many readily available alternatives
(like Windows). I gave
Changes by Claudiu.Popa pcmantic...@gmail.com:
Added file: http://bugs.python.org/file35247/issue21027_1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21027
Claudiu.Popa added the comment:
Added a new version of the patch with improvements suggested by Berker Peksag.
Thanks for the review!
--
Added file: http://bugs.python.org/file35237/issue19776.patch
___
Python tracker rep...@bugs.python.org
http
New submission from Claudiu.Popa:
Hello. This patch adds a test for ntpath.expanduser, which was missing. Also,
it increases the test coverage for ntpath.py from 68% to 75%.
--
components: Tests
files: expanduser.patch
keywords: patch
messages: 218427
nosy: Claudiu.Popa
priority
Claudiu.Popa added the comment:
But it improves the API. It's much nicer to actually access the values returned
by sndhdr as f.type, f.sampling_rate, f.channels than f[0], f[1], f[2]. You do
have a point though. Would it be more acceptable if we'll provide a new
function which returns
Claudiu.Popa added the comment:
Right, my benchmark was indeed flawed. Here are the new results on my machine:
Without the patch
# ./python -S -m timeit -n 10 -s import dbm.dumb as dbm;
d=dbm.open('x.dat', 'c') len(d)
10 loops, best of 3: 0.564 usec per loop
With the patch
# ./python
Claudiu.Popa added the comment:
Here's a new patch which uses the EAFP approach for dunder methods (__len__,
__contains__ etc) and the _verify_open method for the other methods (.keys,
.iterkeys) etc. Now the results are similar with the benchmark without the
patch.
--
Added file
Changes by Claudiu.Popa pcmantic...@gmail.com:
--
nosy: +Claudiu.Popa
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21436
___
___
Python-bugs-list
Claudiu.Popa added the comment:
Updated patch according to the python-dev thread:
- processes renamed to workers
- `workers` defaults to 1
- When `workers` is equal to 0, then `os.cpu_count` will be used
- When `workers` 1, multiple processes will be used
- When `workers` == 1, run normally
Claudiu.Popa added the comment:
Do you mean int.from_bytes?
It's already changed in Python 3.5: int.from_bytes(_urandom(32), 'big').
--
nosy: +Claudiu.Popa
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21394
Claudiu.Popa added the comment:
Do you have a module/file named concurrent.py in your PATH?
--
nosy: +Claudiu.Popa
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21378
Claudiu.Popa added the comment:
In Python 3 docs there is a hint in the documentation for `loadTestsFromModule`:
This method searches module for classes derived from TestCase and creates an
instance of the class for each test method defined for the class.
The phrase with a fixture per test
Claudiu.Popa added the comment:
Ping? The change is clear, has the same semantics and its a little bit faster.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20642
Claudiu.Popa added the comment:
Can anyone review this patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18039
___
___
Python-bugs-list
Claudiu.Popa added the comment:
Ping. :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18615
___
___
Python-bugs-list mailing list
Unsubscribe
New submission from Claudiu.Popa:
Due to some bad math on my side, I passed max_workers=0 to
concurrent.futures.ThreadPoolExecutor. This didn't fail properly, but hanged.
The same behaviour occurs in ProcessPoolExecutor, but this time it fails
internally with something like this:
Exception
Claudiu.Popa added the comment:
For instance, multiprocessing behaves like this:
multiprocessing.Pool(-1)
Traceback (most recent call last):
File stdin, line 1, in module
File C:\Python34\lib\multiprocessing\context.py, line 118, in Pool
context=self.get_context())
File C:\Python34
Claudiu.Popa added the comment:
Added a new patch with improvements suggested by Jim. Thanks!
I removed the handling of processes=1, because it can still be useful: having a
background worker which processes the files received from _walk_dir. Also, it
checks that compile_dir receives
Claudiu.Popa added the comment:
Add new patch with fixes proposed by Berker Peksag. Thanks for the review.
Hopefully, this is the last iteration of this patch.
--
Added file: http://bugs.python.org/file35055/issue16104_10.patch
___
Python tracker
Changes by Claudiu.Popa pcmantic...@gmail.com:
Added file: http://bugs.python.org/file35056/issue16104_11.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16104
Claudiu.Popa added the comment:
Attached patch with improvements suggested by Charles-François Natali. Thank
you for the review.
--
Added file: http://bugs.python.org/file35057/issue21362.patch
___
Python tracker rep...@bugs.python.org
http
Changes by Claudiu.Popa pcmantic...@gmail.com:
Added file: http://bugs.python.org/file35058/issue21362_1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21362
Changes by Claudiu.Popa pcmantic...@gmail.com:
--
nosy: +sbt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21367
___
___
Python-bugs-list mailing
Claudiu.Popa added the comment:
Added a new version of the patch which incorporates suggestions made by Jim.
Thanks for the review!
--
Added file: http://bugs.python.org/file35018/issue16104_8.patch
___
Python tracker rep...@bugs.python.org
http
Claudiu.Popa added the comment:
It would be easier to review your patch if you'll upload it as a proper patch.
Usually for these cases (modifying the return by passing a specific argument)
it's best to provide a new function with this functionality, by having
get_close_matches
Claudiu.Popa added the comment:
Ah, nevermind my first comment.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21344
___
___
Python-bugs-list
Claudiu.Popa added the comment:
Your patch needs tests and documentation update. For examples, you could look
in test_difflib.py and see how get_close_matches is tested.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21344
Claudiu.Popa added the comment:
I have updated the previous patch, by documenting the new class method.
--
versions: +Python 3.5 -Python 3.4
Added file: http://bugs.python.org/file35027/issue9731.patch
___
Python tracker rep...@bugs.python.org
http
Claudiu.Popa added the comment:
gzip uses the same name, _check_closed, but your suggestion sounds good. I'll
update the patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19385
Claudiu.Popa added the comment:
Python's interactive interpreter doesn't show the offending code lines too. And
given the fact that code.InteractiveInterpreter tries to be an emulation of the
default interpreter, first the change should be addressed directly there, I
think. But I agree
Claudiu.Popa added the comment:
On my machine I get the following results for the unclosed-database case.
With patch:
# ./python -S -m timeit -n 10 -s import dbm.dumb as dbm;
d=dbm.open('x.dat', 'c');len(d)
10 loops, best of 3: 0.0638 usec per loop
Without patch:
# ./python -S -m
Claudiu.Popa added the comment:
Hi. I added a couple of comments for your previous patch, the new one doesn't
seem to have a review link.
--
nosy: +Claudiu.Popa
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20752
Claudiu.Popa added the comment:
Raymond, any news on this?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21027
___
___
Python-bugs-list mailing
Claudiu.Popa added the comment:
Hello. I added a couple of comments to your latest patch.
--
nosy: +Claudiu.Popa
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15795
Claudiu.Popa added the comment:
- We added tests of decorated classes. The source of decorated classes does
not include the decorators, which is different than the usual behavior of
decorated functions. What is the correct behavior here?
There is an open issue for this, http
Claudiu.Popa added the comment:
If there is anything left to do for this patch, please tell me.
--
Added file: http://bugs.python.org/file34837/issue19546.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19546
Claudiu.Popa added the comment:
Added patch which addresses the comments of Berker Peksag. Thanks for the
review!
--
Added file: http://bugs.python.org/file34786/issue19628_1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Claudiu.Popa added the comment:
Ping. :) Can someone review this patch, please?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19628
New submission from Claudiu.Popa:
The error message from the title is not very intuitive from a user point of
view. For instance, in the following traceback, only the first one gives a
meaning to this error, through the leaked KeyError, thus the user knows that
home_dir1 is invalid
Claudiu.Popa added the comment:
I've created a new issue for the InterpolationMissingOptionError message,
issue21159. This issue can be closed.
--
resolution: - 3rd party
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19546
Claudiu.Popa added the comment:
Ups, sorry for the change of resolution.
--
resolution: 3rd party -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19546
Claudiu.Popa added the comment:
Yury, Nick, how is my latest patch?
--
Added file: http://bugs.python.org/file34733/issue15582_1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15582
Claudiu.Popa added the comment:
But the last traceback conveys enough information, the user can see immediately
that the given section does not exist.
My problem with the current behaviour is that the first error distracts the
user, while the actual problem is the second traceback.
But I have
Changes by Claudiu.Popa pcmantic...@gmail.com:
--
nosy: +Claudiu.Popa
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21090
___
___
Python-bugs-list
Claudiu.Popa added the comment:
What can I do to move this forward? I believe all concerns have been addressed
and it seems ready to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16104
Changes by Claudiu.Popa pcmantic...@gmail.com:
Added file: http://bugs.python.org/file34570/issue19714.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19714
New submission from Claudiu.Popa:
Hello!
The attached patch proposes a new command line interface to difflib module.
Currently, `python -m difflib` does nothing useful, it runs the doc suite for
the difflib module.
Right now, there are a couple of modules in the standard lib, which provides
Changes by Claudiu.Popa pcmantic...@gmail.com:
Added file: http://bugs.python.org/file34572/difflib_cli.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21027
Claudiu.Popa added the comment:
Here's a new patch which addresses the comments of berker.peksag. Thank you for
the review!
--
Added file: http://bugs.python.org/file34573/issue21027.patch
___
Python tracker rep...@bugs.python.org
http
Claudiu.Popa added the comment:
Hello. Here's a patch for this issue. It tests only the conditions described by
Eric.
--
keywords: +patch
nosy: +Claudiu.Popa
Added file: http://bugs.python.org/file34549/issue19714.patch
___
Python tracker rep
Claudiu.Popa added the comment:
My pleasure!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20627
___
___
Python-bugs-list mailing list
New submission from Claudiu.Popa:
There is an invalid item meth:`resume_reading`.
--
assignee: docs@python
components: Documentation
files: asyncio_doc_fix.patch
keywords: patch
messages: 214381
nosy: Claudiu.Popa, docs@python
priority: normal
severity: normal
status: open
title
Changes by Claudiu.Popa pcmantic...@gmail.com:
Added file: http://bugs.python.org/file34553/issue19714.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19714
Claudiu.Popa added the comment:
Hello. I left a couple of comments on Rietveld.
--
nosy: +Claudiu.Popa
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20375
Claudiu.Popa added the comment:
Hello. In 3.3 you can instantiate META class, because it does not properly say
that it wants abc.ABCMeta as a metaclass. For this, you have to write your
class as such:
class META(metaclass=abc.ABCMeta):
@abc.abstractmethod
def _junk(self
Claudiu.Popa added the comment:
Now that the 3.5 branch is the default, can this feature be committed?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20627
Claudiu.Popa added the comment:
Can this patch be committed, now that 3.5 is active?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19385
Claudiu.Popa added the comment:
What can be done to move this forward?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10203
___
___
Python-bugs
Changes by Claudiu.Popa pcmantic...@gmail.com:
--
versions: +Python 3.5 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18615
1 - 100 of 271 matches
Mail list logo