Changes by Eli Bendersky eli...@gmail.com:
--
stage: - needs patch
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17989
Eli Bendersky added the comment:
Fixed. Thanks for the report!
Python 3.4.0a0 (default:1b760f926846+9682241dc8fc+, May 18 2013, 07:52:49)
[GCC 4.6.3] on linux
Type help, copyright, credits or license for more information.
import xml.etree.ElementTree as ET; j = ET.Element('j')
j.ham = 2
Changes by Eli Bendersky eli...@gmail.com:
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17989
Eli Bendersky added the comment:
These compatibility names are likely to be remnants from the out-of-tree xml
etree implementation before it made it into the stdlib. I think they can simply
be removed in 3.4, as they're not documented anywhere
Eli Bendersky added the comment:
I committed a fix with a simplified test. Thanks for the contribution, Aaron.
Also, to get your patches committed directly you need to sign the Python
contributor agreement.
--
___
Python tracker rep
Changes by Eli Bendersky eli...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17901
Eli Bendersky added the comment:
+1 for deletion of them (even in 3.3.3).
Hmm, I don't think I agree. If someone relies on this thing for some obscure
reason, breaking when the switch to 3.4 is made is still less abrasive than a
break in a maintenance version. Since this isn't strictly a bug
Eli Bendersky added the comment:
Aaron, could you please sign the PSF CLA
(http://www.python.org/psf/contrib/contrib-form/) - this will make it accepting
patches from you easier.
Other than that, I agree it's a legit patch. The alternative would be to fix
_elementtree to actually allow
Eli Bendersky added the comment:
For external APIs visible to user code, this can cause some compatibility
problems and users may need to at the very least re-compile this code. So -1
here.
For new external APIs, having const wherever appropriate should be considered
on a case by case basis
Eli Bendersky added the comment:
Antoine, I was referring to the discussion linked earlier
(http://mail.python.org/pipermail/python-dev/2006-February/060689.html). Users
of the C API needed to recompile their code and also add preprocessor hacks to
make things compatible with C and C++, AFAIU
Eli Bendersky added the comment:
Nick, could you open a separate issue for the frame hack discussion, like you
did for the other things? You can make this one depend on it, if you feel it's
a blocker, but let's please not intermix more discussion here
Eli Bendersky added the comment:
Ethan, I pasted the minimized version to point out the problem; I fully agree
it should do the getattr lookup because otherwise it's very difficult to
understand what's going on. Let's keep exceptions for actual exceptional
situations and explicitly code
Changes by Eli Bendersky eli...@gmail.com:
--
nosy: +rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17963
___
___
Python-bugs-list
Eli Bendersky added the comment:
Ethan, something is wrong with _StealthProperty. Well, two things. First, it's
way too general and can be cut to just what Enum needs. Second, this is enough
to make the tests pass:
class _StealthProperty():
Returns the value in the instance
Eli Bendersky added the comment:
Also, your test must run within the regrtest framework. Currently I get:
./python -mtest.regrtest test_enum
[1/1] test_enum
test test_enum failed -- Traceback (most recent call last):
File /home/eliben/python-src/default/Lib/test/test_enum.py, line 245
Eli Bendersky added the comment:
Benjamin, I guess you can just unlink the message from the issue? [and then
your clarification, and when again this message from me ;-)]
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17947
Changes by Eli Bendersky eli...@gmail.com:
Removed file: http://bugs.python.org/file30191/ref435.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17947
Eli Bendersky added the comment:
I don't see docs in the patch, but perhaps that should be a separate patch to
keep reviewing easier.
Also, Ethan, number the patch files in some way (like pep-435.1.patch,
pep-435.N.patch) as they go through rounds of reviews.
--
assignee: docs@python
Eli Bendersky added the comment:
A question that came up while reviewing the new enum code: module or
module_name for this extra argument? The former is shorter, but the latter is
more correct in a way.
--
___
Python tracker rep...@bugs.python.org
Eli Bendersky added the comment:
OK, I sent another batch of reviews through the code review system - Ethan you
should've gotten an email about it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17947
Eli Bendersky added the comment:
On Fri, May 10, 2013 at 7:02 AM, Guido van Rossum rep...@bugs.python.orgwrote:
Guido van Rossum added the comment:
Module, please. The class attribute is also called __module__ after all.
Makes sense. Thanks
Eli Bendersky added the comment:
Regarding module vs. module_name for the extra param in the functional API,
Guido rightly points out in issue 17941 that __module__ is the class attribute,
so module is a consistent choice.
--
___
Python tracker rep
Eli Bendersky added the comment:
By the way, if anyone is willing to take on the documentation, that could be of
great help. It shouldn't be very hard since PEP 435 is extremely detailed. The
stdlib .rst doc would be the descriptions from PEP 435 plus a reference of the
exposed classes which
Eli Bendersky added the comment:
On Fri, May 10, 2013 at 8:09 PM, Nick Coghlan rep...@bugs.python.orgwrote:
Nick Coghlan added the comment:
Two requests:
1. Lose the frame hack. With the explicit module=__name__ API available,
the implicit fragile magic isn't necessary and leads to Enum
Eli Bendersky added the comment:
2. Mike Bayer (SQL Alchemy author) has requested the ability to derive a
custom metaclass that turns off the Enums-with-members-are-final
subclassing restriction (relaxing the rule that members of an enum are
instances of that enum to members of an enum
New submission from Eli Bendersky:
[this came up as part of the Enum discussions. Full details in this thread:
http://mail.python.org/pipermail/python-dev/2013-May/126076.html]
namedtuple currently uses this code to obtain the __module__ for the class it
creates dynamically so that pickling
I made a video tutorial for making a guess the number game in python. You can
check it out here: http://www.youtube.com/watch?v=0WSQb-7wMJQ
--
http://mail.python.org/mailman/listinfo/python-list
Eli Bendersky added the comment:
Thanks for the heads up Chris. Since I'm a bit busy myself lately, it's fine to
wait until you have time to complete the patch. I'll review it then.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Changes by Eli Bendersky eli...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17736
Eli Bendersky added the comment:
LGTM!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17670
___
___
Python-bugs-list mailing list
Unsubscribe
Eli Bendersky added the comment:
Antoine, the patch LGTM. There's some more cleaning that needs to be done in
surrounding code, but I can do that later. Also I should probably update the
documentation with a bit more details.
Just add a NEWS entry when you commit.
Thanks for working
Eli Bendersky added the comment:
It's better, although the distinction between tab column and tab position
is not entirely clear.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17670
Eli Bendersky added the comment:
Thanks Antoine. This looks interesting - I'm somewhat swamped ATM but will try
to review the patch in the next few days.
Incidentally, since it is a new feature would it be worthwhile to discuss it on
python-ideas
Eli Bendersky added the comment:
You can ask on the python-dev mailing list. It's possible that other Python
developers ran into a similar issue.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16954
Eli Bendersky added the comment:
Issue #17375 supersedes this one. Please post updated patches there.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12768
Changes by Eli Bendersky eli...@gmail.com:
--
resolution: - duplicate
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12768
Eli Bendersky added the comment:
I've opened a libffi issue in an attempt to get this fixed upstream:
https://github.com/atgreen/libffi/issues/33
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16575
Eli Bendersky added the comment:
I agree the doc could be clearer and Ned's example is very good. However I'd go
one step forward and add a further elaboration of how the method works. This is
the current doc (in default branch):
Return a copy of the string where all tab characters
Eli Bendersky added the comment:
David, would you like to pursue this further (figuring out how to make
docstrings show in help() without duplicating?)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16954
Eli Bendersky added the comment:
Thanks, looks much better now. I left a couple of small comments in the code
review. Other than that, it makes sense to me to update the existing tests to
follow this scheme as well. Thanks!
On a related note, since you've obviously studied the filecmp
Eli Bendersky added the comment:
A lot of the code in the tests is devoted to building the tested directory tree
and populating it ( _setUpDirectories and related functions). You keep building
and deleting this tree for every running test.
I think that a better idea would be to just create
Eli Bendersky added the comment:
Top/bottom is accepted and understood nomenclature when talking about stacks.
Think about a stack of plates in the kitchen. You put a new plate on top, you
take it out from top. That's it.
Now, lists are just one way to implement stacks, and printing them
Eli Bendersky added the comment:
I actually find the growth direction confusing sometimes for the same reasons
(too much x86 assembly). This is why I wrote this blog post a while back -
mainly so I can always look at it and de-confuse myself:
http://eli.thegreenplace.net/2011/02/04/where
Eli Bendersky added the comment:
moijes12, since Raymond went ahead and committed a patch to 2.7 in #17375, I
think patches to other versions should also be based on his patch. The most
constructive thing you can do at this point is review his changes in 2.7 and
help porting them to 3.x. Also
Any other ideas?
--
http://mail.python.org/mailman/listinfo/python-list
On Monday, March 18, 2013 6:57:30 PM UTC-7, NZach wrote:
Hello everyone,
i am using the MMK.py example from a SimPy tutorial, which can be found here:
http://heather.cs.ucdavis.edu/~matloff/156/PLN/DESimIntro.pdf
I have made very little changes to the code and i have upload it
Changes by Eli Bendersky eli...@gmail.com:
--
nosy: +theller
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16575
___
___
Python-bugs-list mailing
Eli Bendersky added the comment:
See also #17375
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12768
___
___
Python-bugs-list mailing list
Eli Bendersky added the comment:
On Wed, Mar 13, 2013 at 2:52 AM, Raymond Hettinger
rep...@bugs.python.orgwrote:
Raymond Hettinger added the comment:
You didn't specify the contributor in the commit.
I'm the contributor.
Oh, I see. I thought it's taken from one of the two existing
Eli Bendersky added the comment:
Thanks for the patches - committed with slight adaptations (in default branch
the internal documentation switched from comments to docstrings).
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
Eli Bendersky added the comment:
Chris, your reply seems to indicate that you're irritated for some reason, and
I'm not sure why.
I was simply going through my open issue backlog, and since this is something
I'd like to see fixed, I noticed that you said in October that you have some
patches
Eli Bendersky added the comment:
Raymond - which patch is it? You didn't specify the contributor in the commit.
What about the duplicate issue #12768 where someone also worked to supply a
patch?
Also, you've only committed this to 2.7; why
Eli Bendersky added the comment:
Henrik, this patch fails to apply to 3.2
applying issue11367_branch32.patch
patching file Doc/library/xml.etree.elementtree.rst
Hunk #1 FAILED at 411
1 out of 1 hunks FAILED -- saving rejects to file
Doc/library/xml.etree.elementtree.rst.rej
patching file Lib
Eli Bendersky added the comment:
Marc-Andre, Can this issue be closed or are the docs lacking in some way?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17359
Eli Bendersky added the comment:
Gutzwiller, the [position] syntax means the Nth child *of its parent*. Since
you placed the second h1 into p, it's the first child of its parent. So the
library's behavior is correct here. Note:
[e.text for e in xml.findall('.//h1[1]')]
['1', '2
Eli Bendersky added the comment:
Chris Calloway, would you like to pursue this issue further?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
Eli Bendersky added the comment:
Thanks David, the patch looks good. I will commit it with some slight
modifications and touch-ups shortly.
The issue of C extension docstrings vs. Python docstrings is an interesting
one. It's a shame that help() shows empty strings, and it's a shame to
copy
Eli Bendersky added the comment:
No, according to the devguide patches for Python have to be created with 'hg
diff' and applicable with 'hg patch'. I can fix the patch in a number of ways,
but I think it's important for a new contributor to learn how to generate a
correct patch that can
Eli Bendersky added the comment:
Duplicate of #12768?
karl - feel free to review the patch submitted to that issue and offer your
insights.
--
nosy: +eli.bendersky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17375
New submission from Eli Bendersky:
While playing with ctypes a bit, I noticed a feature that doesn't appear to be
documented. Suppose I import the readdir_r function (assuming DIRENT is a
correctly declared ctypes.Structure):
DIR_p = c_void_p
DIRENT_p = POINTER(DIRENT)
DIRENT_pp = POINTER
Eli Bendersky added the comment:
Doc patch for 3.2
--
keywords: +patch
Added file: http://bugs.python.org/file29340/issue17378.1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17378
Changes by Eli Bendersky eli...@gmail.com:
--
nosy: +amaury.forgeotdarc, theller
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17378
Eli Bendersky added the comment:
The patch addresses issue16575 as well
--
nosy: +theller
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16576
I have a python program that accepts input and calculates the factorial of that
number, and i want to know if i can make it so commas get inserted in the
number.
For example: instead of 1000 it would say 1,000
--
http://mail.python.org/mailman/listinfo/python-list
Eli Bendersky added the comment:
I wouldn't expend too much effort on older versions though. So unless it's
simple to adapt, IMHO 3.3+ is good enough.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12768
Changes by Eli Bendersky eli...@gmail.com:
--
nosy: +eli.bendersky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16576
___
___
Python-bugs-list
Eli Bendersky added the comment:
I propose to start with the attached documentation fix (generated vs. 3.2 but
should be applied to all active branches).
A code fix has to be discussed more thoroughly because in theory some code
running only on x86-32 can rely on it and will break
Eli Bendersky added the comment:
I propose to start with the attached documentation fix (generated vs. 3.2 but
should be applied to all active branches).
A code fix has to be discussed more thoroughly because in theory some code
running only on x86-32 can rely on it and will break
Changes by Eli Bendersky eli...@gmail.com:
--
Removed message: http://bugs.python.org/msg183596
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16576
Changes by Eli Bendersky eli...@gmail.com:
Removed file: http://bugs.python.org/file29327/issue16576.docfix.1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16576
Changes by Eli Bendersky eli...@gmail.com:
--
nosy: +amaury.forgeotdarc, belopolsky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16576
Eli Bendersky added the comment:
I haven't read the patch in detail but I think the reference to Java's
threading model could probably be discarded. First, I don't know if it's
still true, second, I don't think anyone cares :)
I agree. It could be a remnant of a time where the threading
Hi guys, i have a program like this: (A lot of code is not included)
run = 0
while run == 0:
raw_input(Type in a function:)
if function == Example:
print (Hello World!)
else:
print (blah blah blah)
The problem is that whenever i type in example with a space after it then it
On Tuesday, March 5, 2013 3:31:13 PM UTC-8, eli m wrote:
Hi guys, i have a program like this: (A lot of code is not included)
run = 0
while run == 0:
raw_input(Type in a function:)
if function == Example:
print (Hello World!)
else:
print (blah blah blah
On Tuesday, March 5, 2013 3:47:31 PM UTC-8, emile wrote:
On 03/05/2013 03:33 PM, eli m wrote:
On Tuesday, March 5, 2013 3:31:13 PM UTC-8, eli m wrote:
Hi guys, i have a program like this: (A lot of code is not included)
run = 0
while run == 0:
function
Eli Bendersky added the comment:
Serhiy, OK - I'll look at #2175 first. But yes, Christian is right, let's wait
for the security issues to be resolved first.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10590
Eli Bendersky added the comment:
A minimal fix would be to update the documentation.
A more comprehensive fix would be to tweak ctypes to reject unions and
bit-fields when running on non-x86 (does this work for ARM and other non-Intel
archs?)
An even more comprehensive fix would be to make
Eli Bendersky added the comment:
moijes, did you address the review comments?
Does your patch apply to 3.2?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12768
Eli Bendersky added the comment:
I'm not very knowledgeable in other XML modules, but I hate to see this patch
linger. Also it's a pre-requisite for #16986, it seems.
Serhiy, since the patch is large could you give a short summary of the things
it fixes? Note that the best approach IMHO
So i have a variable called funds that i want to store the value of even after
the program is exited. My funds variable holds the total value of funds i have.
I add a certain number of funds each time i run the program by entering how
much i want to add. How would i store the funds variable to
Is there a way to display video (an avi) in tkinter without having to download
other modules? If not then are there any other options?
--
http://mail.python.org/mailman/listinfo/python-list
How would you find the slope, y intercept, and slope-intercept form equation
for a line in python?
--
http://mail.python.org/mailman/listinfo/python-list
On Monday, February 25, 2013 10:15:24 PM UTC-8, Dave Angel wrote:
On 02/25/2013 10:48 PM, eli m wrote:
On Friday, February 15, 2013 7:22:41 PM UTC-8, eli m wrote:
Any small program ideas? I would prefer to stick to command line ones.
Thanks.
Thank you guys for the suggestions
On Tuesday, February 26, 2013 4:22:10 PM UTC-8, Joshua Landau wrote:
On 26 February 2013 22:47, eli m techg...@gmail.com wrote:
How hard would it be to change one file to another and would it be a
small-medium sized program?
How do you want to change it? Like rename a file
Eli Bendersky added the comment:
Henrik. Yes, I think the change in 3.3 was intentional in order to avoid
duplication that can be a source of errors. If ET.find() does exactly what
ET.getroot().find() does, it suffices to mention it with a link. Since Element
docs come first and arguably
Eli Bendersky added the comment:
Great, thanks.
Now looking forward to the patch getting rid of the module-level globals. One
idea is explicitly pass the module into each testing class. The classes should
not rely on anything global in this respect
Eli Bendersky added the comment:
On Tue, Feb 26, 2013 at 8:08 PM, Ezio Melotti rep...@bugs.python.orgwrote:
Ezio Melotti added the comment:
The next logical step is to make all test classes in test_xml_etree
accept the ET module in some way and store it, using it to get classes
On Friday, February 15, 2013 7:22:41 PM UTC-8, eli m wrote:
Any small program ideas? I would prefer to stick to command line ones. Thanks.
Thank you guys for the suggestions. Any more?
--
http://mail.python.org/mailman/listinfo/python-list
Eli Bendersky added the comment:
Serhiy, thanks for working on this! I didn't read the whole patch yet - will
tinker with it a bit more when applying. Did you prepare the patch vs. 3.3 or
default? The two are still synced and I'd be happy to apply it to both branches.
Now, the real reason I
Eli Bendersky added the comment:
Henrik, there's no need to provide more information in 3.2 and 2.7 than in 3.3
and default. Could you just align your patches with those (i.e. same wording in
the documentation)?
--
___
Python tracker rep
Eli Bendersky added the comment:
No problems. You can go ahead and commit this patch to 3.3 and default, then. I
will review it post-commit, since I wanted to tweak some things around anyway.
--
___
Python tracker rep...@bugs.python.org
http
Changes by Eli Bendersky eli...@gmail.com:
--
versions: +Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15083
___
___
Python-bugs-list
Eli Bendersky added the comment:
+1, I've been bothered by this description of optimization for a long time.
Terry's patch LGTM
--
nosy: +eli.bendersky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17232
How long does it take for the program to import something? I am asking this
because i have like 7 imports at the beginning of my program and i am thinking
thats the reason why it is slow to start up. Thanks in advance.
--
http://mail.python.org/mailman/listinfo/python-list
Any small program ideas? I would prefer to stick to command line ones. Thanks.
--
http://mail.python.org/mailman/listinfo/python-list
On Friday, February 15, 2013 7:52:57 PM UTC-8, Mitya Sirenef wrote:
On 02/15/2013 10:22 PM, eli m wrote:
Any small program ideas? I would prefer to stick to command line ones.
Thanks.
How about these two:
- simulation of a street crossing with green/red lights allowing cars
I want to make a guess the number game (Which i have), but i want to make the
computer play the game against itself. How would i do this?
--
http://mail.python.org/mailman/listinfo/python-list
On Thursday, February 14, 2013 4:09:37 PM UTC-8, Oscar Benjamin wrote:
On 14 February 2013 23:34, eli m techgeek...@gmail.com wrote:
I want to make a guess the number game (Which i have), but i want to make
the computer play the game against itself. How would i do this?
Your
How do i make something with python that will ask the user for input, and then
use the random.choice function to select a random choice from what the user
entered.
--
http://mail.python.org/mailman/listinfo/python-list
Eli Bendersky added the comment:
moijes,
Yes, it's open. You can examine the comments for the previous patch by clicking
on the review link near the patch. You need to be logged in to the issue
tracker to see that.
--
___
Python tracker rep
401 - 500 of 1419 matches
Mail list logo
