Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25318
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26728
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
Sounds like an easy solution is to open an issue/PR against rust-cpython to
update the doctest, IMO.
--
___
Python tracker
<https://bugs.python.org/issue44
Erlend E. Aasland added the comment:
It's not removed, it's renamed (by 84f7382215b9e024a5590454726b6ae4b0ca70a0,
GH-22994, bpo-42157). You can access it using the '_ucnhash_CAPI' attribute.
--
nosy: +erlendaasland
___
Python tracker
<ht
Erlend E. Aasland added the comment:
Thanks, Christian.
--
___
Python tracker
<https://bugs.python.org/issue44389>
___
___
Python-bugs-list mailing list
Unsub
Change by Erlend E. Aasland :
--
pull_requests: +25284
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/26699
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
Ah, I see now that it's deprecated in the docs as well:
https://docs.python.org/3/library/ssl.html#ssl.OP_NO_TLSv1_3
--
___
Python tracker
<https://bugs.python.org/issue44
Erlend E. Aasland added the comment:
Let me know if you want me to open a PR that adds the correct flag and adds
deprecation wrappers to the tests.
--
___
Python tracker
<https://bugs.python.org/issue44
Erlend E. Aasland added the comment:
Yes, and judging from PEP 644, I figured the TLSv1.3 flag was _not_ deprecated.
Sorry for the misunderstanding/noise.
--
___
Python tracker
<https://bugs.python.org/issue44
Erlend E. Aasland added the comment:
But TLSv1.3 is included in openssl 1.1.1, no?
--
___
Python tracker
<https://bugs.python.org/issue44389>
___
___
Python-bug
Erlend E. Aasland added the comment:
Thanks for the report, Brother Beer.
--
___
Python tracker
<https://bugs.python.org/issue44389>
___
___
Python-bugs-list m
Change by Erlend E. Aasland :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue33450>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue32275>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
keywords: +patch
nosy: +erlendaasland
nosy_count: 1.0 -> 2.0
pull_requests: +25266
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26680
___
Python tracker
<https://bugs.p
Erlend E. Aasland added the comment:
Isn't this just an (explicit) SIGKILL? The _exit code_ seems to be -9, not the
signal number.
--
___
Python tracker
<https://bugs.python.org/issue44
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue44361>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue44360>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue44359>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Erlend E. Aasland added the comment:
Thanks, Victor :)
--
___
Python tracker
<https://bugs.python.org/issue42213>
___
___
Python-bugs-list mailing list
Unsub
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue39573>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue44331>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
Ah, I see I formulated myself a bit unclear:
Yes, we need to allocate/track every time. I just propose to do so as late as
possible, in order to avoid allocating a PyObject before we know if it is
possible to actually create the statement
Erlend E. Aasland added the comment:
... to expand: so currently, if statement creation fails, we must deallocate
the PyObject.
--
___
Python tracker
<https://bugs.python.org/issue44
Erlend E. Aasland added the comment:
> I am not sure what you mean, in the happy path you still need to GC track and
> allocate.
Currently, we allocate the object, then try to create the statement using the
SQLite API. If we create the statement first, we can do the sanity
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25156
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26567
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25155
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26566
___
Python tracker
<https://bugs.python.org/issu
New submission from Erlend E. Aasland :
Currently, pysqlite_statement_create() approx. looks like this:
1. some sanity checks (type, sql lenght, etc.)
2. allocate (PyObject_GC_New)
3. initialise members
4. determine if statement is a DML statement
5. create the statement (sqlite3_prepare_v2)
6
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25154
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26565
___
Python tracker
<https://bugs.python.org/issu
New submission from Erlend E. Aasland :
The timeout and timeout_started members of pysqlite_Connection are never used.
Suggesting to remove them.
--
assignee: erlendaasland
components: Extension Modules
messages: 395219
nosy: erlendaasland
priority: low
severity: normal
status: open
Erlend E. Aasland added the comment:
The "sql" member is also unused. Removing this will make the tp_clear method
redundant, as there are no PyObjects to clear anymore.
--
title: [sqlite3] remove unused db member from pysqlite_Statement -> [sqlite3]
remove unused
New submission from Erlend E. Aasland :
The db member of pysqlite_Statement is only "used" in the statement create
method. Suggesting to remove this. A couple of lines less of code, a couple of
bytes less per statement object.
--
Change by Erlend E. Aasland :
--
Removed message: https://bugs.python.org/msg395216
___
Python tracker
<https://bugs.python.org/issue44326>
___
___
Python-bug
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25153
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26564
___
Python tracker
<https://bugs.python.org/issu
New submission from Erlend E. Aasland :
The db member of pysqlite_Statement is only "used" in the __init__ method.
Suggesting to remove this. A couple of lines less of code, a couple of bytes
less per statement object.
--
assignee: erlendaasland
components: Extension Module
Erlend E. Aasland added the comment:
PR 26351 adds the Py_TPFLAGS_IMMUTABLETYPE type flag to all types converted to
heap type during 3.10 development.
--
___
Python tracker
<https://bugs.python.org/issue43
Erlend E. Aasland added the comment:
sqlit3.Cursor is prone to the same bug. Do you want me to create a new issue
for it, or can I reuse this issue number, Pablo? I'll see if I can create a
reproducer for that as well.
--
___
Python tracker
Erlend E. Aasland added the comment:
Thanks Mike for the report and reproducer, and Pablo for the fix!
--
___
Python tracker
<https://bugs.python.org/issue44
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue44304>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25128
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26537
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25126
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26535
___
Python tracker
<https://bugs.python.org/issu
New submission from Erlend E. Aasland :
The code that used the connection argument was removed one year before pysqlite
was included in CPython, as far as I can see. It can safely be removed.
See also:
https://github.com/ghaering/pysqlite/commit/5a009ed6fb2e90b952438f5786f93cd1e8ac8722
Change by Erlend E. Aasland :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Erlend E. Aasland :
--
___
Python tracker
<https://bugs.python.org/issue44041>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.pyth
Erlend E. Aasland added the comment:
This change breaks existing behaviour (see test below). Also,
sqlite3_column_count() is implemented as a simple lookup in SQLite; it is never
an expensive function. Suggests to add the following test instead:
diff --git a/Lib/sqlite3/test/dbapi.py b/Lib
Erlend E. Aasland added the comment:
Global module state has been established by
f461a7fc3f8740b9e79e8874175115a3474e5930 (bpo-42862, GH-24203). We can safely
migrate static variables into that struct as a next step.
--
___
Python tracker
<ht
Change by Erlend E. Aasland :
--
pull_requests: +25112
pull_request: https://github.com/python/cpython/pull/26517
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
pull_requests: +25110
pull_request: https://github.com/python/cpython/pull/26515
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
pull_requests: +25108
pull_request: https://github.com/python/cpython/pull/26512
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue42514>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue44290>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
See also bpo-39170
--
___
Python tracker
<https://bugs.python.org/issue13299>
___
___
Python-bugs-list mailing list
Unsub
Erlend E. Aasland added the comment:
See also bpo-13299
--
___
Python tracker
<https://bugs.python.org/issue39170>
___
___
Python-bugs-list mailing list
Unsub
Change by Erlend E. Aasland :
--
pull_requests: +25081
pull_request: https://github.com/python/cpython/pull/26485
___
Python tracker
<https://bugs.python.org/issue44
Erlend E. Aasland added the comment:
> Erlend, check out
> https://github.com/python/cpython/pull/26206#discussion_r643910263. After
> that we can close this issue
See msg393857: I'll add a PR for _pysqlite_connection_begin as well. After
that, we
Change by Erlend E. Aasland :
--
pull_requests: +25080
pull_request: https://github.com/python/cpython/pull/26484
___
Python tracker
<https://bugs.python.org/issue44
Erlend E. Aasland added the comment:
Also, note that if identical SQL statements are created in multiple cursors
belonging to the same connection, they will currently _not_ be added to the
connection weak ref list. See the if (self->statement->in_use) in the
Change by Erlend E. Aasland :
--
pull_requests: +25070
pull_request: https://github.com/python/cpython/pull/26475
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue44263>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
pull_requests: +25057
pull_request: https://github.com/python/cpython/pull/26462
___
Python tracker
<https://bugs.python.org/issue42
Erlend E. Aasland added the comment:
FWIW:
1st shell:
$ ./python.exe -m test test_ssl -u all -m test_get_server_certificate -F
$ ps
[...]
1271 ttys0040:01.00 ./python.exe -m test test_ssl -u all -m
test_get_server_certificate -F
2nd shell:
$ sudo errinfo -p 1271
The syscall trace
Erlend E. Aasland added the comment:
See also bpo-44229
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue43855>
___
___
Python-bug
Erlend E. Aasland added the comment:
See also bpo-43855.
--
___
Python tracker
<https://bugs.python.org/issue44229>
___
___
Python-bugs-list mailing list
Unsub
Erlend E. Aasland added the comment:
> It could be, but the same thing happens on Windows
Are you sure? All the reports are from macOS CI. Christian mentioned that it
could be similar to another ssl test failure that also happen on Windows, but
those tracebacks do not match the o
Erlend E. Aasland added the comment:
Here's the output when with test.support.verbose = True:
test_ssl: testing with 'OpenSSL 1.1.1k 25 Mar 2021' (1, 1, 1, 11, 15)
under Mac ('11.3.1', ('', '', ''), 'x86_64
Change by Erlend E. Aasland :
--
pull_requests: +25046
pull_request: https://github.com/python/cpython/pull/26452
___
Python tracker
<https://bugs.python.org/issue42
Erlend E. Aasland added the comment:
This looks useful: https://lldb.llvm.org/use/python.html
--
___
Python tracker
<https://bugs.python.org/issue38768>
___
___
Change by Erlend E. Aasland :
--
pull_requests: +25018
pull_request: https://github.com/python/cpython/pull/26423
___
Python tracker
<https://bugs.python.org/issue42
Erlend E. Aasland added the comment:
I can't contribute to that discussion, as it is on the committers ml, but I'll
keep an eye on it. I'll refrain from further development on this issue until
there's a consensus amongst the core devs
Change by Erlend E. Aasland :
--
pull_requests: +25006
pull_request: https://github.com/python/cpython/pull/26412
___
Python tracker
<https://bugs.python.org/issue43
Erlend E. Aasland added the comment:
GH 26411, run id 2687367477 also failed with an access violation:
https://github.com/python/cpython/pull/26411/checks?check_run_id=2687367477
Not in test_pha_required_nocert, but test_local_bad_hostname.
May be related
Erlend E. Aasland added the comment:
> Lib/test/test_tcl.py might use it [...]
Absolutely.
> Serhiy suggested to write an unit test for curses.ncurses_version:
> https://bugs.python.org/issue43916#msg391936
>
> This work can be done in bpo-43
Erlend E. Aasland added the comment:
I believe we can close this now, Victor. Please reopen if you disagree :)
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Erlend E. Aasland added the comment:
Hm, I'm unable to reproduce it w/addr sanitiser on macOS (FWIW).
$ ./python.exe -m test test_ssl -F -u all -m test_pha_required_nocert
Passing 1000 successful runs now. I'll see if I can get a Win dev env set up
later
Change by Erlend E. Aasland :
--
pull_requests: +24987
pull_request: https://github.com/python/cpython/pull/26394
___
Python tracker
<https://bugs.python.org/issue43
Change by Erlend E. Aasland :
--
pull_requests: +24985
pull_request: https://github.com/python/cpython/pull/26392
___
Python tracker
<https://bugs.python.org/issue43
Erlend E. Aasland added the comment:
I've opened PR's to fix most of the heap types converted during the 3.10 alpha
phase. What's missing (of the 3.10 batch) is:
- _thread types (this needs special care)
- winapi__overlapped.Overlapped (I currently don't have a Win dev env at hand
Change by Erlend E. Aasland :
--
pull_requests: +24968
pull_request: https://github.com/python/cpython/pull/26376
___
Python tracker
<https://bugs.python.org/issue42
Erlend E. Aasland added the comment:
Build info for macOS CI attached.
--
Added file: https://bugs.python.org/file50063/5_Display build info.txt
___
Python tracker
<https://bugs.python.org/issue44
Erlend E. Aasland added the comment:
New failure in CI:
https://github.com/python/cpython/runs/2669949777?check_suite_focus=true
==
ERROR: test_msg_callback_deadlock_bpo43577 (test.test_ssl.TestSSLDebug
Erlend E. Aasland added the comment:
Berker, does this look ok to you?
--
title: [sqlite3] consider removing special rollback handling -> [sqlite3]
Remove special rollback handling
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue44237>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
pull_requests: +24966
pull_request: https://github.com/python/cpython/pull/26374
___
Python tracker
<https://bugs.python.org/issue42
Erlend E. Aasland added the comment:
Thanks! Hashlib PR comin' up.
--
___
Python tracker
<https://bugs.python.org/issue42972>
___
___
Python-bugs-list mailin
Change by Erlend E. Aasland :
--
pull_requests: +24965
pull_request: https://github.com/python/cpython/pull/26373
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
pull_requests: +24964
pull_request: https://github.com/python/cpython/pull/26373
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
pull_requests: -24962
___
Python tracker
<https://bugs.python.org/issue42792>
___
___
Python-bugs-list mailing list
Unsub
Change by Erlend E. Aasland :
--
pull_requests: -24961
___
Python tracker
<https://bugs.python.org/issue42792>
___
___
Python-bugs-list mailing list
Unsub
Change by Erlend E. Aasland :
--
pull_requests: +24963
pull_request: https://github.com/python/cpython/pull/26372
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
pull_requests: +24962
pull_request: https://github.com/python/cpython/pull/26373
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
nosy_count: 4.0 -> 5.0
pull_requests: +24961
pull_request: https://github.com/python/cpython/pull/26372
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
pull_requests: +24960
pull_request: https://github.com/python/cpython/pull/26371
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
pull_requests: +24959
pull_request: https://github.com/python/cpython/pull/26370
___
Python tracker
<https://bugs.python.org/issue42
Erlend E. Aasland added the comment:
Christian, I've got a PR ready for Modules/_ssl.c, but I won't submit it if
you'd rather do it yourself. I'll stay off the sha/md5 types unless you approve
:)
--
nosy: +christian.heimes
___
Python tracker
Change by Erlend E. Aasland :
--
pull_requests: +24957
pull_request: https://github.com/python/cpython/pull/26368
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
pull_requests: +24954
pull_request: https://github.com/python/cpython/pull/26363
___
Python tracker
<https://bugs.python.org/issue42
Erlend E. Aasland added the comment:
Yes, sorry ‘bout the cryptic messages :)
This is against current main branch (I’m not at my computer right now, so I
don’t have the git ref). The first two failures came after 328 and 389 runs.
Increasing the timeout (using test.support.SHORT_TIMEOUT
Erlend E. Aasland added the comment:
$ git diff
diff --git a/Lib/ssl.py b/Lib/ssl.py
index 2b131de043..9c281d8028 100644
--- a/Lib/ssl.py
+++ b/Lib/ssl.py
@@ -257,8 +257,9 @@ class _TLSMessageType:
if sys.platform == "win32":
from _ssl import enum_certificates, enum_cr
Erlend E. Aasland added the comment:
Got it:
0:02:29 load avg: 2.81 [389] test_ssl
test test_ssl failed -- Traceback (most recent call last):
File "/Users/erlendaasland/src/cpython-ssl/Lib/test/test_ssl.py", line 2132,
in test_get_server_certificate
_test_get_server_certif
Erlend E. Aasland added the comment:
Getting there. The error message is similar:
$ ./python.exe -m test test_ssl -m test_get_server_certificate -u all -F
...
0:02:11 load avg: 2.10 [328] test_ssl
test test_ssl failed -- Traceback (most recent call last):
File "/Users/erlendaaslan
601 - 700 of 828 matches
Mail list logo