Florin Papa added the comment:
I tested and the script is no longer called if you do a "make touch" beforehand.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.py
Florin Papa added the comment:
Whenever I did a fresh clone, the Tools/scripts/generate_opcode_h.py would be
called.
Thank you for fixing this.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
New submission from Florin Papa:
Hello,
This is Florin Papa from the Dynamic Scripting Languages Optimizations team in
Intel Corporation.
In changeset 105360:46e2755b022c [1] the generate_opcode_h.py script was
modified to use tokenize.open() in order to avoid a Resource Warning
Florin Papa added the comment:
Hi Christian,
There is a Skylake buildbot that has MPX capabilities. Please find it here:
http://buildbot.python.org/all/builders/x86-64%20Ubuntu%2015.10%20Skylake%20CPU%203.6
Regards,
Florin
--
___
Python tracker
New submission from Florin Papa:
Hi,
This is Florin Papa from the Dynamic Scripting Languages Optimizations Team at
Intel Corporation.
This patch checks whether the benchmark measurement that will be included in
the csv output has more than 3 of the first decimal places equal to 0
Florin Papa added the comment:
I ran perf to use calibration and there is no difference in stability
compared to the unpatched version.
With patch:
python perf.py -b json_dump_v2 -v --csv=out1.csv --affinity=2 ../cpython/python
../cpython/python
INFO:root:Automatically selected timer
Florin Papa added the comment:
I was also talking about the variance/deviation of the mean value
displayed by perf.py, sorry if I was unclear. The perf.py output in my
previous message showed little difference between the patched and
non-patched version. I will also try increasing the number
Florin Papa added the comment:
I have tested the patch and it does not seem to solve the stability
problem.
With patch:
python performance/bm_json_v2.py -n 10 --timer perf_counter
0.02829067991115153
0.027778947027400136
0.027756798081099987
0.027362094027921557
0.027256828034296632
New submission from Florin Papa:
Hi all,
This is Florin Papa from the Dynamic Scripting Languages Optimizations Team
from Intel Corporation.
The patch submitted adds an affinity feature to the Grand Unified Python
Benchmarks suite to allow running benchmarks on a given CPU/set of CPUs
Florin Papa added the comment:
Thank you for the feedback. Please see the updated patch.
--
Added file: http://bugs.python.org/file41791/affinity_v2.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Florin Papa added the comment:
I was thinking that a warning might go unnoticed, that is why I chose to
end the program if taskset is not found. It would force the user to
install missing packages.
Otherwise the patch looks ok.
--
___
Python
Florin Papa added the comment:
I have updated the patch to throw an exception if the taskset command is not
available. Not checking that taskset works will generate an ambiguous error (if
there is no taskset on the system) that does not explicitly point to the
problem.
I believe that users
Florin Papa added the comment:
No problem :)
--
resolution: fixed ->
status: closed -> open
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Florin Papa <florin.p...@intel.com>:
--
nosy: +florin.papa
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26110>
___
_
Florin Papa added the comment:
Hi all,
Our latest effort on enabling MPX in CPython has concentrated around
eliminating all INIT_BOUNDS and BND_LEGACY attributes that are used to bypass
bounds checking for certain pointers. In order to avoid using these attributes,
we needed to find and fix
Florin Papa added the comment:
Hi all,
I fixed a compile error introduced in Python 2.7 by this issue. There is a jump
made to an nonexistent label "error" in type_new function in
Objects/typeobject.c. Please see the attached patch.
Regards,
Florin Papa
--
nosy: +florin.
Florin Papa added the comment:
No problem. Thank you for merging the patch!
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Florin Papa added the comment:
Hi Antoine,
The Py_INIT_BOUNDS calls were used because MPX generated a very large number of
error messages about pointer bounds violations at compile or run time, that
made Python unusable. The approach was to analyze the errors and ignore
checking
Florin Papa added the comment:
Hi Stefan,
> Yes, I dislike that, too. The question is why gcc has supported
> the "struct hack" for more than 20 years but needs an annotation
> just for MPX.
The "struct hack" represents a problem for MPX because it inte
Florin Papa added the comment:
I have adapted the existent patch to the new benchmarks codebase. Please see
the new patch (django_v3_2.patch) in the files section. The benchmark expects
to have django in lib/Django-1.9 folder. The Django-1.9 sources are attached
separately because
Changes by Florin Papa <florin.p...@intel.com>:
Added file: http://bugs.python.org/file41222/Django-1.9.tar.gz
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Florin Papa added the comment:
I have attached django_v3_3.patch, as the previous one did not include the
added file (performance/bm_django_v3.py).
--
Added file: http://bugs.python.org/file41223/django_v3_3.patch
___
Python tracker <
Florin Papa added the comment:
No problem. Thank you!
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue25719>
___
___
Python-bugs-
Florin Papa added the comment:
No problem. Thank you for fixing this.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue25705>
___
__
Florin Papa added the comment:
Yes, thank you for fixing this.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue25721>
___
___
Pyth
New submission from Florin Papa:
Hi all,
This is Florin Papa from the Server Languages Optimizations Team at Intel
Corporation.
The patch submitted here deprecates the spitfire benchmark, which uses psyco.
Psyco is "unmaintained and dead", according to their webs
Changes by Florin Papa <florin.p...@intel.com>:
--
type: -> crash
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue25721>
___
__
New submission from Florin Papa:
Hi all,
This is Florin Papa from the Server Languages Optimizations Team at Intel
Corporation.
The patch submitted here solves a crash occurring on Python 2.7 after running
pybench from perf.py (python perf.py -r -b pybench base_python
modified_python
Changes by Florin Papa <florin.p...@intel.com>:
--
keywords: +patch
Added file: http://bugs.python.org/file41149/fix_pybench_results.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
New submission from Florin Papa:
Hi all,
This is Florin Papa from the Server Languages Optimizations Team at Intel
Corporation.
The patch submitted here solves a crash occurring on Python 2.7 and 3.6 when
running the regex_compile benchmark. The clear_cache() call was replaced with
re.purge
Florin Papa added the comment:
Hi all,
We have set up a Skylake buildbot, which could be used for MPX builds. The
errors that appear when running regrtest are proxy related and we are looking
into a solution for that. There is no problem for tests that do not access
network resources
Florin Papa added the comment:
Please see the updated patch after Zachary Ware's review. Thank you for the
feedback.
--
Added file: http://bugs.python.org/file40931/mpx_enable_3_6_v6.patch
___
Python tracker <rep...@bugs.python.org>
Florin Papa added the comment:
Hi Stefan,
The GCC MPX feature proved stable when using O0, having tested multiple times
with regrtest on Skylake, Broadwell and Haswell.
Still, this is a new feature and GCC might improve it with time.
--
___
Python
Florin Papa added the comment:
Hi all,
I updated the patch after fixing crashes that occurred at compile and run time
on Ubuntu 15.10, with kernel version 4.2.0-16-generic, LD version 2.25.1 and
GCC version 5.2.1. The Python MPX binary will be built with –O0 because other
optimization levels
Florin Papa added the comment:
I have modified the small object allocator to set proper bounds for the
pointers it returns. Please see the updated patches.
--
Added file: http://bugs.python.org/file40728/mpx_enable_3_6_v4.patch
___
Python tracker
Changes by Florin Papa <florin.p...@intel.com>:
Added file: http://bugs.python.org/file40729/mpx_enable_2_7_v4.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Florin Papa added the comment:
I ran the full Grand Unified Python Benchmarks suite on Python 3.6 and 2.7
before submitting the patches and everything went well. Sorry I did not mention
it :)
--
___
Python tracker <rep...@bugs.python.org>
Florin Papa added the comment:
I ran regrtest now and there are a few tests that fail. I will look into the
cause of this and provide a solution.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Florin Papa added the comment:
No modifications need to be made to the small object allocator. The malloc
situation was just an example, it does not mean that setting pointer bounds
occurs only in a malloc call. It also occurs when you declare a static array or
when you initialize a new
Florin Papa added the comment:
> Is there a runtime cost or does the hardware run the bounds checks in
> parallel with memory accesses? Are the bounds set when malloc() is called
> or elsewhere? I read the provided links but can't say I fully understand how
> it works exactly (
Florin Papa added the comment:
Hi Antoine,
I understand the problem with the small object allocator now. I will have a
closer look at it and come back with a solution. Thank you for pointing this
out.
--
___
Python tracker <rep...@bugs.python.
Florin Papa added the comment:
Hi all,
I added LDFLAGS_NODIST in order to avoid distutils problems. Please see the
updated patches.
Thank you,
Florin
--
type: enhancement -> security
Added file: http://bugs.python.org/file40697/mpx_enable_3_6_v3.pa
Changes by Florin Papa <florin.p...@intel.com>:
Added file: http://bugs.python.org/file40698/mpx_enable_2_7_v3.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Florin Papa added the comment:
Hi Stefan,
When activating the "--with-mpx" flag in ./configure, a check is also performed
to see if the compiler is GCC version 5.1 or higher in order to support MPX
(and an appropriate error is shown, indicating that the compiler version is
wrong
Florin Papa added the comment:
Hi Antoine,
Third party modules might need patching to work with MPX, as did the math
module, included in this patch. Everything else worked fine in Python 2.7.10+
and 3.6 when running the Grand Unified Python Benchmarks suite and Openstack
Swift ssbench
Florin Papa added the comment:
Hi all,
Thank you for your feedback on the code I submitted.
I added the MPX flags to CFLAGS, not CFLAGS_NODIST, because they also need to
be included in LDFLAGS.
Please see the new set of patches.
Thank you,
Florin
--
Added file: http
Changes by Florin Papa <florin.p...@intel.com>:
Added file: http://bugs.python.org/file40682/mpx_enable_2_7_v2.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Florin Papa <florin.p...@intel.com>:
Added file: http://bugs.python.org/file40658/mpx_enable_2_7.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
New submission from Florin Papa:
Hi all,
My name is Florin Papa and I work in the Server Languages Optimizations Team at
Intel Corporation.
I would like to submit a patch that enables the use of the Intel MPX (Memory
Protection Extensions) feature on Python default and 2.7. Invalid memory
Florin Papa added the comment:
> Why not enablind the option by default if GCC 5.1 or newer is detected? Is
> there a risk of breaking third-party extensions?
> Should we pass the MPX compiler options to third-party extensions by way?
On a processor that does not support MPX techno
Florin Papa added the comment:
It's OK. I just saw one of Claudiu Popa's issues and figured we have similar
last names.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Florin Papa added the comment:
No problem. The name is Florin Papa :)
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue25266>
___
__
Florin Papa added the comment:
Hi David,
If you are not sure about MPX hardware support, you can find out the processor
model with the following commands:
Linux - cat /proc/cpuinfo | grep model
Mac - sysctl -n machdep.cpu.brand_string
If the processor code is one of the following - i7-6xxx
New submission from Florin Papa:
Hi All,
My name is Florin Papa and I work in the Server Languages Optimizations Team at
Intel Corporation.
I would like to submit a patch that deprecates the mako benchmark for Python
3.6 and above. The mako benchmark uses inspect.getargspec(), which
Florin Papa added the comment:
There is already a mako_v2 benchmark in the Grand Unified Python Benchmarks,
which does not use inspect.getargspec() and does not crash when using Python
3.6.
--
___
Python tracker <rep...@bugs.python.org>
Florin Papa added the comment:
Please download Django from their github website:
https://github.com/django/django
I checked and their latest stable release - Django 1.8.4 - from
https://pypi.python.org/pypi/Django still has the getargspec issue.
Apparently the github version is 1.9.0 alpha
Changes by Florin Papa <florin.p...@intel.com>:
Added file: http://bugs.python.org/file40315/Django-1.9.zip
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Florin Papa added the comment:
The Django 1.8 archive that I attached is not patched, it is downloaded from
the django github page without modifications. I have tested and Django 1.8
works with the latest Python version pulled from hg.python.org/cpython
Florin Papa added the comment:
I have modified the Django-1.8.zip archive to extract to Django-1.8 directory.
To apply the patch please follow these steps:
hg clone https://hg.python.org/benchmarks
cd benchmarks/
copy django_v3.patch to the current directory and Django-1.8.zip to the lib
Florin Papa added the comment:
I have modified the patch to introduce django_v3 to the benchmark suite and
deprecate django_v2 for Python 3.6 and up. In order for django_v3 to work, the
latest django release must be present in lib/Django-1.8.
Django-1.8 is attached as a zip file because
Changes by Florin Papa florin.p...@intel.com:
Added file: http://bugs.python.org/file40260/Django-1.8.zip
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24934
New submission from Florin Papa:
Hi All,
My name is Florin Papa and I work in the Server Languages Optimizations Team at
Intel Corporation.
I would like to submit a patch that solves compatibility issues of the
django_v2 benchmark in the Grand Unified Python Benchmark. The django_v2
62 matches
Mail list logo
