Change by Jason Killen :
--
nosy: +Jason.Killen
___
Python tracker
<https://bugs.python.org/issue38741>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason Killen added the comment:
Yep I wasn't seeing the forest for the trees. Thanks for clearing that up.
I'll swoop back in and see what I can do.
--
___
Python tracker
<https://bugs.python.org/issue38
Jason Killen added the comment:
Tests working now. PR submitted.
--
___
Python tracker
<https://bugs.python.org/issue38722>
___
___
Python-bugs-list mailin
Change by Jason Killen :
--
keywords: +patch
pull_requests: +16734
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/17234
___
Python tracker
<https://bugs.python.org/issu
Jason Killen added the comment:
This appears to be a bug in pytz which as far as I can tell is not part of the
"standard" lib, at least it's not in Lib.
Running this example which does not use pytz:
from datetime import timedelta, datetime, tzinfo, timezone, time
# stole this fro
Jason Killen added the comment:
I made the change but the test suite is giving me fits and I don't know why.
Running: ./python -m test
...
== Tests result: FAILURE ==
392 tests OK.
1 test failed:
test_tools
26 tests skipped:
test_curses test_dbm_gnu test_dbm_ndbm test_devpoll
Jason Killen added the comment:
I think this sounds great and I'll take a crack at it over the next few days.
If anybody wants to jump ahead of me I don't mind.
--
___
Python tracker
<https://bugs.python.org/issue38
Change by Jason Killen :
--
nosy: +Jason.Killen
___
Python tracker
<https://bugs.python.org/issue38724>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason Killen added the comment:
I'll plan on tackling this one. I already did pdb.
--
nosy: +Jason.Killen
___
Python tracker
<https://bugs.python.org/issue38
Change by Jason Killen :
--
keywords: +patch
pull_requests: +16638
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/17129
___
Python tracker
<https://bugs.python.org/issu
Jason Killen added the comment:
I flipped through PEP 578 (Runtime Audit Hooks) and this seems like the type of
situation that PEP 578 was trying to handle. I've got a change that seems to
be working and can provide a PR or whatever once I remember/read up on doing
that. (I'm a very
Jason Killen jsnk...@gmail.com added the comment:
Given I'm new I wouldn't say I evaluated the usefulness of the new functions
but I have given them a look and didn't see anything obvious. If thats good
enough great, if not then hopefully someone with a little more experience will
take
Jason Killen jsnk...@gmail.com added the comment:
I'm adding a patch for test_smtpd.py. This version includes the changes in my
previous patch and adds sending HELO before the commands in the test. Works
good for me.
--
Added file: http://bugs.python.org/file24963/test_smtpd.patch
Jason Killen jsnk...@gmail.com added the comment:
smtpd.py does not require HELO before NOOP or QUIT. I added them to
test_smtpd.py because I felt it made test_smtpd.py well written as opposed to
doing the least the spec requires. That said I suppose I should have added
QUITs to every test
Changes by Jason Killen jsnk...@gmail.com:
Removed file: http://bugs.python.org/file24948/smtpd_nogo.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14269
Changes by Jason Killen jsnk...@gmail.com:
Removed file: http://bugs.python.org/file24826/smtpd_nogo.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14269
Changes by Jason Killen jsnk...@gmail.com:
Removed file: http://bugs.python.org/file24949/test_smtpd_nogo.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14269
Changes by Jason Killen jsnk...@gmail.com:
Added file: http://bugs.python.org/file24968/smtpd.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14269
Changes by Jason Killen jsnk...@gmail.com:
Removed file: http://bugs.python.org/file24968/smtpd.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14269
Changes by Jason Killen jsnk...@gmail.com:
Added file: http://bugs.python.org/file24969/smtpd.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14269
Jason Killen jsnk...@gmail.com added the comment:
Ok I think this quote from the spec referenced pretty much sums it up.
The NOOP, HELP, EXPN, VRFY, and RSET commands can be used at any time during
a session, or without previously initializing a session. SMTP servers SHOULD
process
Jason Killen jsnk...@gmail.com added the comment:
Yes, either way in the test. The server shouldn't expect them and the client
can do it either way.
I'm adding a patch that tests with and without HELO for those commands that can
be sent either way.
--
Added file: http
Jason Killen jsnk...@gmail.com added the comment:
Removed '_syntax' apparently I fix that before but didn't regen the patch.
Added tests for noHELO before some commands to test that failures happen as
expected.
--
Added file: http://bugs.python.org/file24973/test_smtpd.patch
Jason Killen jsnk...@gmail.com added the comment:
Thanks and thanks for all you help. My method names are known to need some
tweaking.
Where is the agreement I need to sign? I looked around the documentation stuff
and didn't see it. I'd like to continue contributing just have to find
Jason Killen jsnk...@gmail.com added the comment:
Redone diff including wording preferred by R. David Murray.
--
Added file: http://bugs.python.org/file24948/smtpd.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14269
Jason Killen jsnk...@gmail.com added the comment:
Change of the smtpd test code to match the wording from the smtpd.patch. Also,
added \r\n to the end of the expected string.
--
Added file: http://bugs.python.org/file24949/test_smtpd.patch
Jason Killen jsnk...@gmail.com added the comment:
On using a different approach: I weighed an approach like that and decided to
go with what I thought was the clean/simple/easy approach. If there were more
commands that smptd.py accepted I would have probably gone with more like what
you
Jason Killen jsnk...@gmail.com added the comment:
Given this is marked as good for a newbie and easy I figured I'd take a crack
at it but I'm confused. As example I don't see where inflateReset2 would be
useful. I don't see anywhere inflateReset is used and would need to be
replaced
Jason Killen jsnk...@gmail.com added the comment:
I've generated a patch that checks to see if seen_greeting is set before
processing other commands. This is the first time I've submitted a patch so if
there is something more I need to do let me know.
--
nosy: +Jason.Killen
Added
29 matches
Mail list logo
