Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +28409
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30189
___
Python tracker
<https://bugs.python.org/issu
New submission from Jason R. Coombs :
In https://github.com/python/importlib_metadata/issues/302, I learned that the
way unittest reports failures in tests is incentivizing the replacement of
docstrings with comments in order not to make resolution of the relevant
failing test more difficult
Jason R. Coombs added the comment:
I filed issue46125 to track that issue separately.
--
___
Python tracker
<https://bugs.python.org/issue46124>
___
___
Pytho
Change by Jason R. Coombs :
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org/issue46125>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Jason R. Coombs :
--
components: +Library (Lib)
versions: +Python 3.11
___
Python tracker
<https://bugs.python.org/issue46125>
___
___
Python-bug
New submission from Jason R. Coombs :
importlib_resources 5.4 did some refactoring to ensure that the preferred
traversable API was tested
(https://github.com/python/importlib_resources/pull/239). Let's incorporate
those changes for importlib.resources.
--
messages: 408872
nosy
Jason R. Coombs added the comment:
I just confirmed, and `normalize_path` has been moved to the _legacy module for
importlib_resources, so I'd expect that change to land in CPython soon too.
--
___
Python tracker
<https://bugs.python.
Change by Jason R. Coombs :
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org/issue46124>
___
___
Python-bugs-list mailing list
Unsubscrib
Jason R. Coombs added the comment:
I would hope that normalize_path would not be needed. It might be for drop-in
compatibility. If it's needed for zoneinfo, I'd like to consider why and what
implications that has for the deprecation of the legacy API
Jason R. Coombs added the comment:
Compatibility considerations:
- importlib.readers and importlib.simple are public, so probably need aliases.
- Same abc classes.
Should we embark on an effort to migrate users to the new names in
`importlib.resources`, or simply leave the `importlib.{mod
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +28393
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30176
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
I wonder if maybe it's more important to address issue46118 first.
--
___
Python tracker
<https://bugs.python.org/issue46
New submission from Jason R. Coombs :
The importlib.resources module has several modules on which it relies
(_adapters, _legacy, simple) and some classes in other modules shared by other
parts of importlib (namely abc).
Because these implementations overlap, it adds difficulty in maintaining
Jason R. Coombs added the comment:
My main motivation for moving `.abc` was because it contains classes
exclusively relevant to `.resources` (those also present in
`importlib_resources.abc`. I want to explore moving those classes to the
resources documentation so they're available together
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +28379
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30160
___
Python tracker
<https://bugs.python.org/issu
New submission from Jason R. Coombs :
The `importlib` documentation is fairly long and covers a number of topics.
Furthermore, the `importlib.metadata` is separately documented and presents a
good example of breaking out major aspects. Let's do the same with `.abc` and
`.resources
Jason R. Coombs added the comment:
Expect the fix in 3.11a3.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
New changeset 864ec170e14b663f999eb415a4f1a0067ec6833a by Jason R. Coombs in
branch '3.9':
[3.9] bpo-46105: Honor spec when generating requirement specs with urls and
extras. (GH-30151). (GH-30157)
https://github.com/python/cpython/commit
Change by Jason R. Coombs :
--
pull_requests: +28376
pull_request: https://github.com/python/cpython/pull/30157
___
Python tracker
<https://bugs.python.org/issue46
Jason R. Coombs added the comment:
New changeset 04deaee4c8d313717f3ea8f6a4fd70286d510d6e by Jason R. Coombs in
branch 'main':
bpo-44893: Implement EntryPoint as simple class with attributes. (GH-30150)
https://github.com/python/cpython/commit/04deaee4c8d313717f3ea8f6a4fd70286d510d6e
Jason R. Coombs added the comment:
New changeset 109d96602199a91e94eb14b8cb3720841f22ded7 by Jason R. Coombs in
branch 'main':
bpo-46105: Honor spec when generating requirement specs with urls and extras.
(GH-30151)
https://github.com/python/cpython/commit
Change by Jason R. Coombs :
--
pull_requests: -28371
___
Python tracker
<https://bugs.python.org/issue44893>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason R. Coombs added the comment:
The change as implemented for importlib_metadata involves refactorings that
can't be backported, so the fix will only go into Python 3.11. I'll consider
backporting a more selective fix for this issue if it's important, but I
suspect there may
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +28370
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30151
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
pull_requests: +28371
pull_request: https://github.com/python/cpython/pull/30151
___
Python tracker
<https://bugs.python.org/issue44
New submission from Jason R. Coombs :
In https://github.com/python/importlib_metadata/issues/357, a user reported an
issue where a requirement generated by importlib.metadata from egg info
metadata would result in a parse error attempting to parse the error. A fix was
released
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +28369
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30150
___
Python tracker
<https://bugs.python.org/issu
New submission from Jason R. Coombs :
Can you provide a description of what motivated you to change the behavior or
what benefits this change would have for you or others? Do you know why others
haven’t reported this need previously?
--
nosy: +jaraco
Jason R. Coombs added the comment:
See
https://discuss.python.org/t/deprecating-importlib-resources-legacy-api/11386
for some lively discussion on this deprecation.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
Jason R. Coombs added the comment:
New changeset d5cd2effa69551c6bc7edfef8a414d545dea9117 by Jason R. Coombs in
branch 'main':
bpo-45514: Deprecate importlib resources legacy functions. (GH-29036)
https://github.com/python/cpython/commit/d5cd2effa69551c6bc7edfef8a414d545dea9117
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
New changeset ed55426acd58f030ccc0cf1297e66078f538797c by Miss Islington (bot)
in branch '3.10':
[bpo-45765] Fix distribution discovery on empty path. (GH-29487) (GH-29510)
https://github.com/python/cpython/commit/ed55426acd58f030ccc0cf1297e66078f538797c
Jason R. Coombs added the comment:
New changeset 3e0b830e859ca8792401bfd1402d659f56f99941 by Jason R. Coombs in
branch '3.9':
[3.9] [bpo-45765] Fix distribution discovery on empty path. (GH-29487).
(GH-29511)
https://github.com/python/cpython/commit/3e0b830e859ca8792401bfd1402d659f56f99941
Change by Jason R. Coombs :
--
pull_requests: +27762
pull_request: https://github.com/python/cpython/pull/29511
___
Python tracker
<https://bugs.python.org/issue45
Jason R. Coombs added the comment:
New changeset 6ec0dec7b7b50d4fee5b2b66cf38e4291bcdf44c by Jason R. Coombs in
branch 'main':
[bpo-45765] Fix distribution discovery on empty path. (#29487)
https://github.com/python/cpython/commit/6ec0dec7b7b50d4fee5b2b66cf38e4291bcdf44c
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +27738
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/29487
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org/issue45765>
___
___
Python-bugs-list mailing list
Unsubscrib
New submission from Jason R. Coombs :
Reported in https://github.com/python/importlib_metadata/issues/353,
importlib.metadata fails to find distributions in the path "". A fix was
applied to importlib_metadata 2.1.2 and 4.8.2. Let's apply that fix and
backport it to support
Jason R. Coombs added the comment:
I vaguely recall exploring this concept and finding that tarfiles don’t supply
the requisite interface because they’re not random access. I’m only 10%
confident in that recollection, so worth exploring
Jason R. Coombs added the comment:
New changeset 8ce20bbdd6d2b1277a5e74154fcdcef2cb0fee49 by Filipe Laíns in
branch 'main':
bpo-45516: add protocol description to the TraversableResources documentation
(#29173)
https://github.com/python/cpython/commit/8ce20bbdd6d2b1277a5e74154fcdcef2cb0fee49
Jason R. Coombs added the comment:
New changeset c0295675305f6896e4ba7496441cc470d7edca89 by Filipe Laíns in
branch 'main':
bpo-45516: use documentation links in TraversableResources' description
(GH-29045)
https://github.com/python/cpython/commit/c0295675305f6896e4ba7496441cc470d7edca89
New submission from Jason R. Coombs :
New changeset 4d03de3329ed8daa9c1107b1aedbb0fa280bddb6 by Filipe Laíns in
branch 'main':
bpo-45516: add protocol description to the Traversable documentation (#29039)
https://github.com/python/cpython/commit/4d03de3329ed8daa9c1107b1aedbb0fa280bddb6
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +27307
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/29036
___
Python tracker
<https://bugs.python.org/issu
New submission from Jason R. Coombs :
[importlib_resources
5.3](https://importlib-resources.readthedocs.io/en/latest/history.html#v5-3-0),
deprecates the functions in _legacy. Let's introduce that deprecation in
CPython also.
In addition to merging the changes from importlib_resources
Jason R. Coombs added the comment:
Thanks Dave for closing. I would recommend in the future if you have packaging
questions to bring them to packaging problems repo as indicated at
https://packaging.python.org/support/#how-to-get-support.
Glad to hear that `as_file` promised to do what you
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: behavior ->
___
Python tracker
<https://bugs.python
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +27156
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28844
___
Python tracker
<https://bugs.python.org/issu
New submission from Jason R. Coombs :
In [pytest-dev/pytest#9174](https://github.com/pytest-dev/pytest/issues/9174),
it became clear that the DegenerateFiles object has a couple of interface
mismatches to Traversable:
- name is a property
- open accepts a 'mode' and arbitrary args and kwargs
Jason R. Coombs added the comment:
Here's what I propose:
1. In pypa/distutils, add support for honoring the proposed install schemes
(based on PR 25718). Merge with Setuptools.
2. Add whatever ugly hacks are needed to pypa/distutils to honor other
Debian-specific behaviors (revive https
Jason R. Coombs added the comment:
> In the short term, and possible for the long term, Debian can continue to
> patch the install routine...
The problem with this approach is Setuptools is attempting to adopt distutils
by exposing its own vendored copy of distutils as `distutils
Jason R. Coombs added the comment:
Oh, and I see now Serhiy has proposed a change that looks reasonable.
--
___
Python tracker
<https://bugs.python.org/issue43
Jason R. Coombs added the comment:
>> Subclass of set can now define
> Is there any use case for this?
Is your concern about a use-case for the general concept or for set
specifically?
I appreciate that Serhiy has taken the time to evaluate the specific concern I
raised and ex
Jason R. Coombs added the comment:
The builder is now passing after the buildbot owner reset the checkout.
--
resolution: -> fixed
stage: -> resolved
status: pending -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
Reported concern can be addressed in the new issue.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
I'm not confident that I can get the message to the buildbot, so I sent a
message to python-buildb...@python.org requesting to run the workaround on the
buildbot. The message was flagged for moderation. My hope is that eventually
goes through
Jason R. Coombs added the comment:
I've submitted a PR that deletes the file and requested it be built by the
buildbots, but I also see that that bot hasn't built anything in 7 days
(https://buildbot.python.org/all/#/builders/405), so I'm not hopeful my request
for it to build that change
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +26561
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28120
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
I'm going to attempt that technique again and see if it's sufficient to bypass
the symptom.
--
___
Python tracker
<https://bugs.python.org/issue45
Jason R. Coombs added the comment:
There is an issue where that file originally got EOL conversions, so all
Windows buildbots were failing (issue44779).
I'd thought we'd worked around the issue by pushing out a PR that deleted the
file and ensuring it ran on the buildbots
(https
Jason R. Coombs added the comment:
I'll probably fix the issue in importlib_metadata first
(https://github.com/python/importlib_metadata/issues/337).
--
___
Python tracker
<https://bugs.python.org/issue44
Change by Jason R. Coombs :
--
versions: +Python 3.11 -Python 3.10
___
Python tracker
<https://bugs.python.org/issue43976>
___
___
Python-bugs-list mailin
Jason R. Coombs added the comment:
Thanks Filipe for the summary. I was unsure the status.
Even if we grant that Debian is too intrusive in its patching of distutils,
it's Python and distutils that are making the change here, so it's not
unreasonable for Python to maintain feature parity
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
New changeset 21d5897982698a461215203ab51f56ad05648001 by Miss Islington (bot)
in branch '3.10':
bpo-44784: Apply changes from importlib_metadata 4.6.3 (GH-27508) (#27510)
https://github.com/python/cpython/commit/21d5897982698a461215203ab51f56ad05648001
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +26022
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27508
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
Patch at https://github.com/python/importlib_metadata/pull/333.
--
___
Python tracker
<https://bugs.python.org/issue44
Jason R. Coombs added the comment:
All four of those tests had used `capture_warnings` in an attempt to capture
them, but it did not alter the warnings filter.
--
___
Python tracker
<https://bugs.python.org/issue44
Jason R. Coombs added the comment:
In addition to the two reported, there are two others:
- test_entry_points_dict_construction
- test_entry_points_by_index
that also fail. I've been able to replicate the issue in importlib_metadata, so
I'll fix it there first
Jason R. Coombs added the comment:
New changeset e63e6311aa258a5f3f49a7aed9fdde445fd384d6 by Jason R. Coombs in
branch 'main':
bpo-44771: Sync with importlib_resources 5.2.2, fixing refleak. (#27497)
https://github.com/python/cpython/commit/e63e6311aa258a5f3f49a7aed9fdde445fd384d6
Change by Jason R. Coombs :
--
pull_requests: +26015
pull_request: https://github.com/python/cpython/pull/27497
___
Python tracker
<https://bugs.python.org/issue44
Change by Jason R. Coombs :
--
nosy: +jaraco
nosy_count: 6.0 -> 7.0
pull_requests: +26014
pull_request: https://github.com/python/cpython/pull/27436
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
Awesome. Thanks Łukasz.
--
___
Python tracker
<https://bugs.python.org/issue44777>
___
___
Python-bugs-list mailing list
Unsub
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +25998
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27436
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
pull_requests: +25997
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27436
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
stage: patch review ->
___
Python tracker
<https://bugs.python.org/issue44777>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Jason R. Coombs :
--
pull_requests: -25996
___
Python tracker
<https://bugs.python.org/issue44777>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Jason R. Coombs :
In [this
comment](https://github.com/python/cpython/pull/27436#issuecomment-889815333),
I learned that it's possible to get repo clones into a bad state by:
- commit a text file to main (merge a PR)
- customize the newline handling for that file
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +25996
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27436
___
Python tracker
<https://bugs.python.org/issu
New submission from Jason R. Coombs :
In [this
comment](https://github.com/python/cpython/pull/27436#issuecomment-889815333),
I learned that it's possible to break the buildbots in a way that's not fixable
with a simple code change.
The recommendation there was to contact the buildbot
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
New changeset aaa83cdfab6817446285e631232f64b394ac6791 by Jason R. Coombs in
branch 'main':
bpo-44771: Apply changes from importlib_resources 5.2.1 (GH-27436)
https://github.com/python/cpython/commit/aaa83cdfab6817446285e631232f64b394ac6791
Jason R. Coombs added the comment:
In [this
comment](https://github.com/python/importlib_resources/pull/221#discussion_r679124389),
I did more analysis and assuaged my own concerns about the implementation.
Everything seems to be working as intended, thanks to the strong work by FFY00
Change by Jason R. Coombs :
--
nosy: -jaraco
___
Python tracker
<https://bugs.python.org/issue40263>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Jason R. Coombs :
--
pull_requests: -25966
___
Python tracker
<https://bugs.python.org/issue40263>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason R. Coombs added the comment:
On further consideration, the concern I had may not be manifest in the
implementation. It may be the _adapters.wrap_spec provides all the
compatibility that's needed. I'll see if I can concoct an idiomatic case, but I
may find that there's no concern
Jason R. Coombs added the comment:
I've put together a patch based on python/importlib_resources@3b24bd6307, and
interestingly, the tests pass... which is a little concerning because in
https://github.com/python/importlib_resources/pull/221#discussion_r659214483, I
describe a compatibility
Change by Jason R. Coombs :
--
nosy: +FFY00
___
Python tracker
<https://bugs.python.org/issue44771>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Jason R. Coombs :
--
nosy: +jaraco
nosy_count: 8.0 -> 9.0
pull_requests: +25966
pull_request: https://github.com/python/cpython/pull/27436
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +25965
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27436
___
Python tracker
<https://bugs.python.org/issu
New submission from Jason R. Coombs :
Importlib_resources 5.1 and 5.2 introduced the following changes (more details
at https://importlib-resources.readthedocs.io/en/latest/history.html#v5-2-1):
- Added ``simple`` module implementing adapters from a low-level resources
reader interface
Jason R. Coombs added the comment:
This issue is solved. Thanks Irit for taking the time to investigate the issue
and do the hard part of developing a test.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
_
Jason R. Coombs added the comment:
New changeset 49b5e20fa8c091f9158ccd26f9a12fc1e91cfc93 by Jason R. Coombs in
branch '3.9':
[3.9] bpo-44461: Check early that a pdb target is valid for execution.
(GH-27227) (GH-27400)
https://github.com/python/cpython/commit
Change by Jason R. Coombs :
--
pull_requests: +25933
pull_request: https://github.com/python/cpython/pull/27400
___
Python tracker
<https://bugs.python.org/issue44
Change by Jason R. Coombs :
--
pull_requests: +25932
pull_request: https://github.com/python/cpython/pull/27399
___
Python tracker
<https://bugs.python.org/issue44
Jason R. Coombs added the comment:
New changeset ee03bad25e83b00ba5fc2a0265b48c6286e6b3f7 by Jason R. Coombs in
branch 'main':
bpo-44461: Check early that a pdb target is valid for execution. (#27227)
https://github.com/python/cpython/commit/ee03bad25e83b00ba5fc2a0265b48c6286e6b3f7
Change by Jason R. Coombs :
--
pull_requests: -25553
___
Python tracker
<https://bugs.python.org/issue44461>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Jason R. Coombs :
--
pull_requests: +25768
pull_request: https://github.com/python/cpython/pull/27227
___
Python tracker
<https://bugs.python.org/issue44
Jason R. Coombs added the comment:
Additional problems I noticed while working on the refactor:
- There is a lot of overlap in behavior between the implementations of
_run_script and _run_module (initializing private variables, setting
mainpyfile, resetting the __main__ namespace
101 - 200 of 1492 matches
Mail list logo
