[issue30788] email.policy.SMTP.fold() issue for long filenames with spaces

2017-09-20 Thread Joel Hillacre
Joel Hillacre added the comment: I just took a quick peek at your PR to see if a similar test exists from this bug and it is looking good. Thanks for your work. -- ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/i

[issue30788] email.policy.SMTP.fold() issue for long filenames with spaces

2017-07-28 Thread Joel Hillacre
Joel Hillacre added the comment: Just wanted to ping this and see if there was someone available to review my PR associated with this issue. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue30788] email.policy.SMTP.fold() issue for long filenames with spaces

2017-07-07 Thread Joel Hillacre
Changes by Joel Hillacre <j...@403forbidden.ca>: -- pull_requests: +2688 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue30788> ___

[issue30532] email.policy.SMTP.fold() mangles long headers

2017-07-05 Thread Joel Hillacre
Changes by Joel Hillacre <j...@403forbidden.ca>: -- pull_requests: +2663 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue30532> ___

[issue30532] email.policy.SMTP.fold() mangles long headers

2017-07-05 Thread Joel Hillacre
Changes by Joel Hillacre <j...@403forbidden.ca>: -- pull_requests: +2662 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue30532> ___

[issue30788] email.policy.SMTP.fold() issue for long filenames with spaces

2017-06-27 Thread Joel Hillacre
Changes by Joel Hillacre <j...@403forbidden.ca>: -- title: email.policy.SMTP.fold() issue with long filenames with spaces -> email.policy.SMTP.fold() issue for long filenames with spaces ___ Python tracker <rep...@bugs.pytho

[issue30788] email.policy.SMTP.fold() issue with long filenames with spaces

2017-06-27 Thread Joel Hillacre
New submission from Joel Hillacre: Found an issue in email.policy.SMTP.fold on "Content-Disposition" headers for long filenames with spaces. Managed to simply the issue to a test case as follows: >>> from email.policy import SMTP; SMTP.fold('Content-Disposition', >&g

[issue30532] email.policy.SMTP.fold() mangles long headers

2017-06-21 Thread Joel Hillacre
Joel Hillacre added the comment: > Ping the issue again next week if I don't get to it this weekend. I am a week late, but here is a ping. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.or

[issue30532] email.policy.SMTP.fold() mangles long headers

2017-06-05 Thread Joel Hillacre
Joel Hillacre added the comment: Rebased the github PR on latest master to get the windows build passing CI. Is there anything I need to do to keep the PR moving? -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue30532] email.policy.SMTP.fold() mangles long headers

2017-05-31 Thread Joel Hillacre
Joel Hillacre added the comment: I added a pull request that causes Chris's test to pass. I can confirm that the Chris's was not pass for me on master branch. -- nosy: +jhillacre ___ Python tracker <rep...@bugs.python.org> <http://bugs.p

[issue30532] email.policy.SMTP.fold() mangles long headers

2017-05-31 Thread Joel Hillacre
Changes by Joel Hillacre <j...@403forbidden.ca>: -- pull_requests: +1968 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue30532> ___

[issue30394] smtplib leaves open sockets around if SMTPConnectError is raised in __init__

2017-05-23 Thread Joel Hillacre
Joel Hillacre added the comment: r.david.murray, How would a test would have a reference to after an exception in the smtplib.SMTP.__init__()? -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue30394] smtplib leaves open sockets around if SMTPConnectError is raised in __init__

2017-05-21 Thread Joel Hillacre
Joel Hillacre added the comment: > Joel, our patch system has moved to GitHub. Mind to turn your patch into a PR? I have opened a PR now. I took a look at changing my example into a test. I am not sure how to test for a lack of warning. Closest test I found was BadHELOServerTe

[issue30394] smtplib leaves open sockets around if SMTPConnectError is raised in __init__

2017-05-21 Thread Joel Hillacre
Changes by Joel Hillacre <j...@403forbidden.ca>: -- pull_requests: +1796 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue30394> ___

[issue30394] smtplib leaves open sockets around if SMTPConnectError is raised in __init__

2017-05-17 Thread Joel Hillacre
Changes by Joel Hillacre <j...@403forbidden.ca>: Added file: http://bugs.python.org/file46875/test_client.py ___ Python tracker <rep...@bugs.python.org> <http://bugs.python

[issue30394] smtplib leaves open sockets around if SMTPConnectError is raised in __init__

2017-05-17 Thread Joel Hillacre
Changes by Joel Hillacre <j...@403forbidden.ca>: Added file: http://bugs.python.org/file46874/test_server.py ___ Python tracker <rep...@bugs.python.org> <http://bugs.python

[issue30394] smtplib leaves open sockets around if SMTPConnectError is raised in __init__

2017-05-17 Thread Joel Hillacre
New submission from Joel Hillacre: I am encountering a ResourceWarning about an unclosed socket when getting a non 220 response during connect() in __init__() of smtplib.SMTP. Attached are a client script causing this warning for me, a server script to cause the client to the warning