[issue43123] email MIME splitting

2021-04-12 Thread Ross Rhodes
Ross Rhodes added the comment: PR now “stale” since I have not received any feedback, yet. -- ___ Python tracker <https://bugs.python.org/issue43123> ___ ___

[issue42916] Support for DICOM image file format in imghdr module

2021-04-12 Thread Ross Rhodes
Ross Rhodes added the comment: PR already open to support DICOM based on the first 132 characters. Marked “stale” since I haven’t had any feedback on GitHub, yet. -- ___ Python tracker <https://bugs.python.org/issue42

[issue42778] Add follow_symlinks=True parameter to both os.path.samefile() and Path.samefile()

2021-02-08 Thread Ross Rhodes
Ross Rhodes added the comment: Thanks for sharing the alternative approach, Serhiy. Sounds like the proposed changes aren’t necessary if the combined use of samestat and lstat achieve the desired behaviour. Any objections if I close the open PR

[issue42916] Support for DICOM image file format in imghdr module

2021-02-08 Thread Ross Rhodes
Ross Rhodes added the comment: Looking for input from other contributors here. Naturally with a PR already open I’m inclined to keep these changes, but if the majority agree that it is too specific a format then I’m happy to hear alternative suggestions? Ross

[issue43123] email MIME splitting

2021-02-07 Thread Ross Rhodes
Ross Rhodes added the comment: Hi Martin, Looking into this further, it appears we already catch CR-LF characters in header values, but your test case shows that we do not run the same checks on header names. I've opened a PR to rectify this - feel free to leave feedback. Ross

[issue43123] email MIME splitting

2021-02-07 Thread Ross Rhodes
Change by Ross Rhodes : -- keywords: +patch nosy: +trrhodes nosy_count: 3.0 -> 4.0 pull_requests: +23267 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24475 ___ Python tracker <https://bugs.python.org/i

[issue42916] Support for DICOM image file format in imghdr module

2021-01-16 Thread Ross Rhodes
Ross Rhodes added the comment: Hello Charles, Following the format provided, I've opened a PR to implement your proposal. Feedback welcome. -- ___ Python tracker <https://bugs.python.org/issue42

[issue42916] Support for DICOM image file format in imghdr module

2021-01-16 Thread Ross Rhodes
Change by Ross Rhodes : -- keywords: +patch nosy: +trrhodes nosy_count: 2.0 -> 3.0 pull_requests: +23050 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/24227 ___ Python tracker <https://bugs.p

[issue42756] smtplib.LMTP.connect() raises TypeError if `timeout` is not specified

2021-01-01 Thread Ross Rhodes
Change by Ross Rhodes : -- pull_requests: +22886 pull_request: https://github.com/python/cpython/pull/24050 ___ Python tracker <https://bugs.python.org/issue42

[issue42794] test_nntplib fails on CI

2020-12-31 Thread Ross Rhodes
Ross Rhodes added the comment: Server is returning '215 Newsgroup descriptions in form "group description"', but an empty list of lines, so it's reaching the 'nothing' case in _getdescriptions: https://github.com/python/cpython/blob/master/Lib/nntplib.py#L660 -- nosy:

[issue41914] test_pdb fails

2020-12-30 Thread Ross Rhodes
Ross Rhodes added the comment: Hi Sumagna, test_pdb appears to be working as expected on my machine. I realise this was posted a few months ago so would you mind trying again and seeing if the issue persists? If so, which OS are you running your tests on? -- nosy: +trrhodes

[issue42787] email.utils.getaddresses improper parsing of unicode realnames

2020-12-30 Thread Ross Rhodes
Ross Rhodes added the comment: Hi Konstantin, Thanks for raising this issue. It appears the field provided in your example does not conform to RFC 2822 followed by this email library. Square brackets are treated as special characters in [section 3.2.1](https://tools.ietf.org/html/rfc2822

[issue42778] Add follow_symlinks=True parameter to both os.path.samefile() and Path.samefile()

2020-12-29 Thread Ross Rhodes
Ross Rhodes added the comment: Hi Tom, Thanks for raising this issue. I've opened a PR to permit us to set `follow_symlinks` in both os.path and pathlib. Feel free to leave feedback. -- ___ Python tracker <https://bugs.python.org/issue42

[issue42778] Add follow_symlinks=True parameter to both os.path.samefile() and Path.samefile()

2020-12-29 Thread Ross Rhodes
Change by Ross Rhodes : -- keywords: +patch nosy: +trrhodes nosy_count: 1.0 -> 2.0 pull_requests: +22839 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23996 ___ Python tracker <https://bugs.python.org/i

[issue42756] smtplib.LMTP.connect() raises TypeError if `timeout` is not specified

2020-12-27 Thread Ross Rhodes
Ross Rhodes added the comment: Hello Wüstengecko, Thanks for raising this issue. I've opened a PR which I believe will resolve the problem, but it's difficult to verify this against the mock socket setup. Feel free to leave feedback

[issue42756] smtplib.LMTP.connect() raises TypeError if `timeout` is not specified

2020-12-27 Thread Ross Rhodes
Change by Ross Rhodes : -- keywords: +patch nosy: +trrhodes nosy_count: 1.0 -> 2.0 pull_requests: +22814 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23969 ___ Python tracker <https://bugs.python.org/i

[issue41781] Typos in typing.py

2020-12-26 Thread Ross Rhodes
Ross Rhodes added the comment: Hello Patrick, Thanks for opening this issue. I'm creating a PR to resolve the typo in "_allow_reckless_class_cheks", but I'm unable to find "instnance". Presumably the latter was resol

[issue41781] Typos in typing.py

2020-12-26 Thread Ross Rhodes
Change by Ross Rhodes : -- keywords: +patch nosy: +trrhodes nosy_count: 1.0 -> 2.0 pull_requests: +22804 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23957 ___ Python tracker <https://bugs.python.org/i

[issue40028] Math module method to find prime factors for non-negative int n

2020-04-18 Thread Ross Rhodes
Ross Rhodes added the comment: Unable to dedicate time to this issue under the change of circumstances. Happy for someone else to re-open this if they take an interest in picking up this work. -- resolution: -> postponed stage: needs patch -> resolved status: open -&g

[issue40028] Math module method to find prime factors for non-negative int n

2020-03-21 Thread Ross Rhodes
Ross Rhodes added the comment: Hi Steven, I agree, your set of proposed methods seem sensible to me. I'm happy to start with an implementation of at least some of those methods and open for review, taking this one step at a time for easier review and regular feedback. > Another quest

[issue40028] Math module method to find prime factors for non-negative int n

2020-03-21 Thread Ross Rhodes
Ross Rhodes added the comment: Hi Serhiy, > Provide a pull request. Apologies, by "this idea" I should clarify I meant the "imath" module proposal. On this particular enhancement, yes, I'm happy to work on and later

[issue40028] Math module method to find prime factors for non-negative int n

2020-03-21 Thread Ross Rhodes
Ross Rhodes added the comment: Hi Serhiy, Thanks for sharing your thread. I support this proposal, and would be happy to help where time permits if we can gather sufficient support. I inadvertently posted my support twice on your thread with no obvious means of deleting the duplicate post

[issue40028] Math module method to find prime factors for non-negative int n

2020-03-21 Thread Ross Rhodes
Ross Rhodes added the comment: Hi Tim, Are there any open discussions or threads following the proposed “imath” module? I’m a relatively new entrant to the Python community, so if there’s any ongoing discussion on that front I’d be happy to read further. I think as a first step it would

[issue40028] Math module method to find prime factors for non-negative int n

2020-03-20 Thread Ross Rhodes
New submission from Ross Rhodes : Hello, Thoughts on a new function in the math module to find prime factors for non-negative integer, n? After a brief search, I haven't found previous enhancement tickets raised for this proposal, and I am not aware of any built-in method within either

[issue39507] http library missing HTTP status code 418 "I'm a teapot"

2020-01-31 Thread Ross Rhodes
Change by Ross Rhodes : -- keywords: +patch pull_requests: +17665 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18291 ___ Python tracker <https://bugs.python.org/issu

[issue39507] http library missing HTTP status code 418 "I'm a teapot"

2020-01-31 Thread Ross Rhodes
New submission from Ross Rhodes : http library missing HTTP status code 418 "I'm a teapot". -- messages: 361106 nosy: trrhodes priority: normal severity: normal status: open title: http library missing HTTP status code 418 "I'm a teapot" __