Senthil Kumaran added the comment:
Serhiy - Is there any technical issue that is holding up this patch? (I dont
see any). If nothing is holding up and you are busy, I shall go ahead with
committing this one. /cc flox
--
___
Python tracker rep
Senthil Kumaran added the comment:
I am okay with closing this. If Diego gets back with more info or specifics of
error, we can deal with it.
--
assignee: - orsenthil
resolution: - wont fix
stage: - committed/rejected
status: pending - closed
Senthil Kumaran added the comment:
Karl - I reviewed the patch and like it. Here are some comments.
At first, I did not see the need for both message and explain in the API
both having almost similar purposes. But given that explain is already used
by send_error and at the moment, un
Senthil Kumaran added the comment:
Karl, I am getting back to this. Thanks for your review comments on the patch.
1. Agree with your explanation on HTTP PUT. I shall modify the comment.
2. I think, it is okay to remove the HTTP PUT server example. I wrote it for
test purposes and I think
Senthil Kumaran added the comment:
Karl - thanks for your telnet debugging session output. Helped realized the
problem better. So I had been thinking that sending message is okay. But had
not realized that same variable name was used and was causing problem.
I have gone ahead with the fix
Senthil Kumaran added the comment:
There is a test failure. which leads me to believe that Error message may
probably be relied upon by some applications.
FAIL: test_header_length (test.test_httpservers.BaseHTTPRequestHandlerTestCase
Senthil Kumaran added the comment:
Karl,
Ack. The patch looks good. I shall go about with testing + committing this..
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12921
Senthil Kumaran added the comment:
Ronald:
Sorry for the delay in response. I was referring to this:
https://github.com/capistrano/capistrano/issues/250#issuecomment-8055991
Mountain Lion no longer includes OpenSSL as it uses a different SSL
implementation. So, you need to have RVM install
Senthil Kumaran added the comment:
David Karl -
I had been thinking on this. My understanding of the RFC implies that server
should reject when the headers contain the whitespace and I had a little
concern if the client library should feel free to cleanup a wrongly set
headers? Would
Senthil Kumaran added the comment:
Looks like curl is sending the headers without removing spaces.
Check Raw here link here. (The link would probably be online a week)
http://requestb.in/1kfodmj1?inspect
$ curl --header X-MyHeader: 123 http://requestb.in/1kfodmj1
ok
$ curl --header X
Senthil Kumaran added the comment:
Oh wow. Thank you very much Karl for the care. I am having the same
inclination are you too, but determining a definite answer is really
helpful before going ahead into making the change.
--
___
Python tracker rep
Senthil Kumaran added the comment:
The curl example also suggest to think about pragamatic de-facto
stuff. Will removing the spaces cause any breakage? I can say for
sure. But if someone can think of it, it would be good for at least us
know
Senthil Kumaran added the comment:
I thought this was fixed (recently). Shall look again. Having the tests is the
only hard part here.
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17324
New submission from Senthil Kumaran:
I think an explicit HTTP put request example in the docs may help. Previously,
I thought the POST example was enough as PUT is very similar, but given the
folks are looking for it, an example of how to do a PUT request using httplib
may be helpful.
Here
Senthil Kumaran added the comment:
Ezio. yes in 3.3 onwards it should be done in urllib.request. I was having 2.7
docs in my mind, but I ended up writing for latest with the intention to
backport. I have updated the patch to include both ways, while backporting to
2.7 and 3.2, plan to include
Senthil Kumaran added the comment:
I am noticing this one late. Sorry for that.
I agree that this is docs issue and I would like to fix it in this way.
Give the doc example as:
urlparse('www.cwi.nl/%7Eguido/Python.html')
ParseResult(scheme='', netloc='', path='www.cwi.nl/%7Eguido/Python.html
Senthil Kumaran added the comment:
I have fixed the docs issue. Thanks for the report and following up.
--
assignee: - orsenthil
keywords: -buildbot
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
type: - behavior
Senthil Kumaran added the comment:
Yes, feature complete of 1.1 will be a start. :(
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17302
Senthil Kumaran added the comment:
let me check that.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue979407
___
___
Python-bugs-list mailing
Senthil Kumaran added the comment:
Serhiy Storchaka added the comment:
+ append = res.append
And then use 'append'?
This speed up unquote_to_bytes by 15%.
Thanks for the response. In fact, writing the whole _hextobyte
verbatim would further increase the speed, but that would be huge
dis
Senthil Kumaran added the comment:
The doc change looks good to me. I am adding Terry and Ezio to see if they have
any comments on wordings in the doc. If not, I can commit this change. I think
that this is helpful.
--
nosy: +ezio.melotti, orsenthil, terry.reedy
Senthil Kumaran added the comment:
Chris: The patch is for the docs. the test code I believe, is for
reference. It would be to run it on different OS and verify the
documentation matches the behavior.I am okay with more than one person
verifying this and I shall do on OS'es I have
Applying this patch - I tried this hypothetical test.
$ ./python.exe -m timeit -s import urllib.parse; x='a%20' * 10
urllib.parse.unquote(x)
10 loops, best of 3: 205 msec per loop
Without the patch, the above test will run for minutes!
This creates a significant difference for extremely
Senthil Kumaran added the comment:
I wrongly minutes. Here is actual data of execution speeds. There is
magnitude of difference (almost 130x faster). Measured on macbook pro
with 2 cores and 4 Gig mem.
Before Patch:
$ ./python.exe -m timeit -s import urllib.parse; x='a%20' * 10
Senthil Kumaran added the comment:
Thanks for the bug report, Reuben. I verified that this is indeed a bug and
should be fixed in all versions. Thanks for the patch too, would you like to
enhance it with tests? GeneralTests in test_telnetlib.py support timeout and
you could that exercise
Senthil Kumaran added the comment:
@gps: looks like it is. For changeset: 78129:de229dde486b for Issue #14635
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17200
Serhiy: The patch LGTM.
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
Changes by Senthil Kumaran sent...@uthcode.com:
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10852
___
___
Python-bugs-list
Senthil Kumaran added the comment:
There is another option. To have the same behavior like svn keywords
through hg. Having this setting at server hgrc can help.
This will be useful if we have more than one instance of keyword expansion.
[extensions]
keyword=
[keyword]
**/*.man =
[keywordmaps
Changes by Senthil Kumaran sent...@uthcode.com:
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17164
___
___
Python-bugs-list
Senthil Kumaran added the comment:
You will stumble on that message, only if you give help(module
somename) and note that somename could be any module in the
PYTHONPATH.
We can change to show the text only if the module is a valid module,
but I think, it is costly do that computation for help
Senthil Kumaran added the comment:
It should be noted that latest OSX Mountain Lion has caused problems for other
language libraries too (specifically ruby, which I use at work). Ease the
support of correct openssl in OSX may help a long way in all versions of python.
--
nosy
Senthil Kumaran added the comment:
The patch looks good to me. This change is helpful and definitely an
improvement over the existing text. Please go ahead with committing it, Terry.
Thanks.
--
___
Python tracker rep...@bugs.python.org
http
Senthil Kumaran added the comment:
The patch looks good and it is correct thing to do IMO. thanks.
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17169
Changes by Senthil Kumaran sent...@uthcode.com:
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17172
___
___
Python-bugs-list
Senthil Kumaran added the comment:
I shall go ahead with this change. And when the URLopener and FancyURLopener
removed, all their references in the docs (including this change) will be
removed.
--
___
Python tracker rep...@bugs.python.org
http
Changes by Senthil Kumaran sent...@uthcode.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17069
Senthil Kumaran added the comment:
Here is he patch against the default that would address this reported issue.
Same would go for other 3.x branches. The 2.7 only can just see the addition of
getcode() documented.
--
assignee: - orsenthil
keywords: +patch
stage: - patch review
type
Senthil Kumaran added the comment:
Éric, thanks for the comment. URLopener and FancyURLopener is deprecated, so
that reference to that can be removed from 3.4 (after removing the URLopener
and FancyURLopener class). Rest of the patch can stay the same
Changes by Senthil Kumaran sent...@uthcode.com:
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17069
___
___
Python-bugs-list
Senthil Kumaran added the comment:
I updated the patch addressing Ezio's comments in the review system and also
condensed the tests. This fixes the parse_multipart's byte handling at some
level.
The docstring of parse_multipart say that, this should be deprecated in favor
of FieldStorage
Senthil Kumaran added the comment:
I personally think, that the grey area of multipart form encoding and trying
to use email's updated features for parsing was holding it, not the tests. This
can be submitted IMO after looking at the related bugs, I shall do a review
on this one today
Senthil Kumaran added the comment:
If it does go in, due the RFC requirement, then it would be only in 3.4
(default branch) and the feature may not be backported. Without reading the RFC
section, I have an intuitive -1 for this proposal because the suggestion may be
a corner case rather than
Changes by Senthil Kumaran sent...@uthcode.com:
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16904
___
___
Python-bugs-list
Senthil Kumaran added the comment:
Regardless of the topic of merge, the suggested improvements for both idle.rst
and help.txt are great! Thanks for working the patch, Todd.
I am +1 with the changes. If no else has any comments, I can go ahead with
committing this.
--
nosy: +orsenthil
Looks good in most of the places, but at some places the parenthesis are of
course helpful for cohesiveness, and this can be quite subjective. With
these patches, are you in general removing all instances of parenthesis
when it is not required or also considering for places where parens may
help
Senthil Kumaran added the comment:
Should not this be?
*.S) obj=`basename $src .S`.o; cc='$(CC)';; #
The filetype extension .S instead .cpp.
And, I have less know-how on these, but for my understanding how would
non-preprocessed asm files (.s) will be handled? And doc reference to
how
Senthil Kumaran added the comment:
Thanks for the fix. The patches fixes it. Since this is a bug fix, it should be
backported all the way till 2.7.
--
assignee: - orsenthil
nosy: +orsenthil
stage: - commit review
versions: +Python 2.7, Python 3.2, Python 3.3
Senthil Kumaran added the comment:
Digging a little deeper, make libainstall needs $(BINDIR) because of this
$(INSTALL_SCRIPT) python-config $(DESTDIR)$(BINDIR)/python$(VERSION)-config
*And* that python$(VERSION)-config file refers to the python exe which is
available only after bininstall
Senthil Kumaran added the comment:
Thanks Benno. I think that making libainstall depend on bininstall is
a right solution too. A nod from devs who have committed changes in
that area may help. Also, I believe that this is a bug fix and should
be ported back upto 2.7. If there are any concerns
Senthil Kumaran added the comment:
The patch seems good to me. Please commit it.
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16819
Senthil Kumaran added the comment:
Hello Zachary, What'wrong with referencing :class:`file` for iterable? I find
it as OK. Also if it needs to be corrected, the reference could be made for
:ref:`bltin-file-objects`
Re grammatical fixes, you could point out which were made as with the reflow
Senthil Kumaran added the comment:
I find, cd Doc easy to remember as well. If make tricks can be used then I
hope readers note it rather than be exposed via Documentation. Chris's
patch is helpful to me, but still I may not vote a +1 for it to be in
Documentation. thanks.
On Sun, Dec 30, 2012
Senthil Kumaran added the comment:
Oh Okay, Thanks! I was checking it against 2.7!
On Tue, Jan 1, 2013 at 11:48 AM, R. David Murray rep...@bugs.python.orgwrote:
R. David Murray added the comment:
senthil: the file type doesn't exist any more in python3.
--
nosy: +r.david.murray
Senthil Kumaran added the comment:
I reviewed the patch. Changes LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16747
___
___
Python-bugs
I think, the the URLs on this page are correct ( or have been corrected
since the opening of this issue) -
http://hg.python.org/devguide/file/20333d160f4e/documenting.rst
If anything needs to be changed, then a patch would be helpful.
On Sat, Dec 29, 2012 at 8:48 AM, Tshepang Lekhonkhobe
Changes by Senthil Kumaran sent...@uthcode.com:
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1674555
___
___
Python-bugs-list
Senthil Kumaran added the comment:
+1 from me as well. I am also adding Eric who might have views on the
customization part which added by him.
--
nosy: +eric.araujo, orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Senthil Kumaran added the comment:
Looks an invalid bug to me as well. request is a socket.socket object and has
shutdown method taking a single argument.
The error pasted in the report leads me to believe if the shutdown_request call
is not thread-safe and it is ending up called shutdown
Senthil Kumaran added the comment:
Jeff, Thanks for raising this issue. The aspect of skipping localhost for
proxies in urllib2_localnet tests can be handled in a different way as well,
namely by setting the environment varible NO_PROXY to *. By this the
skip_proxies in urllib2 returns True
Senthil Kumaran added the comment:
Fixed in all branches of CPython. Thanks.
--
assignee: - orsenthil
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16702
Changes by Senthil Kumaran sent...@uthcode.com:
--
resolution: - duplicate
stage: - committed/rejected
status: open - closed
superseder: - Add fixups for encoding problems to wsgiref
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Senthil Kumaran added the comment:
Fixed in all codelines. Thank you!
--
assignee: - orsenthil
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16713
Senthil Kumaran added the comment:
Okay. this is fixed in all versions of python. Sorry for the delay.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15701
Senthil Kumaran added the comment:
Even though 2.x is in security fix mode, this can be fixed by a overriding the
base class's info method in the HTTPError class and returning the .hdrs
attribute instead of .headers.
--
Added file: http://bugs.python.org/file28273/Issue1571.patch
Senthil Kumaran added the comment:
Thanks for raising the bug and patch, Berker Peksag.
Fixed in all versions.
--
nosy: +orsenthil
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16634
Senthil Kumaran added the comment:
Hello Miki Tebeka,
The change requested by this issue (and provided by the patch) is already in
place in 3.3. This was committed as part of issue1673007 has the same behavior
too.
I am closing this as duplicate.
Thank you,
Senthil
--
resolution
Changes by Senthil Kumaran sent...@uthcode.com:
--
assignee: - orsenthil
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16450
Senthil Kumaran added the comment:
Calvin. - I shall act upon old bug. The tricky nature of backwards
compatibility sometimes let's it stale because we can not come t a good
conclusion.
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
Changes by Senthil Kumaran sent...@uthcode.com:
--
assignee: docs@python - orsenthil
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16423
Senthil Kumaran added the comment:
This is fixed in 3.3 and 3.2
3.2 5e71f2712076
3.3 30547e2cd04d
--
resolution: - fixed
status: open - closed
versions: -Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16301
Senthil Kumaran added the comment:
This is fixed in all versions now.
--
assignee: - orsenthil
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Senthil Kumaran added the comment:
Buildbot issues are taken care. They are green for while. Tests have been
backported 3.3 and 3.2 as well.
3.2 5e71f2712076
3.3 30547e2cd04d
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
Senthil Kumaran added the comment:
This has been backported.
3.2 5e71f2712076
3.3 30547e2cd04d
--
assignee: - orsenthil
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Senthil Kumaran added the comment:
Nope, I have backport it to other versions. I shall close it then.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10836
Senthil Kumaran added the comment:
Serhiy Storchaka added the comment:
+tmp_fileurl = 'file://localhost' + tmp_file
tmp_fileurl = 'file://localhost/' + tmp_file.replace(os.path.sep, '/')
Ok, I realized the mistake. 'file://localhost' + tmpfile is getting
expanded to 'file
Senthil Kumaran added the comment:
Buildbot still failing, but due to different reason.
PermissionError: [WinError 32] The process cannot access the file because it is
being used by another process:
'c:\\users\\buildbot\\appdata\\local\\temp\\tmpwwvqao'
http://buildbot.python.org/all
New submission from Senthil Kumaran:
From the Buildbot failure -
http://buildbot.python.org/all/builders/x86%20XP-4%203.x/builds/7573/steps/test/logs/stdio
I remember that we restricted the access for file:// scheme to localhost only
for Windows/Cygwin. In terms of exception raised it could
New submission from Senthil Kumaran:
localhost() returns a string and thishost() returns tuple. In
urllib/request.py, for file:// protocol, there is a verification to check to if
the host is in the localhost and check happens:
socket.gethostbyname(host) in (localhost() + thishost
Senthil Kumaran added the comment:
thanks for the bug-report/patch.
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16302
Senthil Kumaran added the comment:
The problem is here:
if url[:2] == '//' and url[2:3] != '/' and url[2:12].lower() != 'localhost/':
raise ValueError(file:// scheme is supported only on localhost)
On Unix like systems url[2:3] == '/', that is path starts with '/' and this
ValueError
Senthil Kumaran added the comment:
Serhiy: Yes. I stand corrected. That snippet suggestion was my mistake.
I think, wrapping the test is better than changing the return of localhost. It
would always return a single value. Thanks.
--
___
Python
Senthil Kumaran added the comment:
Fixed in 478cda291bbc
Berker -
with urlopen(tmp_fileurl) as fobj:
self.assertTrue(fobj)
is enough when using context manager as the fobj gets closed automatically at
exiting of context.
Thanks.
--
resolution: - fixed
status: open
Senthil Kumaran added the comment:
The change in 49de26395d1a addresses the buildbot failure. I have given a run
again.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16250
Senthil Kumaran added the comment:
The change I had made for fixing the windows buildbot had not fixed it. I am
skipped (1f92315d9568) the test on windows, investigating the reason for
windows behavior and I shall remove the skiptest on windows after fix
Senthil Kumaran added the comment:
Here is the patch which captures both HTTPError and URLError at the open_file
and thus preventing multiple exceptions to be raised ( URLError and next
IOError). This can go in 3.4 and since this is bug, where correct exception is
not being caught and wrong
Senthil Kumaran added the comment:
This one is fixed in 3.4. I can see the previous versions raised IOError
exception and it is not a good idea to change by backporting. But the wrong
arguments on URLError should be fixed tough.
--
___
Python
Senthil Kumaran added the comment:
This patch fixed these URLError wrong invocation issue and adds some tests for
testing those it.
I noticed that some of these were in the dead-end of the code, like checking if
url is not a str (it is always, unwrap makes it a str if otherwise). Those
Senthil Kumaran added the comment:
The URLError changes gone in as part of fix for issue10836 should give
e.filename and e.reason.
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16247
Senthil Kumaran added the comment:
This is fixed in 3.4. I shall backport to other branches.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16250
Senthil Kumaran added the comment:
@Ezio, regarding msg172988. That's embarrassing. It should be fixed soon.
Review on the patch, how about having the strerror and filename from the
exception?
-raise URLError(e.errno, e.strerror, e.filename)
+raise URLError(e.strerror
Changes by Senthil Kumaran sent...@uthcode.com:
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16250
___
___
Python-bugs-list
Senthil Kumaran added the comment:
Only the classes which are marked as deprecated are allowed removed in
the next release.
So the ones which we marked as deprecated in 3.3 can safely go in 3.4.
URLopener and FancyURLopener AFAIR had some dependency/ usage,
deprecating those may require some
Senthil Kumaran added the comment:
I took the privilege of testing, adding news and docs and committing it.
Thank you!
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http
Changes by Senthil Kumaran sent...@uthcode.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15922
Senthil Kumaran added the comment:
+1 to this change. It may be helpful in the cases like issue15991.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16088
Senthil Kumaran added the comment:
Personally, I want to do away with all those scheme specific stuff, if we can.
I have tried previously, but failed due to some backwards incompatibility. 3.4
gives a good chance/time to make those changes to get rid of those scheme
specific stuff (again
Senthil Kumaran added the comment:
issue9374 - another related one which should be taken care. Which is simply
reverting this:
http://hg.python.org/cpython/diff/a0b3cb52816e/Lib/urllib/parse.py and
informing in the DOCs that those globals are not available anymore. (But this
should also
Changes by Senthil Kumaran sent...@uthcode.com:
--
assignee: - orsenthil
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16095
Senthil Kumaran added the comment:
The patch looks good and is doing the right thing, that is, when the, strict
mode is passed, it fails and without strict mode, it is printing the parsed
list.
--
nosy: +orsenthil
___
Python tracker rep
701 - 800 of 1774 matches
Mail list logo
