Senthil Kumaran sent...@uthcode.com added the comment:
Hello Glenn,
Your suggestions were valid. I have made those changes in the code. Thanks! I
think, we can close this bug now and move over to others.
Thanks,
Senthil
--
status: open - closed
Senthil Kumaran sent...@uthcode.com added the comment:
I had to carefully review a lot of changes for this. In addition, I did setup a
apache and tested the behaviors too.
Few notes -
- The test for _url_collapse_path_split is not directly helpful, especially
for PATH_INFO. I removed my
Senthil Kumaran sent...@uthcode.com added the comment:
Hi David,
I am sorry, I did not notice your second comment in this bug and later when you
closed this, noticed the bug report.
Yes, the default=None but actually pointing to a sentinel value is an odd duck
and I believe the explanation
Senthil Kumaran sent...@uthcode.com added the comment:
Well, I would like to correct this further and add clarification based on the
current implementation (_sre.c)
The definition of LOCALE Space is this -
#define SRE_LOC_IS_SPACE(ch) (!((ch) ~255) ? isspace((ch)) : 0)
And the definition
Senthil Kumaran sent...@uthcode.com added the comment:
On Tue, Apr 03, 2012 at 08:37:35AM +, Ezio Melotti wrote:
Ezio Melotti ezio.melo...@gmail.com added the comment:
+ hg import --no-commit mywork.patch
Is the '' correct here?
No!. It should just be hg import --no-commit
Senthil Kumaran sent...@uthcode.com added the comment:
That's not an error, but in fact a correct statement. Please test it in the
interpreter.
--
nosy: +orsenthil
resolution: - invalid
stage: - committed/rejected
status: open - closed
type: - behavior
Senthil Kumaran sent...@uthcode.com added the comment:
It's funny, Antoine had raised an issue too. Should see why is this
sporadic failures..
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10050
Senthil Kumaran sent...@uthcode.com added the comment:
Instead of what's new, I think, linking the benchmarks in the docs could be
helpful so that library users can find it they want to. I think, we have
similar performance benchmark links at other places too.
--
nosy: +orsenthil
Senthil Kumaran sent...@uthcode.com added the comment:
To note in the tracker, the original 2.6 code was changed in Issue 2254 and the
relevant changeset is c6c4398293bd
I find, Glenn's suggestion a possibly okay solution for PATH_INFO problem,
keeping in tact the security issue
Senthil Kumaran sent...@uthcode.com added the comment:
Actually no. I revert back my previous statement. Meddling with splitpath
breaks all the tests.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10484
Senthil Kumaran sent...@uthcode.com added the comment:
I treated this as a regression from 2.6. A cgi url with
/cgi-bin/hello.py/hello/world would have PATH_INFO as '/hello/world'
I saw some apache specs saying that it should be 'hello/world', but I relied on
python2.6's behavior with had
Changes by Senthil Kumaran sent...@uthcode.com:
--
assignee: - orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10487
___
___
Python-bugs
Changes by Senthil Kumaran sent...@uthcode.com:
--
superseder: - Make CGIHTTPServer capable of redirects (and status other than
200)
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10487
Changes by Senthil Kumaran sent...@uthcode.com:
--
assignee: - orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10485
___
___
Python-bugs
Senthil Kumaran sent...@uthcode.com added the comment:
I have rewritten some parts of the documentation, explaining the use of charset
parameter with Content-Type header. Used the suggestions from the previous
patch's review comments too. I see that other parts of the documentation can
Senthil Kumaran sent...@uthcode.com added the comment:
Here is patch which adds DeprecationWarning to URLOpener and (it's subclasses
FancyURLopener) as well as some other Request methods.
The idea would be, in the next release we remove this old URLOpener and it's
subclasses and remove
Senthil Kumaran sent...@uthcode.com added the comment:
My concern was with the method get_full_url. I have seen it being
useful in more than one place and it's not just the accessor. Others
are just the accessors and those can be safely removed. When
get_full_url gives the correct url, taking
Senthil Kumaran sent...@uthcode.com added the comment:
It should be noted that diff in git supported format is recommended in the
devguide -
http://docs.python.org/devguide/committing.html#minimal-configuration
If it breaks the rietveld integration, then we should not be advising
Senthil Kumaran sent...@uthcode.com added the comment:
Éric - not really. nonlocal is from python3.x onwards only.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14217
Yeah, the other option is to fix the tracker-reitveld integration.
(Which I assumed was harder because diff did not give hg info required
for it)
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran sent...@uthcode.com added the comment:
Closing this based on - msg155387. The upstream bug is unfortunately closed
as OLD. We can reopen if this stumble upon this again.
--
resolution: - invalid
stage: needs patch - committed/rejected
status: open - closed
Senthil Kumaran sent...@uthcode.com added the comment:
One at the time - urlretrieve is re-written. Now should add deprecation
warnings to things methods to be deprecated / removed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Senthil Kumaran sent...@uthcode.com added the comment:
Thanks for the patch, Jeff McNeil. I pushed the patches to 3.2 and 3.3 docs.
Since it is a documentation change (an explaination rather), I did not update
the NEWS.
Thanks again!
--
___
Python
Senthil Kumaran sent...@uthcode.com added the comment:
Yes, it is simply a matter of adding warnings.warn in proper classes
and methods. I have started on that, Jeff. No problem. I just wanted
the changes to be two separate commits. Thanks
New submission from Senthil Kumaran sent...@uthcode.com:
Opening the this bug following this discussion -
http://mail.python.org/pipermail/docs/2012-March/007829.html
library/re.html
\S
When the LOCALE and UNICODE flags are not specified, matches any non-whitespace
character
Senthil Kumaran sent...@uthcode.com added the comment:
This clarification is specific to Python 2.7.
For Python3, the use of LOCALE flag is explicitly discouraged and
confusing references to it's meaning is not present in the docs.
--
___
Python
Senthil Kumaran sent...@uthcode.com added the comment:
Just a minor comment on the patch - It should be %r instead of %s.
-raise TypeError('must be str, not %s' % type(s))
+raise TypeError('must be str, not %r' % type(s))
If there is any test for this, it could be added
Senthil Kumaran sent...@uthcode.com added the comment:
I am closing this issue as I feel that the requirement may not be addressed by
a change. If there is patch for HowTo, we can tackle that in another issue.
Thank you for contribution.
--
resolution: - invalid
status: open - closed
Senthil Kumaran sent...@uthcode.com added the comment:
Couple of points:
1. On your last example, which webserver treats 'L' as part of port number? I
can't of anything.
2. Can you write a real application which is listening to beyond 65535? Which
platform would it be?
Current way
Senthil Kumaran sent...@uthcode.com added the comment:
I reviewed the patch, built the docs and found it good.
Fixed it in 3d877dee1bde and aaf45928899c
Thanks!
--
nosy: +orsenthil
resolution: - fixed
status: open - closed
versions: -Python 2.7
Senthil Kumaran sent...@uthcode.com added the comment:
It's an interesting issue. Thanks for the report and patch, Xavier. I am
setting patch to needing review.
--
keywords: +needs review -patch
nosy: +orsenthil
versions: +Python 2.7, Python 3.3
Senthil Kumaran sent...@uthcode.com added the comment:
Hi Jay Éric,
I understand your points and providing an extra argument seems like an idea
that could be useful to circumvent , what you see as a problem.
The RFC section states that -
The action required MAY be carried out by the user
Senthil Kumaran sent...@uthcode.com added the comment:
On Mon, Mar 05, 2012 at 11:15:38AM +, Éric Araujo wrote:
Ah, so there is a way to achieve it! If Jay is satisfied by this,
we could add an example of using that in the urllib howto, with the
appropriate warnings. That would have
Senthil Kumaran sent...@uthcode.com added the comment:
Oh Sorry. I shall fix this by this weekend.
--
assignee: - orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10484
Senthil Kumaran sent...@uthcode.com added the comment:
Here is a section which talks about 3xx redirection
http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html
10.3 Redirection 3xx
This class of status code indicates that further action needs to be taken by
the user agent in order
Senthil Kumaran sent...@uthcode.com added the comment:
If I recollect correctly, redirecting a POST request with POST data is not a
recommended thing to do and could be a security hazard. That's why RFC
prohibits it too. It is intentional that urllib2 is not redirecting carrying
along
Senthil Kumaran sent...@uthcode.com added the comment:
A couple of points to help summarize and to help come to a conclusion.
In the initial message, Stephen pointed out, it would be desirable to merely
encode spaces using percent encoding.
It seems to me that only in cases where a custom
Changes by Senthil Kumaran sent...@uthcode.com:
--
assignee: - orsenthil
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14072
Changes by Senthil Kumaran sent...@uthcode.com:
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14001
___
___
Python-bugs-list
Senthil Kumaran sent...@uthcode.com added the comment:
Stephen - urlencode is responsible for producing the
application/x-www-form-urlencoded format, usually used in the FORMs in the web.
As per the spec, the Space characters are replaced by `+'. -
http://www.w3.org/TR/html4/interact
Senthil Kumaran sent...@uthcode.com added the comment:
Thanks for patches. This is fixed.
--
nosy: +orsenthil
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Senthil Kumaran sent...@uthcode.com added the comment:
Added suggested changes to the documentation. Thanks.
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
type: - behavior
___
Python tracker rep...@bugs.python.org
http
Senthil Kumaran sent...@uthcode.com added the comment:
On Wed, Feb 08, 2012 at 03:42:16AM +, Eli Bendersky wrote:
Any objections?
None. The explanation sounds reasonable.
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http
Senthil Kumaran sent...@uthcode.com added the comment:
I have stumbled upon a wrong impression as well by reading the docs, but
usually in the code, I tend to catch the specific Exceptions, like timeout
instead or URLError when it is known. I saw some libraries following similar
pattern too
Senthil Kumaran sent...@uthcode.com added the comment:
I am sorry. I see that with context object in 3.x, verification is being done.
The CA certs can be pointed to using load_verify_locations.
As the author had in this patc tothe pass on addition ca_certs and ca_reqs to
wrap_socket in ssl
Senthil Kumaran sent...@uthcode.com added the comment:
Thanks for submitting the patch. Couple of comments.
1. This is a new feature, so the patch should be addressed against 3.x.
2. The patch lacks tests and documentation and hence it is not complete.
You could take a look at http/client.py
Senthil Kumaran sent...@uthcode.com added the comment:
urljoin(http://;, //somedomain.com)
results in http://somedomain.com;
So, I wonder if this way to specify the relative url properly and not the
base-url.
The test suite of urlparse tries to follow all the advertised scenarios
Senthil Kumaran sent...@uthcode.com added the comment:
On Sun, Jan 29, 2012 at 10:48:35PM +, Martin v. Löwis wrote:
orsenthil: I don't fully understand your question (what kind of carrying
should the clients do);
By that I mean, sending the ca_file and cert_reqs from the client,
which I
Senthil Kumaran sent...@uthcode.com added the comment:
On Sun, Jan 29, 2012 at 10:30:45PM +, Antoine Pitrou wrote:
Well, if you are a security expert you can volunteer to maintain a
trusted certificates' file in the Python repository :) I think
nobody else amongst us is qualified
Senthil Kumaran sent...@uthcode.com added the comment:
I think, I was using wrong terminology, by 'sending' I meant, 'using' the
ca_file in the client to verify Server's certificates.
--
___
Python tracker rep...@bugs.python.org
http
Changes by Senthil Kumaran sent...@uthcode.com:
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13856
___
___
Python-bugs-list
Senthil Kumaran sent...@uthcode.com added the comment:
Actually, I saw this as a bug with urllib.urlopen and urllib2 had
exhibited proper behaviour previously. Now, both behaviour will be
consistent now.
But, you are right that an *incorrect* usage of urllib.urlopen would
break in 2.7.2
Changes by Senthil Kumaran sent...@uthcode.com:
--
assignee: - orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13736
___
___
Python-bugs
Changes by Senthil Kumaran sent...@uthcode.com:
--
title: urlparse.urlunsplit() can't handle relative files (for urllib*.open() -
Disallow relative files paths in urllib*.open()
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Changes by Senthil Kumaran sent...@uthcode.com:
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
type: performance - behavior
versions: +Python 2.7, Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
http
Senthil Kumaran sent...@uthcode.com added the comment:
I add -o as a short form for --slow. regrtest was using getopt and this
conflicting option was not caught. I see it is a bug than a feature so the
change is made in 3.2 and 3.3
default: b84f61fdcb4c and 6797e7458ad0
Thanks for catching
Senthil Kumaran sent...@uthcode.com added the comment:
Here we go! I thought the problem did not exist in py3k, but good that the
tests caught them and we have a fix now.
Thanks for the complete patch, Joonas. I hope it was easy to port the patch to
3k. The encoding part may perhaps
Changes by Senthil Kumaran sent...@uthcode.com:
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13766
___
___
Python-bugs-list
Senthil Kumaran sent...@uthcode.com added the comment:
Fixed now. Thanks!
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13726
Changes by Senthil Kumaran sent...@uthcode.com:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13294
___
___
Python-bugs
Senthil Kumaran sent...@uthcode.com added the comment:
Eric - noted the point. :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13294
Senthil Kumaran sent...@uthcode.com added the comment:
Joonas and Michele - The fix along with the tests is in for 2.7 line. W.r.t to
tests having it in the class level buf seems to be only easy way, for other it
seemed to be that FakeSocket and FakeConnection stuff need some major change
Senthil Kumaran sent...@uthcode.com added the comment:
This is fixed. Thanks for your contribution.
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Senthil Kumaran sent...@uthcode.com added the comment:
Sorry, this escaped for so long. First thing is, having different values for
HTTP_PROXY and HTTP_proxy and http_proxy is plain wrong at the user side. They
all should be same and in that case the possible problem which Kirikaza and
Neil
Senthil Kumaran sent...@uthcode.com added the comment:
Some review comments. Instead of doing the inline unquote like this -
-auth = base64.b64encode(user_passwd).strip()
+auth = base64.b64encode(unquote(user_passwd)).strip()
It is better to do the explicitly above
Senthil Kumaran sent...@uthcode.com added the comment:
Here is the patch against 3.2. Something is wrong with the mercurial at the
moment where 3.2 is shown as inactive. Once that is corrected, I shall commit
and push this to 3.2 and cpython codelines.
This bug is not present in 2.7
Changes by Senthil Kumaran sent...@uthcode.com:
--
resolution: - fixed
stage: test needed - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13696
Senthil Kumaran sent...@uthcode.com added the comment:
The concern here is if the request line had something like this.
Method SP Request-URI SP HTTP-Version ANY_\r_\n_\r\n_Combination\r\n
The previous behavior would have resulted in
Method SP Request-URI SP HTTP-Version ANY_\r_\n_\r
Senthil Kumaran sent...@uthcode.com added the comment:
The original issue was invalid.
Incorporated Michele Orrù's code style changes into the trunk and other
codelines.
--
resolution: - fixed
status: open - closed
title: http.server: HEAD request should not return a body
Senthil Kumaran sent...@uthcode.com added the comment:
Fixed this in 2.7.
--
nosy: +orsenthil
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13443
Senthil Kumaran sent...@uthcode.com added the comment:
Updated the doc with Sandro Tosi's suggested changes in all the codelines.
--
nosy: +orsenthil
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http
Senthil Kumaran sent...@uthcode.com added the comment:
This is in 3.3. Thanks for the patches.
--
nosy: +orsenthil
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13620
Changes by Senthil Kumaran sent...@uthcode.com:
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11012
___
___
Python-bugs-list
Senthil Kumaran sent...@uthcode.com added the comment:
Let's make it useful, that's much better instead of removing it. I am
+1 with Ezio's suggestion on this to return a list of tuples with
matching headers.
--
title: http.client.HTTPMessage.getallmatchingheaders() always returns
Changes by Senthil Kumaran sent...@uthcode.com:
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13425
___
___
Python-bugs-list
Senthil Kumaran sent...@uthcode.com added the comment:
Hi Jason Petri,
urllib2.HTTPError never had a reason attribute. In the docs, it is mentioned
that only URLError has the reason attribute. The HTTPError sublasses URLError
and addinforurl class, but the further initialization happens only
Senthil Kumaran sent...@uthcode.com added the comment:
Here is the docs patch which will help us close the issue. Addressing Eric's
last comment - I believe the what's new and News for this issue was added with
the feature, this one was Exception msg change.
--
Added file: http
Changes by Senthil Kumaran sent...@uthcode.com:
--
assignee: - orsenthil
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13323
Senthil Kumaran sent...@uthcode.com added the comment:
Thanks for the report, Jakub and for the patch, Jyrki
--
nosy: +orsenthil
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13147
Senthil Kumaran sent...@uthcode.com added the comment:
Thanks flox for the patch.
Just the News item is added. I don't think, this requires any Docs update. One
change I had to make in the patch is to remote HTTPSHandler from __all__
because that is only conditionally available when
Senthil Kumaran sent...@uthcode.com added the comment:
This is fixed in all codelines. Thanks for your contribution, Jyrki Pulliainen.
--
resolution: - fixed
status: open - closed
versions: +Python 3.2, Python 3.3
___
Python tracker rep
Senthil Kumaran sent...@uthcode.com added the comment:
I agree with your interpretation of the RFC. The parsing rules do not specify
any provision for inclusion of blank lines within the records.
However, I find that inclusion is no harm either. I checked that with a
robots.txt parser (Google
Senthil Kumaran sent...@uthcode.com added the comment:
Let's deprecate some of these (or add deprecation warnings) for
upcoming release. But, doing from xxx import * is not a recommended
way for any module, as we know that it stands to pollute the namespace
with unneccesary functions/methods. I
Senthil Kumaran sent...@uthcode.com added the comment:
This kind of suggestion has come up before and easy fix is to add individual
schemes as the patch does. There is a number of limitations if want to make the
parser generic for any scheme. The difficult thing being the parsing behavior
Changes by Senthil Kumaran sent...@uthcode.com:
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13033
___
___
Python-bugs-list
Senthil Kumaran sent...@uthcode.com added the comment:
Similar issue Issue7904 and 7da7f9bfdaac wherein the accepted way to parse
x-newscheme://foo.com/stuff was added. Does the new ws:// scheme not fall under
that?
--
___
Python tracker rep
New submission from Senthil Kumaran sent...@uthcode.com:
This was in the docs mailing list, not translated to bug report
Paul Koning wrote:
Section 8.1.6 of the library manual talks about utcoffset(dt)-dst(dt) as the
standard offset and says that this should not depend on the date or +time
Changes by Senthil Kumaran sent...@uthcode.com:
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13211
___
___
Python-bugs-list
The code is pretty straight forward and works on Linux. Is the problem
with the download? If you open the json file, is it a valid one?
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran sent...@uthcode.com added the comment:
Thanks for the patch, Petri and Ben.Darnell.
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12529
Senthil Kumaran sent...@uthcode.com added the comment:
Fixed in all active branches. Thanks for the patch, Petri.
Mark, for this issue, raising ValueError from zipfile was seemingly a right
thing to do, the previous error from struct for a side effect of sending a
value lower than 1980
Senthil Kumaran sent...@uthcode.com added the comment:
- page.encoding is a good idea.
- page.decode_content sounds definitely better than page.decode which can be
confusing as page is not a bytes object, but a file-like object.
I am thinking if an attribute to urlopen would be better
Senthil Kumaran sent...@uthcode.com added the comment:
Hi Eric,
The changes suggested in the patch are good for readability, I
shall include them all. Thanks!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1673007
Senthil Kumaran sent...@uthcode.com added the comment:
I have committed the patch accomodating the doc review comments which Ezio had
mentioned. At the moment, the current way seems to be most backwards compatible
one and did not want to delay it. Let's hope we get some feedback
Senthil Kumaran sent...@uthcode.com added the comment:
Fixed in 25ff1adf5f30
--
nosy: +orsenthil
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13154
Senthil Kumaran sent...@uthcode.com added the comment:
Patrick,
Lots of valid points. I had not looked at the RFC spec when I mentioned about
data over request (GET) method, but was trying to derive the current
functionality of module (so that users can have a seamless experience
Senthil Kumaran sent...@uthcode.com added the comment:
Hi Ezio, I had probably overlooked this one. But It's a very interesting one
for me. Do you mind if I commit it ?
On Oct 10, 2011 7:20 PM, Ezio Melotti rep...@bugs.python.org wrote:
Ezio Melotti ezio.melo...@gmail.com added the comment
Senthil Kumaran sent...@uthcode.com added the comment:
Our discussion stemmed from this point. If you look at the change proposed,
Request class is taking a new parameter by name 'method' and it is initialized
to None:
class Request:
def __init__(self, url, data=None, headers
Senthil Kumaran sent...@uthcode.com added the comment:
Yes, I agree. I think, it can be clarified at that point too. Because.
in 2.7 the string is being checked and in 3.3 the message_body is
checked if it's instance of bytes. But, I think, it should be
carefully worded (aligned with how other
Senthil Kumaran sent...@uthcode.com added the comment:
I believe, I have addressed all the comments. Closing this report.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13073
901 - 1000 of 1774 matches
Mail list logo
