Tal Einat added the comment:
Serhiy, this looks like a great step in the right direction!
Tested on Win10 with PR GH-16545 (commit f4db0e7e00). Here is a copy/paste from
an IDLE shell session:
>>> '\N{PERSONAL COMPUTER}'
'ð»'
>>> print('')
SyntaxError: 'utf-8'
Change by Tal Einat :
--
versions: +Python 2.7
___
Python tracker
<https://bugs.python.org/issue37883>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
Removed message: https://bugs.python.org/msg353402
___
Python tracker
<https://bugs.python.org/issue37883>
___
___
Python-bugs-list m
Tal Einat added the comment:
Looking at Lib/threading.py and Modules/_threadmodule.c, it actually appears
that RLock.locked() is only implemented by the C implementation, but not the
Python implementation which is used as a backup.
If we're going to make the locked() method more visible
Tal Einat added the comment:
For future reference, there's a nicer, more concise way to reference PRs: just
type GH-16420 (using the relevant PR number).
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue37
Tal Einat added the comment:
Michael, many many thanks for the time and effort that you have poured into
getting this fixed, and for your patience and perseverance over the three years
that it took to happen. Well done!
--
resolution: -> fixed
stage: patch review -> resolved
Tal Einat added the comment:
New changeset 0bcbfa43d55d9558cdcb256d8998366281322080 by Tal Einat (Michael
Felt) in branch 'master':
bpo-28009: Fix uuid.uuid1() and uuid.get_node() on AIX (GH-8672)
https://github.com/python/cpython/commit/0bcbfa43d55d9558cdcb256d8998366281322080
Tal Einat added the comment:
I can confirm that the crash from pasting these characters happens when trying
to fetch the clipboard contents. We can override the built-in <> event,
but then we have to get the clipboard's contents directly, and the only
portable way to do that in the
Tal Einat added the comment:
FWIW, though this is arguably fixing a bug, IMO this shouldn't be back-ported
to 2.7 or 3.7, but only be in 3.8+, to avoid breaking backwards-compatibility.
That being said, it would be great to get this into 3.8.0!
--
nosy: +taleinat
Tal Einat added the comment:
I've also seen these occasionally, but I haven't yet found a way to reproduce
consistently.
Regardless, IMO the shutdown close() and _close() should be the places handling
shutdown-related exceptions if possible. In all of the tracebacks posted here,
as well
Tal Einat added the comment:
> Would it be possible to tell pickle to serialize .isocalendar() as a tuple,
> and deserialize it from a tuple to a structseq?
The former is possible but that latter is not: If the object is pickled as a
tuple, it will always be unpickled as a simple
Tal Einat added the comment:
See PR GH-15664 with an implementation.
--
___
Python tracker
<https://bugs.python.org/issue38022>
___
___
Python-bugs-list mailin
Change by Tal Einat :
--
keywords: +patch
pull_requests: +15329
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15664
___
Python tracker
<https://bugs.python.org/issu
New submission from Tal Einat :
The rest of our docs use version 2.x of Sphinx with its new HTML5 output
writer. However, IDLE's help.html is a version of idle.rst rendered with the
old writer, via the `-D html4_writer=1` command line parameter.
The reason for this is that the new output
Tal Einat added the comment:
New changeset 58067d2cf6e81187f9782aff03cc8bec3d878778 by Tal Einat (Miss
Islington (bot)) in branch '3.8':
bpo-37798: Fix _statistics module doc (GH-15546)
https://github.com/python/cpython/commit/58067d2cf6e81187f9782aff03cc8bec3d878778
Tal Einat added the comment:
New changeset 0cf832a9ef84be6e18aad02464814530d80b82b2 by Tal Einat (Dong-hee
Na) in branch 'master':
bpo-37798: Fix _statistics module doc (GH-15546)
https://github.com/python/cpython/commit/0cf832a9ef84be6e18aad02464814530d80b82b2
--
nosy: +taleinat
Tal Einat added the comment:
Paul, I'm also on the fence regarding the advantage of this. It's not clear
that the minor possible benefits outweigh the additional complexity and slight
backwards-incompatibility (pickling).
Thinking about this further, yes, we'd probably avoid making
Change by Tal Einat :
--
pull_requests: +15302
pull_request: https://github.com/python/cpython/pull/15634
___
Python tracker
<https://bugs.python.org/issue35
Tal Einat added the comment:
Dong-hee Na, yes, that would be welcome.
Making a PR would be a great first step.
I also suggest adding a note about the issue unpickling with earlier versions,
in the NEWS entry and it the "What's New" entry.
--
versions: +Python 3.9 -
Tal Einat added the comment:
Terry, thanks for the detailed writing of your thoughts on the matter and their
context.
Serhiy's argument (in msg246602) is that different terminals interpret
different control characters in different ways, and that we have no way of
unifying their behavior
Tal Einat added the comment:
IMO the benefit here is very small and not worth the added complexity
(implementation + tests + docs + maintenance).
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue31
Tal Einat added the comment:
Fixed.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
See issue #37827 regarding handling of progress output, as written by
tensorflow.keras for example.
--
versions: +Python 3.9
___
Python tracker
<https://bugs.python.org/issue35
Tal Einat added the comment:
New changeset d4b4c00b57d24f6ee2cf3a96213406bb09953df3 by Tal Einat in branch
'master':
bpo-37929: IDLE: avoid Squeezer-related config dialog crashes (GH-15452)
https://github.com/python/cpython/commit/d4b4c00b57d24f6ee2cf3a96213406bb09953df3
Tal Einat added the comment:
See PR GH-15474 with an implementation.
--
___
Python tracker
<https://bugs.python.org/issue37903>
___
___
Python-bugs-list mailin
Change by Tal Einat :
--
keywords: +patch
pull_requests: +15162
stage: test needed -> patch review
pull_request: https://github.com/python/cpython/pull/15474
___
Python tracker
<https://bugs.python.org/issu
Tal Einat added the comment:
See PR GH-15452 with a fix.
--
___
Python tracker
<https://bugs.python.org/issue37929>
___
___
Python-bugs-list mailing list
Unsub
Change by Tal Einat :
--
keywords: +patch
pull_requests: +15144
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15452
___
Python tracker
<https://bugs.python.org/issu
Tal Einat added the comment:
I see none of this on latest master (0567786d26348aa7eaf0ab1b5d038fdabe409d92)
on Windows 10. Can you specify on what OS and Python branch/version this
happens?
--
___
Python tracker
<https://bugs.python.
Tal Einat added the comment:
Il take a look at this. I've very recently gone through the relevant parts of
the code and I should be able to figure it it efficiently.
--
___
Python tracker
<https://bugs.python.org/issue37
Tal Einat added the comment:
> Unless you say differently, I will add idlelib/NEWS.txt item tomorrow and
> merge.
I've added an idlelib/NEWS.txt entry to the PR. Feel free to merge.
--
___
Python tracker
<https://bugs.python.org/i
Change by Tal Einat :
--
pull_requests: -14989
___
Python tracker
<https://bugs.python.org/issue37849>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: +14989
pull_request: https://github.com/python/cpython/pull/15169
___
Python tracker
<https://bugs.python.org/issue37
Tal Einat added the comment:
See PR GH-15267 with a fix.
--
___
Python tracker
<https://bugs.python.org/issue37849>
___
___
Python-bugs-list mailing list
Unsub
Change by Tal Einat :
--
keywords: +patch
pull_requests: +14988
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15267
___
Python tracker
<https://bugs.python.org/issu
Change by Tal Einat :
Added file:
https://bugs.python.org/file48541/idle_completion_window_position.png
___
Python tracker
<https://bugs.python.org/issue37849>
___
___
New submission from Tal Einat :
When the current line is near the bottom of the shell window, the completions
list will be shown above it. However, instead of appearing directly above the
current line, it appears quite a bit higher, about one line too high. See
attached screenshot.
Seen
Tal Einat added the comment:
Terry, many thanks for the clarifications!
> The intended behavior is to complete if at all possible.
I can see the point in that.
> What is odd to me is that you seem happy using the more numerous non-user
> IDLE imports when there is
Change by Tal Einat :
--
Removed message: https://bugs.python.org/msg349556
___
Python tracker
<https://bugs.python.org/issue37821>
___
___
Python-bugs-list m
Tal Einat added the comment:
Terry, many thanks for the clarifications!
> The intended behavior is to complete if at all possible.
I can see the point in that.
> What is odd to me is that you seem happy using the more numerous non-user
> IDLE imports when there is
Tal Einat added the comment:
See issue #37768 regarding opening of help(object) output in a separate window.
--
___
Python tracker
<https://bugs.python.org/issue35
Tal Einat added the comment:
With PR GH-15211 (for issue #37827), which implements terminal-like handling of
the \r and \b control characters, the TensorFlow tutorial almost works as
intended in the IDLE shell; a minor change to Tensorflow is needed to make it
work as intended.
Tensorflow
Change by Tal Einat :
--
pull_requests: -14939
___
Python tracker
<https://bugs.python.org/issue23220>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
See PR GH-15211 with a working implementation.
--
___
Python tracker
<https://bugs.python.org/issue37827>
___
___
Python-bugs-list m
Tal Einat added the comment:
Ah, sorry for missing that, Terry. See new issue, #37827, for the proposed
change.
--
___
Python tracker
<https://bugs.python.org/issue23
Change by Tal Einat :
--
keywords: +patch
pull_requests: +14945
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15211
___
Python tracker
<https://bugs.python.org/issu
New submission from Tal Einat :
IDLE's shell doesn't currently handle \r and \b in any special way; they are
written the the Tk Text widget which displays them in strange, system-dependent
ways.
These are often used to show continuously updated progress, e.g. in text-based
progress bars
Tal Einat added the comment:
See initial working implementation of handling \r and \b characters is the
shell, PR GH-15211.
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue23
Change by Tal Einat :
--
pull_requests: +14939
pull_request: https://github.com/python/cpython/pull/15211
___
Python tracker
<https://bugs.python.org/issue23
Tal Einat added the comment:
See fix in PR GH-15207.
--
___
Python tracker
<https://bugs.python.org/issue37821>
___
___
Python-bugs-list mailing list
Unsub
Change by Tal Einat :
--
keywords: +patch
pull_requests: +14936
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15207
___
Python tracker
<https://bugs.python.org/issu
New submission from Tal Einat :
Currently, when running an IDLE shell with a sub-process, it will allow
completing attributes of objects not actually in the shell's namespace. For
example, typing "codecs." will bring up completions for the codecs module's
attributes, despite that
Tal Einat added the comment:
I propose closing this as "wontfix", since this goes strongly against how
completions currently work in IDLE (based on the namespace of the shell), and I
don't think we're considering changing that.
--
nosy:
Tal Einat added the comment:
I'm happy to look into implementing this. Also perhaps auto-saved backups for
edited files.
Where would you suggest the files be kept? The user's .idlerc directory?
--
nosy: +taleinat
___
Python tracker
<ht
Tal Einat added the comment:
Many thanks for the review, Kyle!
--
___
Python tracker
<https://bugs.python.org/issue21261>
___
___
Python-bugs-list mailin
Tal Einat added the comment:
Raymond, your with may just come true!
I've just created PR GH-15169 with a new implementation of my own, complete
with tests. I have not yet thoroughly tested it though, and would like some
feedback
Change by Tal Einat :
--
pull_requests: +14901
pull_request: https://github.com/python/cpython/pull/15169
___
Python tracker
<https://bugs.python.org/issue21
Tal Einat added the comment:
So, Jupyter notebook has special support for carriage-return ('\r') and
backspace ('\b') characters[1].
Do we want to consider adding similar support in IDLE?
[1]
https://github.com/jupyter/notebook/blob/e498de6775b3de57f5ff827e562c179b17893064/notebook/static
Tal Einat added the comment:
IDLE in general doesn't recognize and support control characters commonly used
in terminals. This is often a problem with running things that show a progress
bars, which usually print "\r" to return the cursor to the beginning of the
line and then
Tal Einat added the comment:
I had no idea that this was desired... I had this working in a old version of
autocomplete back before 2010! I'm not sure whether I'll be able to find it
though.
I can't understand why Louie's PR was closed, it seemed to be going in the
right direction... Any
Tal Einat added the comment:
Raymond, I'm interested in your opinion on this.
--
nosy: +rhettinger
___
Python tracker
<https://bugs.python.org/issue37
Tal Einat added the comment:
See PR GH-15140.
--
___
Python tracker
<https://bugs.python.org/issue37768>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
keywords: +patch
pull_requests: +14878
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15140
___
Python tracker
<https://bugs.python.org/issu
New submission from Tal Einat :
Currently, IDLE just writes the entire help message into the shell.
If auto-squeezing is enabled, then long help messages are automatically
squeezed, following which the help text can be viewed in a text viewer or
expanded inline. This is still not great UX
Tal Einat added the comment:
Regarding help(), there's actually a comment in IDLE's code by KBK that it
should be opened in a reader (this was before TextViewer was added). IMO
that's a much better approach for long help() outputs, and is simple to
implement
Tal Einat added the comment:
To be clear, I'm currently -1 on this suggestion.
--
___
Python tracker
<https://bugs.python.org/issue37765>
___
___
Python-bug
Tal Einat added the comment:
The global completion list (i.e. when not completing a file name or object
attribute) is already full of all the built-ins, imported modules and
variables. So IMO we'd need a good reason to add yet more options into the
completions list.
Personally, I don't
Tal Einat added the comment:
I too find this surprising, especially given how thoroughly UUID validates
inputs of types other than "hex".
The documentation simply states that for hex input, hypens, curly braces and a
URN prefix are optional. In practice, though, it is much mo
Tal Einat added the comment:
I'm closing this: It has had no followup in over 3 months, and seems to be a
simple misuse of the C API rather than a bug.
--
nosy: +taleinat
stage: -> resolved
status: pending -> closed
___
Python tracker
Tal Einat added the comment:
Tkinter calls Tcl_DeleteInterp when a Tk object is garbage collected, and it
registers a cleanup callback for each registered command, which according to
the Tcl docs should be called upon Tcl_DeleteInterp[1]. So this must either be
a bug in Tcl or something
Tal Einat added the comment:
I am able to reproduce this with Python 3.6.3 and 3.7.0, but not with 3.7.4,
3.8.0b3 or current master (to be 3.9).
This has been fixed since 3.7.3; see issue #34572.
--
nosy: +taleinat
resolution: not a bug -> fixed
stage: -> resolved
status: p
Tal Einat added the comment:
On Windows 10, this reproduces consistently with 3.6 and 3.7.0, but not with
3.7.4, 3.8.0b3 and current master. So this definitely seems to be fixed.
--
nosy: +taleinat
resolution: -> fixed
stage: -> resolved
status: open -&g
Tal Einat added the comment:
Note that the original fix, in PR GH-9133, contained a bug: UUID objects with
`is_safe` set to `SafeUUID.unknown` would cause an exception if unpickled with
Python <3.7.
This was reported by Thomas Wiebe in a comment to a commit in that PR:
https://github.
Tal Einat added the comment:
New changeset a2ea9448c677706d6318eaa71101f08df7604eb9 by Tal Einat in branch
'3.7':
[3.7] bpo-34621: backwards-compatible pickle UUID with is_safe=unknown
(GH-14834)
https://github.com/python/cpython/commit/a2ea9448c677706d6318eaa71101f08df7604eb9
Tal Einat added the comment:
I was even able to reproduce this on Windows, though not on my Mac. A sneaky
bug.
See PR GH-15103 with a fix.
--
___
Python tracker
<https://bugs.python.org/issue37
Change by Tal Einat :
--
pull_requests: +14845
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15103
___
Python tracker
<https://bugs.python.org/issu
Tal Einat added the comment:
Ah, my bad, I mixed up "Check Module" with the proposed external checkers
feature.
Anyways, I'm +1 on this reordering, but have no opinion on the specifics.
--
___
Python tracker
<https://bugs.python.o
Tal Einat added the comment:
Perhaps we should use a separator to differentiate between things that run in
the shell and those that don't, e.g. as following:
Run Module
Run... Customized
Python Shell
-
Check Module
--
___
Python
Change by Tal Einat :
--
nosy: +Michael.Felt
___
Python tracker
<https://bugs.python.org/issue37733>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
Hi Tal, could you please make your report clearer by giving more context? Right
now it is very hard to understand.
The following would be helpful:
* What are you trying to do that is failing? (perhaps extract a Zip archive?)
* Which libraries/classes/functions
Tal Einat added the comment:
I can't reproduce this on a Mac now with the recent 3.8.0b3 installer: After
removing the skipIf() decorators, the tests all pass as expected.
Ned, can you check with this installer? If it still fails for you, can you give
some details about your Mac, e.g
Tal Einat added the comment:
Karl, many thanks for bringing this up, making a PR and iterating on it with me!
--
nosy: +taleinat
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.9
___
Pytho
Tal Einat added the comment:
Unfortunately, my Mac is out of order, so I am unable to diagnose and fix this.
I hope to be able to do so again in a few weeks.
--
___
Python tracker
<https://bugs.python.org/issue37
Tal Einat added the comment:
Terry, thanks for reviewing, helping get this fully ready, and merging.
Kyle, thanks for the kind feedback, it's truly heart-warming!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
Tal Einat added the comment:
> The current right margin is 1 pixel. Let's try making it 2.
See PR GH-14959. I added 2 pixels of horizontal padding to the line numbers
text widget, and it certainly does look much nicer. Thanks for the suggestion,
K
Change by Tal Einat :
--
pull_requests: +14727
pull_request: https://github.com/python/cpython/pull/14959
___
Python tracker
<https://bugs.python.org/issue17
Tal Einat added the comment:
See proposed fix in PR GH-14958.
--
___
Python tracker
<https://bugs.python.org/issue37628>
___
___
Python-bugs-list mailin
Change by Tal Einat :
--
keywords: +patch
pull_requests: +14726
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/14958
___
Python tracker
<https://bugs.python.org/issu
Tal Einat added the comment:
Correction: Terry commented on that issue (#37628) earlier today; Raymond
Hettinger originally reported it a about a week ago.
--
___
Python tracker
<https://bugs.python.org/issue17
Tal Einat added the comment:
Thanks for trying this and giving such useful feedback, Kyle!
Interestingly, Terry just opened an issue about exactly what you mention
regarding the font configuration window; see issue #37628.
--
___
Python tracker
Tal Einat added the comment:
Since it's a text widget, it would be simple and rather intuitive to make it
scrollable. We could then make its size set according to the size of the
config dialog window, rather than the other way around
Tal Einat added the comment:
PR Merged! This will be in 3.8.0 and 3.7.5. Thanks to everyone who worked on
this and took part in the discussion!
Special thanks to Saimadhav for preparing a patch and iterating on it several
times; I picked up the work from where he left off
Tal Einat added the comment:
New changeset e9ec1663d8fa0b3829add14e784107482af8dacb by Tal Einat in branch
'3.7':
[3.7] bpo-17535: IDLE editor line numbers (GH-14030)
https://github.com/python/cpython/commit/e9ec1663d8fa0b3829add14e784107482af8dacb
Change by Tal Einat :
--
pull_requests: +14692
pull_request: https://github.com/python/cpython/pull/14917
___
Python tracker
<https://bugs.python.org/issue17
Tal Einat added the comment:
New changeset 7123ea009b0b004062d91f69859bddf422c34ab4 by Tal Einat in branch
'master':
bpo-17535: IDLE editor line numbers (GH-14030)
https://github.com/python/cpython/commit/7123ea009b0b004062d91f69859bddf422c34ab4
Tal Einat added the comment:
New changeset 1ebee37dde5c2aabc8e2d2c7bbe2a69b293133bb by Tal Einat in branch
'master':
bpo-33610: validate non-negative integer inputs in IDLE's config (GH-14822)
https://github.com/python/cpython/commit/1ebee37dde5c2aabc8e2d2c7bbe2a69b293133bb
Change by Tal Einat :
--
pull_requests: +14625
pull_request: https://github.com/python/cpython/pull/14834
___
Python tracker
<https://bugs.python.org/issue34
Tal Einat added the comment:
Regarding validating integer inputs in the configuration dialog (E3), see my
new PR GH-14822.
--
___
Python tracker
<https://bugs.python.org/issue33
Change by Tal Einat :
--
pull_requests: +14616
pull_request: https://github.com/python/cpython/pull/14822
___
Python tracker
<https://bugs.python.org/issue33
Tal Einat added the comment:
Terry, on latest master (with the aforementioned PR merged), the context is
updated quickly after the code-context is shown. This happens after a delay of
up to 100ms due to the update loop.
I've created PR GH-14821 with a fix
401 - 500 of 1483 matches
Mail list logo
