lekma <lekma...@gmail.com> added the comment:
sorry, my mistake, I missed the format specifier in PyObject_CallFunction()
sorry for the noise
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Pyth
New submission from lekma <lekma...@gmail.com>:
Am I wrong in thinking 'filename_obj' should be decrefed before the last two
return statements in set_main_loader()? If yes, what am I missing?
--
components: Interpreter Core
messages: 317789
nosy: lekma
priority: normal
severity:
Change by lekma <lekma...@gmail.com>:
--
pull_requests: +6367
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue33391>
___
__
Change by lekma <lekma...@gmail.com>:
--
pull_requests: +6366
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue33391>
___
__
lekma <lekma...@gmail.com> added the comment:
> Good catch! Do you mind to create a pull request on GitHub?
done
--
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Change by lekma <lekma...@gmail.com>:
--
pull_requests: +6365
stage: -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
New submission from lekma <lekma...@gmail.com>:
shouldn't otherset be decrefed before returning on error in
set_symmetric_difference? if not, what am I missing?
--
components: Interpreter Core
files: setobject.c.diff
keywords: patch
messages: 315945
nosy: lekma
priority:
lekma <lekma...@gmail.com> added the comment:
thinking out loud here: maybe both behavior can be exposed, i.e. a
PyCapsule_Import that would expect a valid import statement and a Py_GetCapsule
that would behave more like getattr?
--
___
lekma <lekma...@gmail.com> added the comment:
> PR 4988 will break the case 'module.attr.capsule' if 'module.attr' is
> not a module.
you are right, but is that a case you would expect in an import
statement?
--
___
Python
New submission from lekma <lekma...@gmail.com>:
When capsule name is in the form 'package.module.capsule', PyCapsule_Import
fails with an AttributeError (module is never an attribute of package).
--
components: Interpreter Core
messages: 308950
nosy: lekma
priority: normal
se
Changes by lekma lekma...@gmail.com:
--
nosy: +lekma
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15870
___
___
Python-bugs-list mailing list
Changes by lekma lekma...@gmail.com:
--
nosy: +lekma
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7330
___
___
Python-bugs-list mailing list
lekma lekma...@gmail.com added the comment:
Thank you very much for your help
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10271
lekma lekma...@gmail.com added the comment:
how should we go about that?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10271
___
___
Python
lekma lekma...@gmail.com added the comment:
Is there anything else I should be doing?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10271
lekma lekma...@gmail.com added the comment:
- split the patch between the actual fix and the test
- rewrote the test a little bit (I'm not sure it's even needed, hence the split)
- rediff against 3.3 (should still apply cleanly on top of 3.2 (modulo offset))
--
versions: +Python 3.3
Changes by lekma lekma...@gmail.com:
Added file: http://bugs.python.org/file21695/Issue10271.33.test.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10271
lekma lekma...@gmail.com added the comment:
brett,
is there any chance for this to make it in?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10271
Changes by lekma lekma...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file20647/Issue10271.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10271
New submission from lekma lekma...@gmail.com:
Overriding warnings.showwarning() with a c/python module function (from a
c/python module) doesn't work because warn_explicit() only allow PyFunction or
PyMethod objects to be called (unfortunately c/python module functions are of
type PyCFunction
lekma lekma...@gmail.com added the comment:
lekma, do you have a real name that we should add to the ACKS file?
no, lekma is fine (that's a nick I carry since childhood)
Looking at it again, there's the question of accept() behaviour. [...]
Sorry for not having seen that earlier and thanks
lekma lekma...@gmail.com added the comment:
lekma, this patch is now listed in the 2.7 what's new document as
contributed by the lekma user, please tell us if you want your name
there.
Nope, that's ok (it's perfect).
--
___
Python tracker rep
lekma lekma...@gmail.com added the comment:
Thanks for the patch! I rewrote the C function a bit to also take a dict
argument, and added a test for that. Committed in r77088. Will merge
to py3k.
Great!
Thanks to all for the help!
--
___
Python
lekma lekma...@gmail.com added the comment:
patch against trunk:
- fix tabs issue (I hope)
- add test
--
Added file: http://bugs.python.org/file15645/issue7033_trunk_3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7033
lekma lekma...@gmail.com added the comment:
The same with a simpler test.
I leave it up to you guys to choose which one is the best.
--
Added file: http://bugs.python.org/file15646/issue7033_trunk_3_alt_test.diff
___
Python tracker rep
lekma lekma...@gmail.com added the comment:
this one addresses Antoines's comments (with the help of R. David Murray).
--
Added file: http://bugs.python.org/file15621/Issue7523_3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
lekma lekma...@gmail.com added the comment:
Is there any chance that this will make it in?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7033
lekma lekma...@gmail.com added the comment:
It would be better to use test skipping: (eg: @unittest.SkipUnless
before the test class).
I didn't know about this feature, thanks for the tip.
Now I wonder if it would be better to do it this way:
@unittest.SkipUnless(hasattr(socket, SOCK_CLOEXEC
lekma lekma...@gmail.com added the comment:
- when importing fcntl, bear in mind that some systems don't have this
module (e.g. Windows), so you should catch and silence the ImportError
would something like the following be ok?:
try:
import fcntl
except ImportError:
fcntl = False
New submission from lekma lekma...@gmail.com:
It would be nice to have those.
See http://udrepper.livejournal.com/20407.html for background.
--
components: Library (Lib)
messages: 96482
nosy: lekma
severity: normal
status: open
title: add SOCK_NONBLOCK and SOCK_CLOEXEC to socket module
lekma lekma...@gmail.com added the comment:
First attempt, against trunk.
--
keywords: +patch
Added file: http://bugs.python.org/file15573/Issue7523.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7523
lekma lekma...@gmail.com added the comment:
better patch (mainly test refactoring).
still against trunk.
should I provide one against py3k?
--
components: +IO
Added file: http://bugs.python.org/file15578/Issue7523_2.diff
___
Python tracker rep
Changes by lekma lekma...@gmail.com:
--
nosy: +lekma
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3605
___
___
Python-bugs-list mailing list
lekma lekma...@gmail.com added the comment:
Even though I don't fully agree with your comments here is a second
attempt addressing them, against trunk.
For the record, I think that the signature difference is enough to
warrant a name that is a clear cut from PyErr_NewException
lekma lekma...@gmail.com added the comment:
Same as previous against py3k
--
Added file: http://bugs.python.org/file15036/issue7033_py3k_2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7033
New submission from lekma lekma...@gmail.com:
It would be nice to have an obvious/simple way to document C exceptions
(especially when using the autoexception feature from Sphinx).
Something along:
PyObject *PyErr_Create(char *name, const char *doc)
Creates and returns a new exception
lekma lekma...@gmail.com added the comment:
First attempt at implementing this.
Diff is against trunk.
--
keywords: +patch
Added file: http://bugs.python.org/file15021/issue7033_trunk.diff
___
Python tracker rep...@bugs.python.org
http
lekma lekma...@gmail.com added the comment:
The same against py3k
--
Added file: http://bugs.python.org/file15022/issue7033_py3k.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7033
lekma lekma...@gmail.com added the comment:
thanks guys
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5585
___
___
Python-bugs-list mailing
lekma lekma...@gmail.com added the comment:
The same against py3k.
Jesse, is there any chance that this will make it in, or should I just
go and implement a local solution?
--
Added file: http://bugs.python.org/file13508/Issue5585_2_py3k.patch
lekma lekma...@gmail.com added the comment:
I'm thinking about it and plan on discussing it with other core devs
today. Altering the Api is not something done lightly
yep.
Thanks for considering it.
--
___
Python tracker rep...@bugs.python.org
lekma lekma...@gmail.com added the comment:
Right, it's just the Thread/Process API equivalance. I'm not saying
it's a stopper, but the docs would probably need to be modified
accordingly.
I'm a bit confused here. The patch only adds a small feature to
BaseManager and subtypes (the same way
lekma lekma...@gmail.com added the comment:
AFAIK there is no equivalent to the managers api in threading.
As for the tests, what kind of tests would you like to see? Jesse, some
thoughts on that?
--
___
Python tracker rep...@bugs.python.org
http
New submission from lekma lekma...@gmail.com:
It would be useful to have the ability to run arbitrary code before a
manager's server subprocess is started (I'd use this feature to install
signal handlers for example).
--
components: Library (Lib)
messages: 84302
nosy: lekma
severity
lekma lekma...@gmail.com added the comment:
here is a patch doing just that (against trunk).
ps: this is my first bug report and contribution to Python, please, be
gentle :)
--
keywords: +patch
Added file: http://bugs.python.org/file13438/Issue5585.patch
45 matches
Mail list logo
