Re: ssl module doesn't validate that domain of certificate is correct

2010-04-19 Thread exarkun
On 04:51 pm, na...@animats.com wrote: I'm converting some code from M2Crypto to the new ssl module, and I've found what looks like a security hole. The ssl module will validate the certificate chain, but it doesn't check that the certificate is valid for the domain. Here's the basic

Re: ssl module doesn't validate that domain of certificate is correct

2010-04-19 Thread John Nagle
exar...@twistedmatrix.com wrote: On 04:51 pm, na...@animats.com wrote: I'm converting some code from M2Crypto to the new ssl module, and I've found what looks like a security hole. The ssl module will validate the certificate chain, but it doesn't check that the certificate is valid for the

Re: ssl module doesn't validate that domain of certificate is correct

2010-04-19 Thread geremy condra
On Mon, Apr 19, 2010 at 1:49 PM, John Nagle na...@animats.com wrote: exar...@twistedmatrix.com wrote: On 04:51 pm, na...@animats.com wrote:   I'm converting some code from M2Crypto to the new ssl module, and I've found what looks like a security hole.  The ssl module will validate the

Re: ssl module doesn't validate that domain of certificate is correct

2010-04-19 Thread exarkun
On 05:49 pm, na...@animats.com wrote: exar...@twistedmatrix.com wrote: On 04:51 pm, na...@animats.com wrote: I'm converting some code from M2Crypto to the new ssl module, and I've found what looks like a security hole. The ssl module will validate the certificate chain, but it doesn't

Re: ssl module doesn't validate that domain of certificate is correct

2010-04-19 Thread John Nagle
exar...@twistedmatrix.com wrote: On 05:49 pm, na...@animats.com wrote: exar...@twistedmatrix.com wrote: On 04:51 pm, na...@animats.com wrote: I'm converting some code from M2Crypto to the new ssl module, and I've found what looks like a security hole. The ssl module will validate the