[issue10967] move regrtest over to using more unittest infrastructure

2013-03-04 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- nosy: +zach.ware ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10967 ___ ___ Python-bugs-list

[issue17351] Fixed python3 descriptor documentation example + removal of explicit object inheritance in docs

2013-03-04 Thread Phil Elson
New submission from Phil Elson: The example at http://docs.python.org/3.4/howto/descriptor.html#properties does not run due to the old style raise AttributeError, message form. This patch fixes the problem, and also goes through the docs to remove explicit sub-classing from object. The only

[issue8273] move generally useful test.support functions into the unittest package

2013-03-04 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- nosy: +zach.ware ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8273 ___ ___ Python-bugs-list

[issue17322] urllib.request add_header() currently allows trailing spaces (and other weird stuff)

2013-03-04 Thread karl
karl added the comment: R. David.: A crazy idea that occurred to me was to create an rfc822-style-header management module, and share it between email, http, and urllib. Yes it is basically what I had in mind when I said: Maybe the way forward in the future is to have a header factory

[issue17328] Fix reference leak in dict_setdefault() in case of resize failure

2013-03-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1a589001d752 by Benjamin Peterson in branch '3.3': fix possible setdefault refleak (closes #17328) http://hg.python.org/cpython/rev/1a589001d752 New changeset fac46cf6af3f by Benjamin Peterson in branch 'default': merge 3.3 (#17328)

[issue16575] ctypes: unions as arguments

2013-03-04 Thread Eli Bendersky
Eli Bendersky added the comment: A minimal fix would be to update the documentation. A more comprehensive fix would be to tweak ctypes to reject unions and bit-fields when running on non-x86 (does this work for ARM and other non-Intel archs?) An even more comprehensive fix would be to make

[issue16004] Add `make touch` to 2.7 Makefile

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: Nick, is the attached patch ok? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16004 ___ ___ Python-bugs-list

[issue17352] Be clear that __prepare__ must be declared as a static method

2013-03-04 Thread Nick Coghlan
New submission from Nick Coghlan: The docs on __prepare__ don't make it clear that it should be a staticmethod, and the error message if you forget is not obvious at all. (This is particularly so, since the examples in PEP 3115 had it as an ordinary method). -- messages: 183463 nosy:

[issue16575] ctypes: unions as arguments

2013-03-04 Thread Armin Rigo
Armin Rigo added the comment: See also http://bugs.python.org/issue16576. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16575 ___ ___

[issue17341] Poor error message when compiling invalid regex

2013-03-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: See also issue14462. It will be easier to include a full group name than an invalid character. -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17341

[issue17352] Be clear that __prepare__ must be declared as a class method

2013-03-04 Thread Nick Coghlan
Nick Coghlan added the comment: Class method, not static method (super() breaks if you declare it as a static method) -- title: Be clear that __prepare__ must be declared as a static method - Be clear that __prepare__ must be declared as a class method

[issue17322] urllib.request add_header() currently allows trailing spaces (and other weird stuff)

2013-03-04 Thread R. David Murray
R. David Murray added the comment: Aren't the folding rules are the same? The character set rules are different, I think, but the email package is going to be flexible in that regard. The email package also uses a data structure that is not a python dictionary (it is actually a list with an

[issue16997] subtests

2013-03-04 Thread Michael Foord
Michael Foord added the comment: That's a use case that I'm not very *interested* in supporting personally - however it may well be a use case that was designed in and that others have a need for (I didn't implement expectedFailure support). I think expectedFailure should be used sparingly

[issue16997] subtests

2013-03-04 Thread Nick Coghlan
Nick Coghlan added the comment: The docs are fairly explicit about the intended use case: Mark the test as an expected failure. If the test fails when run, the test is not counted as a failure. (from http://docs.python.org/3/library/unittest#unittest.expectedFailure) Nothing there about

[issue16997] subtests

2013-03-04 Thread Michael Foord
Michael Foord added the comment: So, if it's not documented behaviour I think it's fine to lose it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16997 ___

[issue12921] http.server.BaseHTTPRequestHandler.send_error and trailing newline

2013-03-04 Thread karl
karl added the comment: orsenthil, I made a proper patch for it with hg diff. It is very short. See issue-12921-2.patch -- Added file: http://bugs.python.org/file29306/issue-12921-2.patch ___ Python tracker rep...@bugs.python.org

[issue17343] Add a version of str.split which returns an iterator

2013-03-04 Thread Brett Cannon
Changes by Brett Cannon br...@python.org: -- nosy: +brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17343 ___ ___ Python-bugs-list

[issue17338] Add length_hint parameter to list, dict, set constructors to allow efficient presizing

2013-03-04 Thread Brett Cannon
Changes by Brett Cannon br...@python.org: -- nosy: +brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17338 ___ ___ Python-bugs-list

[issue12921] http.server.BaseHTTPRequestHandler.send_error and trailing newline

2013-03-04 Thread Senthil Kumaran
Senthil Kumaran added the comment: Karl, Ack. The patch looks good. I shall go about with testing + committing this.. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12921 ___

[issue17338] Add length_hint parameter to list, dict, set constructors to allow efficient presizing

2013-03-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This unlikely will be useful. C code uses __length_hint__ because C code is fast enough and fill time can be comparable to resize time. But Python code will be one or two order slower and resize time is insignificant fraction of total time for any real

[issue16997] subtests

2013-03-04 Thread Barry A. Warsaw
Changes by Barry A. Warsaw ba...@python.org: -- nosy: +barry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16997 ___ ___ Python-bugs-list mailing

[issue13477] tarfile module should have a command line

2013-03-04 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13477 ___ ___

[issue17339] bytes() TypeError message is misleadingly narrow

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: 'object' object cannot be converted to bytes This is not entirely accurate for the bytes(int) case though, since it's not converting the int to bytes. OTOH if we want to keep the message short we have to make compromises about accuracy and completeness.

[issue12921] http.server.BaseHTTPRequestHandler.send_error and trailing newline

2013-03-04 Thread karl
karl added the comment: orsenthil, When you have done a patch for testing I would love to see it. I could not find a proper way of doing it. I'm eager to learn. Thanks. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12921

[issue14123] Indicate that there are no current plans to deprecate printf-style formatting

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: The only issue seems about the use of the word deprecate, but I think it's fine, so I'll close this issue. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org

[issue16278] os.rename documentation slightly inaccurate

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: Adding more tests is good, even though there are still a few things that should be improved (see comments on rietveld). Regarding the documentation I'm not sure it's a good idea to be so detailed. On one hand, if we test the behavior we can make sure that the

[issue17301] An in-place version of many bytearray methods is needed

2013-03-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: How *just and *strip can modify an argument in-place? All other methods except title (lower, swapcase, upper) are partial cases of translate. I.e. you need only in-place translate. However I doubt that difference will be more than several percents. Actually

[issue17332] typo in json docs - convered should be converted

2013-03-04 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- keywords: +easy stage: - needs patch versions: -Python 2.6, Python 3.1, Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17332

[issue12768] docstrings for the threading module

2013-03-04 Thread moijes12
moijes12 added the comment: Hi I am seen the review comments and made the changes accordingly. I am not sure if my changes apply to 3.2. How do I do that ? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12768

[issue17344] checking size of size_t... configure: error:

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: The SPARC Solaris buildbot with cc compilers run configure without problems, whereas the ones with gcc are broken because of gcc (and they don't even reach the configure step that checks for size_t). If we cannot confirm that there is a problem on a currently

[issue16851] Hint about correct ismethod and isfunction usage

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: I checked the tests on 2.7 and found this: # contrary to spec, ismethod() is also True for unbound methods # (see #1785) self.assertIn(('f', B.f), inspect.getmembers(B, inspect.ismethod)) #1785 also has some discussion about this.

[issue15866] encode(..., 'xmlcharrefreplace') produces entities for surrogate pairs

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: I doubt about '\ud83d\udc9d' on wide build. Is it right to encode it as b'#128157;' and not as b'#55357;#56477;'? I don't think so. IIRC surrogates are invalid in UTF-32, and certainly shouldn't be recombined. This will be compatible with narrow build but

[issue11787] File handle leak in TarFile lib

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: Closing as duplicate then. -- resolution: - duplicate stage: test needed - committed/rejected status: open - closed superseder: - tarfile fails to close file handles in case of exception ___ Python tracker

[issue12768] docstrings for the threading module

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: 3.2$ hg imp --no-c http://bugs.python.org/file29268/12768_2.patch applying http://bugs.python.org/file29268/12768_2.patch patching file Lib/threading.py Hunk #3 FAILED at 58 Hunk #4 FAILED at 79 Hunk #5 FAILED at 92 Hunk #6 FAILED at 125 Hunk #10 FAILED at 252

[issue12768] docstrings for the threading module

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: FWIW it applies cleanly on 3.3, but unless we decide to target 3.3+ only, the patch needs to be adapted for 2.7/3.2. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12768

[issue17343] Add a version of str.split which returns an iterator

2013-03-04 Thread Santoso Wijaya
Changes by Santoso Wijaya santoso.wij...@gmail.com: -- nosy: +santa4nt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17343 ___ ___

[issue17330] Stop checking for directory cache invalidation in importlib

2013-03-04 Thread Barry A. Warsaw
Changes by Barry A. Warsaw ba...@python.org: -- nosy: +barry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17330 ___ ___ Python-bugs-list mailing

[issue17025] reduce multiprocessing.Queue contention

2013-03-04 Thread Charles-François Natali
Charles-François Natali added the comment: So, what do you think? Is the simple version offloading the serialization to queue enough, or should we go for a full-blown atomic Connection/Pipe/etc? I find the performance gain quite appreciable (basically queue didn't scale at all, now it scales

[issue17025] reduce multiprocessing.Queue contention

2013-03-04 Thread Antoine Pitrou
Antoine Pitrou added the comment: IMHO the simple version is good enough. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17025 ___ ___

[issue17278] SIGSEGV in _heapqmodule.c

2013-03-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset 21ded74b51fa by Antoine Pitrou in branch '2.7': Issue #17278: Fix a crash in heapq.heappush() and heapq.heappop() when the list is being resized concurrently. http://hg.python.org/cpython/rev/21ded74b51fa -- nosy: +python-dev

[issue14266] pyunit script as shorthand for python -m unittest

2013-03-04 Thread Barry A. Warsaw
Changes by Barry A. Warsaw ba...@python.org: -- nosy: +barry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14266 ___ ___ Python-bugs-list mailing

[issue14266] pyunit script as shorthand for python -m unittest

2013-03-04 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: As I mentioned on python-dev, having a `pyunit` script is nice (whatever it's called), but we need to keep the `-m invocation` which will probably be the recommendation on distros such as Debian which provide multiple versions of Python. We're not going to

[issue17278] SIGSEGV in _heapqmodule.c

2013-03-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset 905b02749c26 by Antoine Pitrou in branch '3.2': Issue #17278: Fix a crash in heapq.heappush() and heapq.heappop() when the list is being resized concurrently. http://hg.python.org/cpython/rev/905b02749c26 New changeset 451299b97b4f by Antoine

[issue14266] pyunit script as shorthand for python -m unittest

2013-03-04 Thread Antoine Pitrou
Antoine Pitrou added the comment: We're not going to want to install all possible flavors of `pyunit2.6`, `pyunit2.7`, `punit2.6-dbg`, `pyunit-3.2-dbg`, etc. etc. Why not? -- ___ Python tracker rep...@bugs.python.org

[issue17278] SIGSEGV in _heapqmodule.c

2013-03-04 Thread Antoine Pitrou
Antoine Pitrou added the comment: Ok, committed, thank you! -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17278

[issue17025] reduce multiprocessing.Queue contention

2013-03-04 Thread Richard Oudkerk
Richard Oudkerk added the comment: It looks like queues_contention.diff has the line obj = pickle.dumps(obj) in both _feed() and put(). Might that be why the third set of benchmarks was slower than the second? -- ___ Python tracker

[issue14266] pyunit script as shorthand for python -m unittest

2013-03-04 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Mar 04, 2013, at 07:45 PM, Antoine Pitrou wrote: Antoine Pitrou added the comment: We're not going to want to install all possible flavors of `pyunit2.6`, `pyunit2.7`, `punit2.6-dbg`, `pyunit-3.2-dbg`, etc. etc. Why not? We don't know at package build

[issue17025] reduce multiprocessing.Queue contention

2013-03-04 Thread Charles-François Natali
Charles-François Natali added the comment: It looks like queues_contention.diff has the line obj = pickle.dumps(obj) in both _feed() and put(). Might that be why the third set of benchmarks was slower than the second? _feed() is a Queue method, put() its SimpleQueue() counterpart. Am

[issue17353] Plistlib outputs empty data tags when deeply nested

2013-03-04 Thread Jacques Fortier
New submission from Jacques Fortier: To reproduce: import plistlib print plistlib.writePlistToString([{'test': plistlib.Data('aa')}]) Compare to: print plistlib.writePlistToString({'test': Data('aa')}) It looks like the max line length calculation in

[issue17353] Plistlib outputs empty data tags when deeply nested

2013-03-04 Thread Jacques Fortier
Jacques Fortier added the comment: My second print should have been: print plistlib.writePlistToString({'test': plistlib.Data('aa')}) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17353

[issue14266] pyunit script as shorthand for python -m unittest

2013-03-04 Thread Tshepang Lekhonkhobe
Changes by Tshepang Lekhonkhobe tshep...@gmail.com: -- nosy: +tshepang ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14266 ___ ___

[issue17343] Add a version of str.split which returns an iterator

2013-03-04 Thread Gregory P. Smith
Gregory P. Smith added the comment: Indeed, a bytearray version would require the talked about but not implemented due to complexity (in pep3118) support for locking a buffer from other mutations. best concentrate on bytes then. Do we have a memoryview equivalent for PyUnicode? If not, we

[issue17066] Fix test discovery for test_robotparser.py

2013-03-04 Thread Zachary Ware
Zachary Ware added the comment: I got to looking over my patch here again, and thought of another possible fix. I'm not sure which is uglier, though :) The problem is that most of the test cases are created using a custom subclass of unittest.TestCase which takes extra constructor arguments.

[issue17066] Fix test discovery for test_robotparser.py

2013-03-04 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: Added file: http://bugs.python.org/file29308/test_robotparser_discovery.v3.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17066 ___

[issue17025] reduce multiprocessing.Queue contention

2013-03-04 Thread Richard Oudkerk
Richard Oudkerk added the comment: On 04/03/2013 8:01pm, Charles-François Natali wrote: It looks like queues_contention.diff has the line obj = pickle.dumps(obj) in both _feed() and put(). Might that be why the third set of benchmarks was slower than the second? _feed() is a Queue

[issue17343] Add a version of str.split which returns an iterator

2013-03-04 Thread Brett Cannon
Brett Cannon added the comment: There is no string view that I know of. Interesting idea, though, thanks to the immutability of strings. Would much have to be different other than boundary checking and __hash__ (and hoping extension authors are changing things in-place)? I say go ahead and

[issue17301] An in-place version of many bytearray methods is needed

2013-03-04 Thread Terry J. Reedy
Terry J. Reedy added the comment: Gregory, if an in-place version of .translate is all you want, only ask for that. Change the title and let us focus on the best case. Forget what others *might* want. Serhiy, what is 'tacts per byte'? -- ___

[issue11732] Skip decorator for tests requiring manual intervention on Windows

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: Attached an updated patch: - renamed the context manager from no_crash_popups to suppress_crash_popup, as suggested by Brian (I also made it singular, because there shouldn't be more than one crash/popup per call); - used the context manager on all the crashing

[issue16848] Mac OS X: python-config --ldflags and location of Python.framework

2013-03-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset bab708624dc4 by Ned Deily in branch '2.7': Issue #16848: python-config now returns proper --ldflags values for OS X http://hg.python.org/cpython/rev/bab708624dc4 -- nosy: +python-dev ___ Python tracker

[issue17301] An in-place version of many bytearray methods is needed

2013-03-04 Thread Ezio Melotti
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17301 ___ ___

[issue16848] Mac OS X: python-config --ldflags and location of Python.framework

2013-03-04 Thread Ned Deily
Ned Deily added the comment: Other than the tabs, the patch LGTM. I originally noticed the problem when addressing Issue14197, a Python 3 only issue, and fixed it there. But I did not go back and check that the python-config part was also an issue for 2.7. Now committed for release in

[issue16848] Mac OS X: python-config --ldflags and location of Python.framework

2013-03-04 Thread Ned Deily
Changes by Ned Deily n...@acm.org: -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16848 ___ ___ Python-bugs-list mailing

[issue3290] python-config --cflags includes irrelevant flags

2013-03-04 Thread Matthias Braun
Matthias Braun added the comment: I hacked up a proof-of-concept patch which filters out the most annoying flags (warnings, -Ox and -DNDEBUG flags). (Though IMO the only really robust solution would be not having code but just declarations in the public headers, so --includes is enough. In my

[issue13477] tarfile module should have a command line

2013-03-04 Thread Berker Peksag
Berker Peksag added the comment: Patch looks good! Some minor comments on Rietveld. Thanks for the review, Éric. Could you add tests? Done. Here's the new patch with Éric's comments addressed. -- Added file: http://bugs.python.org/file29311/issue13477_v2.diff

[issue16278] os.rename documentation slightly inaccurate

2013-03-04 Thread Todd Rovito
Todd Rovito added the comment: Ezio, Thank you or the feedback I will continue to polish the test cases. As far as the documentation I really like the table and find it easy to read but I could go either way. If you read the history of this issue other Python Core Developers asked to

[issue17353] Plistlib outputs empty data tags when deeply nested

2013-03-04 Thread Jacques Fortier
Jacques Fortier added the comment: Quick source inspection suggests this is present in the latest version. -- versions: +Python 3.4, Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17353

[issue17344] checking size of size_t... configure: error:

2013-03-04 Thread Trent Nelson
Trent Nelson added the comment: Shilpi, can you paste the exact ./configure invocation you're using? -- status: pending - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17344 ___

[issue16098] Bisect optimization in heapq.nsmallest is never used

2013-03-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset de6627cf81f4 by Raymond Hettinger in branch '3.3': Issue #16098: Update heapq.nsmallest to use the same algorithm as nlargest. http://hg.python.org/cpython/rev/de6627cf81f4 -- ___ Python tracker

[issue17128] OS X system openssl deprecated - installer should build local libssl

2013-03-04 Thread Senthil Kumaran
Senthil Kumaran added the comment: Ronald: Sorry for the delay in response. I was referring to this: https://github.com/capistrano/capistrano/issues/250#issuecomment-8055991 Mountain Lion no longer includes OpenSSL as it uses a different SSL implementation. So, you need to have RVM install

[issue16098] Bisect optimization in heapq.nsmallest is never used

2013-03-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset aa9ed98a49cb by Raymond Hettinger in branch '2.7': Issue #16098: Update heapq.nsmallest to use the same algorithm as nlargest. http://hg.python.org/cpython/rev/aa9ed98a49cb -- ___ Python tracker

<    1   2