[issue21321] itertools.islice() doesn't release reference to the source iterator when the slice is exhausted

2014-04-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: Ok, then I've committed to 2.7 too. Thank you very much for contributing! -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21321 ___

[issue21386] ipaddress.IPv4Address.is_global not implemented

2014-04-29 Thread Roger Luethi
New submission from Roger Luethi: Lib/ipaddress.py does not implement is_global for IPv4Address, in contrast to the documentation which states for IPv4Address.is_global: True if the address is allocated for public networks. A patch like the one attached to this report should fix that.

[issue21387] Memory leaks when embedded interpreter is reinitialized

2014-04-29 Thread Evgeniy Stepanov
New submission from Evgeniy Stepanov: Following https://docs.python.org/2/c-api/init.html#Py_Finalize, I'm reinitializing embedded python interpreter multiple time in one process. #include Python.h void f() { Py_Initialize(); PyRun_SimpleString(from time import time,ctime\n import

[issue1820] Enhance Object/structseq.c to match namedtuple and tuple api

2014-04-29 Thread Stefan Krah
Stefan Krah added the comment: Okay, if no one else wants this, I'll go ahead with the _fields part. Andrew, could you sign a contributor agreement? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1820

[issue20230] structseq types should expose _fields

2014-04-29 Thread Stefan Krah
Changes by Stefan Krah stefan-use...@bytereef.org: -- resolution: - duplicate stage: - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20230 ___

[issue20230] structseq types should expose _fields

2014-04-29 Thread Stefan Krah
Changes by Stefan Krah stefan-use...@bytereef.org: -- superseder: - Enhance Object/structseq.c to match namedtuple and tuple api ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20230

[issue19001] test_gdb fails on Fedora buildbot

2014-04-29 Thread Stefan Krah
Stefan Krah added the comment: Since Fedora 16 is EOL, let's close this. -- resolution: - out of date stage: needs patch - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19001

[issue21386] ipaddress.IPv4Address.is_global not implemented

2014-04-29 Thread Eric V. Smith
Changes by Eric V. Smith e...@trueblade.com: -- nosy: +eric.smith, ncoghlan, pmoody ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21386 ___ ___

[issue21138] mimetypes.MimeType UnicodeDecodeError

2014-04-29 Thread Tim Golden
Tim Golden added the comment: Fixed by issue9291 -- resolution: - duplicate stage: - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21138 ___

[issue1284316] Win32: Security problem with default installation directory

2014-04-29 Thread Jason R. Coombs
Jason R. Coombs added the comment: I still disagree. If the preferable place for Python to be installed is not in the root (and I fervently feel so), then there could be a transitional approach to move it to the appropriate place, such as creating symbolic links from the legacy destinations

[issue21124] _struct module compilation error under Cygwin 1.7.17 on Python 3.4

2014-04-29 Thread dellair jie
dellair jie added the comment: Hello masamoto, The patch you provided works quite well. The build passed and Python calls are successfully. Please let me know what else you need me to test in order to have the patch accepted or else feel free to close it with Resolution Fixed. Thanks, Dellair

[issue21085] compile error Python3.3 on Cygwin

2014-04-29 Thread dellair jie
dellair jie added the comment: Finally got it compiled on Cygwin! :) Victor, I am still having issue with the make test on Cygwin, hence can only do some manual testing: Output: info = signal.sigwaitinfo({signal.SIGINT}) ^C info = signal.struct_siginfo((2, 128, 0, 0, 0, 3)) Traceback

[issue21388] decimal.InvalidContext is unused

2014-04-29 Thread Stefan Krah
New submission from Stefan Krah: We could remove decimal.InvalidContext, which is completely unused both in decimal.py and _decimal. -- messages: 217519 nosy: mark.dickinson, rhettinger, skrah priority: normal severity: normal status: open title: decimal.InvalidContext is unused type:

[issue17386] Bring Doc/make.bat as close to Doc/Makefile as possible

2014-04-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset c75a2282166f by Zachary Ware in branch '3.4': Issue #17386: List the 'htmlview' target in the Doc/Makefile help output. http://hg.python.org/cpython/rev/c75a2282166f New changeset c378c67c4170 by Zachary Ware in branch '3.4': Issue #17386: Update

[issue19630] marshal.dump cannot write to temporary file

2014-04-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0f6bdc2b0e38 by Tim Golden in branch '2.7': Issue #19630 Emphasise that the file parameter to marshal.dump must be a real file object http://hg.python.org/cpython/rev/0f6bdc2b0e38 -- nosy: +python-dev

[issue19630] marshal.dump cannot write to temporary file

2014-04-29 Thread Tim Golden
Tim Golden added the comment: I updated the docs to emphasise that the file parameter to marshal.dump must be a real file, not a wrapper. -- assignee: - tim.golden status: open - closed ___ Python tracker rep...@bugs.python.org

[issue21040] socketserver: use selectors module

2014-04-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: Shouldn't this issue be closed? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21040 ___ ___ Python-bugs-list

[issue21314] Document '/' in signatures

2014-04-29 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- keywords: +easy stage: - needs patch status: - open type: - enhancement versions: +Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21314

[issue12916] Add inspect.splitdoc

2014-04-29 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: Hi all, Here is a new version of the patch, please, keep me informed and I think I have to modify some parts, but give me your feedback. Thanks -- Added file: http://bugs.python.org/file35093/issue12916-2.patch

[issue21388] decimal.InvalidContext is unused

2014-04-29 Thread Mark Dickinson
Mark Dickinson added the comment: It's part of the specification, though. For me, that's a good enough reason to keep it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21388 ___

[issue21040] socketserver: use selectors module

2014-04-29 Thread Charles-François Natali
Changes by Charles-François Natali cf.nat...@gmail.com: -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21040 ___ ___

[issue21316] mark test_devpoll to be meaningful only for Solaris

2014-04-29 Thread Jesús Cea Avión
Changes by Jesús Cea Avión j...@jcea.es: -- assignee: - jcea nosy: +jcea title: mark test_devpoll to be meaningfull only for Solaris - mark test_devpoll to be meaningful only for Solaris versions: +Python 3.5 ___ Python tracker

[issue21316] mark test_devpoll to be meaningful only for Solaris

2014-04-29 Thread Jesús Cea Avión
Jesús Cea Avión added the comment: Thanks for the head-up!!. Can you compile new version and try it out?. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21316 ___

[issue21316] mark test_devpoll to be meaningful only for Solaris

2014-04-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset cc2345e6e9ff by Jesus Cea in branch '3.4': Closes issue #21316: mark test_devpoll to be meaningfull only for Solaris http://hg.python.org/cpython/rev/cc2345e6e9ff New changeset 825c67196aac by Jesus Cea in branch 'default': MERGE: Closes issue

[issue21316] mark test_devpoll to be meaningful only for Solaris

2014-04-29 Thread Jesús Cea Avión
Changes by Jesús Cea Avión j...@jcea.es: -- resolution: - fixed stage: - resolved status: open - closed type: enhancement - ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21316 ___

[issue21374] DecimalTuple.__module__ is set to _frozen_importlib

2014-04-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset bf64a5f7c1af by Stefan Krah in branch 'default': Issue #21374: Fix pickling of DecimalTuple. http://hg.python.org/cpython/rev/bf64a5f7c1af New changeset 25919f35241e by Stefan Krah in branch '3.4': Issue #21374: Fix pickling of DecimalTuple.

[issue21374] DecimalTuple.__module__ is set to _frozen_importlib

2014-04-29 Thread Stefan Krah
Changes by Stefan Krah stefan-use...@bytereef.org: -- resolution: - fixed stage: needs patch - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21374 ___

[issue21378] ImportError: No module named 'concurrent.futures'

2014-04-29 Thread Bill Bergmann
Bill Bergmann added the comment: Thank you for your response. The program works as expected. I removed PYTHONPATH settings for 3.4 and 2.7. I'm not sure how those settings were written. I suspect something related to virtualenv, and I will be watching to see if they are written again. When I

[issue21382] Signal module doesnt raises ValueError Exception

2014-04-29 Thread Florent Xicluna
Changes by Florent Xicluna florent.xicl...@gmail.com: -- components: +Library (Lib), Windows nosy: +flox type: enhancement - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21382 ___

[issue21381] Python 3.4+ interpreter built on/with OS X 10.7 deployment target segfaults on 10.8+

2014-04-29 Thread Christian Tismer
Christian Tismer added the comment: Ned, thank you for locating the patch that causes the problem. At least, I could now make my script work, built a patch feature into it. cheers - Chris -- ___ Python tracker rep...@bugs.python.org

[issue21382] Signal module doesnt raises ValueError Exception

2014-04-29 Thread Florent Xicluna
Florent Xicluna added the comment: It's about documentation only. The sentence is not wrong, but it is slightly confusing, and there's no hint which signals are defined on Windows. On Windows, signal() can only be called with SIGABRT, SIGFPE, SIGILL, SIGINT, SIGSEGV, or SIGTERM. A ValueError

[issue9291] mimetypes initialization fails on Windows because of non-Latin characters in registry

2014-04-29 Thread Tim Golden
Changes by Tim Golden m...@timgolden.me.uk: -- assignee: - tim.golden resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9291

[issue21362] concurrent.futures does not validate that max_workers is proper

2014-04-29 Thread Brian Quinlan
Brian Quinlan added the comment: The patch looks good to me too. I'll commit it soon. -- assignee: - bquinlan ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21362 ___

[issue6839] zipfile can't extract file

2014-04-29 Thread Adam Polkosnik
Adam Polkosnik added the comment: Gentlemen, Is there's any way this fix can be included in any version? Currently, the fact that the exception is thrown makes extracting some zip files impossible with this library, and rolling your own is a bit painful. (either using a wrapper around 7zip to

[issue17611] Move unwinding of stack for pseudo exceptions from interpreter to compiler.

2014-04-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: Here is an updated patch keeping up with recent changes in the source tree. -- Added file: http://bugs.python.org/file35094/unwinding.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17611

[issue21387] Memory leaks when embedded interpreter is reinitialized

2014-04-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thanks. It would be nice if you could try the same with Python 3.4, or the development version. -- nosy: +pitrou, skrah ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21387

[issue21353] document Popen.args attribute

2014-04-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0a4b211b927e by Gregory P. Smith in branch '3.3': Document the subprocess Popen.args attribute (issue21353) http://hg.python.org/cpython/rev/0a4b211b927e New changeset 182b869283a5 by Gregory P. Smith in branch '3.4': Document the subprocess

[issue21353] document Popen.args attribute

2014-04-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: yes. this was overlooked. thanks! -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21353

[issue18314] Have os.unlink remove junction points

2014-04-29 Thread Kim Gräsman
Kim Gräsman added the comment: Here's a new attempt, please let me know if this works out better. Changes: - Switched to CRT string functions (wcsncmp, wcscpy) instead of Windows lstrxxxW. There was no lstrncmpW. - Switched to PyMem_Raw(Malloc|Free) and added explicit memset after allocation -

[issue21388] decimal.InvalidContext is unused

2014-04-29 Thread Stefan Krah
Stefan Krah added the comment: Okay, also it is easier to keep it. I was just busy with the exception docs and found the InvalidContext situation slightly odd. Of course, there is a very small chance that external software is using it. -- resolution: - not a bug stage: - resolved

[issue21387] Memory leaks when embedded interpreter is reinitialized

2014-04-29 Thread Stefan Krah
Stefan Krah added the comment: Are we fixing these on a case by case basis or is it hopeless (msg146615)? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21387 ___

[issue21387] Memory leaks when embedded interpreter is reinitialized

2014-04-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: I think fixing on a case by case is fine. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21387 ___ ___

[issue2159] dbmmodule inquiry function is performance prohibitive

2014-04-29 Thread Jesús Cea Avión
Jesús Cea Avión added the comment: Eric, would you mind to clarify the points I raised in the last message?. Lets move this forward. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2159

[issue21037] add an AddressSanitizer build option

2014-04-29 Thread Charles-François Natali
Charles-François Natali added the comment: That said, it would be better if you first check said options work locally. I wasn't clear, but I did test it, and it works: the only problem I encountered is address space exhaustion: I have a 32-bit box, and ASAN uses a lot of virtual address space

[issue21037] add an AddressSanitizer build option

2014-04-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: I guess we could go for any non-stable buildbot meeting the following criteria: - Linux 64-bit - clang = 3.1 or gcc = 4.8 Hmm... perhaps Stefan would like to set something up? -- nosy: +skrah ___ Python

[issue21037] add an AddressSanitizer build option

2014-04-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: How do we spot any ASAN issues, though? Does ASAN change the process' return code on errors? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21037 ___

[issue6839] zipfile can't extract file

2014-04-29 Thread Terry J. Reedy
Terry J. Reedy added the comment: Adam P, please don't screw around with the version headers. If you want to claim that this is a security issue of the type we care about (threats to the public internet) for patching old releases, and severe enough that we should do anything about it, send a

[issue21037] add an AddressSanitizer build option

2014-04-29 Thread Charles-François Natali
Charles-François Natali added the comment: How do we spot any ASAN issues, though? Does ASAN change the process' return code on errors? It aborts: $ cat /tmp/test.c int main(int argc, char *argv[]) { int bar[16] = {0}; /* oops */ return bar[16]; } $ gcc -Wall -fsanitize=address

[issue18104] Idle: make human-mediated GUI tests usable

2014-04-29 Thread Terry J. Reedy
Terry J. Reedy added the comment: The new patch adds a docstring with spec template, a second example, and a crude runall(). I am inclined to push this as a base for further patches -- at least one to improve runall and others to test more widget classes. These might be separate issues.

[issue21233] Add *Calloc functions to CPython memory allocation API

2014-04-29 Thread STINNER Victor
STINNER Victor added the comment: Patch version 6: - I renamed int zero parameter to int use_calloc and move the new parameter at the first position to avoid confusion with nelem. For example, _PyObject_Alloc(ctx, 1, nbytes, 0) becomes _PyObject_Alloc(0, ctx, 1, nbytes). It also more logical

[issue21379] StopIteration is silenced when raised by generator within context manager

2014-04-29 Thread Hannan Aharonov
Hannan Aharonov added the comment: OK. Thanks. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21379 ___ ___ Python-bugs-list mailing list

[issue6839] zipfile can't extract file

2014-04-29 Thread Adam Polkosnik
Adam Polkosnik added the comment: For the version headers, I've added the versions featuring the broken behavior. That's all. I'm not saying that this is I'm extracting malware from the Central Quarantine files, and the vendor's implementation is broken and is causing this issue for me on

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

2014-04-29 Thread William Tisäter
William Tisäter added the comment: Found this a simple fix for an annoying and time consuming error. Patched as discussed earlier and decided to leave the filename out. -- components: +Windows -Library (Lib) keywords: +patch nosy: +tiwilliam versions: +Python 3.5 Added file:

[issue6839] zipfile can't extract file

2014-04-29 Thread Adam Polkosnik
Adam Polkosnik added the comment: Also, this behavior is present on all platforms and all versions of Python (zipfile Library), so maybe the headers should be adjusted there too. I'm not saying that this is necessarily a big freaking hole, but by using this, one can prevent files from being

[issue21233] Add *Calloc functions to CPython memory allocation API

2014-04-29 Thread Charles-François Natali
Charles-François Natali added the comment: LGTM! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21233 ___ ___ Python-bugs-list mailing list

[issue21375] Fix and test overflow behavior in the C version of heapq

2014-04-29 Thread Tim Peters
Tim Peters added the comment: I don't see a way to test it either, but it's easy enough to prove it's correct ;-) That is, looks good to me! -- nosy: +tim.peters ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21375

[issue6839] zipfile can't extract file

2014-04-29 Thread Adam Polkosnik
Adam Polkosnik added the comment: If I got a file scanner in my mail gateway implemented with this, one can easily avoid getting the contents of zip-files scanned. Is that enough of a security impact? -- ___ Python tracker rep...@bugs.python.org

[issue2159] dbmmodule inquiry function is performance prohibitive

2014-04-29 Thread Eric Olson
Eric Olson added the comment: Thank you for the feedback. Sorry I didn't see your previous response until today. I will take a look and respond tonight. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2159

[issue6839] zipfile can't extract file

2014-04-29 Thread Adam Polkosnik
Adam Polkosnik added the comment: I've also tested with WinZip, and Windows Explorer, on windows. Both extract the contents of test.zip without a warning (just like 7zip on Windows did). This behavior counts as Denial Of Service if the zipfile Library is used to extract files, besides lots of

[issue21281] DEBUGGING: Simultaneous stopping of all threads on breakpoint and switching between threads

2014-04-29 Thread Jesús Cea Avión
Changes by Jesús Cea Avión j...@jcea.es: -- versions: -Python 2.7, Python 3.1, Python 3.2, Python 3.3, Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21281 ___

[issue19214] shutil.make_archive should recognize extensions in filenames

2014-04-29 Thread William Tisäter
William Tisäter added the comment: I'm not sure if this is a suitable feature in `make_archive()`, it would only introduce a more expensive and ugly lookup. Using this method with a pre-defined filename including extension must be rare. If you really want this behaviour, I would prefer having

[issue18104] Idle: make human-mediated GUI tests usable

2014-04-29 Thread Terry J. Reedy
Terry J. Reedy added the comment: New patch. I refined the definition of the parameter for run() in the process of adding a test for EditorWindow.HelpDialog. This cannot be tested directly. This example is also a reminder that some files define more than one display widget. I should try

[issue6839] zipfile can't extract file

2014-04-29 Thread Terry J. Reedy
Terry J. Reedy added the comment: Adam P. I politely asked you to leave the headers alone. Since you ignored that, LEAVE THE HEADERS ALONE! If you continue, you will eventually get banned. An issue gets dealt with when a volunteer core developer makes it his top priority. In the past 24

[issue21234] __contains__ and friends should check is for all elements first

2014-04-29 Thread Jesús Cea Avión
Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21234 ___ ___ Python-bugs-list mailing list

[issue21124] _struct module compilation error under Cygwin 1.7.17 on Python 3.4

2014-04-29 Thread Masayuki Yamamoto
Masayuki Yamamoto added the comment: I have solved about compiling _struct module too. I have no authority of this issues, So please close of issues. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21124

[issue21124] _struct module compilation error under Cygwin 1.7.17 on Python 3.4

2014-04-29 Thread Masayuki Yamamoto
Changes by Masayuki Yamamoto light2happy@gmail.com: -- nosy: -masamoto ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21124 ___ ___

[issue19217] Calling assertEquals for moderately long list takes too long

2014-04-29 Thread Ezio Melotti
Ezio Melotti added the comment: I don't think I will have time for this for a while, so if anyone wants to provide tests they are welcomed to do it. The related #11763 already has some tests, so those might be adapted for this issue. -- keywords: +easy stage: patch review - test

[issue21320] dict() allows keyword expansion with integer keys, e.g. dict(**{5:'v'})

2014-04-29 Thread R. David Murray
R. David Murray added the comment: I'm not going to reopen it, but my point was that if we really are going to add additional -3 warnings to help people port 2.7, as discussed at the language summit, then this would be a candidate. -- ___ Python

[issue21377] PyBytes_Concat could try to concat in-place

2014-04-29 Thread Nikolaus Rath
Changes by Nikolaus Rath nikol...@rath.org: Added file: http://bugs.python.org/file35100/issue_21377_r3.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21377 ___

[issue18154] make install failed on solaris

2014-04-29 Thread Jesús Cea Avión
Jesús Cea Avión added the comment: Palm, I am trying ln -sf on Solaris 10 and it works ok. What error are you getting? -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18154 ___

[issue21389] The repr of BoundMethod objects sometimes incorrectly identifies the bound function

2014-04-29 Thread Steven Barker
New submission from Steven Barker: The repr of bound method objects can be misleading in certain situations. The repr is always is of the format: bound method x.y of object But x is often incorrect. Here are some examples where the current code gets it wrong: # inherited method

[issue20951] SSLSocket.send() returns 0 for non-blocking socket

2014-04-29 Thread Nikolaus Rath
Nikolaus Rath added the comment: Antoine, are you sure this was a problem related to this patch? The test seems to work just fine for me: $ hg update -C -r b0f6983d63df $ make clean $ ./configure --with-pydebug make -j1 $ ./python -m test -u network,urlfetch -j 8 test_poplib [1/1] test_poplib

[issue2159] dbmmodule inquiry function is performance prohibitive

2014-04-29 Thread Eric Olson
Eric Olson added the comment: Hi Jesús, I believe the patch should have this behavior: a) If the database is closed, raise an exception. b) If database is empty, return False. c) If database has any entry, return True. Fast and simply checking if the database has at least a single

[issue6839] zipfile can't extract file

2014-04-29 Thread Ethan Furman
Changes by Ethan Furman et...@stoneleaf.us: -- nosy: +ethan.furman ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6839 ___ ___ Python-bugs-list

[issue6839] zipfile can't extract file

2014-04-29 Thread Adam Polkosnik
Adam Polkosnik added the comment: Terry, I apologize about the second change of headers, somehow I must have used the submission form to post the comment from a tab that had the old content, and the headers didn't refresh there. I assure you that it was not my intention to change them again.

[issue6839] zipfile can't extract file

2014-04-29 Thread Adam Polkosnik
Adam Polkosnik added the comment: In any event, I think that zipfile_stupid3.patch would be the best trivial fix to this issue. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6839 ___

[issue6839] zipfile can't extract file

2014-04-29 Thread Nick Coghlan
Nick Coghlan added the comment: The check can be simplified further to if self.debug and fname != zinfo.orig_filename:, but the conversion to a debugging print seems reasonable to me. -- nosy: +ncoghlan ___ Python tracker rep...@bugs.python.org

[issue6839] zipfile can't extract file

2014-04-29 Thread Adam Polkosnik
Adam Polkosnik added the comment: Patch against 2.7.6 attached. -- Added file: http://bugs.python.org/file35101/zipfile_276_filename_mismatch.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6839

[issue6839] zipfile can't extract file

2014-04-29 Thread Terry J. Reedy
Terry J. Reedy added the comment: Nick, do you agree that this should be treated as a bug (apply to all 3 versions)? Should debug messages be 'print'ed, sent to stderr, or go through the warnings module? -- ___ Python tracker rep...@bugs.python.org

[issue6839] zipfile can't extract file

2014-04-29 Thread Adam Polkosnik
Adam Polkosnik added the comment: Patch against zipfile 3.4.0 attached. -- Added file: http://bugs.python.org/file35102/zipfile_340_filename_mismatch.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6839

[issue6839] zipfile can't extract file

2014-04-29 Thread Adam Polkosnik
Changes by Adam Polkosnik apolkos...@gmail.com: Removed file: http://bugs.python.org/file35102/zipfile_340_filename_mismatch.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6839 ___

[issue6839] zipfile can't extract file

2014-04-29 Thread Adam Polkosnik
Changes by Adam Polkosnik apolkos...@gmail.com: Removed file: http://bugs.python.org/file35101/zipfile_276_filename_mismatch.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6839 ___

[issue6839] zipfile can't extract file

2014-04-29 Thread Adam Polkosnik
Adam Polkosnik added the comment: update -- Added file: http://bugs.python.org/file35103/zipfile_340_filename_mismatch.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6839 ___

[issue6839] zipfile can't extract file

2014-04-29 Thread Adam Polkosnik
Adam Polkosnik added the comment: Once again patch against 2.7.6 -- Added file: http://bugs.python.org/file35104/zipfile_276_filename_mismatch.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6839

<    1   2