Steve Dower added the comment:
New changeset 32d14b262d6d914f63485f8d6e7859df58cd2089 by Miss Islington (bot)
in branch '3.9':
bpo-45220: Ensure RT_MANIFEST is defined when compiling Windows resource files
(GH-29501)
https://github.com/python/cpython/commit
Steve Dower added the comment:
You're right. You probably need to uninstall and reinstall for the
subdirectories of WindowsApps.
--
___
Python tracker
<https://bugs.python.org/issue45
Steve Dower added the comment:
> Could it be possible that it might not be able to replace that link when it
> is currently in use?
That (or something like that) would be my suspicion. It's happened
before, though as Eryk Sun says the link itself does not remain in use
very long at a
Steve Dower added the comment:
I'm expecting another dumb error (on my part) or two in the PR, but I'm very
close to having this working.
Reviews would be appreciated! Bear in mind that I'm trying to match the current
(quirky) behaviour, rather than streamline anything by changing it (yet
Steve Dower added the comment:
Can you look in your %LocalAppData%\Microsoft\WindowsApps folder and see
if the python*.exe files are there? You should be able to double-click
them to launch them.
That folder should be on your PATH so that they work everywhere, and it
should reflect what
Steve Dower added the comment:
If you open "Manage app execution aliases", do you see the entries for Python?
I've heard that they sometimes switch themselves off during updates, but nobody
seems to know why. Even if not, disabling and re-enabling them may help.
The executable
Steve Dower added the comment:
Marking this as fixed, because the fix is already checked in. Release
scheduling is a separate conversation, so keep an eye out for the next release.
--
resolution: -> fixed
stage: -> resolved
status: open -&g
Steve Dower added the comment:
Oh I think I know what happened. Because RT_MANIFEST wasn't defined, it was
added as a resource tagged with that as a string. So the manifest is still
embedded, just not under the right type constant, so it has no effect.
Yeah, I think we should do a fresh
Steve Canny added the comment:
The resolution for me (the python-pptx and python-docx libraries) is clear, to
add a
separate `import collections.abc` statement rather than assuming (hoping) that
the
`collections.abc` module is available on an `abc` attribute of the
`collections` module.
I
Steve Dower added the comment:
> I just installed it and can confirm that there's no embedded manifest in
> "C:\Program
> Files\WindowApps\PythonSoftwareFoundation.Python.3.9<...>\python.exe".
Strange, because when I inspect the files that I published, it's there.
Steve Dower added the comment:
> Did my accidental breakage of the resource files make it into the last 3.9
> release?
Turns out, no, it didn't. So this is something else.
When I get to work later today I'll take a look.
--
___
Python t
Steve Dower added the comment:
Oh, no, wait. Did my accidental breakage of the resource files make it into the
last 3.9 release? If so, we probably lost the manifest option to opt-in to
supporting long paths, and perhaps Windows 11 has decided to start honouring
that (Windows 10 ignored
Steve Dower added the comment:
I wonder if the Windows 11 upgrade process disables this registry key when it's
set directly?
That's not something we can fix (I don't think?), so we may just have to list
it as an option.
If you can, check whether running a Repair of your Python install
Steve Dower added the comment:
Since collections.abc is a module, it should work if you import it:
>>> import collections.abc
>>> collections.abc.Container
Submodules being implicitly imported is not part of any API guarantee, which
will be why somebody changed it w
New submission from Steve Canny :
On CPython 3.10.0 on Windows but not MacOS, AttributeError is raised when
referencing `abc` on collections (instead of importing `collections.abc`).
>>> import collections
>>> collections.abc.Container
AttributeError: module 'collections
Steve Dower added the comment:
New changeset a56fbad85ea655631bce68d4c0f47f1a8b500abd by Steve Dower in branch
'main':
bpo-45220: Ensure RT_MANIFEST is defined when compiling Windows resource files
(GH-29501)
https://github.com/python/cpython/commit/a56fbad85ea655631bce68d4c0f47f1a8b500abd
Change by Steve Dower :
--
pull_requests: +27750
pull_request: https://github.com/python/cpython/pull/29501
___
Python tracker
<https://bugs.python.org/issue45
Steve Dower added the comment:
FYI, adding a fix for this on issue45220
--
___
Python tracker
<https://bugs.python.org/issue45354>
___
___
Python-bugs-list m
Steve Dower added the comment:
New changeset 4d1cdd7006def053c815c354bd6f266b4850bd97 by Steve Dower in branch
'3.9':
bpo-45732: Update bundled Tcl/Tk on Windows to 8.6.12 (GH-29477)
https://github.com/python/cpython/commit/4d1cdd7006def053c815c354bd6f266b4850bd97
Change by Steve Dower :
--
pull_requests: +27746
pull_request: https://github.com/python/cpython/pull/29496
___
Python tracker
<https://bugs.python.org/issue45
Steve Dower added the comment:
New changeset 340ecafdf3bfb1377a1b8584addbb8e7bb423459 by Steve Dower in branch
'3.10':
bpo-45732: Update bundled Tcl/Tk on Windows to 8.6.12 (GH-29477)
https://github.com/python/cpython/commit/340ecafdf3bfb1377a1b8584addbb8e7bb423459
Change by Steve Dower :
--
pull_requests: +27742
pull_request: https://github.com/python/cpython/pull/29493
___
Python tracker
<https://bugs.python.org/issue45
Steve Dower added the comment:
New changeset bcc4e46832010469bb35a97c1d1e962a82ee7fd9 by Steve Dower in branch
'main':
bpo-45732: Update bundled Tcl/Tk on Windows to 8.6.12 (GH-29477)
https://github.com/python/cpython/commit/bcc4e46832010469bb35a97c1d1e962a82ee7fd9
Steve Dower added the comment:
> bpo-45220 removed the winuser.h include from the PC\*.rc files, so the
> RT_MANIFEST resource type macro isn't defined. It needs to be defined in the
> file or a common header. For example:
>
> #define RT_MANIFEST 24
>
Change by Steve Dower :
--
keywords: +patch
pull_requests: +27727
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/29477
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
I guess I've actually got to fix my build process now :)
--
___
Python tracker
<https://bugs.python.org/issue45732>
___
___
Pytho
Steve Dower added the comment:
New changeset 5017306c8732b3ceda878db13088f8c2cf0c5e71 by Miss Islington (bot)
in branch '3.9':
bpo-45720: Drop references to shlwapi.dll on Windows (GH-29417)
https://github.com/python/cpython/commit/5017306c8732b3ceda878db13088f8c2cf0c5e71
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 804ea41211b042fa20c3cd8c0457bbfa3873128a by Steve Dower in branch
'3.10':
bpo-45720: Drop references to shlwapi.dll on Windows (GH-29417)
https://github.com/python/cpython/commit/804ea41211b042fa20c3cd8c0457bbfa3873128a
Change by Steve Dower :
--
pull_requests: +27689
pull_request: https://github.com/python/cpython/pull/29435
___
Python tracker
<https://bugs.python.org/issue45
Steve Dower added the comment:
New changeset a4774f42e35861c4bb16928cffb011c2d8a285ac by Steve Dower in branch
'main':
bpo-45720: Drop references to shlwapi.dll on Windows (GH-29417)
https://github.com/python/cpython/commit/a4774f42e35861c4bb16928cffb011c2d8a285ac
Steve Dower added the comment:
FTR, I see about 1-1.5ms improvement (using timeit to do a check_call) out of
~32ms total startup time.
I also don't actually see gdi32 being transitively loaded as claimed in the
Twitter thread, even back to 3.8. So presumably there's something else going
Change by Steve Dower :
--
nosy: +eryksun
___
Python tracker
<https://bugs.python.org/issue45720>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
keywords: +patch
pull_requests: +27670
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/29417
___
Python tracker
<https://bugs.python.org/issu
New submission from Steve Dower :
According to https://twitter.com/BruceDawson0xB/status/1455714820485894151?s=20
there are some serious performance implications from referencing shlwapi.dll.
It turns out, we only use it for one native path calculation function, which is
easily replaceable
Steve Dower added the comment:
> What fresh clone do you mean? test_embed is failing, not test_freeze.
test_freeze is passing, but it shouldn't be able to locate a valid Lib/
directory to load modules from. So it's somehow managing to do it against the
"official"
Steve Dower added the comment:
New changeset 6340ba7f2c1bef94939dcab0d5babc256ffd7485 by Steve Dower in branch
'3.10':
bpo-43652: Actually update to Tcl/Tk 8.6.11 on Windows (GH-29397)
https://github.com/python/cpython/commit/6340ba7f2c1bef94939dcab0d5babc256ffd7485
Change by Steve Dower :
--
pull_requests: +27663
pull_request: https://github.com/python/cpython/pull/29407
___
Python tracker
<https://bugs.python.org/issue43
Steve Dower added the comment:
New changeset 36b4f9e2a7d5ed55c441eb6dfe5c13baa483b9d4 by Steve Dower in branch
'main':
bpo-43652: Actually update to Tcl/Tk 8.6.11 on Windows (GH-29397)
https://github.com/python/cpython/commit/36b4f9e2a7d5ed55c441eb6dfe5c13baa483b9d4
Steve Dower added the comment:
New changeset fd0c84dc28d00d68e4f43034dc41786a682390fd by Steve Dower in branch
'main':
bpo-45220: Remove invalid include from resource definition files on Windows
(GH-29396)
https://github.com/python/cpython/commit/fd0c84dc28d00d68e4f43034dc41786a682390fd
Change by Steve Dower :
--
pull_requests: +27655
pull_request: https://github.com/python/cpython/pull/29397
___
Python tracker
<https://bugs.python.org/issue43
Steve Dower added the comment:
Unsurprisingly, it was a bad edit that I made to the Makefile myself. The
commit that undoes it is
https://github.com/python/cpython/pull/29041/commits/aedebcc45a638f5cf65d17046ae09b5cac97cebf
but since I made the initial change as part of this PR
Change by Steve Dower :
--
pull_requests: +27654
pull_request: https://github.com/python/cpython/pull/29396
___
Python tracker
<https://bugs.python.org/issue45
Steve Dower added the comment:
I'm betting the out-of-tree (actually just deeper within the same tree) bit is
related, but I just can't see how. Modules/getbuildinfo.c takes extra
parameters and they seem to be being used, so I can't tell why getpath.c's are
not (those rules are listed
Steve Dower added the comment:
Last remaining test failure is one that I can't figure out on my own - the
freeze test is rerunning a CPython build (on Linux) and is apparently building
getpath.c with the ".c.o" rule rather than the "Modules/getpath.o" rule.
Any tips
Steve Dower added the comment:
FTR, I used to run all Windows builds out of tree on Azure Pipelines, but too
many tests broke so I reverted it:
https://github.com/python/cpython/blob/456e27ac0ac6bc1cfd6da0191bd7802d8667457b/.azure-pipelines/windows-steps.yml#L7-L10
Setting $env:Py_OutDir
Steve Dower added the comment:
FWIW, I don't have wslview in the Debian distro I'm currently using. It
does have wslpath though.
Consistent detection and integration throughout CPython's standard
library (unless we believe we need special build options too) is
probably worth a python-dev
Steve Dower added the comment:
We don't formally support it yet. We probably need somebody to develop
expertise in the emulation layer so that they can work with the Linux distro
experts to make sure their distros are doing things properly.
It has no relation at all to our Windows support
Steve Dower added the comment:
Looks like something went wrong back when I built it in March and it built the
older version again.
I probably need to revamp that build step. I think it relies on a race to build
properly, since it's in the main repo. We need a way to override the version
Steve Dower added the comment:
What tool did you use to find all the component registrations?
If your answer is "Registry Editor", there's no chance you found them all.
You'll need a tool specifically designed for cleaning up MSI issues.
I don't know all the keys used. They'
Steve Dower added the comment:
So I think I've found my first completely unavoidable API break:
PyConfig_Read(config) has to work before initialisation, but is also supposed
to fill out all the fields (including the search path). But because we need at
least an interpreter state, we now
Steve Dower added the comment:
There's nothing gained by complicating this API with more options.
Document it as "Passing *force_hide* as True attempts to start the application
without creating or showing any windows. Some applications may ignore this
request, and applica
Steve Dower added the comment:
> But why does it happen only on Windows?
Because it's the operating system that is terminating the process :)
Other operating systems behave differently when you exceed the stack,
and may also allocate different amounts of stack space, making it less
lik
Steve Dower added the comment:
This is almost certainly because of how Windows handles stack overflow
exceptions, and the fact that there's no way for us to detect it reliably.
There's some work going on to reduce the C stack depth when calling heavily
nested Python code (see issue45256
Steve Dower added the comment:
I'd rather only have one force_hide option that does its best to hide
everything.
Yes, it's probably unintuitive for GUI apps, it might even be maliciously
misused, but it does have occasional legitimate uses. And besides, an app can
easily ignore SW_HIDE
Steve Dower added the comment:
winver is static data, so no reason we can't define it all the time.
Unassigning myself - if anyone else would like to work on this, feel free.
--
assignee: steve.dower ->
___
Python tracker
<
Change by Steve Dower :
--
pull_requests: -27312
___
Python tracker
<https://bugs.python.org/issue42260>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
The PR has more work to do, but the overall layout/changes are more or less
there, so happy to discuss feedback/etc.
Obviously there are a lot of edge cases here, but they seem to be mostly tested
already. And I think we're early enough in alpha to find any
Change by Steve Dower :
--
keywords: +patch
pull_requests: +27452
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/29041
___
Python tracker
<https://bugs.python.org/issu
New submission from Steve Dower :
As discussed in issue42260, combining the two getpath implementations into a
single Python implementation would make it more maintainable and modifiable
(particularly where distros need to patch to support alternative layouts).
--
assignee
Steve Dower added the comment:
It seems like it is, however, it sounds like the OP didn't restart PowerShell
after the uninstall or reinstall, which is necessary (though not mentioned, but
given it would usually be missed including text to that effect wouldn't have
any impact anyway
Change by Steve Dower :
--
resolution: -> out of date
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.o
Steve Dower added the comment:
All that said, if we're going to shell out to "ver", we may as well try "wmic
os get Caption,Version /value" first and parse its output. For me, it looks
like the below (with a number of blank lines around it):
Caption=Microsoft Windows 1
Steve Dower added the comment:
> The store app doesn't add "App Paths" entries for "python.exe" and
> "python3.exe".
You're right, it's not following the aliases, but the actual executable. For
3.7, we had them as "python.exe", but from 3.8 t
Steve Dower added the comment:
We'd also need the other log files from %TEMP% in this case, but I suspect
we're not going to get them now.
The associated PR is not related to this bug.
--
resolution: -> out of date
stage: patch review -> resolved
status: open -&g
Steve Dower added the comment:
Somewhat deliberate. We moved to properly support side-by-side installs, which
can't be done with this key - App Paths would end up out of sync with PATH...
almost instantly, really. (However, the Windows Store package manages this
correctly in line with its
Steve Dower added the comment:
New changeset 8702b667d8e7da7a1888297d84f493f26c580a2d by Erlend Egeberg
Aasland in branch 'main':
bpo-43851: Build SQLite with SQLITE_OMIT_AUTOINIT on Windows (GH-25414)
https://github.com/python/cpython/commit/8702b667d8e7da7a1888297d84f493f26c580a2d
Steve Dower added the comment:
Assuming this is fixed
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Affects distutils, which is deprecated and won't be getting any more fixes.
I've migrated it to https://github.com/pypa/distutils/issues/63
--
resolution: -> out of date
stage: -> resolved
status: open -&g
Change by Steve Dower :
--
nosy: +steve.dower
nosy_count: 5.0 -> 6.0
pull_requests: +27312
pull_request: https://github.com/python/cpython/pull/29041
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
It's not really complicated, it's just a little difficult to find the right
files you need.
> Running from the Add Remove Programs entry prompts for admin access.
Which clearly shows it was previously installed by an admin, and so you'll need
that to rem
Steve Dower added the comment:
Bit more complicated. It'll need changes to
Tools/msi/launcher/launcher_reg.wxs, Tools/msi/tcltk/tcltk_reg.wxs, and
PC/layout/support/appxmanifest.py, but I don't think it's that obvious where
(we don't want these files to open with py.exe by default, so
Steve Dower added the comment:
That 'force_hide' in the NEWS shouldn't have single backticks. Make them
``double``, or the docs won't compile.
--
___
Python tracker
<https://bugs.python.org/issue30
Steve Dower added the comment:
Had a look. The change looks fine, just needs a NEWS entry, which I suggested
as:
Adds new `force_hide` argument to :mod:`subprocess` functions. This passes
``SW_HIDE`` to the new process, which most applications will use to not display
any window even
Steve Dower added the comment:
You probably need to also select the "Install for All Users" checkbox, rather
than just updating the target path. Running as admin *technically* gives you
the ability to write to those locations, but it also implies that nobody except
Admin shou
, of course. Much cleaner and I should have seen that myself.
Thanks.
BUT
> (untested) ?
I have tested it and with () instead of [] it's even slower:
explicit loop: 37s ± .5s
sum([...]) 44s ± .5s
sum((...)) 47.5s ± .5s
Now completely surprised.
Steve
--
https://mail.python.org/mailman/listinfo/python-list
I generate about 14 million pairs of sequences of ints each
of length 15 which need to be summed. The first version with sum() needs
44 seconds while the second version runs in 37 seconds.
Can someone explain this difference?
Steve
--
https://mail.python.org/mailman/listinfo/python-list
Steve Dower added the comment:
*facepalm* on myself, for not even thinking of that. Indeed, clearing all my
.pyc files fixes it.
I think I got distracted by the error coming from one of the newly frozen
modules, except because we're in tree it shouldn't be using the frozen one, so
Steve Dower added the comment:
I can't get it to go with that option (with or without -DDEBUG, which I *think*
is needed to get assert to work?), and I also don't see anything obvious in the
changeset I linked. So I guess there's some other assumption that isn't holding
Steve Dower added the comment:
Also +Victor, because I think we should switch back to debug builds in CI in
order to catch failed assertions before they get merged.
Since you're the most strongly against this, I wanted to give you a chance to
argue against it (or suggest a better approach
Steve Dower added the comment:
+Pablo because of blocker.
+Mark because it seems like f6eafe18c004 is probably the cause
--
nosy: +Mark.Shannon, pablogsal
___
Python tracker
<https://bugs.python.org/issue45
New submission from Steve Dower :
encodings.search_function is triggering this assertion at Python/ceval.c#L4055:
TARGET(JUMP_ABSOLUTE) {
PREDICTED(JUMP_ABSOLUTE);
assert(oparg < INSTR_OFFSET());<<<
It seems to be saying that absolute jumps sh
Steve Dower added the comment:
Pushed the branch so the changes are out there, but I still need to check (and
probably fix) some handling of the Store package layout. The changes now will
probably create some executables that won't work (pip.exe and idle.exe), so we
might have to go back
Change by Steve Dower :
--
keywords: +patch
pull_requests: +27135
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/28817
___
Python tracker
<https://bugs.python.org/issu
New submission from Steve Dower :
Currently the venv redirector on Windows is hardcoded for "python.exe" and
"pythonw.exe". There is no good reason for this, and it's fairly easy to make
the redirector able to invoke any executable in the base environment by
ins
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 6811fdaec825bd6ab64e358a4b480108f5634d2d by Steve Dower in branch
'main':
bpo-45337: Use the realpath of the new executable when creating a venv on
Windows (GH-28663)
https://github.com/python/cpython/commit
Steve Dower added the comment:
If we know which parts of the function are critical, perhaps we should
be designing a PGO profile that actually hits them all? The current
profile is very arbitrary, basically just waiting for someone motivated
enough to figure out a better one
Steve Dower added the comment:
I would very much appreciate any new compiler be compatible with the
standard Windows debuggers (windbg primarily, but I imagine most
contributors would like it to keep working from VS).
Last I heard, clang is fine as a compiler for debugging if you use
Steve Dower added the comment:
New changeset 6c942a86a4fb4c8b731cb1bd2933dba554eb79cd by Steve Dower in branch
'main':
bpo-45375: Fix off by one error in buffer allocation (GH-28764)
https://github.com/python/cpython/commit/6c942a86a4fb4c8b731cb1bd2933dba554eb79cd
Change by Steve Dower :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue45375>
___
___
Pyth
Change by Steve Dower :
--
pull_requests: +27104
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/28764
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
Thanks for mentioning it! New PR to fix
--
priority: release blocker -> high
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
> Hmm, but the "ver" output seems to have more information than those APIs.
It's always had build numbers, which the regular APIs do not, because the
regular APIs are meant for detecting incompatibilities rather than reporting.
Since t
Steve Dower added the comment:
The version number for "Windows 11" still starts with 10.0. Just like how
Windows 5.x and 6.x were around for a very long time each ;)
There are tables in platform module that map the specific version to the
release name. These probably need to
Steve Dower added the comment:
Yeah, we're getting close. I'll reopen this issue for tracking.
We still need that pip release and it'll have to be merged into ensurepip.
We'll also need better access to test systems than any of us currently have
(the buildbot is great, but we need
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
stage: backport needed -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue45354>
___
___
Pyth
Steve Dower added the comment:
New changeset d0d0909a3a0b553826d1ddbb04a676fdabb61359 by Miss Islington (bot)
in branch '3.10':
bpo-45354: Skip obsolete device name tests on Windows 11 (GH-28712)
https://github.com/python/cpython/commit/d0d0909a3a0b553826d1ddbb04a676fdabb61359
Steve Dower added the comment:
New changeset 5146877623ebe8a2806411703b0de9c0aba179a1 by Steve Dower in branch
'main':
bpo-45375: Fix assertion failure due to searching for stdlib in unnormalised
paths (GH-28735)
https://github.com/python/cpython/commit
401 - 500 of 13157 matches
Mail list logo
