Bohuslav "Slavek" Kabrda added the comment:
Hi all, it seems to me that this change has been reverted not only in 2.7, but
also in 3.5 (changeset: 101549:c8df1877d1bc). Benjamin, was this intentional?
If so, perhaps this issue should be reopened and not marked as resolved.
Th
Bohuslav "Slavek" Kabrda added the comment:
Hi, I'm maintainer of flexmock [1] and some users of my library have started
hitting this bug [2] - when one tries to mock __new__ and then revert this mock
at the end of testcase to the original one (either by deleting the mock __new__
or
Bohuslav "Slavek" Kabrda added the comment:
> IMHO these two debug features superseded COUNT_ALLOCS. Please try to convince
> me of the use case of this very old debug feature.
I no longer use this feature and I think that noone does. As you said, it seems
to be obsole
Bohuslav "Slavek" Kabrda added the comment:
The patch looks good to me.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue25717>
___
Bohuslav Slavek Kabrda added the comment:
I'm also hitting an issue with test_sysconfig_module, but for a different
reason: While building Python, I used make EXTRA_CFLAGS='some flags' and this
makes test_sysconfig_module fail when I run make test or python -m
test.regrtest.
The problem
Bohuslav Slavek Kabrda added the comment:
@wolma any idea why this only happens on Windows? I can't reproduce the CSV
failing test on Linux.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23700
Bohuslav Slavek Kabrda added the comment:
I'm attaching second version of the patch. It now contains link to this bug and
a more real test case according to suggestion from the review.
One of the reviews of first patch version mentioned that there should be a
better explanation of how
Bohuslav Slavek Kabrda added the comment:
Thank you!
To answer Paul's question: I honestly have no idea why this can't be reproduced
on Windows. I managed to reproduce this in 100 % cases on various RPM-flavour
Linux distros (Fedora, CentOS, RHEL) as well as on Debian and Ubuntu
New submission from Bohuslav Slavek Kabrda:
This bug is very similar to #18879, the only difference is that
_TemporaryFileWrapper.__iter__ is the problem (in #18879, __getattr__ was
fixed, but __iter__ was not). The real world use case that helped me find this
bug is at the bottom
Bohuslav Slavek Kabrda added the comment:
Attaching a new version of patch:
- Rebased to latest default branch
- Simplified prints
- Using OSError instead of IOError
Hopefully this is the final version :)
--
Added file:
http://bugs.python.org/file37421/doctest-dont-end-with-exception
Bohuslav Slavek Kabrda added the comment:
Good catch, using getrefcount was a mistake. I'm attaching a new version which
always checks for getcounts (and also applies on 3.4.2).
--
Added file:
http://bugs.python.org/file37414/00141-fix-tests_with_COUNT_ALLOCS-v3.patch
New submission from Bohuslav Slavek Kabrda:
The attached patch fixes two test_gdb problems that can occur under some
circumstances:
- With new GDB (I think version = 7.4.0, but I'm not sure about the precise
version), GDB sometimes prints entry-values for variables, which can lead
Bohuslav Slavek Kabrda added the comment:
Hi, so I'm not sure I understand this correctly. AFAICS there are two patches
in issue 14443 that are, to certain degree, independent. As for the patch that
overrides __os_install_post [1], that is no longer needed in RHEL 7, since the
line
/usr
New submission from Bohuslav Slavek Kabrda:
Reproducer attached. To describe the problem in words, one needs to do this to
reproduce this issue:
- Create a signal handler and register it using signal.signal to SIGCHLD.
- Create a thread that invokes a subprocess, e.g. sleep 1 and then continues
Bohuslav Slavek Kabrda added the comment:
I think that the problem here is that the documentation sets an expectation
that's not met, at least from my POV. Running the reproducer, I was expecting
the main thread to unpause and execute the signal handler (citing: Python
signal handlers
Bohuslav Slavek Kabrda added the comment:
I'm attaching fourth version of the patch. Changes:
- fileio's _blksize member is now of type T_UINT
- extended test_fileio.AutoFileTests.testAttributes to also test _blksize value
--
Added file:
http://bugs.python.org/file35702/python3-remove
Bohuslav Slavek Kabrda added the comment:
Thanks, Antoine. So, is there anything else that should be done about the patch
so that it gets accepted?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21679
Bohuslav Slavek Kabrda added the comment:
So, as pointed out by haypo, blksize_t is actually signed long on Linux. This
means that my patch (as well as the current code) is not right.
Both with and without my patch, io_open function uses int to store blksize_t
and it also passes it to one
Bohuslav Slavek Kabrda added the comment:
Again, thanks for the review. It's true that HAVE_FSTAT can be defined without
stat structure containing st_blksize. I added an ifdef
HAVE_STRUCT_STAT_ST_BLKSIZE for that. Attaching third version of the patch,
hopefully everything will be ok now
Bohuslav Slavek Kabrda added the comment:
Thanks a lot for the code review! I'm attaching a revised version of the patch.
Fixes I made:
- added check whether PyLong_AsLong returned an error
- removed ADD_INTERNED(_blksize) and PyObject *_PyIO_str__blksize; - I
noticed that these are only
New submission from Bohuslav Slavek Kabrda:
Hi,
with Python 3.3/3.4, I noticed that there are lots of syscalls on open() - I
noticed 2x fstat, 2x ioctl and 2x lseek. This is not noticable when working
with small amounts of files on local filesystem, but if working with files via
NSF
Bohuslav Slavek Kabrda added the comment:
I'd really prefer IRC, if at all possible for you :)
When online, I'm usually on #fedora-python, but I can really come any channel
of your choice.
Sorry for the delays in communication, I've got a lot on my plate right now and
I'll probably
Bohuslav Slavek Kabrda added the comment:
@jcea: So here is my proposal for dealing with this: let's take what I
currently have (e.g. tracepoints for function entry/function exit) and extend
my patch to also work with DTrace in a similar fashion. Then, when we have a
working patch for both
New submission from Bohuslav Slavek Kabrda:
This is a tracking bug for development of combined systemtap and dtrace patch
for Python. The separate patches were submitted at [1] (systemtap) and [2]
(dtrace).
Since it was agreed that it'd be best to merge the two patches to reuse as much
code
Bohuslav Slavek Kabrda added the comment:
I opened a bug for tracking progress of development of the combined dtrace and
systemtap support: http://bugs.python.org/issue21590
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Bohuslav Slavek Kabrda added the comment:
I opened a bug for tracking progress of development of the combined dtrace and
systemtap support: http://bugs.python.org/issue21590
--
nosy: +bkabrda
___
Python tracker rep...@bugs.python.org
http
Bohuslav Slavek Kabrda added the comment:
I'd be fine with adapting the patch to support both systemtap and dtrace,
however I have very little knowledge of dtrace and I don't have a machine to
test it on.
@jcea would you be willing to work on such patch with me? I'm sure we could
work
Bohuslav Slavek Kabrda added the comment:
Hi,
I'd like to take this over after Dave Malcolm. I don't see any issues that
haven't been resolved, so my question is: What else can I do to make this patch
acceptable?
I'm attaching a rebased version of this patch that applies to current default
Bohuslav Slavek Kabrda added the comment:
As usual, I forgot to hg add the new files before running hg diff, so the newly
created files didn't get added to the patch. Attaching a fixed version that
hopefully has everything.
AFAICS all the scripts that Fedora has are 1:1 copy of documentation
New submission from Bohuslav Slavek Kabrda:
test_faulthandler.test_register_chain fails on some 64bit architectures (arm8,
ppc64) with kernel = 3.10:
==
FAIL: test_register_chain (__main__.FaultHandlerTests
Bohuslav Slavek Kabrda added the comment:
I'm also surprised that this depends on kernel version, however that's what I
found out (and the opensuse guys seem to only have reproduced this on kernel =
3.10, too).
- Full kernel version (uname -r output): 3.13.0-0.rc7.28.sa2.aarch64
Bohuslav Slavek Kabrda added the comment:
Ok, so with #undef HAVE_SIGACTION both the reproducer and the original test
(as well as all tests in test_faulthandler) pass fine.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Bohuslav Slavek Kabrda added the comment:
Brett, I signed it just yesterday, it probably wasn't processed yet. Hopefully
it will be in few days. Thanks for patching this!
--
resolution: fixed -
status: closed - open
___
Python tracker rep
Bohuslav Slavek Kabrda added the comment:
Whoops, reopened by accident. Closing again.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20778
New submission from Bohuslav Slavek Kabrda:
ModuleFinder.load_module currently only skips 8 bytes before trying to
marshal.load the rest of the file, but it should skip 12 since 3.3 (magic,
date, file size). I'm attaching a patch with test case.
BTW this was very painful to find out, since I
Bohuslav Slavek Kabrda added the comment:
Since 3.4.0.b2, this also causes failures in another tests: test_io,
test_logging, test_threading, test_warnings. There are various cases testing
that some types get collected when the interpreter shuts down.
I'm attaching a new patch that covers all
Bohuslav Slavek Kabrda added the comment:
Attaching a list of files in /usr/sbin in Fedora's minimal buildroot. (Note,
that in Fedora /sbin is a symlink to /usr/sbin.)
FWIW I can workaround this issue by adding net-tools to BuildRequires, so this
is no big pain for me.
--
Added file
Bohuslav Slavek Kabrda added the comment:
As noted in Misc/SpecialBuilds:
COUNT_ALLOCS
Each type object grows three new members:
/* Number of times an object of this type was allocated. */
int tp_allocs;
/* Number of times an object of this type was deallocated
Bohuslav Slavek Kabrda added the comment:
When building for Fedora, we usually use minimal buildroot, that doesn't have
net-tools (e.g. ifconfig and others) installed, so this test fails for us. It'd
probably be best to skip this based on whether ifconfig binary can be found
Bohuslav Slavek Kabrda added the comment:
Nick: Sure, once there is an upstream solution that people have agreed on, I'll
look into backporting it, NP. Thanks for letting me know about this.
--
___
Python tracker rep...@bugs.python.org
http
Bohuslav Slavek Kabrda added the comment:
I can also reproduce it on Arch Linux. It seems that the bad characters are
only output if env variable TERM starts with xterm.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19884
New submission from Bohuslav Slavek Kabrda:
A simple reproducer:
python -c 'import readline' | xxd
000: 1b5b 3f31 3033 3468 .[?1034h
This was reported at [1] and originally at [2]. The readline maintainer
suggests [3] using:
rl_variable_bind (enable-meta-key, off
Changes by Bohuslav Slavek Kabrda bkab...@redhat.com:
--
nosy: +bkabrda
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15657
___
___
Python-bugs
Bohuslav Slavek Kabrda added the comment:
Seems that Ezio was faster :)
Yep, the attached patch does seem to solve the issue.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19680
New submission from Bohuslav Slavek Kabrda:
Steps to reproduce:
[bkabrda@zizalka python]$ python
help()
help keywords
snip
# prints lots of keywords including print and exec
/snip
help print
no documentation found for 'print'
So either keywords should not list print and exec
New submission from Bohuslav Slavek Kabrda:
When Python is compiled with COUNT_ALLOCS, some tests in test_gc and
test_module fail. I'm attaching the patch that skips 3 of them and modifies
assertions in one of them, so that the tests pass.
I'm however still unsure about one of the skipped
Bohuslav Slavek Kabrda added the comment:
And the patch...
--
keywords: +patch
Added file:
http://bugs.python.org/file32540/00141-fix-tests_with_COUNT_ALLOCS.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19527
Changes by Bohuslav Slavek Kabrda bkab...@redhat.com:
--
nosy: +bkabrda
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9216
___
___
Python-bugs
Changes by Bohuslav Slavek Kabrda bkab...@redhat.com:
--
nosy: +bkabrda
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19347
___
___
Python-bugs
New submission from Bohuslav Slavek Kabrda:
If py_compile.compile is used on a file with bad encoding (e.g.
Lib/test/bad_coding2.py), the function raises even if doraise=False is passed.
I'm attaching a patch that fixes this in 3.3 - I haven't tried on 3.4 yet and
the code has changed, so I'm
Bohuslav Slavek Kabrda added the comment:
Ok, I'm attaching a patch for 3.3 with a test case included.
--
Added file:
http://bugs.python.org/file32424/dont-raise-from-py_compile-test-included.patch
___
Python tracker rep...@bugs.python.org
http
Changes by Bohuslav Slavek Kabrda bkab...@redhat.com:
--
nosy: +bkabrda
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17998
___
___
Python-bugs
Changes by Bohuslav Slavek Kabrda bkab...@redhat.com:
--
nosy: +bkabrda
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10131
___
___
Python-bugs
Bohuslav Slavek Kabrda added the comment:
I just tried rebuilding with my patch and running test suite + I did some
manual testing and everything seems to work fine - and the memory leak is not
there.
--
___
Python tracker rep...@bugs.python.org
New submission from Bohuslav Slavek Kabrda:
Function dbm_length from Modules/_gdbmmodule.c seems to be leaking memory. A
simple reproducer:
import dbm
d = dbm.open('spam', 'c')
d['x'] = '1'
print(len(d))
The interesting part of valgrind output with --leak-check=full:
==3312== 1 bytes in 1
Bohuslav Slavek Kabrda added the comment:
I'm currently patching Python 3.3.2 with this, so I thought it might be nice to
attach an up-to-date patch. The only notable difference is that I added
self.preclean() at the beginning of test_refcount_errors - without it, running
test suite produced
Changes by Bohuslav Slavek Kabrda bkab...@redhat.com:
--
nosy: +bkabrda
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12425
___
___
Python-bugs
New submission from Bohuslav Slavek Kabrda:
Hi,
I'm getting these warnings with -fstrict-aliasing, compiling Python 3.3.2
(compiling with gcc 4.4.7):
/builddir/build/BUILD/Python-3.3.2/Python/ceval.c: In function
'PyEval_EvalFrameEx':
/builddir/build/BUILD/Python-3.3.2/Python/ceval.c:1006
Bohuslav Slavek Kabrda added the comment:
Hmm, you're probably right. The problem seems to be in downstream redefinition
of READ_TIMESTAMP. Sorry for the fuzz, closing.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http
Bohuslav Slavek Kabrda added the comment:
Actually, this appears on vanilla Python 3.3 with -DWITH_TSC:
Python/ceval.c: In function ‘PyEval_EvalFrameEx’:
Python/ceval.c:986:5: warning: dereferencing type-punned pointer will break
strict-aliasing rules [-Wstrict-aliasing]
READ_TIMESTAMP
Changes by Bohuslav Slavek Kabrda bkab...@redhat.com:
--
nosy: +bkabrda
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17980
___
___
Python-bugs
Bohuslav Slavek Kabrda added the comment:
Hmm, good point. I'll try to discuss with Fedora people who work on secondary
arches. Thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17837
New submission from Bohuslav Slavek Kabrda:
Hi, would it be possible to add ppc64p7 (Power7 optimized) to supported arches
in config.sub? It should be as easy as the attached one-liner patch.
Thanks.
--
components: Build
files: python-add-support-for-ppc64p7.patch
keywords: patch
Bohuslav Slavek Kabrda added the comment:
So, to give it a little background: I need this for Fedora builds on ppc64p7.
Just the name recognition helps, because the name is passed automatically by
rpmbuild to configure (== if not recognized, build fails). So this is basically
a way
New submission from Bohuslav Slavek Kabrda:
On Python 2, Condition.wait timeout is always taken as
min(delay * 2, remaining, .05)
which means it cannot be longer than 50 ms. I don't see a reason for this and
AFAIK this is no longer true for Python 3, where timeout can be arbitrarily
long
Bohuslav Slavek Kabrda added the comment:
This may also be related to the tests failing on official buildbots as
mentioned in [1], although the error messages look different. However both of
these issues seem to be a memory corruption problem, as one of the frames in
stack trace (the one
New submission from Bohuslav Slavek Kabrda:
Hi,
it seems that test_gdb fails on armv7hl on Fedora 19 and 20 [1] (I'm also
tracking my notes of the bug there). Basically, the problem seems to come down
to PyObjectPtr.subclass_from_type (file python-gdb.py) returning different
values
Bohuslav Slavek Kabrda added the comment:
I'm strongly +1 on this one. I package Python RPMs for Fedora and I know what
mess can come out of installing through both RPM and easy_install/pip.
In Fedora, both Perl and Ruby use vendor specific dirs for installing RPM
packaged modules and site
Bohuslav Slavek Kabrda added the comment:
I'm attaching a patch that I'm currently using to solve this. It works, but
it's a bit aggressive - in the sense that it only adds a string to the
sysconfig variable iff this string is not a substring of current variable
value. So it may corrupt some
New submission from Bohuslav Slavek Kabrda:
When compiling Python 3.3.1, I noticed that some variables like LDFLAGS or
CFLAGS in sysconfig have some flags multiple times. (Which BTW breaks
distutils.tests.{test_sysconfig_compiler_vars,test_sysconfig_module}) This is
caused by interpretation
New submission from Bohuslav Slavek Kabrda:
When building extension modules of Python 2.7.4 through Modules/Setup.dist, the
socketmodule gets built badly, as it also needs to be compiled with
timemodule.c (see the attached patch).
This was caused by commit 8ec39bfd1f01, which introduced usage
Changes by Bohuslav Slavek Kabrda bkab...@redhat.com:
--
nosy: +bkabrda
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16754
___
___
Python-bugs
Changes by Bohuslav Slavek Kabrda bkab...@redhat.com:
--
nosy: +bkabrda
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9253
___
___
Python-bugs
Bohuslav Slavek Kabrda added the comment:
I have a similar problem with python 3.3.0. During installation, I get
snip
running install_lib
creating
/builddir/build/BUILDROOT/python33-python-3.3.0-3.el6.i386/opt/rh/python33/root/usr/lib/python3.3/lib-dynload
copying build/lib.linux-i686-3.3
Bohuslav Slavek Kabrda added the comment:
Ouch, the problem was in fact on my side. I was building python inside a mock
[1] chroot that had different version of headers than the actual kernel. When I
figured this out and made the versions the same, everything passed perfectly.
Sorry
New submission from Bohuslav Slavek Kabrda:
When I use zipfile.is_zipfile on file fastjar (sample uploaded at [1]) from
libgcj, I get True, while I should get False (reproducible with fastjar from
libgcj 4.7.2 on Fedora 18).
This is caused by stringEndArchive string being present in the file
Bohuslav Slavek Kabrda added the comment:
Oh, sorry, I will upload it on the bugtracker next time.
I know that jar files are zip files, but this is not a jar (although it has
jar in file). This is a binary.
--
___
Python tracker rep
Bohuslav Slavek Kabrda added the comment:
Tried is_zipfile on /usr/bin/zip and it returns True, too, so it seems that
this is a more general problem for zip-handling binaries... Anyway, thank you
both, I agree that there is not much that can be done here
Bohuslav Slavek Kabrda bkab...@redhat.com added the comment:
Fifth version :)
- On failure in a loaded test, the _test function returns, so this behaviour is
preserved.
- During _test function, count of both loaded and non-loaded files is kept.
- If a file fails to be loaded, the tests
Bohuslav Slavek Kabrda bkab...@redhat.com added the comment:
So maybe an optimal solution would be to add a note summarizing this to the end
of output? I mean that this:
X passed and Y failed.
Could be replaced by:
X passed and Y failed, Z files were not loaded.
Then the user will know
New submission from Bohuslav Slavek Kabrda bkab...@redhat.com:
Hi,
when using Python's Lib/mimetypes.py and none of the default files is present,
there are some defaults used. For javascript, the default is
application/x-javascript. However, according to IANA specification [1
Bohuslav Slavek Kabrda bkab...@redhat.com added the comment:
So I figured it might be best to first agree on the actual behaviour (what the
patch will look like) and then I can write the tests.
So here is my 3rd version:
- It seems that returning 1 only if last file fails is intentional
Bohuslav Slavek Kabrda bkab...@redhat.com added the comment:
Ok, attaching 4th version :)
I think it is nice when the testing library can react in situations like this
one and not show a traceback. IMHO it is always nicer to display a pretty
user-readable message than ending with a traceback
New submission from Bohuslav Slavek Kabrda bkab...@redhat.com:
Hi,
I think that doctest should be able to handle situations when the file that is
being tested does not exist/is unreadable/etc...
Currently, doctest raises an IOError exception and the whole Python ends with
an exception
Bohuslav Slavek Kabrda bkab...@redhat.com added the comment:
Thanks for the comment David. I'm attaching second version that does the same
in the _test function.
--
Added file:
http://bugs.python.org/file26155/doctest-dont-end-with-exception-on-unreadable-files-v2.patch
Bohuslav Slavek Kabrda bkab...@redhat.com added the comment:
Sure, if you give me some time, I'll try to do everything as you suggest.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15178
Changes by Bohuslav Slavek Kabrda bkab...@redhat.com:
--
nosy: +bkabrda
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14803
___
___
Python-bugs
Changes by Bohuslav Slavek Kabrda bkab...@redhat.com:
--
nosy: +bkabrda
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14776
___
___
Python-bugs
88 matches
Mail list logo