[issue27806] 2.7 32-bit builds fail on macOS 10.12 Sierra due to dependency on deleted header file QuickTime/QuickTime.h

2016-10-17 Thread Jeremy Sequoia
Jeremy Sequoia added the comment: QuickTime/QuickTime.h was deprecated long ago. python fails to compile if QuickTime/QuickTime.h isn't present. QuickTime/QuickTime.h was removed in Sierra, causing the build to fail on Sierra. This patch fixes that issue. > On Oct 17, 2016, at 05

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-16 Thread Jeremy Sequoia
Jeremy Sequoia added the comment: sys/cdefs.h (on new enough darwin) does this for such cases: #ifndef __has_include #define __has_include(x) 0 #endif but of course that isn't present in sys/cdefs.h on older SDKs, so you can just shove that above the check and it should fallback the way you

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-16 Thread Jeremy Sequoia
Jeremy Sequoia added the comment: Thanks, yep that looks much nicer to me. Containing the core logic at a central choke point makes maintenance much easier. I'll work to get this into MacPorts. -- ___ Python tracker <rep...@bugs.python.org>

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-15 Thread Jeremy Sequoia
Jeremy Sequoia added the comment: Correction (bugfix and Tiger-compat): #if __has_include() #include #define APPLE_SUPPORTS_QUICKTIME (__MAC_OS_X_VERSION_MAX_ALLOWED < 101200) && !__LP64__ #else #define APPLE_SUPPORTS_QUICKTIME !__LP

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-15 Thread Jeremy Sequoia
Jeremy Sequoia added the comment: AvailabilityMacros.h is super deprecated and should not be used by anything current. Availability.h was added as replacement in 10.5. __MAC_OS_X_VERSION_MAX_ALLOWED should be checked instead of defined (DEPRECATED_IN_MAC_OS_X_VERSION_10_12_AND_LATER) You