Leon Weber added the comment:
I noticed an inconsistency between IPv4 and IPv6 in my temporary variable names
when looking at the patch again after a few days. Here’s an updated patch. Not
that it’s important, but I sleep better that way :)
As consensus seems to have settled on leaving out
Leon Weber added the comment:
I’ve changed the wording in the documentation a bit and added an explanatory
sentence, how about this?
I think this should make pretty clear what it does and does not, and also easy
to find in the documentation when searching for “reverse”, “PTR” and “pointer
Leon Weber added the comment:
As for what the host command does, it doesn't add any trailing dots
here:
Oh, interesting. It does on Fedora 19 with version 9.9.3, but not on my Ubuntu
installation with version 9.8.1. So it seems this was added between 9.8.1 and
9.9.3
Leon Weber added the comment:
According to apt-cache, the version I tried with is
1:9.9.3.dfsg.P2-4ubuntu1
Ok, then it depends on something else apparently. It’s not so relevant anyway
because even with the trailing dot, “host” is inconsistent between IPv4 and
IPv6, and we should choose
Leon Weber added the comment:
I can live without the trailing dot, although I’d find it “more correct” to
have it.
I’ve attached an alternative patch that doesn’t return a trailing dot, it’s up
to you guys to decide which one you prefer.
--
Added file:
http://bugs.python.org
New submission from Leon Weber:
I was missing a method to compute the reverse DNS name for an IP address, and I
felt this is something that would belong in the ipaddress module; so here’s a
patch for the ipaddress module adding a reverse_name property to IPv?Address.
This is an example
Leon Weber added the comment:
Thanks for the feedback, I agree reverse_pointer is a better, less ambiguous
name for the property. I’ve amended the patch to reflect this suggestion.
Regarding the trailing dot, I felt it more appropriate to have it that to leave
it out, but I don’t have
Leon Weber added the comment:
Oh nice, then fewer trees have to die. I’ve now signed the contributor’s
agreement.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20480
