Rolf Krahl added the comment:
First of all, thanks all for the great work, in particular to you Martin for
your patience!
Martin, on your changes: as mentioned earlier, I'm in holidays right now, so I
didn't had a close look yet. But I tested my application and it works, so I
guess I'm
Rolf Krahl added the comment:
Ok, here comes the next version of the patch. I made the changes discussed in
the last post and addressed the review comments. Looks like we are converging
towards a final version.
--
Added file: http://bugs.python.org/file44076/issue12319_11.patch
Rolf Krahl added the comment:
Martin,
> _is_textIO(): I’m sorry but I still prefer the TextIOBase check over
> read(0). Each option has a disadvantage, but with TextIOBase, the
> disadvantage only affects text files, not byte files.
Ok, this is a valid argument.
> Maybe an
Rolf Krahl added the comment:
I just wrote:
> There were also requests to drop support for stuff that is working
> in the current library, although not documented, and that is
> explicitly covered by the test suite. I'm fine with dropping that
> and also adapted the tests
Rolf Krahl added the comment:
Martin,
> I wonder if it would be safer to test for TextIOBase. With the
> read(0) hack, the zero size may be unexpected. A file object may
> need special handling to generate an empty result, or to not
> interpret it as an EOF indicator. See e.g.
Rolf Krahl added the comment:
Thanks for your review! Here comes a new version of the patch. I believe I
addressed all review comments.
Since I didn't get any feedback on my questions raised above, I resolved them
as follows:
1. I dropped the EncodingError exception introduced
Rolf Krahl added the comment:
*ping*
It's more then four weeks ago that I revised my patch, still waiting for
review. I also still need feedback on the question whether the new
EncodingError exception introduced by Damien should be kept or whether I should
change this to a ValueError
Rolf Krahl added the comment:
Here comes a new version of the patch. I believe, I addressed all review
comments made on issue12319_7.patch, with the exception of the EncodingError
mentioned in the last post.
Most relevant changes compared to last patch:
* Do not try to dertermine
Rolf Krahl added the comment:
Martin, I'm almost through with your comments. There is however one item that
I need some feedback on: You asked for more documentation on the new
EncodingError exception. This was introduced by Demian. It is raised when the
Transfer-encoding header set
Rolf Krahl added the comment:
Martin, thank you for your review! I have to work through the list of comments
and get back to you when I'm done. Please note that I didn't got your earlier
reviews, so I don't know which comments are new and which are left over from
earlier reviews
Rolf Krahl added the comment:
Python 3.6.0a2 has been released this week. I guess, we need to speed up a
bit. I really would like to see this issue fixed in 3.6.0 final.
I updated Demian's patch to match the current Python sources, see the
attachment. I also addressed the issue
Rolf Krahl added the comment:
I disagree. I believe that the suggested modification of
AbstractHTTPHandler.do_request_() belongs into this change set for the
following reasons:
1. This module [http.client] defines classes which implement the client side
of the HTTP and HTTPS protocols
Rolf Krahl added the comment:
Hi again,
first of all, sorry for not contributing to the discussion for such a long
time. I was quite busy lately.
I tested the patch with Python 3.5.0a3. It works nicely for my use case.
Thanks a lot!
I have one issue though: urllib's HTTPHandler
Rolf Krahl added the comment:
The design goal for my implementation was compatibility. My version can be
used as a drop in replacement for the existing urllib's HTTPHandler. The only
thing that need to be changed in the calling code is that it must call
build_opener() to select the chunked
Rolf Krahl added the comment:
I'd like to support the request. I have a use case where I definitely need
this feature: I maintain a Python client for a scientific metadata catalogue,
see [1] for details. The client also features the upload of the data files.
The files may come in as a data
Rolf Krahl added the comment:
Thanks for the notice! As far as I read from the link you cite, getting rid of
the current httplib in urllib3 is planned but far from being done.
Furthermore, I don't like packages with too many 3rd party dependencies. Since
my package is working fine
16 matches
Mail list logo
