Vincent Legoll added the comment:
Maybe if the server change is not approved you can still push the part of the
patch that un-hardwire that server name everywhere...
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
New submission from Vincent Legoll:
Here is a patch to fix a missing word in the urllib doc
--
assignee: docs@python
components: Documentation
files: python-doc-fix.hgpatch
messages: 245927
nosy: docs@python, vincent-legoll
priority: normal
severity: normal
status: open
title: [doc
New submission from Vincent Legoll vincent.leg...@gmail.com:
Using pylint I found some unused imports in Lib.
I filtered the most obvious ones by hand to produce the attached patch.
Should I submit individual patches, one for each file, so as to ease review ?
--
components: Library
Vincent Legoll vincent.leg...@gmail.com added the comment:
Looking through http://hg.python.org/cpython/rev/8c17e898e0e8
I see that the glob.py hunk has been applied reversed.
The changeset 68349:55bea11d892e removing it is 3 monthes old...
Looks like I missed a svn-hg migration on my side
Vincent Legoll vincent.leg...@gmail.com added the comment:
This one reverts glob.py to the previous state
--
Added file: http://bugs.python.org/file22510/reremove-sys-import-from-glob.patch
___
Python tracker rep...@bugs.python.org
http
Vincent Legoll vincent.leg...@gmail.com added the comment:
OK I'll look at it and respin with the comments in mind
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11302
Vincent Legoll vincent.leg...@gmail.com added the comment:
Here we are, I left the exact messages for raised exceptions as comments so
they can easily be checked in case of test failure...
Does that look OK ?
--
Added file: http://bugs.python.org/file22495/add-more-tests-for-ast_py-2
Vincent Legoll vincent.leg...@gmail.com added the comment:
I was testing exact matches on the strings because I think pypy wants to be as
compliant as possible with cpython, and IMHO that include exception msgs as far
as possible. I don't see any reason to be different just for the sake
Vincent Legoll vincent.leg...@gmail.com added the comment:
* removed the comments for exc msgs
* added explanation to multiline statements
* added 2 tests to test_AST_objects()
Regarding Éric's comment, I'm starting to wonder if those Exception tests
should be added to cpython's testsuite
New submission from Vincent Legoll vincent.leg...@gmail.com:
While working to improve pypy's compliance with cpython2.7
I added more tests to the ast module test suite.
They may be of interest here too...
--
components: Tests
files: add-more-tests-for-ast_py.patch
keywords: patch
Vincent Legoll vincent.leg...@gmail.com added the comment:
The real question I had is why mkstemp return an os-level opened file
descriptor instead of a python file object...
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
New submission from Vincent Legoll vincent.leg...@gmail.com:
As per the blog entry
http://www.logilab.org/blogentry/17873
I think the tempfile.mkstemp() documentation could be more helpful by
suggesting the use of os.close() appropriately.
If some native english speaker could give a review
Vincent Legoll vincent.leg...@gmail.com added the comment:
Or a review of the markup I used
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6875
Vincent Legoll vincent.leg...@gmail.com added the comment:
Yes it does
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6620
___
___
Python-bugs
Vincent Legoll vincent.leg...@gmail.com added the comment:
Could someone ensure the attached unittest does the job, I blindly
copied from above...
I don't know how to launch an unittest with the svn 'Lib', it takes the
system one and just messing with PYTHONPATH won't work either
Vincent Legoll vincent.leg...@gmail.com added the comment:
If the macro_lines is not emptied upon end of parsing a macro
definition, if there's another macro definiton it will 'inherit' the
lines from the previous one, which could very well be uncool.
The use before definition should also
New submission from Vincent Legoll vincent.leg...@gmail.com:
The isgenerator() function looks duplicated, remove the one with the
shortest docstring
--
components: Library (Lib)
files: py3k-inspect.py-remove-duplicated-func.patch
keywords: patch
messages: 91172
nosy: vincele
severity
New submission from Vincent Legoll vincent.leg...@gmail.com:
The last_interval variable could potentially be used before being first
assigned a value.
--
components: Library (Lib)
files: py3k-locale.py-use-before-assignment.patch
keywords: patch
messages: 91173
nosy: vincele
severity
New submission from Vincent Legoll vincent.leg...@gmail.com:
The binhex module still has uses of the deprecated and now now removed
Carbon module.
The attached patch 'fix' this by removing the code, something else may
be required, but I don't know what.
So this is only a RFC to start
New submission from Vincent Legoll vincent.leg...@gmail.com:
The poplib modules use the 'secret' variable during its creation, this
may be a mistake. Perhaps the intention was to use the 'password' instead...
--
components: Library (Lib)
files: py3k-poplib.py-use-wrong-variable.patch
Changes by Vincent Legoll vincent.leg...@gmail.com:
--
components: Library (Lib)
nosy: vincele
severity: normal
status: open
title: Lib/ftplib.py
versions: Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6623
New submission from Vincent Legoll vincent.leg...@gmail.com:
The 'macro_lines' list should probably be emptied upon leaving macro
parsing mode.
Simplify code by using the 'macro_name' variable as the boolean for
macro parsing mode.
Deprecated code probably should be fixed until completely
Vincent Legoll [EMAIL PROTECTED] added the comment:
- Added shut pylint up comment for ** keyword expansion
- Added Copyright license header
Added file: http://bugs.python.org/file11330/pipeline.py
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org
Vincent Legoll [EMAIL PROTECTED] added the comment:
Hello,
I was searching for a bug in subprocess
module when I saw your patch.
I was implementing the exact same functionality
and mixed some of your ideas in what I use now,
which is attached...
Feel free to use it
--
nosy
Vincent Legoll [EMAIL PROTECTED] added the comment:
Here's a clean version with doc test
enjoy !
Added file: http://bugs.python.org/file11263/pipeline.py
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3548
New submission from Vincent Legoll [EMAIL PROTECTED]:
The subprocess.Popen() object documentation should indicate
that the stdout attribute should not be modified after
object construction. Because that won't work.
Or the attribute may be rendered read-only
from subprocess import Popen, PIPE
26 matches
Mail list logo
