[issue5001] Remove assertion-based checking in multiprocessing

2017-08-19 Thread drallensmith
drallensmith added the comment: I've updated the PR to include all of the non-Windows-specific asserts; I am not sufficiently familiar with Windows multiprocessing to feel confident writing informative error messages. -- ___ Python tracker <

[issue5001] Remove assertion-based checking in multiprocessing

2017-08-18 Thread drallensmith
drallensmith added the comment: Sorry! I was starting to wonder if the PR had been overlooked somehow... -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/

[issue5001] Remove assertion-based checking in multiprocessing

2017-08-17 Thread drallensmith
drallensmith added the comment: No discussion yet on pull request (5 days); just submitted fixes for util.py. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/

[issue5001] Remove assertion-based checking in multiprocessing

2017-08-16 Thread drallensmith
drallensmith added the comment: Pull request submitted (4 days ago) for managers.py, queue.py; just added pool.py changes to those. -- versions: +Python 3.7 -Python 3.6 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/

[issue5001] Remove assertion-based checking in multiprocessing

2017-08-12 Thread drallensmith
Changes by drallensmith <allen.w.smi...@gmail.com>: -- pull_requests: +3120 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue5001> ___

[issue31169] Unknown-source assertion failure in multiprocessing/managers.py

2017-08-12 Thread drallensmith
drallensmith added the comment: Pull request equivalent for the patch submitted. This will not, of course, fix this particular bug, but it should help others with debugging such errors. -- ___ Python tracker <rep...@bugs.python.org>

[issue31169] Unknown-source assertion failure in multiprocessing/managers.py

2017-08-12 Thread drallensmith
Changes by drallensmith <allen.w.smi...@gmail.com>: -- pull_requests: +3118 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue31169> ___

[issue5001] Remove assertion-based checking in multiprocessing

2017-08-12 Thread drallensmith
Changes by drallensmith <allen.w.smi...@gmail.com>: -- pull_requests: +3117 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue5001> ___

[issue5001] Remove assertion-based checking in multiprocessing

2017-08-12 Thread drallensmith
drallensmith added the comment: Patches (for 2.7 and 3.5; the code is identical, only the line numbers changed) for the portion I commented on can be found in issue 31169. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.p

[issue31169] Unknown-source assertion failure in multiprocessing/managers.py

2017-08-10 Thread drallensmith
drallensmith added the comment: I've updated the title to be more accurate. On second thought, putting in a pdb.set_trace() would require that I know where the assertion failure is taking place... sigh. BTW, is there some way to edit earlier messages? I am used to github in that regard

[issue31169] convert_to_error assertion failure in multiprocessing/managers.py

2017-08-10 Thread drallensmith
drallensmith added the comment: pdb is not currently working for debugging a subprocess. I suspect I will need to put "import pdb" and "pdb.set_trace()" into managers.py. BTW, a thank-you to berker.peksag; while the link is present in Travis, I s

[issue31169] convert_to_error assertion failure in multiprocessing/managers.py

2017-08-10 Thread drallensmith
drallensmith added the comment: Here is the patch for 2.7. -- Added file: http://bugs.python.org/file47076/managers-2.7.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue31169] convert_to_error assertion failure in multiprocessing/managers.py

2017-08-10 Thread drallensmith
drallensmith added the comment: Well, it looks like I was incorrect in where the AssertionError is coming from - the attached patches, while an improvement IMO on the current code, did not result in a change in behavior. Unfortunately, the combination of bare asserts (with no messages

[issue31169] convert_to_error assertion failure in multiprocessing/managers.py

2017-08-10 Thread drallensmith
drallensmith added the comment: The section in question is: def convert_to_error(kind, result): if kind == '#ERROR': return result elif kind == '#TRACEBACK': assert type(result) is str return RemoteError(result) elif kind == '#UNSERIALIZABLE': assert

[issue31169] convert_to_error assertion failure in multiprocessing/managers.py

2017-08-10 Thread drallensmith
drallensmith added the comment: Correction - 2.7.9 - Travis seems to be a bit behind. Here's one from 3.6.2: Traceback (most recent call last): File "/opt/python/3.6.2/lib/python3.6/multiprocessing/process.py", line 249, in _bootstrap self.run() File "/opt/python/3.6.

[issue31169] convert_to_error assertion failure in multiprocessing/managers.py

2017-08-10 Thread drallensmith
drallensmith added the comment: An example on 2.7.13: Traceback (most recent call last): File "/opt/python/2.7.9/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap self.run() File "/opt/python/2.7.9/lib/python2.7/multiprocessing/process.py", line 1

[issue31169] convert_to_error assertion failure in multiprocessing/managers.py

2017-08-09 Thread drallensmith
New submission from drallensmith: I am seeing a triggering of one of the assertions in convert_to_error, in managers.py. (This assertion is completely without any message, incidentally, which is also problematic - I've commented on this in issue5001.) This is in common across all versions

[issue5001] Remove assertion-based checking in multiprocessing

2017-08-09 Thread drallensmith
Changes by drallensmith <allen.w.smi...@gmail.com>: -- nosy: +drallensmith ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue5001> ___