Re: [python-win32] adodbapi changing autocommit

2016-10-25 Thread Vernon D. Cole
Please file a bug report at https://sourceforge.net/p/adodbapi/bugs/ . I will rebuild my test environment which has gradually evaporated over time. Make sure to specify which database engine were you running to find the bug. On Tue, Oct 25, 2016 at 2:53 PM, Max Slimmer

Re: [python-win32] adodbapi changing autocommit

2016-10-25 Thread Max Slimmer
Vernon, Yes, that is what I'm saying, I just didn't want to come out shouting "bug". I tried setting up the package test at one point but got stuck somewhere so I'm not sure I'm the person to file the PR (or whatever the process is). But, I'd be happy to file it using whatever the appropriate

Re: [python-win32] adodbapi changing autocommit

2016-10-24 Thread Vernon D. Cole
Wait a bit... Did I just hear that there is a difference in operation between starting a connection with autocommit=false and turning autocommit off during a session? If so, I think that's a bug. PEP-249 has no hook for explicitly starting a transaction, so adodbapi needs to always have done

Re: [python-win32] adodbapi changing autocommit

2016-10-24 Thread Tim Roberts
Max Slimmer wrote: > The adodbapi documentation and code implies that with autocommit = > False I should only have to call commit (and possibly rollback) and if > using the connection as a context manager not even those are required. > If autocommit = False is passed on the initial connect the

Re: [python-win32] adodbapi changing autocommit

2016-10-23 Thread Tim Roberts
On Oct 22, 2016, at 9:42 PM, Max Slimmer III wrote: > > Setting connection.autocommit = False does not cause a > connection.connector.BeginTrans() and so any subsequent > connection.commit() raises an exception that there is no open > transaction. Is this by design and

[python-win32] adodbapi changing autocommit

2016-10-23 Thread Max Slimmer III
Setting connection.autocommit = False does not cause a connection.connector.BeginTrans() and so any subsequent connection.commit() raises an exception that there is no open transaction. Is this by design and I'm supposed to explicitly call BeginTrans() when switching autocommit off? Thanks,