Re: [Pytrainer-devel] Pytrainer service layer refactoring

2011-08-23 Thread Nathan Jones
To help put this refactoring into perspective I've added a wiki page describing Pytrainer architecture: https://sourceforge.net/apps/trac/pytrainer/wiki/Architecture - Nathan -- Get a FREE DOWNLOAD! and learn more about

Re: [Pytrainer-devel] Pytrainer service layer refactoring

2011-08-13 Thread David GarcĂ­a Granda
Hi Nathan, I have just been through complete thread and... congratulations for becoming father! (sorry I skipped that message) Regarding technical stuff, fortunately you landed here to put some order and trying to follow better practices ;) David 2011/8/13 Nathan Jones : > In revisions 840-844

Re: [Pytrainer-devel] Pytrainer service layer refactoring

2011-08-13 Thread Nathan Jones
In revisions 840-844 the sport editing UI has been refactored to use a new sport service. The sport service has strict value checking so an automatic migration script has also been added which cleans up any existing invalid values in the sports table. There are still a few areas of the code where

Re: [Pytrainer-devel] Pytrainer service layer refactoring

2011-05-16 Thread Nathan Jones
On 16 May 2011 19:57, Druzee wrote: > I guess you've seen that currently the data is being inserted with string > query building ... besides being a bad practice it causes a problem when > trying to insert/update strings with single/double quotes Yeah, tell me about it. This service layer will ef

Re: [Pytrainer-devel] Pytrainer service layer refactoring

2011-05-16 Thread Druzee
I guess you've seen that currently the data is being inserted with string query building ... besides being a bad practice it causes a problem when trying to insert/update strings with single/double quotes On Fri, May 13, 2011 at 12:43 PM, Nathan Jones wrote: > > I'm starting with the simplest en

Re: [Pytrainer-devel] Pytrainer service layer refactoring

2011-05-13 Thread Nathan Jones
> I'm starting with the simplest entity, Sport, so I need to know what > the allowable values for the properties of a sport are. These are the > validation rules I am currently assuming: > > * description: String, required (default ""), must be unique > * met: Float, optional > * weight: Float, req

Re: [Pytrainer-devel] Pytrainer service layer refactoring

2011-05-12 Thread Nathan Jones
It's been a very busy year so far - I was on a death march project at work since December and I also became a father in March - but I've quit my job now so I'm finally getting around to doing this service layer refactoring. As part of this refactoring I am also going to implement strict value chec