[pywikibot] Re: f strings and regexes

2023-02-11 Thread Bináris
Yes, definitely. Thank you! Merlijn van Deen (valhallasw) ezt írta (időpont: 2023. febr. 11., Szo, 22:41): > Hi Bináris, > > I would consider it on a case-by-case basis. Note that the guidelines > state "should be avoided", not "are absolutely forbidden to be used" :-) > > For short regexps,

[pywikibot] Re: f strings and regexes

2023-02-11 Thread Merlijn van Deen (valhallasw)
Hi Bináris, I would consider it on a case-by-case basis. Note that the guidelines state "should be avoided", not "are absolutely forbidden to be used" :-) For short regexps, I'd use f-strings where reasonable (i.e. where the regex itself does not use {} for the number of characters to match)

[Pywikipedia-bugs] [Maniphest] [Commented On] T191901: archivebot should allow to specify a wiki-wide set of default values for the marker template

2023-02-11 Thread binbot
binbot added a comment. A vote for the second option. AFAIK json pages are protected by default, so vandalism is not a real threat. TASK DETAIL https://phabricator.wikimedia.org/T191901 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: binbot Cc:

[pywikibot] Re: f strings and regexes

2023-02-11 Thread Bináris
Bináris ezt írta (időpont: 2023. febr. 2., Cs, 19:22): > > https://www.mediawiki.org/wiki/Manual:Pywikibot/Development/Guidelines#Miscellaneous > says: > " Prefer f-strings over string.format(). Modulo operator % for string > formatting should be avoided." > > I tried to rewrite a

[Pywikipedia-bugs] [Maniphest] [Commented On] T305302: Provide tests for Lexeme classes

2023-02-11 Thread matej_suchanek
matej_suchanek added a comment. Please upload your changes as a patch for review to Gerrit , where the code can be reviewed. TASK DETAIL https://phabricator.wikimedia.org/T305302 EMAIL PREFERENCES