Dalba renamed this task from "Site.server_time caches the results and returns wrong results in the next call." to "Site.server_time sometimes returns a wrong timestamp on the first call.".
TASK DETAILhttps://phabricator.wikimedia.org/T202227EMAIL
Dalba added a comment.
I think the root cause of the issue is that sometimes the general SiteInfo is loaded using a CachedRequest from a cache file, but gets a new timestamp.
We should change Siteinfo class to make it not update timestamps when loading from a CachedRequest or update it with a
Dalba added a comment.
There are some packages like wcwidth that can detect the display width of a line, but even them are not 100% accurate. The real display width depends on other factros like user's installed fonts and unicode version. There are also some characters that when put next to each
Dalba closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T202238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: gerritbot, Aklapper, Dalba, Xqt, pywikibot-bugs-list, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci,
gerritbot added a comment.
Change 453786 merged by jenkins-bot:
[pywikibot/core@master] Revert "pywikibot.tools.chars: Update and simplify the code"
https://gerrit.wikimedia.org/r/453786TASK DETAILhttps://phabricator.wikimedia.org/T202238EMAIL
JAnD reopened this task as "Open".JAnD added a comment.
I am afraid, this is not because bot is broken, but because database is broken.
https://cs.wikisource.org/w/index.php?title=Index:Žák,_František_-_Ohlasy_žalmů.pdf=prev=168733
you can see, there was nothing changed in page, but its size
Dalba added a comment.
In T202238#4513231, @Xqt wrote:
btw for what is this test good for?
Busing my commit, apparently. :)
As the documentation suggests, BMP unicode code points are being converted into two unicode characters under python 2.7, therefore I don't think there's any easy way to
gerritbot added a comment.
Change 445956 abandoned by Xqt:
In return statement of RecentChangesPageGenerator if rcstart > rcend then reverse = True and when rcstart < rcend then reverse = False
Reason:
https://gerrit.wikimedia.org/r/#/c/pywikibot/core/ /445392/
Xqt added a comment.
btw for what is this test good for?TASK DETAILhttps://phabricator.wikimedia.org/T202238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dalba, XqtCc: gerritbot, Aklapper, Dalba, Xqt, pywikibot-bugs-list, Gaboe420, Versusxo,
Dalba added a comment.
These are surrogate characters. Perhaps related to this note in the documentation of 2.7:
Any Unicode character can be encoded this way, but characters outside the Basic Multilingual Plane (BMP) will be encoded using a surrogate pair if Python is compiled to use 16-bit code
Dalba added a comment.
I set maxDiff to None and here is the result:
==
FAIL: test_category_cf (tests.tools_chars_tests.CharsTestCase)
Test that all characters in _category_cf are actually in Cf.
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T202238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, Dalba, Xqt, pywikibot-bugs-list, Gaboe420, Versusxo, Majesticalreaper22,
gerritbot added a comment.
Change 453786 had a related patch set uploaded (by Dalba; owner: dalba):
[pywikibot/core@master] Skip test_category_cf on Pyhton 2.7
https://gerrit.wikimedia.org/r/453786TASK DETAILhttps://phabricator.wikimedia.org/T202238EMAIL
Dalba claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T202238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: gerritbot, Aklapper, Dalba, Xqt, pywikibot-bugs-list, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985,
Dalba added a comment.
It's only failing on Python 2.7.x and it's because of the old Unicode versions there. I don't think it's worth finding the exact characters that were not in Cf category in those versions, in order to exempt them. I'd suggest skipping this test on 2.7.TASK
Dalba added a commit: rPWBC02e3830b5826: pywikibot.tools.chars: Update and simplify the code.
TASK DETAILhttps://phabricator.wikimedia.org/T202238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Aklapper, Dalba, Xqt, pywikibot-bugs-list, Tbscho, MayS,
Xqt added a comment.
There are some hidden characters inside like "়া" (without the last one) which are counted with len() but I have 5 characters available until the rigtht side of a 80 column page. Maybe this is a such a minor problem that we just could decline it. I guess it does not worth to
Xqt lowered the priority of this task from "Low" to "Lowest".
TASK DETAILhttps://phabricator.wikimedia.org/T202189EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Framawiki, Aklapper, Dalba, Xqt, pywikibot-bugs-list, Tbscho, MayS, Mdupont, JJMC89,
Xqt created this task.Xqt added projects: Pywikibot-core, Pywikibot-tests.Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTION4758==
4759FAIL: test_category_cf
Xqt triaged this task as "High" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T202238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Aklapper, Dalba, Xqt, pywikibot-bugs-list, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb,
gerritbot added a comment.
Change 445392 merged by jenkins-bot:
[pywikibot/core@master] pagegenerators._handle_recentchanges: Do not request for reversed results
https://gerrit.wikimedia.org/r/445392TASK DETAILhttps://phabricator.wikimedia.org/T199199EMAIL
Dalba updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...```lang=python
from pywikibot import *...s = Site('fa'en', 'wpbeta''wikipedia')...sleep(52)...sleep(52)...2018-08-19T07:228T11:23:28Z
2018-08-19T10:52:14Z1:03:03Z
2018-08-19T10:52:19Z1:03:06Z
```
Second and third
Dalba created this task.Dalba added a project: Pywikibot-core.Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONRun the following script:
from pywikibot import *
from time import *
s = Site('fa', 'wpbeta')
print(s.server_time())
sleep(5)
Xqt reassigned this task from AdityaJ to Dalba.
TASK DETAILhttps://phabricator.wikimedia.org/T199199EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dalba, XqtCc: zhuyifei1999, gerritbot, Dvorapa, AdityaJ, Xqt, darthbhyrava, Dalba, Aklapper,
Xqt closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T199199EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AdityaJ, XqtCc: zhuyifei1999, gerritbot, Dvorapa, AdityaJ, Xqt, darthbhyrava, Dalba, Aklapper, pywikibot-bugs-list,
MarcoAurelio removed a project: User-MarcoAurelio.
TASK DETAILhttps://phabricator.wikimedia.org/T167709EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MarcoAurelioCc: PokestarFan, valhallasw, Mpaa, jayvdb, Xqt, Magul, Aklapper, MarcoAurelio,
26 matches
Mail list logo
