[Pywikipedia-bugs] [Maniphest] [Commented On] T233392: FilePage.getRedirectTarget should return a FilePage

2019-09-20 Thread JJMC89
JJMC89 added a comment. I'd go further and have `BasePage.getRedirectTarget()` return an object of the same class as the redirect. This would keep the implementation general and allow other subclasses that want the returned object to be the same class to use the method without overriding

[Pywikipedia-bugs] [Maniphest] [Commented On] T233419: Unexpected success for FailingSiteTestCase.test_hackerspaces

2019-09-20 Thread Dvorapa
Dvorapa added a comment. Wasn't this a test of the decorator then? Anyway it should be clearly stated in the test description/comment at least or a better url like example.com/google.com chosen instead. TASK DETAIL https://phabricator.wikimedia.org/T233419 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T230196: Implement filearchive in Pywikibot Site

2019-09-20 Thread gerritbot
gerritbot added a comment. Change 536620 **merged** by jenkins-bot: [pywikibot/core@master] [IMPR] Add ListGenerator for filearchive to site.py https://gerrit.wikimedia.org/r/536620 TASK DETAIL https://phabricator.wikimedia.org/T230196 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Lowered Priority] T233419: Unexpected success for FailingSiteTestCase.test_hackerspaces

2019-09-20 Thread Xqt
Xqt lowered the priority of this task from "High" to "Low". TASK DETAIL https://phabricator.wikimedia.org/T233419 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Dvorapa, Aklapper, Xqt, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho,

[Pywikipedia-bugs] [Maniphest] [Commented On] T233419: Unexpected success for FailingSiteTestCase.test_hackerspaces

2019-09-20 Thread Xqt
Xqt added a comment. In T233419#5510016 , @Dvorapa wrote: > That's because their wiki moved to the new url: https://wiki.hackerspaces.org/ Instead of removing the decorator we should update the url or not? The decorator should

[Pywikipedia-bugs] [Maniphest] [Reopened] T233419: Unexpected success for FailingSiteTestCase.test_hackerspaces

2019-09-20 Thread Dvorapa
Dvorapa reopened this task as "Open". Dvorapa added a comment. That's because their wiki moved to the new url: https://wiki.hackerspaces.org/ Instead of removing the decorator we should update the url or not? TASK DETAIL https://phabricator.wikimedia.org/T233419 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T233438: script_tests' collector function should be validated

2019-09-20 Thread Dvorapa
Dvorapa added a comment. I did some work on this issue here: https://github.com/dvorapa/pywikibot/commits/dvorapa-test TASK DETAIL https://phabricator.wikimedia.org/T233438 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvorapa Cc: Dvorapa,

[Pywikipedia-bugs] [Maniphest] [Edited] T233438: script_tests' collector function should be validated

2019-09-20 Thread Xqt
Xqt updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T233438 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper, Xqt, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa,

[Pywikipedia-bugs] [Maniphest] [Edited] T233438: script_tests' collector function should be validated

2019-09-20 Thread Xqt
Xqt updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T233438 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper, Xqt, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa,

[Pywikipedia-bugs] [Maniphest] [Updated] T233416: unexpected success for several scripts in TestScriptSimulate

2019-09-20 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T233416 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, Maintenance_bot Cc: Aklapper, pywikibot-bugs-list, Dvorapa, Xqt, Viztor, DannyS712, Wenyi,

[Pywikipedia-bugs] [Maniphest] [Updated] T233419: Unexpected success for FailingSiteTestCase.test_hackerspaces

2019-09-20 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T233419 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, Maintenance_bot Cc: Aklapper, Xqt, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho,

[Pywikipedia-bugs] [Maniphest] [Retitled] T213814: xml.etree.ElementTree.Element.getchildren() has been removed in Python 3.9

2019-09-20 Thread Xqt
Xqt renamed this task from "xml.etree.ElementTree.Element.getchildren() will be removed in python 3.9" to "xml.etree.ElementTree.Element.getchildren() has been removed in Python 3.9". Xqt raised the priority of this task from "Low" to "Normal". Xqt updated the task description. TASK DETAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T233416: unexpected success for several scripts in TestScriptSimulate

2019-09-20 Thread gerritbot
gerritbot added a comment. Change 538285 **merged** by jenkins-bot: [pywikibot/core@master] [tests] Allow all scripts tested with -simulate option https://gerrit.wikimedia.org/r/538285 TASK DETAIL https://phabricator.wikimedia.org/T233416 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Closed] T233416: unexpected success for several scripts in TestScriptSimulate

2019-09-20 Thread Xqt
Xqt closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T233416 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper, pywikibot-bugs-list, Dvorapa, Xqt, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400,

[Pywikipedia-bugs] [Maniphest] [Commented On] T233416: unexpected success for several scripts in TestScriptSimulate

2019-09-20 Thread gerritbot
gerritbot added a comment. Change 538285 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [tests] Allow all scripts tested with -simulate option https://gerrit.wikimedia.org/r/538285 TASK DETAIL https://phabricator.wikimedia.org/T233416 EMAIL

[Pywikipedia-bugs] [Maniphest] [Updated] T233416: unexpected success for several scripts in TestScriptSimulate

2019-09-20 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T233416 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, gerritbot Cc: Aklapper, pywikibot-bugs-list, Dvorapa, Xqt, Hook696, Daryl-TTMG, RomaAmorRoma,

[Pywikipedia-bugs] [Maniphest] [Commented On] T233419: Unexpected success for FailingSiteTestCase.test_hackerspaces

2019-09-20 Thread gerritbot
gerritbot added a comment. Change 538290 **merged** by jenkins-bot: [pywikibot/core@master] [bugfix] Remove expectedFailure decorator in test_hackerspaces https://gerrit.wikimedia.org/r/538290 TASK DETAIL https://phabricator.wikimedia.org/T233419 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Closed] T233419: Unexpected success for FailingSiteTestCase.test_hackerspaces

2019-09-20 Thread Xqt
Xqt closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T233419 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper, Xqt, pywikibot-bugs-list, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild,

[Pywikipedia-bugs] [Maniphest] [Updated] T233419: Unexpected success for FailingSiteTestCase.test_hackerspaces

2019-09-20 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T233419 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, gerritbot Cc: Aklapper, Xqt, pywikibot-bugs-list, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400,

[Pywikipedia-bugs] [Maniphest] [Commented On] T233419: Unexpected success for FailingSiteTestCase.test_hackerspaces

2019-09-20 Thread gerritbot
gerritbot added a comment. Change 538290 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [bugfix] Remove expectedFailure decorator in test_hackerspaces https://gerrit.wikimedia.org/r/538290 TASK DETAIL https://phabricator.wikimedia.org/T233419 EMAIL

[Pywikipedia-bugs] [Maniphest] [Created] T233419: Unexpected success for FailingSiteTestCase.test_hackerspaces

2019-09-20 Thread Xqt
Xqt created this task. Xqt added a project: Pywikibot-tests. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. Restricted Application added a project: Pywikibot. TASK DESCRIPTION FailingSiteTestCase.test_hackerspaces unexpectedly passes. The site is not available and

[Pywikipedia-bugs] [Maniphest] [Triaged] T233419: Unexpected success for FailingSiteTestCase.test_hackerspaces

2019-09-20 Thread Xqt
Xqt triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T233419 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper, Xqt, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89,

[Pywikipedia-bugs] [Maniphest] [Claimed] T233416: unexpected success for several scripts in TestScriptSimulate

2019-09-20 Thread Xqt
Xqt triaged this task as "High" priority. Xqt claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T233416 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper, pywikibot-bugs-list, Dvorapa, Xqt, Viztor, DannyS712, Wenyi,

[Pywikipedia-bugs] [Maniphest] [Created] T233416: unexpected success for several scripts in TestScriptSimulate

2019-09-20 Thread Xqt
Xqt created this task. Xqt added a project: Pywikibot-tests. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. Restricted Application added a project: Pywikibot. TASK DESCRIPTION There is no reason to skip script tests with -simulate option when a required package is not

[Pywikipedia-bugs] [Maniphest] [Updated] T232117: sseclient is not installed for tests

2019-09-20 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T232117 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, Maintenance_bot Cc: Dvorapa, Aklapper, Dalba, Xqt, pywikibot-bugs-list, Viztor, DannyS712,

[Pywikipedia-bugs] [Maniphest] [Unblock] T225591: Make Travis and Appveyor pass again

2019-09-20 Thread Xqt
Xqt closed subtask T232117: sseclient is not installed for tests as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T225591 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: D3r1ck01, Mpaa, Framawiki, Lokal_Profil, Dvorapa, Dalba,

[Pywikipedia-bugs] [Maniphest] [Closed] T232117: sseclient is not installed for tests

2019-09-20 Thread Xqt
Xqt closed this task as "Resolved". Xqt claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T232117 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Dvorapa, Aklapper, Dalba, Xqt, pywikibot-bugs-list, Hook696, Daryl-TTMG,

[Pywikipedia-bugs] [Maniphest] [Commented On] T232117: sseclient is not installed for tests

2019-09-20 Thread gerritbot
gerritbot added a comment. Change 537623 **merged** by jenkins-bot: [pywikibot/core@master] [tests] Add 'eventstreams' requirement to test_deps https://gerrit.wikimedia.org/r/537623 TASK DETAIL https://phabricator.wikimedia.org/T232117 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T233406: Refactor Wikibase entities

2019-09-20 Thread gerritbot
gerritbot added a comment. Change 526380 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek): [pywikibot/core@master] [FEAT] Refactor data attributes of Wikibase entities https://gerrit.wikimedia.org/r/526380 TASK DETAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T233406: Refactor Wikibase entities

2019-09-20 Thread gerritbot
gerritbot added a comment. Change 525056 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek): [pywikibot/core@master] [FEAT] Add WikibaseEntity.editEntity and others https://gerrit.wikimedia.org/r/525056 TASK DETAIL https://phabricator.wikimedia.org/T233406

[Pywikipedia-bugs] [Maniphest] [Commented On] T233406: Refactor Wikibase entities

2019-09-20 Thread gerritbot
gerritbot added a comment. Change 523690 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek): [pywikibot/core@master] [FEAT] Add WikibaseEntity.get https://gerrit.wikimedia.org/r/523690 TASK DETAIL https://phabricator.wikimedia.org/T233406 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Updated] T233406: Refactor Wikibase entities

2019-09-20 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T233406 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Aklapper, matej_suchanek, pywikibot-bugs-list, Hook696, Daryl-TTMG, RomaAmorRoma,

[Pywikipedia-bugs] [Maniphest] [Created] T233406: Refactor Wikibase entities

2019-09-20 Thread matej_suchanek
matej_suchanek created this task. matej_suchanek added projects: Pywikibot, Pywikibot-Wikidata, Patch-For-Review. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. Restricted Application removed a project: Patch-For-Review. TASK DESCRIPTION This needs to be done, so that

[Pywikipedia-bugs] [Maniphest] [Commented On] T213287: Drop support of python 2.7

2019-09-20 Thread gerritbot
gerritbot added a comment. Change 538257 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [IMPR] derive LoginStatus with IntEnum https://gerrit.wikimedia.org/r/538257 TASK DETAIL https://phabricator.wikimedia.org/T213287 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T213287: Drop support of python 2.7

2019-09-20 Thread gerritbot
gerritbot added a comment. Change 538244 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [Python3] require enum34 for Python 2.7 https://gerrit.wikimedia.org/r/538244 TASK DETAIL https://phabricator.wikimedia.org/T213287 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Updated] T213287: Drop support of python 2.7

2019-09-20 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T213287 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Multichill, zhuyifei1999, Dalba, Eatcha, KTC, Lokal_Profil, Dvorapa, Aklapper,

[Pywikipedia-bugs] [Maniphest] [Edited] T233392: FilePage.getRedirectTarget should return a FilePage

2019-09-20 Thread Strainu
Strainu updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T233392 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Strainu Cc: Aklapper, pywikibot-bugs-list, Strainu, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89,

[Pywikipedia-bugs] [Maniphest] [Created] T233392: FilePage.getRedirectTarget should return a FilePage

2019-09-20 Thread Strainu
Strainu created this task. Strainu added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION Please treat this as an RFC rather than a bug report. The following simplified code should illustrate the problem: val =