gerritbot added a comment.
Change 606942 **merged** by jenkins-bot:
[pywikibot/core@master] [cleanup] deprecate Page.isEmpty without 'instead'
parameter
https://gerrit.wikimedia.org/r/c/pywikibot/core/ /606942
TASK DETAIL
https://phabricator.wikimedia.org/T112340
EMAIL PREFERENCES
gerritbot added a comment.
Change 257367 merged by jenkins-bot:
Deprecate page.isEmpty() and add function in interwiki to check for empty pages
https://gerrit.wikimedia.org/r/257367
TASK DETAIL
https://phabricator.wikimedia.org/T112340
EMAIL PREFERENCES
gerritbot added a comment.
Change 257367 had a related patch set uploaded (by Vadiraja.k):
Deprecate page.isEmpty() and add function in interwiki to check for empty pages
https://gerrit.wikimedia.org/r/257367
TASK DETAIL
https://phabricator.wikimedia.org/T112340
EMAIL PREFERENCES
XZise added a comment.
Just as a general note, these 6 lines mentioned in the OP could be easily
shortened into one: `return len(page.text) > 50`
TASK DETAIL
https://phabricator.wikimedia.org/T112340
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To:
jayvdb added a comment.
In https://phabricator.wikimedia.org/T112340#1813154, @Xqt wrote:
> @jayvdb, anyway this was an inappropriate implementation for a minor problem
> if any.
Yup. Ok
TASK DETAIL
https://phabricator.wikimedia.org/T112340
EMAIL PREFERENCES
gerritbot added a comment.
Change 243487 abandoned by John Vandenberg:
deprecate Page.isEmpty
Reason:
no response from @Rajdeep, please feel free to resume this work if you are
still interested.
https://gerrit.wikimedia.org/r/243487
TASK DETAIL
https://phabricator.wikimedia.org/T112340
Xqt added a comment.
@jayvdb, anyway this was an inappropriate implementation for a minor problem if
any.
TASK DETAIL
https://phabricator.wikimedia.org/T112340
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Xqt
Cc: Xqt, gerritbot, StudiesWorld,
jayvdb added a comment.
@Rajdeep594 , do you intend to complete this task? If not, you can un-assign
it, so someone else may complete the task.
TASK DETAIL
https://phabricator.wikimedia.org/T112340
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To:
XZise added a subscriber: XZise.
XZise added a comment.
In https://phabricator.wikimedia.org/T112340#1677194, @01tonythomas wrote:
> Hello @Rajdeep594! You neednt have the task assigned to you to start working
> on it. If you feel like, you can click on 'Edit Task' and add your name to
>
Rajdeep594 added a comment.
i would like to work on this bug could you assigned me this bug
TASK DETAIL
https://phabricator.wikimedia.org/T112340
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Rajdeep594
Cc: Rajdeep594, Aklapper, jayvdb,
01tonythomas added a subscriber: 01tonythomas.
01tonythomas added a comment.
In https://phabricator.wikimedia.org/T112340#1677189, @Rajdeep594 wrote:
> i would like to work on this bug could you assigned me this bug
Hello @Rajdeep594! You neednt have the task assigned to you to start working
11 matches
Mail list logo