[Pywikipedia-bugs] [Maniphest] [Commented On] T165911: Get the u'' to '' string conversion over with in Pywikibot

Dvorapa added a comment. In case of user-config.py the are not detected (as part of strings) TASK DETAIL https://phabricator.wikimedia.org/T165911 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvorapa Cc: Dvorapa, Dalba, valhallasw, binbot,

[Pywikipedia-bugs] [Maniphest] [Commented On] T165911: Get the u'' to '' string conversion over with in Pywikibot

Xqt added a comment. In T165911#6068211 , @Dvorapa wrote: > I can still see a lot of places in code where u'' or u"" is used They are only in comments otherwise it would have been detected by `flake8-no-u-prefixed-strings`. Anyway

[Pywikipedia-bugs] [Maniphest] [Commented On] T165911: Get the u'' to '' string conversion over with in Pywikibot

gerritbot added a comment. Change 590281 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [cleanup] remove remaining unicode literals specifiers https://gerrit.wikimedia.org/r/590281 TASK DETAIL https://phabricator.wikimedia.org/T165911 EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T165911: Get the u'' to '' string conversion over with in Pywikibot

Dvorapa added a comment. https://phabricator.wikimedia.org/diffusion/PWBC/browse/master/?grep=%5B%5Ea-zA-Z%22%27%5Du%5B%22%27%5D TASK DETAIL https://phabricator.wikimedia.org/T165911 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvorapa Cc:

[Pywikipedia-bugs] [Maniphest] [Commented On] T165911: Get the u'' to '' string conversion over with in Pywikibot

Dalba added a comment. +1. I personally don't care about blame history much. Making the code more visually appealing, more newcomer-friendly, and one less thing to argue about during code reviews is more important for me.TASK DETAILhttps://phabricator.wikimedia.org/T165911EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T165911: Get the u'' to '' string conversion over with in Pywikibot

binbot added a comment. In T165911#3296955, @valhallasw wrote: Not, they don't. The u'' prefix has been allowed since Python 3.3, which was released in 2012. Official support for Python 3.2 was dropped in Feb 2016. There is absolutely no reason to remove them, apart from 'it looks nicer'.

[Pywikipedia-bugs] [Maniphest] [Commented On] T165911: Get the u'' to '' string conversion over with in Pywikibot

valhallasw added a comment. In T165911#3296939, @binbot wrote: Us will always cause problem in Python 3000. Not, they don't. The u'' prefix has been allowed since Python 3.3, which was released in 2012. Official support for Python 3.2 was dropped in Feb 2016. There is absolutely no reason to

[Pywikipedia-bugs] [Maniphest] [Commented On] T165911: Get the u'' to '' string conversion over with in Pywikibot

binbot added a comment. Then a better piece of advice would be "Remove u only from scripts with no pending changes", wouldn't it? I think a patch only removing us can be revised on express lane.TASK DETAILhttps://phabricator.wikimedia.org/T165911EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T165911: Get the u'' to '' string conversion over with in Pywikibot

Multichill added a comment. In T165911#3296939, @binbot wrote: @Xqt wrote at the mentioned page: "Anyway we shouldn't change old code for it". Why? Us will always cause problem in Python 3000. One of the problems we have is 300+ open changesets. If we change u'' to '' now, a lot of these sets