gerritbot added a comment.
Change 442910 abandoned by Xqt:
T196619 Revert "[cleanup] Deprecate pagegenerators.UnconnectedPageGenerator"
Reason:
due to https://gerrit.wikimedia.org/r/#/c/pywikibot/core/ /443027/
https://gerrit.wikimedia.org/r/442910TASK
zhuyifei1999 added a comment.
@JAnD resolved now?TASK DETAILhttps://phabricator.wikimedia.org/T196619EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, zhuyifei1999Cc: Masti, zhuyifei1999, Multichill, gerritbot, matej_suchanek, Xqt, Framawiki, Aklapper,
gerritbot added a comment.
Change 443027 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Enable namespace filtering for unconnected_pages GeneratorFactory
https://gerrit.wikimedia.org/r/443027TASK DETAILhttps://phabricator.wikimedia.org/T196619EMAIL
Xqt added a comment.
As zhuyifei1999 statet the problems is the pagegenerators filtering. It assumes that QueryGenerators always have a namespace parameter. Either the api should do the filtering or pagegenerators should know whether the QueryGenerators is able to do it.TASK
gerritbot added a comment.
Change 443027 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Enable namespace filtering for unconnected_pages GeneratorFactory
https://gerrit.wikimedia.org/r/443027TASK DETAILhttps://phabricator.wikimedia.org/T196619EMAIL
zhuyifei1999 added a comment.
In T196619#4322931, @zhuyifei1999 wrote:
Looks like a no-op to me.
Scratch that. It is relevant, yes, but the original implementation of using a layer of 'indirectness' is not good.
The bug is caused by the combination of pagegenerators.py#L496 and api.py#L2710:
zhuyifei1999 added a comment.
In T196619#4305701, @matej_suchanek wrote:
rPWBCbdeea71e129f0bc9b1a36e75388dfc576c7275ce is behind this.
Looks like a no-op to me.TASK DETAILhttps://phabricator.wikimedia.org/T196619EMAIL
Multichill added a comment.
@Xqt : Why are you deprecating perfectly valid generators?
Buh, simple revert and rebase doesn't work.TASK DETAILhttps://phabricator.wikimedia.org/T196619EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MultichillCc: Multichill,
gerritbot added a comment.
Change 442910 had a related patch set uploaded (by Multichill; owner: Multichill):
[pywikibot/core@master] T196619 Revert "[cleanup] Deprecate pagegenerators.UnconnectedPageGenerator"
https://gerrit.wikimedia.org/r/442910TASK
