[Pywikipedia-bugs] [Maniphest] [Commented On] T233419: Unexpected success for FailingSiteTestCase.test_hackerspaces

2019-09-25 Thread gerritbot
gerritbot added a comment. Change 538377 **merged** by jenkins-bot: [pywikibot/core@master] [tests] Remove test_hackerspaces https://gerrit.wikimedia.org/r/538377 TASK DETAIL https://phabricator.wikimedia.org/T233419 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T233419: Unexpected success for FailingSiteTestCase.test_hackerspaces

2019-09-21 Thread gerritbot
gerritbot added a comment. Change 538377 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [tests] Remove test_hackerspaces https://gerrit.wikimedia.org/r/538377 TASK DETAIL https://phabricator.wikimedia.org/T233419 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T233419: Unexpected success for FailingSiteTestCase.test_hackerspaces

2019-09-21 Thread Xqt
Xqt added a comment. In T233419#5511804 , @Dvorapa wrote: > Wasn't this a test of the decorator then? surely not. We don't test unittest itself. > Anyway it should be clearly stated in the test description/comment at least or

[Pywikipedia-bugs] [Maniphest] [Commented On] T233419: Unexpected success for FailingSiteTestCase.test_hackerspaces

2019-09-20 Thread Dvorapa
Dvorapa added a comment. Wasn't this a test of the decorator then? Anyway it should be clearly stated in the test description/comment at least or a better url like example.com/google.com chosen instead. TASK DETAIL https://phabricator.wikimedia.org/T233419 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T233419: Unexpected success for FailingSiteTestCase.test_hackerspaces

2019-09-20 Thread Xqt
Xqt added a comment. In T233419#5510016 , @Dvorapa wrote: > That's because their wiki moved to the new url: https://wiki.hackerspaces.org/ Instead of removing the decorator we should update the url or not? The decorator should

[Pywikipedia-bugs] [Maniphest] [Commented On] T233419: Unexpected success for FailingSiteTestCase.test_hackerspaces

2019-09-20 Thread gerritbot
gerritbot added a comment. Change 538290 **merged** by jenkins-bot: [pywikibot/core@master] [bugfix] Remove expectedFailure decorator in test_hackerspaces https://gerrit.wikimedia.org/r/538290 TASK DETAIL https://phabricator.wikimedia.org/T233419 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T233419: Unexpected success for FailingSiteTestCase.test_hackerspaces

2019-09-20 Thread gerritbot
gerritbot added a comment. Change 538290 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [bugfix] Remove expectedFailure decorator in test_hackerspaces https://gerrit.wikimedia.org/r/538290 TASK DETAIL https://phabricator.wikimedia.org/T233419 EMAIL