[Pywikipedia-bugs] [Maniphest] [Commented On] T234133: Pywikibot-redirect ignoring -namespace

gerritbot added a comment. Change 654412 **merged** by jenkins-bot: [pywikibot/core@master] [IMPR] use pagegenerators namespace filter for redirect.py https://gerrit.wikimedia.org/r/654412 TASK DETAIL https://phabricator.wikimedia.org/T234133 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T234133: Pywikibot-redirect ignoring -namespace

gerritbot added a comment. Change 654412 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [IMPR] use pagegenerators namespace filter for redirect.py https://gerrit.wikimedia.org/r/654412 TASK DETAIL https://phabricator.wikimedia.org/T234133 EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T234133: Pywikibot-redirect ignoring -namespace

HAKSOAT added a comment. @Dvorapa I realized that the argument for namespace doesn't even send to redirect. I made use of the example **python pwb.py redirect double -namespace:6** TASK DETAIL https://phabricator.wikimedia.org/T234133 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T234133: Pywikibot-redirect ignoring -namespace

HAKSOAT added a comment. Okay. Are there any rules to creating a branch for making my contribution? TASK DETAIL https://phabricator.wikimedia.org/T234133 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HAKSOAT Cc: HAKSOAT, Dvorapa, Xqt, Aklapper,

[Pywikipedia-bugs] [Maniphest] [Commented On] T234133: Pywikibot-redirect ignoring -namespace

Dvorapa added a comment. Yes, this should be the way :) TASK DETAIL https://phabricator.wikimedia.org/T234133 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvorapa Cc: HAKSOAT, Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Ff300, AndreasTraut,

[Pywikipedia-bugs] [Maniphest] [Commented On] T234133: Pywikibot-redirect ignoring -namespace

HAKSOAT added a comment. Thanks @Dvorapa I've spent some time first checking another script, then the redirect script. I see that the script has the ability to pass namespaces to RedirectGenerator. But the value is not being extracted from the arguments as expected. So I'm to get it to

[Pywikipedia-bugs] [Maniphest] [Commented On] T234133: Pywikibot-redirect ignoring -namespace

Dvorapa added a comment. Hello @HAKSOAT! Yes, you can work on this. The issue is that many Pywikibot scripts understand -ns or -namespace parameter and work only on pages using that namespace specified. This script does not understand that parameter. The task is to add missing namespace

[Pywikipedia-bugs] [Maniphest] [Commented On] T234133: Pywikibot-redirect ignoring -namespace

HAKSOAT added a comment. Hello @Dvorapa I am new here. Can I work on this? Though I do not fully understand the problem yet. TASK DETAIL https://phabricator.wikimedia.org/T234133 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HAKSOAT Cc:

[Pywikipedia-bugs] [Maniphest] [Commented On] T234133: Pywikibot-redirect ignoring -namespace

Ff300 added a comment. Sorry for the late response: what I (as a user) was expecting from `-ns:6` was to filter source pages by ns, then fix them. However I never thought that source and destination ns may be different (because I expect a redirect from the file namespace to point to an

[Pywikipedia-bugs] [Maniphest] [Commented On] T234133: Pywikibot-redirect ignoring -namespace

Xqt added a comment. In T234133#5606411 , @Dvorapa wrote: > Parameter for the page to be changed should be done using a different parameter (-targetns), not -ns used for filtering the source code. The description seems to talk about

[Pywikipedia-bugs] [Maniphest] [Commented On] T234133: Pywikibot-redirect ignoring -namespace

Dvorapa added a comment. Parameter for the page to be changed should be done using a different parameter (-targetns), not -ns used for filtering the source code. The description seems to talk about the generator filter TASK DETAIL https://phabricator.wikimedia.org/T234133 EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T234133: Pywikibot-redirect ignoring -namespace

Xqt added a comment. In T234133#5606000 , @Dvorapa wrote: > @Xqt -namespace should always filter the source. This behavior is default in 100 % of scripts and should not be interrupted. Normally no script follow the redirect chain

[Pywikipedia-bugs] [Maniphest] [Commented On] T234133: Pywikibot-redirect ignoring -namespace

Xqt added a comment. The namespace filtering is not determined for cross-namespaces i.e. the namespace of the source page is different from the namespaces in the target chain. Should -namespace option filter the source page or target page or the page(s) to be changed? TASK DETAIL