[Pywikipedia-bugs] [Maniphest] [Commented On] T253709: Bug: Page.botMayEdit() returns incorrect result if "allow=" syntax is used

gerritbot added a comment. Change 599271 **merged** by jenkins-bot: [pywikibot/core@master] [IMPR] Rewrite Page.botMayEdit method https://gerrit.wikimedia.org/r/599271 TASK DETAIL https://phabricator.wikimedia.org/T253709 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Pywikipedia-bugs] [Maniphest] [Commented On] T253709: Bug: Page.botMayEdit() returns incorrect result if "allow=" syntax is used

gerritbot added a comment. Change 599271 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [IMPR] Rewrite Page.botMayEdit method https://gerrit.wikimedia.org/r/599271 TASK DETAIL https://phabricator.wikimedia.org/T253709 EMAIL PREFERENCES https://phabri

[Pywikipedia-bugs] [Maniphest] [Commented On] T253709: Bug: Page.botMayEdit() returns incorrect result if "allow=" syntax is used

Dvorapa added a comment. @russblau It's not a bug, have you read @Xqt's comment? We support Nobots **unnamed** parameter (used on dewiki). TASK DETAIL https://phabricator.wikimedia.org/T253709 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvora

[Pywikipedia-bugs] [Maniphest] [Commented On] T253709: Bug: Page.botMayEdit() returns incorrect result if "allow=" syntax is used

russblau added a comment. The current implementation contains a logic error, in that it tries to split a parameter value on a ',' without first checking for the presence of an '='. This is a bug, regardless of whether we think the correct implementation should or should not allow for {{nobot

[Pywikipedia-bugs] [Maniphest] [Commented On] T253709: Bug: Page.botMayEdit() returns incorrect result if "allow=" syntax is used

Dvorapa added a comment. To make my point clear: if there is any doubt, we are not those who should decide how to behave. Either wiki community finds a solution about the issue @russblau suggested and tells us to adapt Pywikibot, or we will implement it just the way official docs/help pages

[Pywikipedia-bugs] [Maniphest] [Commented On] T253709: Bug: Page.botMayEdit() returns incorrect result if "allow=" syntax is used

Dvorapa added a comment. > We can, but I don't think we should. > On the English Wikipedia such cases are reported as broken. It's not just about enwiki. People on Czech Wikipedia complained before about this meaningless custom of having two templates doing the same thing. They suggest

[Pywikipedia-bugs] [Maniphest] [Commented On] T253709: Bug: Page.botMayEdit() returns incorrect result if "allow=" syntax is used

Xqt added a comment. Better have a look at this doc . `{{nobots}}` must not have any named parameters. And on the other hand `{{bots}}` always must have a named parameter if any. `{{bots|allow=Foo}}` is a valid directive but `{{nobots|allo

[Pywikipedia-bugs] [Maniphest] [Commented On] T253709: Bug: Page.botMayEdit() returns incorrect result if "allow=" syntax is used

JJMC89 added a comment. In T253709#6168567 , @Dvorapa wrote: > So we can merge the behavior? `{{nobots}}` will do one thing, `{{bots}}` another thing, but attributes will be shared? We can, but I don't think we should. In T2537

[Pywikipedia-bugs] [Maniphest] [Commented On] T253709: Bug: Page.botMayEdit() returns incorrect result if "allow=" syntax is used

Dvorapa added a comment. So we can merge the behavior? `{{nobots}}` will do one thing, `{{bots}}` another thing, but attributes will be shared? TASK DETAIL https://phabricator.wikimedia.org/T253709 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Pywikipedia-bugs] [Maniphest] [Commented On] T253709: Bug: Page.botMayEdit() returns incorrect result if "allow=" syntax is used

JJMC89 added a comment. `{{nobots}}` should not have parameters per https://en.wikipedia.org/wiki/Template:Bots#Syntax, so it should be `{{bots|allow=Foo}}` instead of `{{nobots|allow=Foo}}`. If we follow that, then the code could be: [...] for template, params in tem